- 30 Jul, 2020 40 commits
-
-
Taylor Bergquist authored
Bug: 1093972 Change-Id: I0ca6cc1a7dad9240b85745fefb39ac4f52eb9355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300993 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#793270}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8138cbbd875a..dcc562158c8e 2020-07-30 syoussefi@chromium.org Vulkan: Implement GL_EXT_multisampled_render_to_texture 2020-07-30 penghuang@chromium.org Support EGL_ANGLE_display_semaphore_share_group for DisplayNULL 2020-07-30 syoussefi@chromium.org Vulkan: Remove unnecessary endRenderPass calls. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I56e11f757f9dc5ffac7a0cb9da41df3a3cdf0fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330032Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793269}
-
jongdeok.kim authored
When DIPToScreenRect() is asked to find the nearest display to a given rect, it uses the minimum SquaredDistanceBetweenRects() to choose. Since adjacent and overlapping rectangles had the same reported distance (0), a rect on one monitor but touching another could be reported as nearest to the adjacent one, which is clearly incorrect. Bug: 1097049 Change-Id: I626c3ba07d5e084b1a9062b780b2f5d333e26ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315663 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793268}
-
Joe Mason authored
R=drubery, proberge Change-Id: Ibbdd36e0ea2229b7e91d2fcb254f6d8a12368eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329811Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#793267}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/78a8b5cf..d8eae98f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I408f576640724b0878afdeb28170bad4d2d1c84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329409Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793266}
-
Sicheng Li authored
This CL removes fetching ScreenOrientationConstants.EXTRA_ORIENTATION from the intent to compute the default orientation. The fetch is redundant to CustomTabOrientationController#mLockScreenOrientation and ScreenOrientationProviderImpl#mDefaultOrientationOverrides Bug: 812797, 989606 Change-Id: I25ec7ecbdf1a9ac9ac20132568a2cd5da5f12739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324445Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Sicheng Li <scli@google.com> Commit-Queue: Sicheng Li <scli@google.com> Cr-Commit-Position: refs/heads/master@{#793265}
-
Xing Liu authored
These tests are failing on L builders. TBR=gayane@chromium.org Bug: 1111408 Change-Id: I55f062a0fd393241b5dab49aa2badd4337860afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329743Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#793264}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I1414194720098fc526fc25d76288a7bc7116510a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328336Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793263}
-
Etienne Bergeron authored
GetStringRect(...) is no longer used. R=msw@chromium.org Bug: 1111044 Change-Id: I42c28758b817ecbebcc478776850325484dd32ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328212 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#793262}
-
Peng Huang authored
This CL change SharedImageRepresentationSkia::BeginScoped*Access()'s definition to not pass semaphores's ownership to caller. So the caller will not release any semaphores, so shared image backings can reuse or release them. Bug: 1004772 Change-Id: Idfbcf61571a56be6acc8c80ee838ff0e119ba8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323562Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#793261}
-
Avi Drissman authored
Bug: 1105907 Change-Id: I762e0a18817149a506948e9a0392fdac1b7cfa9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328339 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#793260}
-
Sami Kyostila authored
Switch from the legacy JSON format to binary Perfetto traces (.pftrace) in the mobile tracing UI. Perfetto traces can be viewed with the Perfetto UI (https://ui.perfetto.dev) and converted back to JSON format for the legacy Trace Viewer. Bug: b/158460807 Change-Id: I2a2865717eb5bccee7545ea62b7f8d3a0f473366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292473 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#793259}
-
David Black authored
Problem: Sometimes multiple copies to the clipboard occur in the same task sequence. The user is likely only aware of the most recent copy, so seeing previous copies that occurred would be strange in history. Example: User copies the URL from the address bar in the browser. First the short form of the URL is copied to the clipboard. Then the long form of the URL is copied to the clipboard. The user probably only expects to see the most recent copy in history. Solution: Debounce our history commits by queuing them to the end of the task sequence. This should filter out programmatic copies that happen in rapid succession. Bug: 1109367 Change-Id: Ibef538cd15793702ea11e5ff8bbf398cbc62e4a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317754 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#793258}
-
Andrey Kosyakov authored
CSS agent expects to use DOM node id, so notifying it after the node has been unbound is too late. Change-Id: I4dad85d2676ae29998a7a3b05a026768fad97e98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328295Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#793257}
-
Yuke Liao authored
An optional try job to compile lacros related test targets. Bug: 1110382 Ignore-CQ-Freeze: True Change-Id: I0e70022491f17c9573657f18a3d1bd345ed84c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327863 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#793256}
-
Jonathan Ross authored
Recently there has been flaky texture errors on Win7 AMD. This marks the flaking test as RetryOnFailure to help the tree, until the root cause can be investigated TBR=ynovikov@chromium.org TEST= webgl2_conformance_d3d11_passthrough_tests conformance/textures/misc/texture-sub-image-cube-maps.html Bug: 1110951 Change-Id: Ifbdfe117af7cc8981743a12109db6da71014f915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330070Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793255}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/899893a60cc5..425100947acf 2020-07-30 jacktfranklin@chromium.org Fix errors with `Object` type in component bridges 2020-07-30 janscheffler@chromium.org [TypeScript] Migrate `front_end/timeline` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Migrate `front_end/node_main` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Migrate `front_end/profiler` to `devtools_entrypoint` 2020-07-30 janscheffler@chromium.org Migrate `front_end/coverage` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1101738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0ce5027ae9fa5bfc17334ed53a01950bc87ad837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330036Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793254}
-
Wenbin Zhang authored
This CL disabled the reference builds on perf tests of android-pixel2. This tester is picked because among all testers, it has the lowest of anomalies filterd by using reference build. We will monitor the perf data and how dashboard reacts without the ref data. Bug: chromium:1108663 Change-Id: I1f2b94383870d9a02579afcb16b02f5f8e6f27ab Ignore-Cq-Freeze: only affects the config for perf bot to select benchmarks. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318985Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#793253}
-
Teresa Kang authored
With willReadFrequently option, the canvas no longer decelerates from gpu to cpu rendering when getImageData is called. The workaround in ShouldAccelerate can also be removed. Flaky/Failing tests due to this deceleration fallback can also be fixed now. Bug: 1090180, 947532, 1011060, 973448, 1001845 Change-Id: Iac7f7171e821e107d8826a31d898efe71662bab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238991 Commit-Queue: Teresa Kang <teresakang@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#793252}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89b3c1f3f8c5..da1abd1caeff 2020-07-30 johnstiles@google.com Remove unused Editor object from reverseAddPath. 2020-07-30 borenet@google.com [infra] Remove Win10 GT610 tasks 2020-07-30 mtklein@google.com refactor large load/stores If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1109705 Tbr: borenet@google.com Change-Id: I41391f14817c9ca5f5b5e865187048871dbf5a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793251}
-
Avi Drissman authored
Bug: 1105907 Change-Id: Ibe0ee8bb499bd257519ea4451c22630a9fed7765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325236Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793250}
-
Azeem Arshad authored
The hermes DBus API is is changing in https://crrev.com/c/2276588. This change essentially moves all methods from the manager interface into a new Euicc interface. Each Euicc object corresponds to an euicc hardware available on the device. The main manager object now simply holds list of available euiccs. Bug: 1093185 Change-Id: Ib0b668cf47a9b8c3fb3016847d59024492443d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303285 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#793249}
-
minch authored
Bug: 1111005 Change-Id: I29a8281cea3dc067904f708fe5049d3fd55766bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330034Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#793248}
-
Chris Thompson authored
This renames password_detials_view_controller_unittest.mm to password_details_view_controller_unittest.mm to fix the typo. Change-Id: Icb82fc7e6325568cc648f3262d68c7a79725f74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327272 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793247}
-
Ben Joyce authored
Bug: 1107004 Change-Id: I2a84c60bff2b0a93145852e7bab15d5dead55169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327893 Commit-Queue: benjamin joyce <bjoyce@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#793246}
-
David Roger authored
Changes based on feedback from designer. Screenshot light mode: https://drive.google.com/file/d/1xddnpwCSkn5PtTcrUtwByiF_5gKOSbfj/view?usp=sharing Screenshot dark mode: https://drive.google.com/file/d/1Fjn5fGmpc48CYxtKwI6t0GOEmBqjUzQo/view?usp=sharing Bug: 1076880 Change-Id: Ia16fd294ffba2c9bf2726d05433ebbb50a5fc328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324130Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#793245}
-
Mitsuru Oshima authored
They needs to be deleted when the display associated with it is disconnected. Change-Id: I2b65f84b8615b0394bfe405aeb99c85a9f866687 Bug: b/159560648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325130Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#793244}
-
Maks Orlovich authored
... by fixing of handling the chrome:// scheme in site_for_cookies computations in renderer to match the browser. Bug: 1013733 Change-Id: I261bc63e1c308d87d910cb02da1ef5519c33e330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317846Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#793243}
-
Ayu Ishii authored
Bug: 1007643 Change-Id: I41633b19505c54698737009400e27d72607950ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315421Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#793242}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1ca8d87239f1..378a948e0d84 2020-07-30 titovartem@google.com Roll chromium_revision 72280394..f4c74ea1 (791192:792888) 2020-07-30 titovartem@google.com Fix "Assignment had no effect." error during chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5709651f78d608cd8f874bbe51fdcb8dd4ebcb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793241}
-
Sammie Quon authored
Test: ash_unittests InkDropHostViewClippingTest.* Bug: 1056490 Change-Id: If2cc7d01363c40fcc46133d598f4b636eecc8303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327860 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#793240}
-
Adenilson Cavalcanti authored
It was revealed by a new clang flag (i.e. basic-aa-recphi) that chunkcopy_safe could hit a scenario of undefined behavior with the use of 'restrict' modifier when the 'from' and 'out' pointers overlapped during decompression. This patch targets to address this issue and unblock the enablement of the aforementioned compiler flag. Credit for the original investigation and the new unit test stressing the failure scenario goes to Hans Wennborg. Performance implications: initial numbers point to a slight improvement for ARM big cores@64bit (i.e. 2% to 3.6%) and x86-64 (i.e. up to 7.5% for Intel i7) but a regression otherwise for 32bit (i.e. between 2.3% to 3% big.LITTLE respectively). Bug: 1103818 Change-Id: I9b7d2c1e47caaf498cd539fd6b77c4b949cb0dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309041Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#793239}
-
David Benjamin authored
Now that we are using views on Mac, we can use the same client certificate selector used on CrOS, Linux, and Windows. This means less code to maintain, and it also avoids a host of bugs with the tab-constrained sheet logic which has become increasingly buggy as Chrome and macOS have evolved. (See associated bugs.) This retains tab-modality, so sites cannot prevent tab switching or tab closing, but it switches us from the native sheet to our own UI. Screenshots: https://drive.google.com/drive/folders/1YlVAWm-xL8ZDP9k-amdBb4l18nh08rJZ?usp=sharing This should leave parts of components/constrained_window and ClientCertIdentity::sec_identity_ref unused. A follow-up CL will unwind that logic. Bug: 983451, 1020622, 1078158, 1098786 Change-Id: I9b2ea99a91e63e45934725dead6bade35ec3ca4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314036Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#793238}
-
Xiyuan Xia authored
WebMediaPlayerMSCompositor::SetCurrentFrame considers rotation when checking for video frame size change. Otherwise, size is not handled properly when a new frame with a different rotation has the same pre-rotation frame size of the current frame. Bug: 990682 Change-Id: I022923a51697ed56dc036d955f94161906a2cd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327458Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793237}
-
Daniel Classon authored
DeepLinkingBehavior was beefed up to handle more of the logic. Updated the Reset Page to use the new methods. Bug: 1084154 Change-Id: I7234d0f5d9162614aa22e2eb03328ecabdd7fe24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318002 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#793236}
-
Rakina Zata Amni authored
The flag was accidentally deleted in the RenderViewHost->WebContents move. See https://chromium-review.googlesource.com/c/chromium/src/+/2266917/11/content/browser/renderer_host/render_view_host_impl.cc Bug: 1085003. Change-Id: Ifdfa90eb02117c5a599ab12bc5b2375e966c704c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329951 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793235}
-
Fabian Sommer authored
Replace two instances of $(setCertificates) with $(ref:setCertificates) Bug: 1078761 Change-Id: I23d3be5c8ffb04c7aa7f47e1333c55304bc54cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329535 Auto-Submit: Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Meggin Kearney <mkearney@chromium.org> Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#793234}
-
Guido Urdaneta authored
Prior to this CL, the method ContentBrowserClient::ShouldSandboxAudioService() returned false, which made the sandbox disabled by default for embedders that do not override this method, like content_shell. Instead, this should return true if the AudioServiceSandbox feature is enabled. This was a regression introduced in http://crrev.com/790723 Bug: 1111349,1109346 Change-Id: Ib38c02e63ee039e6550707026cf15a1ce8739575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329891Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#793233}
-
Michael Crouse authored
This change adds plumbing to allow the LiteVideo optimization to observe when rebuffer events occur so that all throttling can be stopped. A future change will record the even in the user blocklist and record the event in UKM. Bug: 1082554 Change-Id: I9109fe221800b355e46c78e80254f75f433f9448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#793232}
-
Mikel Astiz authored
This is intended to be used as an indication to the UI that the user should take action to improve recoverability of the sync-ed data. This patch introduces basic plumbing in TrustedVaultClient with TODOs to address platform-specific implementations in later patches. Meanwhile, StandaloneTrustedVaultClient is extended with test-only APIs for integration tests. Change-Id: Ic255e502d9e33b145272903dc2b7c3a7ec2a1cd8 Bug: 1081649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329751Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#793231}
-