- 23 Apr, 2020 40 commits
-
-
Jae Hoon Kim authored
Installing DLC prior to ListVms will cutdown the timeout cost of waiting for PluginVm Dispatcher to startup, which it won't be able to if PluginVM DLC is missing anyways. BUG=b:154285573 TEST=./unit_tests && ./browser_tests # --gtest_filter=*Plugin* Change-Id: Ib8de3a36bfb2b60d755f0457d3c289b8c71cca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155053 Commit-Queue: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#762113}
-
Trent Begin authored
This change adds a separate function for each telemetry category and reduces namespace noise by adding a cros_healthd using declaration. Bug: chromium:1071668 Change-Id: Ief23ce328f7386384b9d9a7309e19c235f00fd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161730 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#762112}
-
David Trainor authored
Move all Download Home strings to a separate grdp file, setting up the new structure for internal android download strings. Bug: 1062116 Change-Id: I29f627c6040f6fbc4baca7c1f11982a650311d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106815 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#762111}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7a0b07a8a543..72f991f760ac git log 7a0b07a8a543..72f991f760ac --date=short --first-parent --format='%ad %ae %s' 2020-04-23 sokcevic@google.com Fix printing error on git-rebase failure Created with: gclient setdep -r src/third_party/depot_tools@72f991f760ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071280 Tbr: agable@chromium.org Change-Id: I0fbdb4674b1c07bb5467502721dfefeb32d84f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163705Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#762110}
-
Collin Baker authored
When a child's preferred size changes, it already calls InvalidateLayout(). Immediately calling Layout() shouldn't be necessary. It causes several redundant layouts in many cases. This CL changes tests to not depend on BrowserView synchronously laying out itself. Instead, these tests trigger a layout when they need it. A method RunScheduledLayouts() is added to InProcessBrowserTest to run all scheduled layouts when needed. Bug: 1054489 Change-Id: Ie3d6197b86d8f9e82fe31fa19d80fa794d751d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133172 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#762109}
-
David Bertoni authored
The ExtensionApiTest.ChromeRuntimeReloadDisable test was broken due to underlying changes in the code that terminates extensions that reload themselves too frequently. It was also flaky. The new version is fixed and is also no longer flaky. Bug: 366181 Change-Id: I8b11cb5b2db1ee17885e3270cf41037faebb0923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150164 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Patrick Monette authored
Since it was now basically a glorified factory class for ServiceWorkerNavigationLoaderInterceptor, this CL moves the 2 factory functions there. Change-Id: I2facfdf8e7691a25027a5b223849138204d8f51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150289 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762107}
-
Matt Menke authored
The new two argument SetHeader() and AddHeader() methods are safer and allow for more flexibility in the design of the class, without requiring redundant string parsing. Fixed: 1068194 Change-Id: I795e69f2ef058ce164b3a97ed7a30040aa357896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155353 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#762106}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6fc0066aad67..e20f36f49562 git log 6fc0066aad67..e20f36f49562 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 j.vigil@samsung.com EGL: Implement EGL_ANDROID_native_fence_sync on vulkan 2020-04-23 jmadill@chromium.org Vulkan: Mask out implementation dirty bit in sync. 2020-04-23 jmadill@chromium.org Vulkan: Track allocated sampler counts. Created with: gclient setdep -r src/third_party/angle@e20f36f49562 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I9d4d77aeed05dbb02a6660bd586d18ca69e8a4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163458Reviewed-by:
-
Mohsen Izadi authored
This CL adds the possibility to inject a base::TickClock* into CompositorFrameReportingController, so its timing can be mocked by tests. CompositorFrameReportingControllerTest is also updated to make use of this. Bug: 1054009,1057193 Change-Id: I6ece91efe32395a37c14cd4ca4c59da9f2e05da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159894Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#762104}
-
Roberto Carrillo authored
R=chanli,bpastene,nodir,agable Bug: 1074031 Change-Id: I9c5529cf44ab4909a85a09fb3fe2b593b1b16bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163421Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#762103}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ee97fa3e34e3..bbb839e1e684 git log ee97fa3e34e3..bbb839e1e684 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 alexrudenko@chromium.org Prevent complete DOM update for breakpoints sidebar when debugging Created with: gclient setdep -r src/third_party/devtools-frontend/src@bbb839e1e684 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069694 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8373d88a95ade2f19c499e05896959226fc48541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163463Reviewed-by:
-
Hazem Ashmawy authored
Drawables all share the same state across the app. Changing the icon color in the bottom nav bar when switching fragments changes in all Drawables using the same resource. Calling Drawable#mutate() makes this Drawable mutable so that it doesn't share its state anymore. Fixed: 1069679 Test: Switch fragments and observe error view icon color Change-Id: I7c2d3c1ace7b3119de91e959ee4c5b9b3321a2dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161228 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#762101}
-
Garrett Beaty authored
This matches the convention used by the infra repo's starlark code and puts files that are more closely related closer to each in other in the hierarchy. Change-Id: I49ce3def16bef580063b2bf8ffe95ee56505ed4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161622 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#762100}
-
Yi Gu authored
The metric Event.VizHitTest.HitTestDataIsEqualAccuracy is still needed. Extend the expiry date to 2020-08-31 to align with other hit test related metrics. Bug: 1037083 Change-Id: Iec005c83eff7746e04331baa2ae498a82159b8b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161929Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#762099}
-
Lily Chen authored
This renames the attach_same_site_cookies parameter on URLRequest, ResourceRequest, and related navigation params to the more descriptive name force_ignore_site_for_cookies. This is mostly a straightforward find-and-replace, except for updating/ clarifying some comments, and leaving TODOs in a couple of places where the usage should be removed. TBR=dcheng@chromium.org,morlovich@chromium.org Bug: 1068792 Change-Id: If70353bd8c9d3a233990daa1733a58c16ebd859f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162209Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#762098}
-
Ian Kilpatrick authored
As above, there should be no behaviour change. Change-Id: I91757699706c632d24b4a71eacc5e8b82face59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163429Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#762097}
-
Qingwen Pi authored
MediaPipelineBackendFactory is not used. CmaBackendFactory is used instead. Bug: 149422033 Test: none Change-Id: I920120c59b325f9a72848ddf46394a7f25f8c52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163648Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Qingwen Pi <qwp@google.com> Cr-Commit-Position: refs/heads/master@{#762096}
-
Akihiro Ota authored
This patch fixes a crash that occurred when checking the available voices. Previously, we were assuming that TtsVoice objects, returned by chrome.tts.getVoices(), had a certain structure e.g. that the voice property was always set. This is not always the case, and the documentation states that all properties are actually optional. We now perform an error check before accessing TtsVoice.lang, which was the root of the issue. The test suite has been updated to check this case as well. Bug: 923068 Change-Id: I5936ab683c46add944bd915b7722733dbdf761bd Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163153 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#762095}
-
Guillaume Jenkins authored
Windows native spell checker integration in Chromium is still under development and the two associated feature flags must be extended. Bug: 978460 Change-Id: I10b252b84fd728b79f73f32e568c644830e3573f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163154Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#762094}
-
Ben Joyce authored
These changes were manually added into build.gn file for androidx migration. They are no longer needed now that the import calls have moved over. Bug: 1067050,1067070 Change-Id: Ia7cd36bf52b39444a2dec6bdc065e41b187a2c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160011Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#762093}
-
Akihiro Ota authored
This change: 1. Adds a new enum to ax_enums.mojom. 2. Creates a new output rule for IME candidates. 3. Adds a new method to PhoneticData to get phonetics for text. 4. Cleans up the goog.require() statements in output.js. Bug: 1034146, 1056062 Relnotes: ChromeVox gives phonetic readings for IME candidates. Change-Id: Idc620f2ef4b06dfcbf6f494ac900f92ee92831d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151852 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/513720f28ece..ed6e82796bde git log 513720f28ece..ed6e82796bde --date=short --first-parent --format='%ad %ae %s' 2020-04-23 csmartdalton@google.com Add a flag for suppressing tessellation shaders 2020-04-23 egdaniel@google.com Track d3d resources using sk_sp instead of raw pointers. 2020-04-23 jcgregorio@google.com Revert "Move SkFrontBufferedStream into Android-only dir" Created with: gclient setdep -r src/third_party/skia@ed6e82796bde If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I80661542f6af5f5b143deebad95307949755d21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163461Reviewed-by:
-
Regan Hsu authored
Do not announce a route has been navigated to when a OS Settings search result is clicked/entered upon. Fixed: 1071283 Change-Id: I522643ffa7d18afd49699eb83e6dabb7e059261b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158685 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#762090}
-
zhaoyangli authored
Added the property to iOS CI and try builder definitions. Recipe side change consuming the properties: crrev/c/2161434 Bug: 1072033 Change-Id: Id14eee275d92b4620156a99ec2d764767f204544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161624 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#762089}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f446cc3c798..dacaac7b0f29 git log 7f446cc3c798..dacaac7b0f29 --date=short --first-parent --format='%ad %ae %s' 2020-04-23 bravi@microsoft.com Implemented URI Action Handling for links 2020-04-23 thestig@chromium.org Fix nits in StructElement code. 2020-04-23 thestig@chromium.org Do IWYU to fix building with gcc. 2020-04-23 thestig@chromium.org Auto format GN build files. Created with: gclient setdep -r src/third_party/pdfium@dacaac7b0f29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:994500 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I860977fb5ed2a5b74398b98891480677f9ccd865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163457Reviewed-by:
-
Chan Li authored
Change-Id: Ie44434f04b903ed4ae66098be3ac7d8ebfccf3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163434Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#762087}
-
Kyle Horimoto authored
This CL migrates device UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: Ia1c5a845ed54e377d8db6f4880759d9dca7f13b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2162106 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#762086}
-
edchin authored
Change-Id: Ic33e18618ad0dcc63c233d97d9c9f87132241f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163410Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#762085}
-
Lan Wei authored
After we merged the new GpuBenchmarking::SmoothScrollByXY, which has two delta values, for vertical and horizontal scroll deltas, we should this new function for all the scroll functions in resources/gesture-util.js. So here we change wheelTick function to take deltaX and deltaY instead of one delta and direction values, so now scroll deltaX and deltaY can be different values. Bug: 1047176 Change-Id: If692c7b807e9d2d5a00fefe09ce4b00a9be0c4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161651 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762084}
-
Stephen McGruer authored
This is symptomatic of crbug.com/1047818, but to stop the pain for sheriffs lets mark it timeout=long for now. Bug: 1073865 Change-Id: I60fa045c61402ec5c6df21c62918df5c109df5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163081 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#762083}
-
Ryan Sturm authored
Bug: 1073990 Change-Id: Icabcf162477719893fd0d84761bfad327ed764a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163253 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#762082}
-
Anders Hartvoll Ruud authored
The @property rule is relevant for CSS Typed OM, because the syntax of a registered custom property can now be changed several times, or even revert back to unregistered. This affects how values should reify. Bug: 973830 Change-Id: I0ad5ba843b89d9153657e8b3f464e2dd33659cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160894 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#762081}
-
Annie Sullivan authored
This was erroneously removed from r761522. TBR=npm@chromium.org Change-Id: I8245dc8f175b53b31c8b8d90b22ada8306dc6684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163418Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#762080}
-
Ella Ge authored
The created SkBitmap was not set to |splash_icon| correctly and it will always be null. Add a "splash_icon = " to fix that. Bug: None Change-Id: Id229c1658612b092cbaf5452dc9a7a250207f567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163075 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#762079}
-
Nico Weber authored
This reverts commit 2864cb50. Reason for revert: Reland with fix, see investigation in https://crbug.com/1056216 Original change's description: > Revert "Roll libunwind 43bb9f8722..d999d54f4b" > > This reverts commit 74270ce2. > > Reason for revert: Apparently causes crashes, https://crbug.com/1055188 > > Original change's description: > > Roll libunwind 43bb9f8722..d999d54f4b > > > > ...and enable Wbitwise-conditional-parentheses on android. > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43bb9f8722..d999d54f4b > > > > Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds > > 11b0129 [libunwind] Treat assembly files as C on mingw > > 76f6916 [libunwind] Fix building standalone after c48974ffd7d1676 > > aea9f89 [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C > > e4cbc26 Bump the trunk major version to 11 > > e12b248 [libunwind] Fix evaluating DWARF operation DW_OP_pick > > c3889d9 [unwind] Don't link libpthread and libdl on Fuchsia > > 81f7e17 [libunwind][RISCV] Add 64-bit RISC-V support > > baf07ac Reland "Enable `-funwind-tables` flag when building libunwind" > > 2ef1190 Revert "Enable `-funwind-tables` flag when building libunwind" > > 2fd0a70 Enable `-funwind-tables` flag when building libunwind > > f939ab7 [libunwind] Emit dependent libraries only when detected > > 4cd4dca [libunwind] Adjust the signal_frame test for Arm > > 0b1d80f change LLVM_VERSION_SUFFIX default from svn to git > > b6a6639 Correctly update isSignalFrame when unwinding the stack via dwarf. > > e7f96ac unwind: restore the LINKER_LANGUAGE > > e24563d unwind: reflow some of the build rules (NFC) > > f2c3035 unwind: disable RTTI during the build of libunwind > > a4a7180 Revert "build: explicitly set the linker language for unwind" > > ccff66b build: explicitly set the linker language for unwind > > a914ec1 [libunwind] [Windows] Add a log message if EnumProcessModules fails > > 2a4f136 [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic > > b6bfd8b [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug > > 1073ad9 [libunwind] Fix issues introduced in r374606 > > cfb6df8 [libunwind] Refactor CMake flag checks to match libc++ and libc++abi > > 57be2d2 [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI > > 5342138 Unwind: avoid warning about unused typedef > > 78b42cc Unwind: prevent unw_get_proc_info from returning stale data > > 2aa34a8 unwind: remove a could of extraneous `else` (NFC) > > c699521 [runtimes] Don't depend on libpthread on Android > > 9d72a29 [libunwind][ARM] Fix types in _Unwind_VRS_Get. > > d003462 [libunwind][ARM] Fix loading FP registers on big-endian targets > > 558e694 Bump the trunk version to 10.0.0svn > > 8d9ed37 [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets > > 0baf612 [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto > > b5b4a50 [Docs] Modernize references to macOS > > 7aecb76 [CMake] Use find_package(LLVM) instead of LLVMConfig > > e2fa4a0 [runtimes] Use -Wunknown-pragmas for the pragma check > > 0e59516 [runtimes] Check if pragma comment(lib, ...) is supported first > > 7b72703 [runtimes] Support ELF dependent libraries feature > > 06a69dc [libunwind] [test] Fix inferring source paths > > 1f9c24d [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++ > > 7611bf2 [PPC] Fix 32-bit build of libunwind > > 8a6fc69 [PPC64][libunwind] Fix r2 not properly restored > > 7f90e76 Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force > > 22e7c0c [gn] Support for building libunwind > > 103afa4 [NFC] Fix typo in debug log > > f5d6a44 Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax) > > f8c730d [NFC] Move the export attribute after extern "C". > > 59d0c60 [NFC] Correct outdated links to the Itanium C++ ABI documentation > > 01fc413 [libunwind] Fix the typo in unw_save_vfp_as_X alias > > 2b63e62 Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__) > > 2ec9ffc [libunwind] Export the weak alias in Mach-O > > 9bbfad5 [libunwind] Export the unw_* symbols as weak symbols > > e63f955 [libunwind] Do not share an object library to create the static/shared libraries > > 2a2b62e Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/" > > 9021011 [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ > > 4287808 [CMake][libunwind] Define add_target_flags which is missing > > 3674fe4 [CMake] Don't cache LLVM_MAIN_SRC_DIR > > 99b7c05 [CMake] Support compiler-rt builtins library in tests > > a6a888a [CMake] Support CMake variables for setting target, sysroot and toolchain > > 5f5036e Provide a placement new definition for the SEH version of UnwindCursor > > 36f6154 [libunwind] Provide placement new definition > > f50a5ed [libunwind] Remove the remote unwinding support > > 370ec3f [CMake] Use correct visibility for linked libraries in CMake > > a0f0700 Revert "[CMake] Use correct visibility for linked libraries in CMake" > > d6e1714 [CMake] Use correct visibility for linked libraries in CMake > > 809c2b5 [libunwind] Support building hermetic static library > > ac0d9e0 Drop the dependency on <algorithm>, add placement new inline > > 8835912 Adjust documentation for git migration. > > fafb21e Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__ > > a9ccb4e Revert "[libunwind] Drop the dependency on <algorithm>, add placement new inline" > > cf8d0d6 Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library" > > b31f294 [libunwind] Drop the dependency on <algorithm>, add placement new inline > > 6a3a019 [CMake] Use __libc_start_main rather than fopen when checking for C library > > 1f978e9 [libunwind] Use placement new to avoid dependency C++ library > > 06be328 [libunwind] Don't abort if encoutering invalid .eh_frame_hdr > > 059a163 Silence warnings about unused parameters > > 13d23c8 Remove an unused variable > > 688e594 Add casts to avoid warnings about implicit conversions losing precision > > 985a1d1 Fix warnings about printf format strings > > 55b1c00 Enable LLVM_ENABLE_WARNINGS when building standalone out of tree > > 0dc7999 Fix typos throughout the license files that somehow I and my reviewers > > 61860a5 Update more file headers across all of the LLVM projects in the monorepo > > 60b38b7 Install new LLVM license structure and new developer policy. > > 9180f77 [SjLj] Don't use __declspec(thread) in MinGW mode > > 14d9c7b Bump the trunk version to 9.0.0svn > > b9268be Update year in license files > > 9f2f07a [Sparc] Add Sparc V8 support > > 38d0a65 Revert "[Sparc] Add Sparc V8 support" > > d71bc56 [Sparc] Add Sparc V8 support > > ce15011 [SEH] Add initial support for AArch64 > > cba83c3 [AArch64][libunwind] Unwinding support for return address signing with B Key > > 4d8e431 [AArch64][libunwind] Unwinding support for return address signing > > > > Bug: 1016947 > > Change-Id: I37d815a111ce4a5cf4a246fc4558d8c7ba5f7fad > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062638 > > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#743604} > > TBR=thakis@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1016947 > Change-Id: I057e99ca246ea87fbcc8799f3ba157915e24a54b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068735 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743922} TBR=thakis@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1016947,1056216,1055188 Cq-Do-Not-Cancel-Tryjobs: true Change-Id: Ib8da66625a45529fb5f9d7ac407bae67bf569cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163440 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#762078}
-
Anastasia Helfinstein authored
In bringing Switch Access up to the visual specification, the menu is being rewritten directly in views/. This change adds the remaining buttons that may appear in the menu, as well as adding the ability to specify which buttons are displayed and firing an event when the button is pressed. This code is not yet used by the feature; it will be fully incorporated in a follow-up change. Relnotes: N/A Bug: 973719 Change-Id: Ibc3c820b2ad791ee8107ce86da75ba52471e71ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151826 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2fab28f9edee8fbdb9987e83777bc18b58b2f8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163155Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#762076}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I2f027d0fa2553367195e71359234b9a455c599a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112988 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#762075}
-
Trent Begin authored
Update cros_healthd telemetry handling code to check for and log errors from BatteryInfo request. Bug: chromium:1041153 Change-Id: Ic88d6146cfd81468d7023f02f7e4d0671e05a68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153603 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
-
