GitLab

This test is super flaky since the tests were moved around, it's failing like 90% of the time.

NOTRY=true
BUG=166703

Review URL: https://codereview.chromium.org/102543005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238510 0039d316-1c4b-4281-b951-d872f2087c98

see https://codereview.chromium.org/78033003/ for the original CL...

BUG=324464
TEST=https://simpl.info/getusermedia/sources/ and manual unittests in media.

Review URL: https://codereview.chromium.org/99063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238509 0039d316-1c4b-4281-b951-d872f2087c98

RenderWidgetHostViewAndroid no longer subclasses DelegatingRendererLayerClient.
As it was the only use case for DelegatingRendererLayerClient, we can now remove
this class.

BUG=273250

Review URL: https://codereview.chromium.org/93463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238508 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321704
TEST=ash_unittests --gtest_filter=*WorkspaceControllerTestDragging.DragWindowOverlapShelf*

Review URL: https://codereview.chromium.org/93103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238507 0039d316-1c4b-4281-b951-d872f2087c98

Because we need hooks to do a bunch of things.

R=ben@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/103123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238506 0039d316-1c4b-4281-b951-d872f2087c98

While r238430 improved things, it didn't fix them enough. Exciting new error:

OSError: File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/<(mac_product_name) Framework.framework doesn't exist

(tracked at http://crbug.com/324911)

> Revert 238036 "Revert 238025 "Let test_isolation_mode default to..."
> 
> The change was reverted because swarming didn't work with branded builds,
> but r238430 should've fixed that. Relanding. (There are no branded trybots.)
> 
> > Revert 238025 "Let test_isolation_mode default to check on mac."
> > 
> > Failing on "Google Chrome Mac" (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15042)
> > In the error log, tools/swarming_client/isolate.py says "File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Chromium Framework.framework doesn't exist"
> > 
> > > Let test_isolation_mode default to check on mac.
> > > 
> > > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to
> > > issues with xcode. Now that xcode is no longer used, it can be set to check
> > > again.
> > > 
> > > BUG=none
> > > 
> > > Review URL: https://codereview.chromium.org/92303002
> > 
> > TBR=thakis@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/98383002
> 
> TBR=hashimoto@chromium.org
> 
> Review URL: https://codereview.chromium.org/102963003

TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/98533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238505 0039d316-1c4b-4281-b951-d872f2087c98

PlatformFile has grown beyond the initial expectations and it doesn't make
sense to continue supporting individual function wrappers instead of a
proper file class.

BUG=322664
TEST=base_unittests
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/93513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238504 0039d316-1c4b-4281-b951-d872f2087c98

Add generic interfaces for the sinks of the media stream audio track to get the audio data, and this patch also adds interfaces of AddToAudioTrack and RemoveFromAudioTrack to connect the sink to the audio track.


BUG=322547

Review URL: https://codereview.chromium.org/90743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238503 0039d316-1c4b-4281-b951-d872f2087c98

BUG=245126
R=nasko@chromium.org, yzshen@chromium.org

Review URL: https://codereview.chromium.org/100943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238502 0039d316-1c4b-4281-b951-d872f2087c98

Introduces two new methods to AudioOutputDispatcher:
CloseStreamsForWedgeFix() and RestartStreamsForWedgeFix().

Respectively, each method closes or restarts all active
streams owned by a given dispatcher.  The process is
completely transparent to upstream clients.

A new method on AudioManager, FixWedgedAudio() calls
CloseStreamsForWedgeFix() for all dispatchers and then
calls RestartStreamsForWedgeFix() afterward.

FixWedgedAudio() is called by each AudioOutputController
when a wedge is detected.  Multiple in flight wedge checks
are serialized by the audio thread.  The hope is that wedges
will be fixed before the next WedgeCheck() fires.

While the methods are available on all platforms, FixWedgedAudio()
is only wired up on OSX.

BUG=160920
TEST=unittest. fake wedge and observe stream recreation.
R=scherkus@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238325

Review URL: https://codereview.chromium.org/61203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238501 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307027

Review URL: https://codereview.chromium.org/73333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238500 0039d316-1c4b-4281-b951-d872f2087c98

r238462 - https://codereview.chromium.org/100303005/
may have broken this test. anantha@chromium.org will investigate and fix this issue.

BUG=325540
TBR=sky

Review URL: https://codereview.chromium.org/103353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238499 0039d316-1c4b-4281-b951-d872f2087c98

This patch will link the blink implementation for mix-blend-mode with
the compositor implementation.
Blink: https://codereview.chromium.org/23511004/
Cc: https://codereview.chromium.org/23455060/

BUG=243223

Review URL: https://codereview.chromium.org/66263003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238498 0039d316-1c4b-4281-b951-d872f2087c98

Flaky failures, see bug

BUG=324915
TEST=browser_tests
R=asargent@chromium.org

Review URL: https://codereview.chromium.org/101613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238497 0039d316-1c4b-4281-b951-d872f2087c98

Some GYP variables are named like "pkg-config"

Replace - with _ when doing converting GN variable names.

TBR=michaeln

Review URL: https://codereview.chromium.org/103193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238494 0039d316-1c4b-4281-b951-d872f2087c98

This checks the bittedness of the local system using getconf instead of "file
/sbin/init". "file" isn't on some ChromeOS roots.

BUG=
R=thakis@chromium.org
TBR=thakis

Review URL: https://codereview.chromium.org/100053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238493 0039d316-1c4b-4281-b951-d872f2087c98

- Removed original mdpi density.

R=newt@chromium.org

Review URL: https://codereview.chromium.org/92133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238492 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238489 0039d316-1c4b-4281-b951-d872f2087c98

R=newt@chromium.org

Review URL: https://codereview.chromium.org/102603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238488 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/103113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238487 0039d316-1c4b-4281-b951-d872f2087c98

Without GYP_DEFINES set, build/gyp_chromium would crash with

Generating gyp files from GN...
Traceback (most recent call last):
  File "./build/gyp_chromium", line 207, in <module>
    if not RunGN(supplemental_includes):
  File "./build/gyp_chromium", line 147, in RunGN
    gyp_vars = GetVarsStringForGN(supplemental_includes)
  File "./build/gyp_chromium", line 79, in GetVarsStringForGN
    items = shlex.split(env_string)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 279, in split
    return list(lex)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 269, in next
    token = self.get_token()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 96, in get_token
    raw = self.read_token()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/shlex.py", line 124, in read_token
    nextchar = self.instream.read(1)
AttributeError: 'list' object has no attribute 'read'

This was broken by r238475

BUG=321352

Review URL: https://codereview.chromium.org/103253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238486 0039d316-1c4b-4281-b951-d872f2087c98

AudioStreamHandler was calling into the AudioManager on the wrong
thread.  On OSX this will lead to undefined behavior since the
CoreAudio API is not thread safe.

Sadly due to antique unit tests, we don't have the proper DCHECKs
in place to catch bad behavior automatically.  I've filed the bug
below to track this effort.

In this case we can simply use a fixed buffer size since ASH is
using MakeAudioOutputStreamProxy() which will take care of any
necessary rebuffering and resampling.

BUG=325373
TEST=none
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/102693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238484 0039d316-1c4b-4281-b951-d872f2087c98

Conflicts:
	tools/gn/bin/win/gn.exe.sha1

iPull GN binary at 238460

Pull Windows GN binary @238460 (debug build).

This is to help debuf issues since it will have proper stack traces.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238479 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the implementation of Mojo's JavaScript bindings out of the
"public" directory. The public directory is intended to be free of dependencies
on other parts of Chromium, but the JavaScript bindings depend on V8 and base.
Now, the bindings are just a subdirectory of mojo/apps/js, which is their only
client. This makes mojo.js more of a self-contained app.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/100573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238476 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of 236542 and 238454 (runs GN in GYP mode before actually running GYP), plus some additions

Move GYP_DEFINES parsing to Python for GN.

I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.

Currently, GN does not produce any files used by the build, these will be added in a second step.

BUG=321352
TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/101573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238475 0039d316-1c4b-4281-b951-d872f2087c98

The shell is now run on the main (UI) thread along with the NativeViewport stuff.

R=abarth@chromium.org
http://crbug.com/324637

Review URL: https://codereview.chromium.org/100623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238474 0039d316-1c4b-4281-b951-d872f2087c98

Reason: Candidate for Mac 10.6 and 10.7 Break - IOSurfaceReuse

> cc: Defer first OutputSurface creation until client is ready
> 
> Remove the |first_output_surface| which was not used before
> the client signals ready.
> This allows the client to wait before creating a graphics context
> until the gpu thread and client channel are set up.
> 
> BUG=270179
> R=danakj@chromium.org, jamesr@chromium.org, jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/85693007

TBR=sievers@chromium.org

Review URL: https://codereview.chromium.org/103163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314791
TEST=No behavior change.
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/101863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238468 0039d316-1c4b-4281-b951-d872f2087c98

TESTS=Please follow steps as outlined in the bug report.
R=cpu@chromium.org, ananta@chromium.org
BUG=318503

Review URL: https://codereview.chromium.org/102403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238467 0039d316-1c4b-4281-b951-d872f2087c98

The change was reverted because swarming didn't work with branded builds,
but r238430 should've fixed that. Relanding. (There are no branded trybots.)

> Revert 238025 "Let test_isolation_mode default to check on mac."
> 
> Failing on "Google Chrome Mac" (http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/15042)
> In the error log, tools/swarming_client/isolate.py says "File /Volumes/data/b/build/slave/google-chrome-rel-mac/build/src/out/Release/Chromium Framework.framework doesn't exist"
> 
> > Let test_isolation_mode default to check on mac.
> > 
> > It was set to noop in https://chromiumcodereview.appspot.com/14055005 due to
> > issues with xcode. Now that xcode is no longer used, it can be set to check
> > again.
> > 
> > BUG=none
> > 
> > Review URL: https://codereview.chromium.org/92303002
> 
> TBR=thakis@chromium.org
> 
> Review URL: https://codereview.chromium.org/98383002

TBR=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/102963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238466 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/102843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98

Previously the tests were using actual media sources. This change makes
the test more reliable as they no longer depend on system resources.
Also FakeDesktopMediaList has been moved from
desktop_media_picker_controller_unittest.mm to a separate file so it can
be reused

R=mpcomplete@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/100303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238463 0039d316-1c4b-4281-b951-d872f2087c98

The current code posts the events via the Aura code path which does not work on Windows with the glass theme for the system
menu buttons (Min/Max/Restore). These are part of the non client area of the Window and rely on the WM_NCLBUTTONDOWN message
to be defproced which eventually posts a WM_SYSCOMMAND message for the corresponding operation.

Fix is to check if the NativeWindow doing a repost is in the Metro environment for Windows. If yes we continue the current logic
of reposting the events via Aura. If not we post the message natively. The RepostLocatedEvent function internally calls
the RepostLocatedEventWin function to post the function natively. The functionality to check if a window is in metro
has been added to the ViewsDelegate interface and is implemented by Chrome.

Fixes bug https://code.google.com/p/chromium/issues/detail?id=323105

BUG=323105
R=sky@chromium.org

Review URL: https://codereview.chromium.org/100303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238462 0039d316-1c4b-4281-b951-d872f2087c98

This is to help debuf issues since it will have proper stack traces.

BUG=

Review URL: https://codereview.chromium.org/102373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238461 0039d316-1c4b-4281-b951-d872f2087c98

R=agl@chromium.org
BUG=315828
TEST=none

Review URL: https://codereview.chromium.org/99253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238460 0039d316-1c4b-4281-b951-d872f2087c98

> Hook up GN to the GYP build system.
> 
> This is a reland of 236542 (runs GN in GYP mode before actually running GYP), plus some additions
> 
> Move GYP_DEFINES parsing to Python for GN.
> 
> I pass in a GN-compatible list of variable sets on the command line from Python. This allows us to parse chromium.gyp_env and src/*/supplemental.gypi in Python like normal without having to duplicate Python dictionary parsing in GN.
> 
> Currently, GN does not produce any files used by the build, these will be added in a second step.
> 
> BUG=321352
> R=bradnelson@google.com
> 
> Review URL: https://codereview.chromium.org/73623005

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/102923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238459 0039d316-1c4b-4281-b951-d872f2087c98

Remove the |first_output_surface| which was not used before
the client signals ready.
This allows the client to wait before creating a graphics context
until the gpu thread and client channel are set up.

BUG=270179
R=danakj@chromium.org, jamesr@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/85693007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238458 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
BUG=325058
TEST=visual

Review URL: https://codereview.chromium.org/98973004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238457 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Test=all tests pass.

Review URL: https://codereview.chromium.org/102243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238456 0039d316-1c4b-4281-b951-d872f2087c98

I also added a break below, where it's not needed, for clarity,
and to avoid any future refactoring from introducing a similar bug.

BUG=102485,177475

Review URL: https://codereview.chromium.org/101383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238455 0039d316-1c4b-4281-b951-d872f2087c98