- 17 Mar, 2016 40 commits
-
-
msramek authored
The Clear Browsing Data dialog UI will provide a notice informing the user that history.google.com stores other forms of browsing history (such as the search history). We will only show the notice to those users for whom it is valid. This will be determined by Sync status, and by a JSON response from history.google.com [not yet implemented]. See https://docs.google.com/document/d/1ZMDSAd44KmzKhqXPjobZOf9rZezs6VqiBnqpDD0auCU/ for the background. To communicate between backends (ProfileSyncService, HistoryService) and frontends on all platforms, we need to put this logic to a component (especially because of iOS). We create a new component "browsing_data_ui". BUG=595332 Review URL: https://codereview.chromium.org/1806873002 Cr-Commit-Position: refs/heads/master@{#381804}
-
scottmg authored
Only used for Metro on Windows, which no longer exists. R=dpapad@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1809213002 Cr-Commit-Position: refs/heads/master@{#381803}
-
danakj authored
These tests fail to set up correctly on Windows, so running the tests just crashes. Restore the early outs with an ifdef for windows so we document where the early out will happen, along with comments. R=kbr@chromium.org, piman@chromium.org BUG=595823, 584497 Review URL: https://codereview.chromium.org/1812033002 Cr-Commit-Position: refs/heads/master@{#381802}
-
petarj authored
Remove options that were valid for pnacl toolchain but are not valid for mipsel-nacl-clang. This fixes the build issues: mipsel-nacl-clang: error: unsupported option '--pnacl-mips-bias' mipsel-nacl-clang: error: unsupported option '--pnacl-allow-translate' Review URL: https://codereview.chromium.org/1806403002 Cr-Commit-Position: refs/heads/master@{#381801}
-
jrummell authored
Now that VideoFrames are transported across mojo using shared memory, the original needs to stay around until the other side is no longer using it, after which the shared memory can be reused for a subsequent VideoFrame. BUG=510153 TEST=compiles on Windows Review URL: https://codereview.chromium.org/1809903002 Cr-Commit-Position: refs/heads/master@{#381800}
-
danakj authored
This removes the method from the WebGraphicsContext3D API, and makes callers go directly to the GLES2Interface instead. The DepthStencilTrackingGLES2Interface is introduced for the DepthStencilTrackingContext to use in DrawingBufferTest, and code will migrate to it as methods are replaced in WebGraphicsContext3D. R=kbr@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1808933002 Cr-Commit-Position: refs/heads/master@{#381799}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/873938e2..79f4376c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1811083002 Cr-Commit-Position: refs/heads/master@{#381798}
-
lukasza authored
WebTestInterfaces::GetAppBannerClient can be removed, because TestRunner::ResolveBeforeInstallPromptPromise can interact with AppBannerClient directly, rather than going through WebTestDelegate. This also means that components/test_runner/app_banner_client.h header no longer needs to be included outside of components/test_runner. BUG=595089 Review URL: https://codereview.chromium.org/1807643002 Cr-Commit-Position: refs/heads/master@{#381797}
-
sergeyu authored
Previoulsy both token_binding_nss.cc and token_binding_openssl.cc were compiled when compiling net for NaCl. This was causing linker warkings about duplicate symbols. BUG=595790 Review URL: https://codereview.chromium.org/1807313002 Cr-Commit-Position: refs/heads/master@{#381796}
-
fnk authored
Up to and including internal change 117245736 Fix a type casting bug in quic stream sequencer buffer. Withough this change, a QUIC frame with offset higher than 2^32 might corrupt StreamSequencerBuffer's missing frame recording logic in a 32-bit machine. Merge internal change: 117245736 https://codereview.chromium.org/1808013003/ Always use recvmmsg or recvmsg if it's available, and consolidate ReadAndDispatchPackets and ReadAndDispatchSinglePacket into a single API. Not flag protected. No functional change. Note that this does somewhat reduce the test coverage of QuicServerTest, now requiring that changes to QuicPacketReader::ReadAndDispatchSinglePacket be run on platforms that don't support recvmmsg. Merge internal change: 117245279 https://codereview.chromium.org/1810103002/ Log when client nonce is invalid. No functional change. Not flag protected. Merge internal change: 116987771 https://codereview.chromium.org/1810073002/ Pass QuicTime, QuicTime::Delta, and QuicBandwidth exclusively by value. Not flag protected. No functional change. Merge internal change: 116973081 https://codereview.chromium.org/1809123002/ Change QUIC tests that use port 80 to use 443. Merge internal change: 116970314 https://codereview.chromium.org/1808963003/ Use byte conservation instead of packet conservation in QUIC's Slow Start Large Recovery experiment. Protected by quic_sslr_byte_conservation. Merge internal change: 116964633 https://codereview.chromium.org/1814873002/ Remove the unused has_retransmittable_data argument from QuicSendAlgorithm::TimeUntilSend. No functional change. Not flag protected. Merge internal change: 116904472 https://codereview.chromium.org/1814843002/ Deprecates check_peer_address_change_after_decryption. Merge internal change: 116887287 https://codereview.chromium.org/1808613003/ Deprecate quic_respect_send_alarm2. Merge internal change: 116879870 https://codereview.chromium.org/1813513002/ Deprecate --quic_include_path_id_in_iv. Merge internal change: 116877752 https://codereview.chromium.org/1810743002/ Don't copy the QuicAckFrame into the QuicPacketGenerator. Protected by quic_dont_copy_acks. Merge internal change: 116808648 https://codereview.chromium.org/1807033002/ No longer limit QUIC's max CWND to 200 packets. Protected by quic_dont_limit_max_cwnd. This is a fix for the deprecation of a similar flag in cr/113769379. Merge internal change: 116794514 https://codereview.chromium.org/1812633002/ Remove QuicFrameList, because it's unused with the new QuicStreamSequencer. Merge internal change: 116768420 https://codereview.chromium.org/1805323003/ Add a QuicConfig option to ask the client not to attempt migration. Merge internal change: 116712124 https://codereview.chromium.org/1808513003/ Do not disable TLP by default in QuicConnection tests. Merge internal change: 116698228 https://codereview.chromium.org/1808863002/ Add a new QUIC connection option, 5RTO, which closes the QUIC connection after 5 consecutive RTOs. Protected by quic_enable_rto_timeout. Merge internal change: 116687954 https://codereview.chromium.org/1806083002/ Change QuicConnection's ScopedPacketBundler to use SEND_QUEUED_ACK instead of NO_ACK, to ensure a queued ack is always sent. Small functional change. Not flag protected. Merge internal change: 116677107 https://codereview.chromium.org/1814483002/ deprecate quic_use_rfc7539 Merge internal change: 116589902 https://codereview.chromium.org/1809703002/ Use cached compressed certs if available to reduce load of compressing certs. Flag protected by quic_use_cached_compressed_certs. Merge internal change: 116579250. https://codereview.chromium.org/1808793002/ R=rch@chromium.org BUG= Review URL: https://codereview.chromium.org/1811043002 Cr-Commit-Position: refs/heads/master@{#381795}
-
fgorski authored
Revert of Update DevTools Tracing.Start to accept trace config as a parameter (patchset #10 id:180001 of https://codereview.chromium.org/1765153002/ ) Reason for revert: TraceConfigTest.TraceConfigFromDict fialed https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/21289/steps/base_unittests/logs/stdio https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/21289 Original issue's description: > Update DevTools Tracing.Start to accept trace config as > a parameter > > This CL updates Tracing.Start to accept trace config as > a parameter when starting tracing. It is backward compatible > with the old way. > > Design doc: https://goo.gl/GxQ23k > BUG=579358 > > Committed: https://crrev.com/c0e3792f832fc454324dbe35d01079b124b072cd > Cr-Commit-Position: refs/heads/master@{#381783} TBR=caseq@chromium.org,primiano@chromium.org,nednguyen@google.com,petrcermak@chromium.org,simonhatch@chromium.org,pfeldman@chromium.org,zhenw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579358 Review URL: https://codereview.chromium.org/1814043002 Cr-Commit-Position: refs/heads/master@{#381794}
-
dcheng authored
BUG=554298 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1810893003 Cr-Commit-Position: refs/heads/master@{#381793}
-
sebsg authored
Some text state fields have a maxlength of two. This can cause problem for some states. For example New York is filled as NE (Nebraska) instead of NY. BUG=595104 TEST=AutofillFieldTest Review URL: https://codereview.chromium.org/1811543002 Cr-Commit-Position: refs/heads/master@{#381792}
-
rch authored
Committed: https://crrev.com/dced4c771d25317d26a0f6e258c7b7f64d4e8eea Cr-Commit-Position: refs/heads/master@{#379652} Committed: https://crrev.com/740688bec5c66af00debe117b6d375ecd212e570 Cr-Commit-Position: refs/heads/master@{#381134} Review URL: https://codereview.chromium.org/1699653002 Cr-Commit-Position: refs/heads/master@{#381791}
-
mek authored
This changes the basic SingleLinkHeaderTest to not verify implementation details of how LinkHeader deals with invalid headers. If a header is invalid it doesn't matter what it's url, rel and other attributes are set to. Also adds a missing EXPECT to compare the expected "as" attribute with the returned "as" attribute. Review URL: https://codereview.chromium.org/1778413005 Cr-Commit-Position: refs/heads/master@{#381790}
-
caseq authored
... for ease of re-used outside of front-end codebase. Review URL: https://codereview.chromium.org/1808063002 Cr-Commit-Position: refs/heads/master@{#381789}
-
alexmos authored
When we changed RenderFrameProxyHost::OnOpenURL to use the transfer logic in r377832, we lost FilterURL validation provided by RenderFrameHostImpl::OpenURL. This CL adds that validation to navigations initiated via proxies. BUG=595339 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1812723002 Cr-Commit-Position: refs/heads/master@{#381788}
-
philipj authored
https://github.com/whatwg/html/issues/869#issuecomment-196189743 R=mlamouri@chromium.org,isherman@chromium.org Review URL: https://codereview.chromium.org/1809023003 Cr-Commit-Position: refs/heads/master@{#381787}
-
marpan authored
https://chromium.googlesource.com/webm/libvpx.git/+log/9aa083d164e0..afd869308ef4 $ git log 9aa083d16..afd869308 --date=short --no-merges --format='%ad %ae %s' 2016-03-15 paulwilkins Revert "Fix bug in stats output for HBD." 2016-03-15 marpan vp9: Fix to scene cut/content change detection. 2016-03-15 huisu Fix typos in unit tests 2016-03-14 marpan vp9: Scene cut/content change detection: Adjust gf update. 2016-03-14 marpan vp9: Scene cut/slide change detection: Increse min_thresh. 2016-03-11 marpan vp9: Switch to model=1 for skin detection. 2016-03-11 marpan vp9: Fix issue in scene/content change detection. 2016-02-24 marpan vp9 non-rd pickmode. Some adjustments for vbr mode. 2016-03-10 marpan vp9: Update to skin detection. 2016-03-08 marpan vp9-svc: Fix to frame dropping in svc mode. 2016-03-08 marpan vp9-svc: Change default spatial bitrate allocation. 2016-03-08 jzern vp9_svc_layercontext(): fix proto mismatch 2016-03-08 marpan vp9-svc unitests: Add more tests for key frame periods. 2016-03-08 slavarnway VPX: loopfilter_mmx.asm using x86inc 2 2016-03-07 marpan vp9-resize tests: Update to real-time resize unittests. 2016-03-07 marpan vp9-svc: Fix to resetting pattern/flags on key frame. 2016-03-07 slavarnway define GET_GOT_DEFINED if not previously defined 2016-03-07 marpan vp9-svc: Non-rd pickmode, fix condition for testing zeromv for spatial ref. R=johannkoenig@google.com Review URL: https://codereview.chromium.org/1811993003 Cr-Commit-Position: refs/heads/master@{#381786}
-
amistry authored
BUG=582468 Review URL: https://codereview.chromium.org/1804353002 Cr-Commit-Position: refs/heads/master@{#381785}
-
gmanikpure authored
BUG= Review URL: https://codereview.chromium.org/1813813003 Cr-Commit-Position: refs/heads/master@{#381784}
-
zhenw authored
a parameter This CL updates Tracing.Start to accept trace config as a parameter when starting tracing. It is backward compatible with the old way. Design doc: https://goo.gl/GxQ23k BUG=579358 Review URL: https://codereview.chromium.org/1765153002 Cr-Commit-Position: refs/heads/master@{#381783}
-
dschuyler authored
Alan felt that just the word 'Search' made the side nav look like it was an option to search inside settings. He asked that the section name be changed to 'Search engine'. BUG=589630 Review URL: https://codereview.chromium.org/1812523004 Cr-Commit-Position: refs/heads/master@{#381782}
-
oshima authored
BUG=595794 R=georgesak@chromium.org Review URL: https://codereview.chromium.org/1807303003 Cr-Commit-Position: refs/heads/master@{#381781}
-
csharrison authored
This patch adds a method on NetworkMetricsProvider that logs aggregate ABORT metrics on the NetworkMetricsProvider::ProvideGeneralMetrics callback. This gives finer grained abort statistics. BUG=557430 Review URL: https://codereview.chromium.org/1796983002 Cr-Commit-Position: refs/heads/master@{#381780}
-
enne authored
Also, add back throttling tests to check changing the source. Depends on https://codereview.chromium.org/1765723002 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1774323003 Cr-Commit-Position: refs/heads/master@{#381779}
-
anthonyvd authored
https://codereview.chromium.org/1781433002 changed some of the constrained_window code and updated some callers, but not the tab-modal signin flow. The modal was being created but not shown. BUG=593091,217034 Review URL: https://codereview.chromium.org/1815433002 Cr-Commit-Position: refs/heads/master@{#381778}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b364ca30..873938e2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1811973002 Cr-Commit-Position: refs/heads/master@{#381777}
-
wkorman authored
The bot now uses 'git config' to explicitly set the intended author/committer user name and email before running the script, rather than routing through the rebaseline script itself. BUG=594817,589140 Review URL: https://codereview.chromium.org/1809723002 Cr-Commit-Position: refs/heads/master@{#381776}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/d427266a58af..852f15da7ceb $ git log d427266a5..852f15da7 --date=short --no-merges --format='%ad %ae %s' 2016-03-17 mtklein free -> reset 2016-03-17 reed update callsites for Make image factories 2016-03-17 djsollen Fix gdb debugging for the latest NDK release. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1806343003 2016-03-17 msarett Disable bad gif decode on CG 2016-03-17 bungeman Revert of Remove uses of SkImageDecoder from gms (patchset #2 id:20001 of https://codereview.chromium.org/1791583002/ ) 2016-03-17 bungeman Use sktarray.begin() instead of &sktarray[0]. 2016-03-17 mtklein try to flush stdio in the crash handler 2016-03-17 bungeman Revert of free -> reset (patchset #3 id:40001 of https://codereview.chromium.org/1811723002/ ) 2016-03-17 borenet Fix Linux Swarming bots 2016-03-17 borenet Some fixes for Swarming bots 2016-03-17 robertphillips Allow SkGpuDevice::drawSprite to handle subset SkBitmaps 2016-03-17 reed Allow const& for SkImages and SkPictures in draw methods. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1811063002 Cr-Commit-Position: refs/heads/master@{#381775}
-
bcwhite authored
Some tests need to be disabled because they create the same histogram with different parameters, a condition which does not always crash in the calling code but does with this CL. This CL will be reverted once the necessary information has been collected, including re-enabling of any tests. SHERIFFS: If a test breaks in the waterfall, you can either revert this CL or disable the test. I'll re-enable it when reverting this after the necessary data has been collected. BUG=588946 Committed: https://crrev.com/ce1315b94863f40d6323fa488490ed866aae4ed4 Cr-Commit-Position: refs/heads/master@{#378957} Committed: https://crrev.com/63f1c5d846f6dac2cf148b81961c38b88ff1bd86 Cr-Commit-Position: refs/heads/master@{#379323} Committed: https://crrev.com/89dca78efa00acb8fc8749adcc1a08a24eb105d5 Cr-Commit-Position: refs/heads/master@{#379489} Committed: https://crrev.com/1375777f66fcf8edd3f393dadd9d9de6a7409030 Cr-Commit-Position: refs/heads/master@{#379690} Committed: https://crrev.com/0abc5c2d2cb7ac70e26eab73d7e3f61f0472461e Cr-Commit-Position: refs/heads/master@{#380070} Committed: https://crrev.com/1d50ab3eec1dab7d3a6c70ec85b8937d5073b66d Cr-Commit-Position: refs/heads/master@{#380474} Committed: https://crrev.com/29601c49ec14ecb8cdfac577288b814e4c425bfa Cr-Commit-Position: refs/heads/master@{#380889} Review URL: https://codereview.chromium.org/1719363002 Cr-Commit-Position: refs/heads/master@{#381774}
-
pkasting authored
This replaces the unconditional update done in (or right after) construction in the subclasses. I need to add a ViewHierarchyChanged() override anyway, so I can set up a widget observer later, but I'm separating this bit out first to try to tease out what's causing trybot failures. BUG=none TEST=none Review URL: https://codereview.chromium.org/1785643002 Cr-Commit-Position: refs/heads/master@{#381773}
-
dschuyler authored
This CL moves the common iron-icon coloring and sizing to the settings shared style-module. The variations and one-offs are now in more specific files (such as the side nav icons). BUG=589630 Review URL: https://codereview.chromium.org/1813643002 Cr-Commit-Position: refs/heads/master@{#381772}
-
dalecurtis authored
This breaks hardware decoded video since ownership of video frames is tied to the hardware decoder. BUG=595716 TEST=none Review URL: https://codereview.chromium.org/1813883002 Cr-Commit-Position: refs/heads/master@{#381771}
-
scottmg authored
This one is a bit subtle. The two removed "helper" AppLaunchParams constructors were using HostDesktopType as an unrelated boolean to choose one or the other of the two constructors (unrelated to the actual value of HostDesktopType). I pulled those two out and had them use the now-single constructor, and tried to give the two names that made some sense according to their comments. R=benwells@chromium.org, sky@chromium.org BUG=558054, 587387, 586862 Review URL: https://codereview.chromium.org/1807743003 Cr-Commit-Position: refs/heads/master@{#381770}
-
danakj authored
Instead of writing it ourselves. Note that StaticAtomicSequenceNumber does not work here since it can only be used in global scope. R=piman@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Review URL: https://codereview.chromium.org/1809753003 Cr-Commit-Position: refs/heads/master@{#381769}
-
afakhry authored
Those reports needed to be queued nicely and each report should be sent with its correct respective system information not the one of the previous report. BUG=593452 Test=manually Review URL: https://codereview.chromium.org/1794513002 Cr-Commit-Position: refs/heads/master@{#381768}
-
rockot authored
This adds a flags argument to watch callbacks and exposes a flag to indicate that the callback was invoked as a result of some external process event (i.e. an incoming EDK IPC message). The public C++ Watcher implementation is updated to take advantage of this, effectively allowing us to dispatch to Mojo bindings synchronously when they live on the IO thread and are servicing messages from out-of-process. BUG=590495 Review URL: https://codereview.chromium.org/1811433002 Cr-Commit-Position: refs/heads/master@{#381767}
-
rdevlin.cronin authored
The preferencesPrivate, location, and principalsPrivate APIs have been reduced/removed. Update the histogram values in one CL with nothing else since presubmit complains about modifying values. BUG=595168 BUG=593166 BUG=586560 NOTRY=true (NOTRY because editing existing histogram entries in valid ways) Review URL: https://codereview.chromium.org/1810583003 Cr-Commit-Position: refs/heads/master@{#381766}
-
danakj authored
If the provider is not null, it will have a context that is not null. The provider is a WebGraphicsContext3DProviderImpl, which is given a ContextProviderWebContext. The ContextProviderWebContext is a ContextProviderCommandBuffer, the factory for which returns a null provider if the underlying context is null. Further, the provider comes from RenderThreadImpl's SharedMainThreadContextProvider(), which will return null if the provider is null, or if the provider fails to initialize its GL context. R=junov@chromium.org, kbr@chromium.org BUG=584497 Review URL: https://codereview.chromium.org/1813603003 Cr-Commit-Position: refs/heads/master@{#381765}
-