- 04 Oct, 2017 40 commits
-
-
Peter Kotwicz authored
This CL limits the state that FirstRunActivity restores to the state sent via FirstRunFlowSequencer#createGenericFirstRunIntent(). This enables deleting the FirstRunActivity#EXTRA_USE_FRE_FLOW_SEQUENCER and FirstRunActivity#POST_NATIVE_SETUP_NEEDED extras Bug=755646 Change-Id: I1a8f4dd7c13ab5649ac2656e5a0b20c34b875e90 Reviewed-on: https://chromium-review.googlesource.com/670359Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#506442}
-
Greg Thompson authored
BUG=717091 Change-Id: Iaa193a2c59c61846535b5686f234cf3022f2c24e Reviewed-on: https://chromium-review.googlesource.com/678510 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506441}
-
Greg Kerr authored
This removes the mac sandbox libraries dependency on //base. The dependency was causing the Chromium Helper binary to be linked against everything //base uses (AppKit, Security.framework, etc.), which is bad for security because of the resource access that happens in those libraries initializers. Bug: 757577 Change-Id: I4699b9cd490c188e1659932e5c97621e37438f32 Reviewed-on: https://chromium-review.googlesource.com/676262 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#506440}
-
Hans Wennborg authored
clang_tot_msan_release_bot was renamed in #506239. BUG=765859 TBR=dpranke Change-Id: I865b202422bc626c98bfca70338ad4e8650aa7cf Reviewed-on: https://chromium-review.googlesource.com/699642Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506439}
-
Eric Holk authored
This reverts commit 33b53b7f. Original change's description: > Add browser_tests for WebAssembly out-of-bounds behavior > > Trap-based bounds checking requires interaction with the crash reporter > to catch out of bounds accesses. These browser tests make sure this > behavior is working in the context of a full Chrome browser. > > Bug: chromium:722585 > Change-Id: I1993540f85f5d3500681cd3fbd7a9af817fe4ce8 > Reviewed-on: https://chromium-review.googlesource.com/648363 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#503907} Change-Id: I32b968177873c1c462c406a23a92dfc8cd27470c Reviewed-on: https://chromium-review.googlesource.com/696293Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506438}
-
Vadym Doroshenko authored
Previously, the Password Manager would suggest adding username autocomplete attributes for fields before those it thought were password fields. Now, those fields have to be explicitly marked as password fields to trigger such warnings. This CL is copy of https://chromium-review.googlesource.com/c/chromium/src/+/691669 with minor fixes, rebasing and a new test Bug: 749516 Bug: Change-Id: Id2b340ba22da064106400b1a49919b081804c42e Reviewed-on: https://chromium-review.googlesource.com/700262 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#506437}
-
James Zern authored
NOTRY=true Bug: Change-Id: I5909d84b77ae71b6b611efe11c1835e925c86ef3 Reviewed-on: https://chromium-review.googlesource.com/699859 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#506436}
-
Lukasz Anforowicz authored
The content::WebContentsDelegate::WebUISend virtual method is a no-op and is not overriden anywhere. Therefore it should be safe to just delete this method and stop calling it (since calling it is a no-op). The only caller of content::WebContentsDelegate::WebUISend was WebContentsImpl::OnWebUISend method which is also deleted by this CL. ViewHostMsg_WebUISend is *not* being deleted - it is still handled by the browser in content::WebUIImpl::OnWebUISend. Bug: 683418, 666525 Change-Id: Icf6272b0df3f4359e758e04ddefd026402b9ea03 Reviewed-on: https://chromium-review.googlesource.com/698348 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#506435}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a02fe096a89c..fa8c08044989 $ git log a02fe096a..fa8c08044 --date=short --no-merges --format='%ad %ae %s' 2017-10-04 robertphillips Use SK_DISABLE_DEFERRED_PROXIES to only disable deferred proxies for Chrome 2017-10-04 caryclark add missing params 2017-10-04 angle-deps-roller Roll skia/third_party/externals/angle2/ 035fd6b39..a99ed554c (2 commits) 2017-10-04 egdaniel Revert "Revert "When flushing, reset flush state before op lists"" 2017-10-04 brianosman Ensure glxGetProcAddress is declared 2017-10-04 robertphillips Disable PinnedImageTest on Test-Win10-MSVC-AlphaR2-GPU-RadeonR9M470X-x86_64-Release-ANGLE bot 2017-10-04 egdaniel Revert "When flushing, reset flush state before op lists" 2017-10-03 egdaniel When flushing, reset flush state before op lists Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Ibaab00c67e4aad33ec4439d9b678906bd6b6dcfd Reviewed-on: https://chromium-review.googlesource.com/699575Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506434}
-
Jialiu Lin authored
+ minor refactoring to make some no-op functions in base class abstract. Bug: 766824 Change-Id: Iea4244f08f82df7331bc2adc0d1f76466dec6445 Reviewed-on: https://chromium-review.googlesource.com/691284 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#506433}
-
Jonathon Kereliuk authored
This command is required for running some WPTs for WebDriver. Will add integration tests in a follow up CL implementing Set Window Rect spec:https://w3c.github.io/webdriver/webdriver-spec.html#get-window-rect Bug: chromedriver:1940 Change-Id: Idef3513dc5ad26fe8dd82d9808e32e84e8f7ad80 Reviewed-on: https://chromium-review.googlesource.com/685639Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506432}
-
Tom Sepez authored
Since the service manager is outside of content and knows about all the sandbox types it supports, we don't need a callback mechanism, and instead add the one additional type here. This was used by only one platform, and that's too much mechanism for this one case. Embedders can still add a sandbox via //sandbox interfaces, as required. Remove mention of nonexistent class SandboxInitializerDelegate while we're at it. Change-Id: If77e29e9c8c564b63f959c62e53f89808f19d9cf Reviewed-on: https://chromium-review.googlesource.com/688683Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506431}
-
Jonathon Kereliuk authored
Still support the old property name and wrap this with w3c mode spec: https://w3c.github.io/webdriver/webdriver-spec.html#switch-to-window Bug: chromedriver:2045 Change-Id: I455fc9c8be076e259809c6b8c505c429db4284c3 Reviewed-on: https://chromium-review.googlesource.com/687807Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#506430}
-
Daniel Bratell authored
Nobody used the member connection_monitor_started and that warning broke jumbo build experiments (it notices such things more than non-jumbo builds). Change-Id: I77055474ecdbb1eaab8fbb925ea9b7a739a6f273 Reviewed-on: https://chromium-review.googlesource.com/700268 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Vincent Scheib <scheib@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#506429}
-
Alexander Timin authored
Change task queue ownership semantics in the scheduler: - TaskQueueManager does not keep a scoped_refptr to TaskQueue. - TaskQueueImpl may be detached from TaskQueue and passed back to TaskQueueManager. New task queue lifetime: - TaskQueueImpl should be unregistered before deletion. - TaskQueueManager unregisters all task queues upon deletion. - TaskQueue holds a unique pointer to TaskQueueImpl while the queue is active. - TaskQueue passes TaskQueueImpl to TaskQueueManager when TaskQueue::UnregisterTaskQueue is called. - (future) TaskQueue may opt into graceful shutdown. In this case a async task runner is provided and upon deleting unregistered TaskQueue TaskQueueImpl will be asynchronously passed to TaskQueueManager. No new tasks may be posted to this task queue due to TaskQueue being deleted and TaskQueueManager will continue running tasks until TaskQueueImpl is empty. This patch is a first step towards supporting graceful shutdown. R=alexclarke@chromium.org, skyostil@chromium.org BUG=770736 Change-Id: I872a3b9e85dd376289e9838fc3dd83b1901ad4ff Reviewed-on: https://chromium-review.googlesource.com/695546Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506428}
-
Brian White authored
This removes the bulk validation of histograms that was introduced to try to locate where the corruption was originating. Validation is still done during metrics upload so corruption will still be detected at that point. Bug: 744734 Change-Id: Ie62ab5617c6939671b1eea93d2fecdf2e55e94d5 Reviewed-on: https://chromium-review.googlesource.com/699760Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#506427}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b16fa6d2..22069a18 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I340bf869d7d8b7e413f07e0ab4a11277fcb8632d Reviewed-on: https://chromium-review.googlesource.com/700479Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#506426}
-
Lukasz Anforowicz authored
After r505922, the http/tests/security/mixedContent/insecure-iframe-in-main-frame.html test will no longer crash, but we still have a test output difference with --site-per-process because of https://crbug.com/771003 (because with --site-per-process the newly opened https window is in a different process than the main test frame). Bug: 602493, 770487 Change-Id: Ic19079c0edbb6c74cb2a2d408acada00340d8973 Notry: True Reviewed-on: https://chromium-review.googlesource.com/699764Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#506425}
-
Matthew Jones authored
This change makes the progress updates to the throttled progress bar decelerate in updating linearly. BUG=759799 Change-Id: Id146bd253bca2d86e655fc4470c98c8bd945937e Reviewed-on: https://chromium-review.googlesource.com/692630Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#506424}
-
Owen Min authored
TemplateWriter.IsPolicySupported and TemplateWriter.IsPolicySupportedOnPlatform are now checking whether the currect version is supported or not. It will affect the generation of html documentation, adm/admx file, etc. TEST: components/policy/tools/template_writers/test_suite_all.py Bug: 770874 Change-Id: I6fcecfaae5c87197b7829bb102afc407d2120779 Reviewed-on: https://chromium-review.googlesource.com/687870 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#506423}
-
proberge authored
(Not a direct reland: the change to extension_settings_browsertest.h was not in the original CL) This is a reland of f3bd7c65 Original change's description: > Extension content verification: unify "is from store" logic > > Bug: 766806 > Change-Id: I1a210ded77cc9ffdc0039fca097c6fdba7ff0131 > Reviewed-on: https://chromium-review.googlesource.com/677403 > Commit-Queue: proberge <proberge@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#505092} Bug: 766806 Change-Id: I4a0c69c50d7bc41a47e264ad9b9e3136a729ec96 Reviewed-on: https://chromium-review.googlesource.com/698985Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#506422}
-
Andrew Grieve authored
NOTRY=true # winbot flake Change-Id: I2510eb714c4ae40903aecbc48da712a2c0b4898c Reviewed-on: https://chromium-review.googlesource.com/699698 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506421}
-
Marc-André (MAD) Decoste authored
Bug: 768429 Change-Id: I67d24b9cc4781fc9a1386a8dcdb160a5f3b23d34 Reviewed-on: https://chromium-review.googlesource.com/687275Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#506420}
-
Hans Wennborg authored
We were already stripping 'clang' and the .so's (in package.py), but more executables have been added since then. On Linux, the package size goes from 67246968 to 65948746 bytes, so about 1.2 MB savings. BUG=none Change-Id: I104055e7faec49d15dd433739d740f00492c48a0 Reviewed-on: https://chromium-review.googlesource.com/699019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#506419}
-
Rouslan Solomakhin authored
This patch adds a test for a payment method https://jonpay.com/pay that supports payment apps from two origins: https://alicepay.com and https://bobpay.com. Bug: 771323 Change-Id: I62feba283ea34cd909019aec0d84046bee572087 Reviewed-on: https://chromium-review.googlesource.com/699084Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506418}
-
Dirk Pranke authored
We are dropping layout test support on 10.9; the first step is to stop expecting the bots to be running and generating baselines. R=qyearsley@chromium.org BUG=736256 Change-Id: I2d5c647cfb2d68df3bf2d078332c504cfccfa8d7 Reviewed-on: https://chromium-review.googlesource.com/699559Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#506417}
-
Stephen McGruer authored
This is a largely behavior-agnostic change that replaces ElementAnimations use of AnimationPlayer with AnimationTicker. This allows a lot of pass-through methods to be removed from AnimationPlayer. Note that the flow of some method calls has changed, mostly to have AnimationPlayer APIs called from AnimationTicker rather than calling into it and using the return value. For example the AnimationPlayer::NotifyAnimationYYY methods are now called from AnimationTicker. Bug: 766915 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I688c204f69785030330aa73be0c5707b4e5d3ce0 Reviewed-on: https://chromium-review.googlesource.com/655221 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#506416}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ce099e95. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/2550 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: glebl@chromium.org: external/wpt/css/CSS2/normal-flow external/wpt/css/CSS2/positioning kojii@chromium.org: external/wpt/css/CSS2 tyoshino@chromium.org, yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry-1 TBR=qyearsley@chromium.org No-Export: true Change-Id: I0a3593ec04d0f30344e2cad019b95d270bb0840a Reviewed-on: https://chromium-review.googlesource.com/700476 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#506415}
-
Etienne Pierre-Doray authored
Old: http://chromium-review.googlesource.com/643886 Revert: http://chromium-review.googlesource.com/698004 Bug: 760614 Change-Id: I6d852739c27d84242a1ee90b558ca39b35b273e1 Reviewed-on: https://chromium-review.googlesource.com/698524Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#506414}
-
Chris Pickel authored
Bug: 768419 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9f5f2b134213de42e241ba7aa16a8026d77e6684 Reviewed-on: https://chromium-review.googlesource.com/695209 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#506413}
-
Corentin Wallez authored
This reverts commit df7b7f8e. Reason for revert: WinAudioInputTest.WASAPIAudioInputStreamMiscCallingSequences started failing on Windows after this patch. Original change's description: > Move microphone debug recording to AM. > > Introduces the AudioInputStreamDataInterceptor, which transparently sends audio > data off for debug recording. AudioManagerBase wraps each created input stream > in an interceptor to enable debug recording. A side effect of this refactoring > is that WebContents input streams will not be recorded, but AFAIK noone ever > used recordings anyways. I also somehow had to fix a bunch of IWYU, not sure > how I got dragged into that :). > > Since AudioInputRendererHost doesn't have to be accessed by the > RenderProcessHostImpl anymore, the member variable was removed; the lifetime of > the AudioInputRendererHost is now managed by the IPC::Channel as it is for other > message filters. > > Bug: 768610 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I24a89435b283cd5df68373eb37d776a320d6ffd5 > Reviewed-on: https://chromium-review.googlesource.com/680217 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Henrik Grunell <grunell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506338} TBR=avi@chromium.org,tommi@chromium.org,grunell@chromium.org,olka@chromium.org,maxmorin@chromium.org Change-Id: Id99c595e6ce4cba32e4a43ef93bee2ec329c749e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 768610 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/700079Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#506412}
-
Fredrik Söderquist authored
Fragment anchors are often used for "spriting purposes" when using SVG documents, so scrolling the referenced element into view could seemingly randomly scroll the top-level document (if it was same-origin with the sprite sheet.) This is usually not an expected or wanted behavior. Inhibit scrolling for all the embedding cases. (It's uncertain whether this ought to affect <iframe>s or not, but let's include those too for now. For simplicity.) While here, also remove the dependency on SVGDocumentExtension for the trivial operation of getting the root element. Bug: 493802 Change-Id: I9942093331b2c53ba94ad83cfbe0a3b8b4ca6cbe Reviewed-on: https://chromium-review.googlesource.com/700638Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#506411}
-
James Cook authored
We have not shipped Windows Ash for years. There is a 1:1 mapping between USE_ASH and OS_CHROMEOS, so consolidate them. The BUILD.gn files will be cleaned up separately. Bug: 673826 Test: compiles, gn check on Chrome OS, Linux and Linux Ozone Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5ebf64a133d1032f0d7864ed1a180d0f0b170da1 Reviewed-on: https://chromium-review.googlesource.com/692699 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#506410}
-
Oleh Prypin authored
LLD is not applicable when using a different compiler (GCC at least) Bug: chromium:607968 Change-Id: I5f4f53a5c91c52cc5ff9a0b9c5f2c5043c7add46 Reviewed-on: https://chromium-review.googlesource.com/700456Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#506409}
-
Yoland Yan authored
This conversion address the search UI unsync issue from crbug/722303. For more on JUnit4 migration, please check src/testing/android/docs/junit4.md Bug: 640116,722303 Change-Id: I3f1aeea09e626ca6bdf16ff06bede2afe6387fd3 Reviewed-on: https://chromium-review.googlesource.com/699596Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506408}
-
Max Moroz authored
R=inferno@chromium.org, ochang@chromium.org, oprypin@chromium.org Bug: 720129 Change-Id: Icbadc3b876c057b3649a0761f1a6775e6c119a2e Reviewed-on: https://chromium-review.googlesource.com/699798Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#506407}
-
Andrew Grieve authored
NOTRY=true # docs update Change-Id: I4f5840875d6d5256ef14b12de5364643a751f1e4 Reviewed-on: https://chromium-review.googlesource.com/700420Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#506406}
-
Lukasz Anforowicz authored
WebContents::GetRenderProcessHost is an API that doesn't behave as expected with out-of-process iframes, as multiple processes can be associated with a single WebContents. This CL replaces callers of this API, so that they go through an equivalent API that explicitly selects which frame's process is needed. This CL was started by using an ad-hoc clang-plugin that replaced existing callsites of WebContents::GetRenderProcessHost() with a call to something like wc->GetMainFrame()->GetProcess(). This was followed-up by manually adding an include of render_frame_host.h and git cl format and git cl lint and then a self-review with small tweaks (e.g. sometimes using a wc->GetRenderViewHost()->GetProcess() is more appropriate). This CL was uploaded by git cl split. R=sky@chromium.org Bug: 666525 Change-Id: I8167f7c6577f457939f2d2379640523f583c9dff Reviewed-on: https://chromium-review.googlesource.com/689109 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#506405}
-
rnephew authored
Previously it was only disable on system_health.common_desktop TBR=nednguyen@google.com Bug: 769809 Change-Id: I02143441e0cee13faab7cf33ba570218a59c480c Reviewed-on: https://chromium-review.googlesource.com/699053 Commit-Queue: rnephew <rnephew@chromium.org> Reviewed-by:
rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#506404}
-
Preeti Nayak authored
Reference: https://docs.google.com/spreadsheets/d/1HKl-gMSzjI-ygRkYTvqpJRwSW0ZI-xj-0aoiNdTum2g/edit#gid=939250318 Change-Id: Id86469bb8072fbc36df7feea1dc665da275531cf Reviewed-on: https://chromium-review.googlesource.com/657337 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sanjoy Pal <sanjoy.pal@samsung.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#506403}
-