- 21 Apr, 2020 40 commits
-
-
Joshua Pawlicki authored
This callback can be called more than once, for example once for a differential update and then (if that fails) again for a full update. Bug: 1071475 Change-Id: I6d5ebce996aa13ece5b5d1d088eb1a9fff31d2c0 Fixed: 1071475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159534 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#761115}
-
Oystein Eftevaag authored
These calls were already being done in ChromeMainDelegate::BasicStartupComplete() resulting in the Renderer/GPU main threads to be sampled twice. R=avi@chromium.org Bug: 1067416 Change-Id: I5e7f57989fde11224c905f092483185ab5be54e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154402Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#761114}
-
Nasko Oskov authored
This test was disabled on some bots due to flakiness. I am updating the test to explicitly wait for process crash, which will likely eliminate the source of flakiness and updating some of the code to take advantage of newer test methods instead of using base::StringPrintf. Bug: 974787 Change-Id: I68182c88905f187b972d93da3504e701a82b96d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159318Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#761113}
-
chrome://flagsKatie D authored
This will help us test the feature in Canary! Bug: 1055150 Change-Id: I02a5deb241dfd26ddf4dc58a84f04a79b1c3d227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158008Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#761112}
-
Dana Fried authored
Much more reliable capture based on a state machine. Now thumbnail capture walks through the following steps: - Navigating to new page - Navigation complete - Capture requested - Frame capture - Cooldown* - Capture complete** * Cooldown allows us to continue capturing for a short period of time after a page indicates it's loaded; this gives the renderer time to actually draw the final version of the page ** Once we've captured a background page, there's no further need to try to capture it again unless it navigates, or the user makes it active, interacts, and then leaves again (a case we handle separately). Typically these states move forward. However, there are potential issues with trying to frame capture a visible/active tab, so we pause video capture while a page is active and then return to capturing it after the user switches away. Since we do not show preview images for the current tab in desktop mode, it's not a problem. For tablet mode (Mohnstrudel), if the tabstrip is observing the thumbnail image for the current tab, the tab will be captured. This complex behavior of stepping forward and backwards based on whether a tab is visible, being observed, etc. is all handled by ThumbnailTabHelper::ThumbnailTabHelperState::UpdateCaptureState(). Still to do: - Create a queue of thumbnails to be captured that prioritizes thumbnails for pages that are being or have recently been observed, to actively limit the number of thumbnails we are trying to observe at once in order to save memory. In-flight thumbnails are uncompressed, which can have a significant impact on RAM usage. Bug: 1057713, 1059862, 1068459 Fixes: 1068459 Change-Id: If81798c0d3df26a5c309e834483042a5b5f24857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145161 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#761111}
-
Collin Baker authored
TBR=ellyjones@chromium.org Bug: 956191 Change-Id: I335e377a40aa937917f95a799e6609c0b2489afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159422Reviewed-by:
-
Brandon Wylie authored
Change-Id: I4c02e2326922ff76fdbc3a4a9a4dcd053bcf0e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158930Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#761109}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d3f79db3fdef..09e523d4093e git log d3f79db3fdef..09e523d4093e --date=short --first-parent --format='%ad %ae %s' 2020-04-21 michael.liao@microsoft.com [Elements]: Fixing failure when onNodeResolved receives a null parameter Created with: gclient setdep -r src/third_party/devtools-frontend/src@09e523d4093e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071952 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If042c65030ad8e1fc4687dc15953e8ecc3969d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761108}
-
Leon Scroggins III authored
Bug: skia:10154 This file is being moved in https://skia-review.googlesource.com/c/skia/+/284721. Once that CL lands in upstream Skia, there will be no need to remove it, since Skia's build files will not tell the build system to build it. Change-Id: Ib886325168042f7fe6ce279182462b0200f1ae11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158929 Auto-Submit: Leon Scroggins <scroggo@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#761107}
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //ipc. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=jam@chromium.org Bug: 714018 Change-Id: I323ecd822f7dbf4eefdf4cabf29a39d21d2e0ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132260 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#761106}
-
Edman Anjos authored
arc-keymasterd should run while ARCVM runs in order to serve the Keymaster HAL service. This change starts arc-keymasterd in the per board feature flow, ensuring the service is stopped and restarted if it's already running. The change https://crrev.com/c/2153037 enables the D-Bus policies needed and must land before this one. && autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='ArcVm*' - verify `status arc-keymasterd` says it is running Bug: b:153278258 Test: gn gen out/Default --args='target_os = "chromeos"' \ Test: manual - deploy chrome to an eve-arc-r device and sign in Change-Id: Ib79c0e407c3724cc9511162103b1196b09a66fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153038 Commit-Queue: Edman Anjos <edman@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#761105}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: I723f79de3ff4f75df75d899922980576db23551e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157105Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/09aea59a8d8b..9c7b4453b116 git log 09aea59a8d8b..9c7b4453b116 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 rslawik@google.com Merge "Thread time_in_state metric" Created with: gclient setdep -r src/third_party/perfetto@9c7b4453b116 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I1de2c714e7226f87ed4d8987a09d42a70e9d5439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159274Reviewed-by:
-
Nate Chapin authored
ResizeObservers are ExecutionContextClients, have them take a LocalDOMWindow or a ScriptState in the constructor (instead of a Document). Since ResizeObservers are strongly tied to a ResizeObserverController, their object associations should match, so ResizeObserverController should be per-LocalDOMWindow. Make it a Supplement<LocalDOMWindow>, since Document doesn't use it directly. Bug: 1029822 Change-Id: Ib57d50ab4973d7abfdeb0ba40870cb354a8e06df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106571 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761102}
-
Ben Pastene authored
Change-Id: Ib5b4cfc157715273115baf6907fbf8211662bbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159747Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761101}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Bug: 1029822 Change-Id: I208d233652916cbb19b06e24090289995012611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111066 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c5db0b25. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." daae887f "CookieStore: Add validation behavior for __Host- prefixed cookies" b9d8ee54 "[WPT] Fix paths in svg-image-orientation.html and ref" 502e3797 "ServiceWorker: Fix timeout on client-navigate.https.html" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I59a06de43b3ac5df5cb154ec5b258bba90cd0400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159253Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761099}
-
Wenyu Fu authored
Bug: 1068831 Change-Id: I6d6aefb0b6e2f787d40da742ab4214eee9695812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159316 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
During flex-row layout we typically perform three passes: 1) Determine the min/max sizes. 2) Layout with a non-stretched size. 3) Layout with a stretched size. Previously we were using the "layout" cache slot for both steps, (2, 3). This patch changes step (2) to use the "measure" cache slot. This also updates the simplified layout pass to abort if it is trying to use a fragment from the "measure" pass, which was triggering a DCHECK. Bug: 845235, 1072429 Change-Id: Ib98187e09b23e86d67b39306a24318e9e932ca60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154489 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761097}
-
Yuke Liao authored
This CL sets up win64 official ci and try bots, and one of the use cases is for PGO auto roller to validate the profiles and warm up GOMA caches for other official builders. Bug: 1071576 Change-Id: I234cac58eb473bdf7834d584c0615ce771fd9dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159530Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#761096}
-
Roberto Carrillo authored
62 Builders will now have their test results exported to luci-resultdb.chromium.ci_test_results R=nodir,chanli,bpastene Bug: 1048825 Change-Id: I98630e07043e76f65d929b8e73317858a0df8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157718Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#761095}
-
Charlie Harrison authored
As documented in crrev.com/c/2151840, the host variant of GetDomainAndRegistry has non-ideal performance if callers are using already-canonicalized hosts (e.g. those pulled from GURL or Origin). This CL migrates a few callers where this is obviously happening (i.e. where no significant plumbing is needed to get access to an underlying Origin or GURL). This CL has no intended behavior change. Bug: None Change-Id: Ia39f87f0ab1df20b9350b7e68aa5a7ea6ea66aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153573 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#761094}
-
Devlin Cronin authored
The NotificationService is deprecated. Remove two notifications from it: NOTIFICATION_EXTENSION_COMMAND_ADDED and NOTIFICATION_EXTENSION_COMMAND_REMOVED. These (as the names imply) were used to notify of when an extension command was added or removed, but can be substituted with the CommandService::Observer. This also fixes a bad cast bug. Bug: 411569 Change-Id: I7b2f0a1cf006a80d62571d20cf8a20968f2d0ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155248Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#761093}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e59f718fc277..efb2133b0dd3 git log e59f718fc277..efb2133b0dd3 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 brianosman@google.com Update CK particle examples 2020-04-21 bsalomon@google.com Notify RTC when OpsTask is closed so it can drop ownership 2020-04-21 egdaniel@google.com Create a shared spirv uniform and varying handling class. 2020-04-21 robertphillips@google.com Add path renderer selection spew 2020-04-21 jvanverth@google.com Implement GrD3DGpu::onReadPixels and GrD3DGpu::onWritePixels. 2020-04-21 lepton@chromium.org Allow empty rendertests commandline flags. Created with: gclient setdep -r src/third_party/skia@efb2133b0dd3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jcgregorio@google.com Change-Id: I9564145e4938b767261bc992a81ac6163357278e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159141Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/811efc06df3d..f2b06ce5c82d git log 811efc06df3d..f2b06ce5c82d --date=short --first-parent --format='%ad %ae %s' 2020-04-21 sprang@webrtc.org Reduces unnecessary thread wakeups in TaskQueuePacedSender. Created with: gclient setdep -r src/third_party/webrtc@f2b06ce5c82d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5007215bc255585cbe7d4c5541962e2653b701e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159277Reviewed-by:
-
Jan Wilken Dörrie authored
This change applies the BindOnceRewriter in //services. This rewriter replaces calls to base::Bind and base::BindRepeating with calls to base::BindOnce, in case the result is immediately assigned to a base::OnceCallback. Given that base::RepeatingCallback is implicitly convertible to base::OnceCallback, there is no change in functionality. Steps: 1. run_tool.py --tool base_bind_rewriters \ --tool-arg='--rewriter=bind_to_bind_once' 2. git cl format This CL was uploaded by git cl split. R=rockot@google.com Bug: 714018 Change-Id: Ic3a80f8510f9ee5fc50549a07e28803aa7cccc63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132374 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: -
Xianzhu Wang authored
- Inline the function into the caller. The condition for Android and ChromeOS should not be in DeviceScaleEnsuresTextQuality() becuase we can't ensure text quality but just accept to sacrifice text quality for better compositing. - Add a comment about keeping sync about the DSF threshold in cc/metrics/lcd_text_metrics_reporter.cc. Bug: 642885 Change-Id: Idb58ebc21db32ded979b24c444497abff37c4a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155279Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761089}
-
Charlene Yan authored
b/153670807 Bug: 1064674 Change-Id: I398bb52dd11da5a8b26aa491b011359f7f34edd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158034Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#761088}
-
Nico Weber authored
No intended behavior change. Bug: 1056290 Change-Id: I60ec2cd5fbe0f151ed1d995b4c13cfcab6758084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157965 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#761087}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/902b55875825..ad85cd0040ff git log 902b55875825..ad85cd0040ff --date=short --first-parent --format='%ad %ae %s' 2020-04-21 geofflang@chromium.org Fix quotes around emails in WATCHLISTS Created with: gclient setdep -r src/third_party/angle@ad85cd0040ff If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: Idea277a756dbcc5f1085a0cd040b23a4b4645ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159268Reviewed-by:
-
Jesse McKenna authored
This change makes boilerplate.py trim a leading ".\" (Windows's current-directory prefix) or "./" (Unix's current-directory prefix) from the filename argument, if present. This is a convenience change for cases where the current-directory prefix is prepended. For example, Windows PowerShell automatically prepends ".\" to a path when tab completion is used (e.g., typing "chrome/b" and pressing tab results in ".\chrome\browser"). This change will remove artifacts of this for users who use tab completion while typing the filename argument. Currently: `tools/boilerplate.py .\test.h` produces include guard `__TEST_H_` `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "./test.h"` With this change: `tools/boilerplate.py .\test.h` produces include guard `TEST_H_` `tools/boilerplate.py ./test.cc` or `.mm` produces `#include "test.h"` Change-Id: I19fd2e72c58135b5e87d4a1e22ec8bc76ef326aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157876 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#761085}
-
Xida Chen authored
There are OOM crashes in FrameSequenceTracker::ReportSubmitFrame, where the ignored_frame_token_ is getting too big. This could only happen if a tracker is somehow never terminated, and thus not getting removed. This CL is a temp fix that if a tracker is scheduled for termination, and still receive 3 frame submissions, then we terminate this tracker right away. Following this, we will add debug strings to find out why is it not terminated. Bug: 1070209 Change-Id: I5a28cb0f52abf44e76211b87f8d8a6b3c1657fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2154498Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#761084}
-
Eero Häkkinen authored
COM is used by media video capture calls either on video capture service process main thread or on browser process thread pool thread (depending on operating system, its version and status of content features). The lack of COM initialization on video capture service process main thread results in media failures. Bug: 1043952 Change-Id: I85a405501961bedd87996864f0f15ad85995fbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066783Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Xi Han authored
In this CL, an overview page is shown when the feature flags InstantStart and tab switcher are turned on. The changes of this CL are behind the flag of InstantStart. The grid tab switcher overview page can be shown with the following commandline flags: --enable-features="TabSwitcherOnReturn<Study, InstantStart,StartSurfaceAndroid" --force-fieldtrials=Study/Group --force-fieldtrial-params=Study.Group:tab_switcher_on_return_time_ms/0 "--disable-native-initialization" which stops native library loading is optional. It helps to test pre-native startup behaviour. Bug: 1061906 Change-Id: I1898d9602c1ab54dc76d55190a1368e14c1d9e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144356Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#761082}
-
Collin Baker authored
TBR=ellyjones@chromium.org Bug: 1073133 Change-Id: I5f799871a8b871b992822682406aa9a9208af9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159609Reviewed-by:
-
Kevin Marshall authored
Records a UserAction at the time of the first meaningful paint. Bug: 1067068 Change-Id: Id1b962642d7deb2b7c085fc21d2056bc8817a249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158018Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761080}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. We should replace eventSender.mouseScrollBy with gpuBenchmarking.smoothScrollBy in all the layout tests, this is part 2. I remove two tests in this CL because they no longer work after scroll unification that wheel scrolling happens on compositor. Bug: 1047176 Change-Id: I954a97175fb4102a1d70b21fc7217c9400ba5671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131296Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#761079}
-
David Black authored
Bug: None Change-Id: I27b1d40f5bb74a5cda96aee5c468eb9404fdd8c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159567Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#761078}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/137ca431..e981e9f0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5e79b5831d99dc1ddeec655305c669ca0f1461ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159252Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761077}
-
Ben Pastene authored
This should hopefully make it clear to sheriffs that either option is valid. Change-Id: Ida41d139dfdb09be3067228d6a05cb3b46806562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159605Reviewed-by:
-
