- 02 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29444c65244a..ec0af26ff8aa 2020-07-02 eshr@google.com [Adaptation] VideoStreamAdapter broadcasts adaptations 2020-07-02 sprang@webrtc.org Revert "Reland "Allows FEC generation after pacer step."" 2020-07-02 sprang@webrtc.org Reland "Allows FEC generation after pacer step." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1b4cfb39a1e16e16fa668444061865087cb1f088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279636Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784864}
-
Matthias Körber authored
Currently, Autofill does not import address profile data from fields that are not focusable. This is problematic because such fields are often used in combination with synthetic form fields. To resolve this, a finch flag is implemented that allows importing profiles from unfocusable fields. This is a reland of f2db4e69 to fix a bad name for a finch experiment. Bug: 1101280 Change-Id: I9e8e734942dee897fa63959cc1f0cc441f0419e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278266Reviewed-by:
Dominic Battré <battre@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784863}
-
Philip Rogers authored
This is a reland of https://crrev.com/784367 with the viewport leak tests fixed with https://crrev.com/c/2278083. The original change description is listed below: Javascript can run after BlinkTestRunner::OnResetRendererAfterWebTest, dirtying TestRunner state for the next test. A navigation to about:blank is done after every test. This patch resets the TestRunner state after the navigation to about:blank, when we are sure no test javascript can change TestRunner state. This fixes a class of flaky bugs. This behavior happened with video-overlay-scroll.html which would set a custom layout dump (setCustomTextOutput) in a fullscreenchange event handler. This event handler was not removed at the end of the test (this will be fixed in a followup), and would run a second time, after the custom text output setting was reset. This caused later tests to run with custom text output from video-overlay-scroll.html. With this patch, video-scrolled-iframe.html is no longer flaky. Code in WebFrameTestProxy::BeginNavigation to intercept navigations relied on TestRunner::PolicyDelegateEnabled being reset before it ran. This patch now skips WebFrameTestProxy::BeginNavigation when the test is not running. Bug: 1048597 Change-Id: I454832953266bc93a0ad02e373009a168f724eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277871 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#784862}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2b8d80936336..b7d4c458e24c 2020-07-02 fmayer@google.com Merge "Do not batch frees." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I52d0a3cb44907293565f6b1b32543e21e23b2029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279637Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784861}
-
Philip Rogers authored
The web testing infrastructure has special logic for tests under the viewsource directory. This testing approach is difficult to maintain (see [1]) and is discouraged in favor of WPT tests. A recent change (see [2]) of when test settings are reset caused these viewsource tests to report leaks because the about:blank load between tests was run in viewsource mode, which did not match the hardcoded leak detector values (see [3]). This patch moves these viewsource tests to unit tests and removes the viewsource web test logic that is now unused. [1] https://groups.google.com/a/chromium.org/g/blink-dev/c/pi235gcfHZc/m/rDLQBFufDwAJ [2] https://crrev.com/784367 [3] https://cs.chromium.org/chromium/src/content/shell/browser/web_test/leak_detector.cc Bug: 1048597 Change-Id: I04fec3f5aee99237ae69ed6bcc26d02a1ae84a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278083Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784860}
-
Ella Ge authored
Bug: 1007635 Change-Id: I6130122826e752443bdc7019cec05b1657f1fe92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279911 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#784859}
-
John Chen authored
This reverts commit 81525fe7. Reason for revert: Build failures on perf waterfall (https://crbug.com/1101820) Original change's description: > Roll src-internal from 30ceaafc85cb to 232b0b4dc0b5 (2 revisions) > > https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30ceaafc85cb..232b0b4dc0b5 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll > Please CC fdegans@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Bug: chromium:1025990,chromium:1101477 > Tbr: fdegans@google.com > Change-Id: Ie5458b19051dd27a52daa2bb2fc81f2e5564cdf3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278214 > Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#784598} TBR=fdegans@chromium.org,chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Change-Id: I750697fee1cfedb80630d7205233bae8cd81d376 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1025990, chromium:1101477, chromium:1101820 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278858Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784858}
-
Gauthier Ambard authored
This CL updates how the NTP animations to shift tiles up (i.e. when the omnibox is focused), using an animator instead of the regular UIView -animate:completion:. It allows to stop the animation in the middle without having the animated properties in an undefined state. Bug: 1101331 Change-Id: Iadff66283784c7a339770b58270099678cf2616c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278253 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784857}
-
Matthias Körber authored
The input and output file prefix of the test files start with 000 while the parameters for testing starts with 001. Consequently, the error message which test is failing is off by one. By renaming 000_* this should be fixed. Bug: 1100855 Change-Id: Ib90f68dd7754215e9b77b7eb6d4258d5ddccb746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275955 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#784856}
-
Stephen McGruer authored
This brings in support for the second HTTPS port. Bug: 1101075 Change-Id: I88fc627e4509648c323cde0ff37abf757975c5bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277349Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#784855}
-
Dave Tapuska authored
In https://chromium-review.googlesource.com/c/chromium/src/+/2243266 I missed that the edit commands were dispatched at the focused frame from the root frame widget. This caused a slight issue with Ctrl-left arrow on gmail causing a history back navigation. BUG=1099459 Change-Id: Iadb39bd3e031dca6e7c1165bf1be674b5de1f978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275490 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784854}
-
edchin authored
Test: Enable DragAndDrop flag. On iPad multitasking: drag item from reading list to another app. Bug: 1099921 Change-Id: Ief8508e18f178e3cc59e41b9a71a42b65bbe302b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277245 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#784853}
-
Christoph Schwering authored
AutofillHandler::OnFormsSeen() ignores cache hits unless the found form is a credit card form. As a consequence, the newly seen form overrides existing cache entry. In particular, the newly seen form's values are stored in the cache. This violates the invariant that cached forms' values are the initial field values. In particular, it means that user-filled values may be considered initial values, in which case they are ignored at submission time. This CL makes OnFormsSeen() treat credit-card and address forms equally (i.e., not ignore cache hits), provided that kAutofillKeepInitialFormValuesInCache is enabled, except that in these cases where cache hits were formerly ignored. As a temporary solution to avoid breaking the captured-site tests, one difference between credit-card and address forms remains: in those cases where the pre-experiment code ignores cache hits, the experimental code ignores the cached signature, i.e., updates the form's signature to the newly seen one's. Bug: 1091401, 1096990 Change-Id: I76aa6d2374a33a11433628adb7560af8cad9c557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273068 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784852}
-
Olivier Robin authored
Test now pass thanks to https://chromium-review.googlesource.com/c/chromium/src/+/2278763 Tbr: rohitrao Bug: 1099435,1099358,1101099,1099430,1099436,1099425 Change-Id: I9b82eb19959a4273005ec77e350071251501824a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274895Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784851}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53c05a8f0110..bf6b1c6739b7 2020-07-02 petermarshall@chromium.org tests: Make e2e --test-file arg relative to gen dir and document it If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1056140 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2e6239d9105e3c845fa5a20b4a1d6b5c5ff74cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784850}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65c9ff30..c5b71d2e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie5669c7216d9dbe0e59041685b2fb0b669a0caab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279710Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784849}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/16ca52cc16ab..f695264d30e6 2020-07-02 cwallez@chromium.org Broaden -Wno-tautological-type-limit-compare 2020-07-02 jiawei.shao@intel.com Fix bugs in the multi-layer copies with BC formats on D3D12 and OpenGL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I22fd4f3a2332f84366674d163d44492dd45eff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784848}
-
Guillaume Jenkins authored
Moves ChromeBrowserCloudManagementRegistrar to components/enterprise so it can be reused by iOS code. Bug: 1091930 Change-Id: Id91f8f85191cb14a0afde72debb7e172a3e236a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270348 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#784847}
-
Leo Lai authored
In order to make a better unittest for this function and to re-use the function in the rewritten attestation flow in the future, the mentioned function is moved out as a stand-alone function. BUG=b:158955123 Change-Id: Ia83e7bf701fe013a2d4935e7e779783e407a104b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279254Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#784846}
-
Christoph Schwering authored
This CL replaces the usage of AutofillField::unique_name() in FormStructure::RetrieveFromCache() with their unique FieldRendererId. Bug: 896689, 1101631 Change-Id: I14109ee20fbcf8b0e9a89b4b190a77516231e567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236396 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#784845}
-
Jeremy Roman authored
Failures spotted on Mac ASAN 64: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29/63655 Bug: 1099847 Change-Id: I345e1a3ae073028e87b1d332f9d97d8426599dd5 Tbr: jkrcal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274542Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#784844}
-
Etienne Pierre-doray authored
To address telemetry regressions (crbug.com/1096694), use a more specific tracing category. Bug: 1096694 Change-Id: Ic3aa8c473dc4c934661572ae28033701163daa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279691Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#784843}
-
Guillaume Jenkins authored
As a follow-up to crrev.com/c/2267645, moves the unit tests for the DM token storage to components/enterprise. Also moves the associated mock class to the same location. Bug: 1091929 Change-Id: I2f5e4712505a60f5ee496249245d0209ad5945fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269968Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#784842}
-
Kushagra Sinha authored
Mark |AccountManager.LegacySetPrimaryAccountAndUpdateAccountInfo| as obsolete. It was removed in M84 with https://crrev.com/c/2131912. Change-Id: I5769f781999b37e34f53fa1b3fa79db5671f1623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275905Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#784841}
-
Dirk Pranke authored
This will hopefully make it a bit easier to find the best documentation we currently have on the syntax of the file and how it works. Bug: 1099242 Change-Id: I23aa9210d25bea57f4c7f61a49f6d98f665e3528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278591 Auto-Submit: Dirk Pranke <dpranke@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#784840}
-
Sylvain Defresne authored
One possible workaround to use New Build System in Xcode is to post-process the build output to convert the relative paths in absolute paths. See https://gn-review.googlesource.com/c/gn/+/9080 for gn part of this CL. Bug: 852522 Change-Id: I3c1c984dd3a0e89d136a543adfb0c78011e846ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279192 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#784839}
-
Lukasz Anforowicz authored
After removing blink::Platform::CreateDefaultURLLoaderFactory method in r783649, there are no more callers of CreateNetworkURLLoaderFactory and CreateDefaultURLLoaderFactoryBundle _inside_ RendererBlinkPlatformImpl. Therefore, this CL moves CreateNetworkURLLoaderFactory and CreateDefaultURLLoaderFactoryBundle into an anonymous namespace in render_frame_impl.cc, where their only remaining caller is. This helps (slightly) in two ways: 1. It helps with encapsulation - after the CL, no headers expose an API for getting the origin-agnostic/process-wide factory via CreateDefaultURLLoaderFactoryBundle. 2. It highlights that the helpers are unrelated from RendererBlinkPlatformImpl - even before this CL they could have been |static| methods. Bug: 1098938 Change-Id: I7a13c4d4fdfaaedda25acfa7f40404d307a2b537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276227Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#784838}
-
Vasilii Sukhanov authored
The bubble follow "Save/Update password?" bubble and tells the user about other compromised passwords to fix. Bug: 1049200 Change-Id: I18f330cc75c3c4ecc6885302313a33543a5bbf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278252 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#784837}
-
Pavol Marko authored
The UI was mistakenly displayed FailedWorkerInfo::state in the UI, which is the state prior to failure, so it will never say Failed. Clarify the meaning of the field by renaming/comments and always display failed for failed workers. In a follow-up, the status text will be changed to Failed (was <other status>) or similar. This is not done in this CL in case we want to merge it back, which does not allow UI string changes. Bug: 1098244 Change-Id: Ib7c2a8308211bb4459640a99dd44e7c5c06dc23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276420Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#784836}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a5e8178b385e..2b8d80936336 2020-07-02 nuskos@google.com Add the descendant_slice table. 2020-07-02 nuskos@google.com Add the ancestor_slice dynamic table. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160148605 Tbr: perfetto-bugs@google.com Change-Id: I0afdf60523522ca11a03e8fdecd2f6286e847fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278298Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784835}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 46c3a3dd. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I6135ca0e944646ddf1cc8119acc6f6580848af35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277675Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784834}
-
Maxime Charland authored
This CL adds PDF assets for the empty state of Reading List. PDF assets will be used as vector images to display at big scale without impacting binary size. These assets will have colour information, so there will be one version for dark mode and another one for any appearance. (Googlers only links) Design Doc: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing UX Specs with mocks: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I440dfb4e2abec07e81ca26de7857154377a4cf9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269973Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#784833}
-
edchin authored
This CL adds 2 reusable handlers: - TableViewURLDragDropHandler - URLDragDropHandler These are constructed similarly, so I put them into one CL for contrast and comparison. I'll create separate CLs that demonstrate how they are used. The delegate and dataSource protocols draw inspiration from UITableViewDropDelegate and UITableViewDataSource. This is in a series of CLs to enable drag and/or drop of URLs in Bookmarks, Reading List, History, Recent Tabs, Omnibox, and tab strip. Note, unit tests will be added in a fast followup CL. Bug: 1087847 Change-Id: Ia2dca93d032054447b5305fe4ce7f8c86655e966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272117 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784832}
-
arthursonzogni authored
COOP was approved to launch in M82. The current development version is M86. This patch turns the flag on by default. This is still disabled on Android WebView. Since the parser is already behind a flag, there is no need to check for the flag again and again everywhere in the code. Only some DCHECK are necessary. Bug: chromium:922191 Change-Id: I5f43652e38d4df5e003eb36b82eccc6f0a952cd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274882Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784831}
-
Stepan Khapugin authored
Adds support for multiple levels of blocking UI in the same scene to simplify accounting. Provides a ScopedUIBlocker object that increments and decrements the blocking counter while it's alive. Bug: 1072408 Change-Id: I39e5713e3b23e0e233958389a5ec8f0c1263bf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259857 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#784830}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ad0b2b8dd121..92c33f329a56 2020-07-02 reed@google.com document Make for paths, and move from pathbuilder into path If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Icadb31c30ff0ad286219176e0f9ed8f58341846e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784829}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I040f38188c2296ecca55089cdcf54e8af57743d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784828}
-
Thomas Tellier authored
Bug: 1066489 Change-Id: Ic997e1b8de256ab66ef28710ff41c2ff9299a378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219889 Commit-Queue: Thomas Tellier <tellier@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784827}
-
Elad Alon authored
Bug: 1100295 Change-Id: Id4dd2ef665e5ef6e03ef241f861bcdf37c28aa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278263Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#784826}
-
Samuel Huang authored
The instructions to build caspian_web is failing due to wasmbuild.patch apply failure. This CL updates updates the patch to get things working again. Bug: 1040645 Change-Id: I2e204e622a29309915ca1086a89d42e9c146132a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272615 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#784825}
-