- 04 Oct, 2018 40 commits
-
-
Stephen Martinis authored
Mixins can now apply to any key in a test. Previously they only applied to swarming configuration values. Also updates mixin docs, and uses the mixins to set args for the 'chromium' master scripts. Change-Id: I20396556464d9f268903afeda1231d83f2aba45a Reviewed-on: https://chromium-review.googlesource.com/c/1258604 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596919}
-
mrefaat authored
Also fixed "Open in" unit test as the existing test was already passing a corrupted PDF data to the UrlLoader. the reason was that the generated pdf data had null characters, So when casting it to char* then converting that to string it produced 8 letters Data stream. Added unittest for the corrupted pdf case. Bug: 892211 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4fff1e22f617e6a0b2c08d9c6412e14265b8aab4 Reviewed-on: https://chromium-review.googlesource.com/c/1261926 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#596918}
-
Vadim Shtayura authored
On LUCI this builder is on 'chromium.mac' master, so by default Buildbucket looks for its migration status on (chromium.mac, WebKit Mac 10.13 (retina)) page, which doesn't exist (because there are no such Buildbot builder). With this change, Buildbucket will look at correct Buildbot builder instead. R=jchinlee@chromium.org, nodir@chromium.org BUG=818301, 864817 Change-Id: Id821857a971e36d1da9b2437950efb39f2c27cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1263343Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596917}
-
Xiyuan Xia authored
- Env owns WindowOcclusionTracker to make it a per-Env singleton; - Expose the tracker API via Window::SetTrackOcclusionState, which later will be wired differently based on aura mode. For LOCAL aura, it calls tracker in local Env. For MUS aura, the code path will be go through WindowTree interface and use the tracker in WindowService Env; - ScopedPauseOcclusionTracking -> ScopedPause since it is a nested class and WindowOcclusionTracker::ScopedPause is clear enough; Bug: 867150 Change-Id: I73d6e0e0a31dae2e69307b35322fe6501289e889 Reviewed-on: https://chromium-review.googlesource.com/c/1259039 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#596916}
-
Lei Zhang authored
Point chrome/browser/chromeos/policy/OWNERS to chromeos/policy/OWNERS. Change-Id: Ifa77f18ad5faf81f7cc4cc4d81e04bbc16a57fab Reviewed-on: https://chromium-review.googlesource.com/c/1263050Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#596915}
-
Shimi Zhang authored
This CL: 1) Moves SelectWordAroundCaret{Ack}() from RenderViewHost to RenderFrameHost. 2) Moves SelectWordAroundCaret() from RenderView to FrameInputHandler, the new place is more suitable for this function. 3) Migrates IPC to mojo, and does other IPC cleanup. Bug: 716618, 545684 Change-Id: Ied823345dc7ff68ea6dd505eeb14ab5c6aca17d1 Reviewed-on: https://chromium-review.googlesource.com/c/821561Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#596914}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae16b74365f4..4302eb9a6e14 git log ae16b74365f4..4302eb9a6e14 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 mtklein@google.com Revert "remove deprecated SkRect::MakeFromIRect()" 2018-10-04 mtklein@google.com remove SkColorSpaceTransferFn::invert() 2018-10-04 brianosman@google.com Restore proper name of the SkImage_Gpu2Cpu unit test 2018-10-04 halcanary@google.com SK_SUPPORT_LEGACY_DOCUMENT_FACTORY: clean up part 2/2 Created with: gclient setdep -r src/third_party/skia@4302eb9a6e14 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ic7fefe114ea42e32f13a0fcda829842ed2706447 Reviewed-on: https://chromium-review.googlesource.com/c/1262976Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596913}
-
Robert Liao authored
Jumbo Build Fix: Fix windowsx.h Conflict with HwndMessageHandler::IsMaximized and HwndMessageHandler::IsMinimized windowsx.h defines the following which break HwndMessageHandler: BUG= TBR=sky@chromium.org Windows jumbo build break. Change-Id: Icc2feeb8496ee80fa59f40b2f21850af1197fdd0 Reviewed-on: https://chromium-review.googlesource.com/c/1263115Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596912}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf0d2438ae53..6a311a5b505c Created with: gclient setdep -r src-internal@6a311a5b505c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7c10f64a31f773e80a8e62bf99be643b6f954999 Reviewed-on: https://chromium-review.googlesource.com/c/1262977Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596911}
-
Greg Kerr authored
The V2 sandbox is now default for all but the network and GPU processes on macOS. This CL deletes the feature flag. A new experiment will be introduced for the GPU process. Bug: 749839 Change-Id: Idb65a83f25f48db5aaf8d8d2400992640673d0e8 Reviewed-on: https://chromium-review.googlesource.com/c/1258214 Commit-Queue: Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#596910}
-
Xianzhu Wang authored
- Remove the last usage from FindPaintOffsetNeedingUpdate of TransformPaintPropertyNode::Clone() and operator==(), so we can remove them. This will make it easy to add move-only data in TransformPaintPropertyNode::State. - Now FindPaintOffsetNeedingUpdateScope is also detecting unexpected change of PaintOffsetTranslation during UpdateForSelf(), and unexpected change of paint offset and PaintOffsetTranslation during UpdateForChildren(). Previously it detected unexpected change of paint offset during UpdateForObjectLocationAndSize() only. - Now FindPropertyNeedingUpdateScope is also detecting unexpected change of FragmentClip. It no longer detects unexpected change of paint offset which is now detected by FindPaintOffsetNeedingUpdateScope. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id78fa30f51445698d3f93e26c8b7852e3811bedb Reviewed-on: https://chromium-review.googlesource.com/c/1260124 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596909}
-
Xianzhu Wang authored
2d translations (e.g. for paint offset translation, scroll translation) are very common in our paint property trees. In many cases GeometryMapper::SourceToDestinationProjection() deals with source and destination transforms under a common subtree that contains 2d translations only, and we expect that the result to be a 2d translation. However, previously, in the case we used source_from_plane_root_or_screen * destination_to_plane_root_or_screen which includes transforms and inverse of transforms of some common ancestors of the input transforms, and contains accumulated floating point errors when calculating the inverses and multiplications of the common ancestors. The new test case in this CL shows the problem. Now let GeometryMapperTransformCache cache the 2d translation root of the transform node. In GeometryMapper::SourceToDestinationProjection(), if the input transforms are under the same 2d translation root, we can use the fast path to calculate the result which will be a 2d translation. Also reduce the size of the GeometryMapperTransformCache in common cases by allocating plane root transform and screen transform only when needed. Bug: 891799 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I926b337469d0c8d79ee6a63f7c0e2f15781266d2 Reviewed-on: https://chromium-review.googlesource.com/c/1259663 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596908}
-
Adam Langley authored
54e0bebf added a histogram to collect metrics on the results of attestation prompts in webauthn. While there is still a sizable amount of legacy U2F usage, it's useful to collect similar metrics there too. This change causes U2F to also emit events for the existing histogram. Since we don't want to do significant work on the U2F code at this point, the granularity of the metrics in the U2F case is limited: there's no direct link to the frame nor U2F logic in the C++ code so timeouts aren't detected and abandonments are classified as negative responses—same as explicit user interactions. Change-Id: Ibb58dc084a0bb6599744d7112cf9975cd278c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/1255154 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#596907}
-
James Cook authored
This is a step toward supporting chrome browser windows under single-process and multi-process mash. Break AXHostService into two parts. The core AXHostService manages a map of AXRemoteHostDelegates. Each AXRemoteHostDelegate is-a ui::AXHostDelegate and therefore can handle PerformAction requests from accessibility extensions. AXHostService receives incoming AXEvents from remote apps and routes them to the correct AXRemoteHostDelegate, which forwards them to the extension. Integration tests already exist in SpokenFeedbackTest. Added unit tests. Bug: 888147 Test: unit_tests, views_mus_unittests Change-Id: If2ee438b310acba9437a251bd77e06bfb7d9a099 Reviewed-on: https://chromium-review.googlesource.com/c/1260205 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#596906}
-
Marijn Kruisselbrink authored
This reverts commit 7cff6f2f. Reason for revert: NavigationPopupTest.testFaviconFetching started crashing after this landed in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/3164 Original change's description: > Refactor NavigationPopup to not expose the View type to clients. > > This is a step towards removing ListPopupWindow and using a vanilla > Popup to deal with styling issues. > > BUG=800033 > > Change-Id: I79506cdd7c3e840e13e9ebbabce39948a9fa5936 > Reviewed-on: https://chromium-review.googlesource.com/c/1259480 > Commit-Queue: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Becky Zhou <huayinz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596734} TBR=tedchoc@chromium.org,huayinz@chromium.org Change-Id: I6a7d3c914fcca88e64eea4158fbea9db224d762c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800033 Reviewed-on: https://chromium-review.googlesource.com/c/1263344Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#596905}
-
rbpotter authored
As requested by UI review. Bug: 891379 Change-Id: I0f5d69300852a4a8cae191684ceddb2c5fbfaa15 Reviewed-on: https://chromium-review.googlesource.com/c/1262431Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#596904}
-
Kenichi Ishibashi authored
This CL adds several UMAs to track time spend each stage of service worker involved main resource loading. The purpose of these UMAs is to make it easier to investigate performance bottleneck. Design doc: https://docs.google.com/document/d/16K2X5k6hUq7lZSee-KXR9FUeSTEEypDXCjYbu_CvkT0/edit?usp=sharing Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 877972 Change-Id: Ibb2433cafb090e66b450236ef2f5f1f4baa918bf Reviewed-on: https://chromium-review.googlesource.com/c/1256384Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Takumi Fujimoto authored
When the presentation request is set, use its origin in the dialog header. E.g. "Cast youtube.com" instead of "Cast". If the user selects a non-tab source (desktop or local file), switch to using just "Cast". Bug: 851610 Change-Id: I7c672e458fa82af0182e1d9ed20a7f922e3ad814 Reviewed-on: https://chromium-review.googlesource.com/c/1259618 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#596902}
-
Tommy Martino authored
This CL adds a 4dp vertical margin on either side of the list inside a Dropdown window. This is needed for the Autofill refresh. Bug: 874077 Change-Id: If37016cafe886417cd4a82e9b59f75dd8ccbba7d Reviewed-on: https://chromium-review.googlesource.com/c/1262962 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#596901}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f638bbc181eb..264079a57aec git log f638bbc181eb..264079a57aec --date=short --no-merges --format='%ad %ae %s' 2018-10-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 70554c25..c5c13a1e (596607:596716) Created with: gclient setdep -r src/third_party/webrtc@264079a57aec The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idab1cc9860710c239fd9be8515a4421b28d54d6e Reviewed-on: https://chromium-review.googlesource.com/c/1262855Reviewed-by:
-
Becky Zhou authored
The Feed NTP attaches the SnapScrollHelper before scroll position restoration, but legacy Zine attaches after. Thus, changing the current logic for search box scrolling to handle scroll position restoration well. Bug: 889228 Change-Id: Ib2055b0e98b877ee3ced35356af2cf3b26743480 Reviewed-on: https://chromium-review.googlesource.com/c/1259609 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Orin Jaworski authored
This CL adds a few new .h and .cc files for upcoming omnibox Pedals prototype. None of this code is used yet, but changes necessary to ensure that one Pedal can be used are included so it compiles. Change-Id: If3d03e1fd532fdace55bde941ab1d5597748a168 Reviewed-on: https://chromium-review.googlesource.com/c/1247223 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#596898}
-
Min Qin authored
If browser is not started, we don't have a profile to get the tracker The Download completed message is used by in-product help/ BUG=842245 Change-Id: I2716dbc659e7e192198070ccd9e3d700a89f2810 Reviewed-on: https://chromium-review.googlesource.com/c/1263275Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596897}
-
Gabriel Marin authored
Original CL: - https://codereview.chromium.org/14769008 Fix mmap region iteration while no regions are recorded. If no mmap regions are recorded, iteration failed since the RegionSet (std::set) object is not initialized. BUG=162208 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198878 BUG=724399,b:70905156 Change-Id: I9659e486e5be89e6c36bcdf83d794dee3295e91b Reviewed-on: https://chromium-review.googlesource.com/c/1130807Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#596896}
-
Nicholas Verne authored
We now test for existence of the path /dev/kvm at startup. This directory only exists for board which can run VMs. As a side effect, this will address the attached bug. Bug: 891554 Change-Id: Icd24f6da9f3490e54b9d86bbefa7a1350627d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/1261840 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#596895}
-
David Trainor authored
This reverts commit bebc3d33. Reason for revert: Causes namespace issues with ontherecord download content ids. Original change's description: > Download shelf : Fix for incognito > > Currently incognito downloads are showing up on the download shelf for > normal profile.We need to initialize the DownloadManagerDelegate and > DownloadShelfController for incognito. Also we need to filter out the > updates for the right profile in the controller since aggregator sends > updates for all profiles. > > Bug: 881499 > Change-Id: I309d1673e87de44b870d4efaca606390dd46345e > Reviewed-on: https://chromium-review.googlesource.com/c/1257003 > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596735} TBR=dtrainor@chromium.org,qinmin@chromium.org,shaktisahu@chromium.org,rayankans@chromium.org Change-Id: I996da981cb9ccf586a1c6965e65c2a90b687b296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 881499 Reviewed-on: https://chromium-review.googlesource.com/c/1263339Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#596894}
-
Ken Buchanan authored
When a user presses a mouse button over a PDF, the PDF receives all mouse input until there is a corresponding MouseUp. This is currently broken for OOPIFs because the browser process doesn't know when a PDF is supposed to capture input and so it doesn't always route events to the right process. This change causes renderers to signal the browser process for mouse capture when a PDF is is clicked. Bug: 864957 Change-Id: If17587d5ca475d9a8ac03a3bba301d4084e6d4e3 Reviewed-on: https://chromium-review.googlesource.com/c/1203883 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#596893}
-
Robbie McElrath authored
Change-Id: Ieb633af2954b9352f4650e3ba773369cbd530a32 Reviewed-on: https://chromium-review.googlesource.com/c/1260216Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#596892}
-
Denis Kuznetsov authored
Bug: 854101 TBR: alemate@chromium.org Change-Id: If980f6b3e45fd7f35378e197a2781d9ce033b28c Reviewed-on: https://chromium-review.googlesource.com/c/1251536 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596891}
-
Matt Falkenhagen authored
Shared worker's factory bundle's default factory can now be AppCache rather than network, since support for shared worker + AppCache was added in issue 715632. Use CloneWithoutDefaultFactory() to make the service worker fallback factory accordingly, as is done for frames in RenderFrameImpl::BuildServiceWorkerNetworkProviderForNavigation and dedicated workers in RenderFrameImpl::CreateWorkerFetchContext. No test added since we don't have a feature that can be set as the default factory and be used in conjunction with service worker. The point of the change is to fix the comments and make it consistent with the other callsites. Bug: 715632 Change-Id: Ie1ee1cae5423fd81933dea599e6d724a12bf51f7 Reviewed-on: https://chromium-review.googlesource.com/c/1260883Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#596890}
-
Boris Sazonov authored
This CL changes how the drawable for the refresh button in the app menu is tinted. Now Drawable object is tinted instead of relying on ImageButton tinting, because ImageView can't tint LevelListDrawable on some Android versions. Bug: 891593 Change-Id: Ic5d45b3f281f3a1dc44cada814e5c0d83b14b2b4 Reviewed-on: https://chromium-review.googlesource.com/c/1262636Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#596889}
-
Yiming Zhou authored
Each action in the Captured Sites Automation Framework has a target frame. The framework uses the IFrameWaiter object to acquire a handle to the RenderFrameHost of the target frame. A target iframe can be identified by its name, its URL or the origin of its URL. Currently the IFrameWaiter object scans for potential targets everytime Chrome adds a new frame. This change adds 2 additional hooks to IFrameWaiter to scan for potential targets: 1. When a frame changes its name. 2. When a frame finishes loading a new URL. Bug: 847905 Change-Id: Ie2b8c2f19a9f08696d474aff6af019ae116b513c Reviewed-on: https://chromium-review.googlesource.com/c/1260510 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#596888}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib20eeebffce6a7c4a51534bafd33e13d7d0a228f Reviewed-on: https://chromium-review.googlesource.com/c/1262757 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#596887}
-
Anne Lim authored
Added per-project functions for credit card uploads. Each project has its own requirements/parameters, so it must have its own function to determine its key. Each project also has its own private function to return a project prefix string. Bug: 884717 Change-Id: Ib241378a8fa6a99071898f61425cdcefe69a16a0 Reviewed-on: https://chromium-review.googlesource.com/c/1260502Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1b6e81b579f3..3f7d74f7cd02 git log 1b6e81b579f3..3f7d74f7cd02 --date=short --no-merges --format='%ad %ae %s' 2018-10-04 simonhatch@chromium.org Dashboard - Remove old buildbot link if new one is there 2018-10-04 sebmarchand@chromium.org Add more system stats to the UI tracing view Created with: gclient setdep -r src/third_party/catapult@3f7d74f7cd02 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884961 TBR=sullivan@chromium.org Change-Id: I943091e568645704071b431cb1da5c0aa2f29693 Reviewed-on: https://chromium-review.googlesource.com/c/1262240Reviewed-by:
-
Jao-ke Chin-Lee authored
This reverts commit e5d0061d. Reason for revert: only switch after confirming WAI Original change's description: > Make WebKit Win10 part of win-ci. > > BUG=790343 > > Change-Id: I64d509837aaf84043e1e3e749bcda748e0c42da4 > Reviewed-on: https://chromium-review.googlesource.com/c/1260012 > Reviewed-by: Ryan Tseng <hinoka@chromium.org> > Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596409} TBR=hinoka@chromium.org,jchinlee@chromium.org Change-Id: I0f3c5228ab4fe404c31244bbcf92f9328ac3b9f1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 790343 Reviewed-on: https://chromium-review.googlesource.com/c/1263051Reviewed-by:
-
Daniel Rubery authored
Referrer chains are broken in M69 if the page sets window.location. This was already fixed at HEAD, so this CL simply introduces a browser test to prevent regression. Change-Id: I4d29b3a4ae36b931273125191f6aa3fe703b44c6 Reviewed-on: https://chromium-review.googlesource.com/c/1262966Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#596883}
-
Martin Kreichgauer authored
This change extracts an abstract base class called FidoDiscoveryBase from FidoDiscovery. The FidoDiscovery::Observer interface is moved into the base class, and its signature is changed to allow observing the instantiation and destruction of FidoAuthenticator instances rather than FidoDevice. I.e. FidoDiscovery::Observer::Device{Added,Removed} becomes FidoDiscoveryBase::Observer::Authenticator{Added,Removed}. FidoDiscovery takes on the responsibility of instantiating and owning FidoAuthenticator instances (more specifically, FidoDeviceAuthenticator instances). The AuthenticatorMap in FidoRequestHandlerBase now only holds plain FidoAuthenticator pointers, rather than owning the unique_ptrs. This gets us closer to getting platform-y authenticators (Touch ID, Windows) injected via Discovery implementations, rather than implementing custom interaction between FidoRequestHandlerBase and AuthenticatorImpl for them (see SetPlatformAuthenticatorOrMarkUnavailable). Better naming might have been "FidoDeviceDiscovery" for FidoDiscovery and perhaps "FidoDiscovery" for FidoDiscoveryBase, but that would be a rather large diff. A sensible additional refactoring might be to make FidoDeviceAuthenticator own its associated FidoDevice. Change-Id: I05d9c24819745c784fef3898bec8d6bb63d2f503 Reviewed-on: https://chromium-review.googlesource.com/c/1256016 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596882}
-
Katie D authored
This makes Slides read more smoothly, but will not differentiate between spaces between words and paragraphs in intonation. DOM ordering is used rather than visual ordering, this is unchanged. Bug: 809734 Change-Id: Ieb17eef53f4de360f2d1f13e8a561d3aa05af115 Reviewed-on: https://chromium-review.googlesource.com/c/1262086Reviewed-by:
-
Robert Ogden authored
Also adds a "Settings" link on Android only that opens the Data Saver settings menu, and related UMA. Bug: 889124 Change-Id: I087a4719671d5ce811c52331f2906e1e4202ced4 Reviewed-on: https://chromium-review.googlesource.com/c/1258972Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#596880}
-
