- 28 Jun, 2019 40 commits
-
-
Ella Ge authored
This reverts commit 759c81d7. Reason for revert: Test failing on Linux TSan bot https://ci.chromium.org/p/chromium/builders/ci/Linux%20TSan%20Tests/40627 Original change's description: > [PM] Add the non recording site data cache. > > Bug: 961336 > Change-Id: I91c40d8d6a603ab6ea7fdef31b2fb76a01ee28b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659468 > Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673313} TBR=chrisha@chromium.org,sebmarchand@chromium.org Change-Id: I0a8b865c7ccdb17fb62b865e43925f5080972b77 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 961336 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682248Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#673448}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b8c9b171..45ddaace Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I270b7984b6a95e0f54a7e97cc451224df82b38d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681680Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673447}
-
Yue Zhang authored
Bug: 979410 Change-Id: I520c1ad7619c5852ce0df0160a4ed5439329602b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681025 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673446}
-
Yue Zhang authored
Although GridTabSwitcherMediatorUnitTest manages to pass the CQ, it doesn't work locally in current build. Specifically, error is caused by ContextUtils.getApplicationContext() returns null locally but gets passed on CQ. This CL fixes this issue. Bug: 979698 Change-Id: I720b0994e376c9071efb031e776f060a3f383fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681008Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 808f0414. With Chromium commits locally applied on WPT: bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ic5ef64c71cb39aa06ea8309e76de81a78242e4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681952Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673444}
-
Juanmi Huertas authored
Adding a function to detect when a renderingcontext2d has pattern and if it is accelerated. Using that to handle the case when the pattern is big and unaccelerated and it is being copied to an accelerated canvas. Falling down to unaccelerated. Bug: 969713 Change-Id: I4fc30fe2f79bb525a25fbedd11dfb5da73277cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678550 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673443}
-
Mason Freed authored
Previous to this CL, it was possible on some platforms for the frame buffer copy texture (used by CopyTexImage2D) to have one format, and the skia wrapped texture (used by SkImage::MakeFromTexture) to have a different format. This lead to intermittent errors in GLUtils::ValidateCopyTexFormatHelper() for mismatched formats. And that lead to the backdrop-filter feature flickering on/off when a re-layout occured. This is now fixed. Bug: 978858,977264 Change-Id: Ie6bb6d41293092eb860429dccf274502c0b1faef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681086 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#673442}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/363f5f2c6246..2e0eea217640 git log 363f5f2c6246..2e0eea217640 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 saklein@chromium.org SdkService/Create: Fix broken chroot check. Created with: gclient setdep -r src/third_party/chromite@2e0eea217640 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I7fbd5b38df4bf3f5cceac408fee2116b693d8144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680932Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673441}
-
Kyle Horimoto authored
The cellular "device" properties (e.g., IMEI, ICCID) were no longer being displayed. This regression was caused by a refactor [1] which renamed a property but was still referencing the old property's name. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1460401 Bug: 979681 Change-Id: I619bc42d2235686fa51002dad3785d6c260fa284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681976 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673440}
-
Xianzhu Wang authored
This reverts commit c7cb1a8e. Use a more reliable way to check if a fixed-pos element's container is LayoutView. The previous method of checking parent transform was not reliable because the fixed-pos container may not create transform nodes. Original change's description: > Revert "Fix TransformNode::IsAffectedByOuterViewportBoundsDelta()" > > This reverts commit ea5c2a2c. > > Reason for revert: Checking the parent transform to check if a fix-pos > element is contained by LayoutView is not reliable. > > Original change's description: > > Fix TransformNode::IsAffectedByOuterViewportBoundsDelta() > > > > Don't set the flag in the following cases: > > 1. The fixed element is contained by an ancestor below the LayoutView; > > 2. The fixed element is not in the main frame. > > > > Bug: 978774 > > Change-Id: I430dc968c0d016ac9bee4f4934508703a3b90645 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680938 > > Reviewed-by: David Bokan <bokan@chromium.org> > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#673239} > > TBR=wangxianzhu@chromium.org,bokan@chromium.org,pdr@chromium.org > > Change-Id: I120ced5c25468a81e0d9ec227073597dce7bb2c8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 978774 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680734 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673370} Change-Id: I5fc8f9c354f616068899b967160425d481dc2c26 Bug: 978774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681931Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673439}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/74561df3e679..83dd452c1fe6 git log 74561df3e679..83dd452c1fe6 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 bclayton@google.com Reactor: Assert that array indexing is in bounds 2019-06-28 bclayton@google.com CMakeLists: Use ccache if found 2019-06-28 srisser@google.com Cleanup unittests a bit 2019-06-28 bclayton@google.com Pipeline/ShaderCore: Reimplement halfToFloatBits to not rely on denorm float multiply 2019-06-28 chrisforbes@google.com Wire up remaining 32b __sync_* functions required for arm32 Created with: gclient setdep -r src/third_party/swiftshader@83dd452c1fe6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/136095012,chromium:b/135691587 TBR=swiftshader-team+autoroll@google.com Change-Id: Ie3730b7aa2d0b822716c4cf4309567d6fb4311f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682092Reviewed-by:
-
Ella Ge authored
TBR=dmazzoni@chromium.org No-Try: true Bug: 979741 Change-Id: I3d5fed13457c83adb095c930bd50f7c0685a23cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682328Reviewed-by:
-
Tarun Bansal authored
Change-Id: I0cc00257f117a5ea92cbeaa137660c972ea9d180 Bug: 913424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681265Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#673436}
-
Saman Sami authored
When GpuProcessHost::ForceShutdown is called, another instance of GpuProcessHost is created before the old one is destroyed, in which case OnGpuServiceLaunched() is called before OnChannelDestroyed(). When this happens, ignore OnChannelDestroyed() and call OnGpuServiceLost() at the beginning of OnGpuServiceLaunched(). Bug: 620927 Change-Id: Ic3d8b3847d5a0a89280bb31dcacd729111dd7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679100Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#673435}
-
Regan Hsu authored
This CL is an example of how tests for components shared by OS and Browser should be moved. Change-Id: Ifa11ebbfc3faf526092b7fb1ea4713ae06073cae Bug: 968182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677768 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#673434}
-
Kevin McNee authored
The view may be null when a keyboard event ack comes in, such as during portal activation. Bug: 979639 Change-Id: Ic8685808939711b4e739ec4bf9ded812a701ea69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681871 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673433}
-
Koji Ishii authored
This patch changes the stack size of Windows x64 to 8MB, matching to other desktop platforms. Historycally, Windows has the lowest stack size among the platforms we support. This has been causing more stack overflows on Windows. Since the stack size wasn't changed for such a long time, r460828 (CL [1]) took conservative increase to 2MB. With the switch to LaoyutNG, some modest site reports stack overflows. We will keep our efforts to limit the stack usage, but matching to other platforms allows us to use reasonable stack for the better performance. [1] https://codereview.chromium.org/2785043002 Bug: 977387 Change-Id: I3e16cebc090a9766d896679105bcd84138816c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681500Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#673432}
-
Khushal authored
Skia may fail to create an SkImage when initializing the SkiaTextureHolder from a mailbox or a provided texture id. Handle this safely in SkiaTextureHolder. R=fserb@chromium.org Bug: 978659 Change-Id: I5e76292b55302cd9045568dd4bc912d1d765af98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679737 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
Adding unitests to ensures the zero width characters are processeed correctly with render_text and font fallbacks. R=msw@chromium.org Bug: 972090 Change-Id: Ie68f706278669f1347475699cf0516e9ad1356ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681451Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673430}
-
Ken Buchanan authored
A type map for authenticator.mojom was added in: https://chromium-review.googlesource.com/c/chromium/src/+/1653489 This follows up by adding one for the test class, virtual_authenticator.mojom, allowing removal of the typeconverter files. Bug: 831209 Change-Id: I166b5076da22e0ac98055e5efbdba88d2590c51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674223Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673429}
-
Kristi Park authored
Bug: 953822 Change-Id: Iec62b45fc25ec411fde50ca6b765139c07a6e6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677236Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#673428}
-
danakj authored
This is a reland of 0287293f It removes the change to use content::NavigateToURL as it introduced flake: https://bugs.chromium.org/p/chromium/issues/detail?id=979664 TBR=rouslan@chromium.org Original change's description: > Make PaymentRequestBrowserTestBase more compatible with Android > > Replace the mojo injection to change how PaymentRequests are made > by instead injecting a factory in C++. Future work will do a similar > injection into the Android Java code to change PaymentRequest behaviour > in similar ways. > > Use content test helpers to navigate instead of chrome ui desktop-only > helpers. > > R=rouslan@chromium.org > > Bug: 961849 > Change-Id: Id4859416e7457686cc35c9c578ee3a4954fe80e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680861 > Commit-Queue: danakj <danakj@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#673091} Bug: 961849 Change-Id: I3083e2c9d7557a7ecf8c48a2bbe2a0d19f56fab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681878Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#673427}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/923582ce437a..c4781ad47d89 Created with: gclient setdep -r src-internal@c4781ad47d89 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ifdd17a63d7c2026e6b6a72a9b4ecacbd3f84a3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673426}
-
Asanka Herath authored
This test was not enabled on macOS due to flakiness. The codepaths involved have changed substantially. This CL re-enables the bug to verify whether the flakiness still exists and if so to determine the underlying cause. Either way, the underlying logic is once again going through some changes which makes it important to have test coverage on macOS. Bug: 927074 Change-Id: Ie39bd7bc974e49b7dcb3ed27febb89a8ec890107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681558Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#673425}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/48e07b5f07a4..7781794b96fb git log 48e07b5f07a4..7781794b96fb --date=short --no-merges --format='%ad %ae %s' 2019-06-28 zoddicus@users.noreply.github.com Rolling 2 dependencies (#748) Created with: gclient setdep -r src/third_party/shaderc/src@7781794b96fb The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Id2daa553da5b98f21871352151f8aebe8178c94c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682091Reviewed-by:
-
Khushal authored
Canvas2DLayerBridge keeps track of the current resource on the cc::TextureLayer to avoid unnecessary updates to the layer's resource if it was not updated. But it missed a case where the TextureLayer's resource was being cleared if the canvas is made invisible after hibernation. Avoid the above by simply asking the layer for its current resource instead of mirroring that state in Canvas2DLayerBridge and running into issues if we can't keep them consistent. R=enne@chromium.org,fserb@chromium.org Bug: 977474 Change-Id: I6850115ffc019d7148a4dad40f97bb66029aa4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680296Reviewed-by:
-
John Lee authored
This CL merges some CSS to just 1 selector, removes some unnecessary CSS, and introduces a CSS variable for controlling the min-height of cr-input. https://imgur.com/a/XpUvUNZ Bug: 973674 Change-Id: I5fa6969548d6cc307e3f91a475e399ee977b5b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680656Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#673422}
-
Natalie Chouinard authored
Migrate the Payment methods preference fragment from the deprecated framework preferences to support library preferences. Bug: 968592 Change-Id: Id59253744c2cf278ad6bcbcad2a897887139c004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680673Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#673421}
-
Jun Cai authored
This is a follow-up CL for the discussion at the following CL about using JniMocker in the instrumentation tests: https://chromium-review.googlesource.com/c/chromium/src/+/1665909/7 This CL updates the jni_generator/README.md saying that currently JniMocker only works for junit/robolectric tests, and is not yet ready for instrumentation tests. Bug: None Change-Id: I9b82f38f47068a18813ed2601b3fe3d779f7fb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681004 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#673420}
-
wutao authored
Assistant web view has different host widget, so the event target may not be the |contents_view|. It should be enough to only check position in Tablet mode because the Assistant window is always on the top if it is visible. Bug: b/134169629 Test: manual Change-Id: I3e7cdac7ac122226ed2cc0b7ced83633a048ac7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679437 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#673419}
-
Yuly Novikov authored
Also update the documentation. Bug: 978103, 898684 Change-Id: I412fa68addac0327c7632d83a90606f99e6ebc31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680974Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#673418}
-
Jun Mukai authored
Currently individual ArcAppResult / CrostiniAppResult instance keeps icon loader and the results will be recreated every time the search is conducted (including suggestion chip). This means the ARC++ / Crostini searchers always attempt to load the same icon every time the app-list is shown and some query is searched. This is apparently inefficient; this CL allows to cache the icon images for such search results so that no further image loading and decoding won't be conducted. This CL doesn't change the performance numbers on the LauncherAnimations test cases since they use dummy data. By measuring on a real session with my test account, I see improvements AnimationSmoothness.Peeking by ~10%. Mean 51.0 to 60.2 for 10 attempts, mode value improved from 41 to 58. Bug: 978461 Test: manually Change-Id: Ie34ad979d6fdf94addc2959ea74a4e4d9652add0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677260Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673417}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6d47875c4c50..85e0cba51e88 git log 6d47875c4c50..85e0cba51e88 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 crouleau@chromium.org [Telemetry] Raise exception when trace buffer is overrun. Created with: gclient setdep -r src/third_party/catapult@85e0cba51e88 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948412 TBR=crouleau@google.com Change-Id: I51da4e1da745425a3a5fd328132c6ba139716dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681970Reviewed-by:
-
Tarun Bansal authored
Enable PredictivePrefetchingAllowedOnAllConnectionTypes by default since we decided to enable the experiment for 100% population now. Change-Id: I053429312301d5665ef599523b8b919ac0e6a0ed Bug: 914503 TBR: rkaplow@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679655Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#673415}
-
dpapad authored
<link rel="import" src="foo.html"> needs to be converted to import './foo.m.js'; Where the "./" prefix is added, otherwise the following error is thrown at runtime. Uncaught TypeError: Failed to resolve module specifier "foo.m.js". Relative references must start with either "/", "./", or "../". This was discovered while porting md_select_css.html to Polymer3, which happens to trigger this case. Bug: 965770 Change-Id: Id22bcb70a2d1bb4035b33b54dbde87bf0321982c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681343 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#673414}
-
Gabriel Charette authored
This is a prerequisite for MOCK_TIME on ThreadPool because base::internal::WorkerThread doesn't support TimeTicks::Now() being zero. And it's also a definite source of pain given the number of codesites found which had to work around this. Bug: 946657 Change-Id: I115b4af77e5095454b2d505915884215e82d7f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677107Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#673413}
-
Evan Stade authored
This re-lands commit a5646d5a. Difference to original: Override TearDownOnMainThread() instead of TearDown(). Original change's description: > Remove NOTIFICATION_FULLSCREEN_CHANGED > > Replace with an observer interface on FullscreenController. > > Bug: 268984 > Change-Id: I1af2056e870af56b2f436a3aa8c6a54ed0ff44fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666148 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671901} Bug: 268984 Change-Id: I735754efa634d8ef21b4bb57f366dbad22b3c682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676731 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673412}
-
Salvador Guerrero authored
leveldb_database.cc used to log all initialization errors, including a case we considered normal. When a database file is missing, and the client set create_if_missing = false then this means the client expected the file to be missing. Our DB code attempts to open the shared database. As no client has migrated to it then it's fine if it doesn't exist. However, as this code get executed when BrowserContext starts then it spams the logs on BrowserTests. This CL removes logging for this specific case, as it is an expected state which doesn't have to be logged. Change-Id: I51a986b43b13c441384a7cf67df6565a64881941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670361 Commit-Queue: Salvador Guerrero <salg@google.com> Auto-Submit: Salvador Guerrero <salg@google.com> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#673411}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a47ba4119f27..8f01c4e1b654 git log a47ba4119f27..8f01c4e1b654 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 eladalon@webrtc.org Define FecControllerOverride and plumb it down to VideoEncoder 2019-06-28 danilchap@webrtc.org Add trait to Build/Parse DependencyDescriptor rtp header extension 2019-06-28 kwiberg@webrtc.org Initialize signal processing function pointers statically Created with: gclient setdep -r src/third_party/webrtc@8f01c4e1b654 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3273b3dfceb7f9e01950a9245ce9788c2e5fd840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682090Reviewed-by:
-
Jun Cai authored
This CL implements the permission prompt for Bluetooth Scanning API on Android: 1. Implements a permission prompt on Android. The message at the top of the prompt calls out that the user is being asked the permission for a site to receive nearby Bluetooth advertisement packets. The prompt lists device name for found nearby Bluetooth devices. 2. Implements the ShowBluetoothScanningPrompt method in TabWebContentsDelegateAndroid which launches a permission prompt displaying the nearby Bluetooth devices. I uploaded some screenshots of the permission prompt in the issue link. Bug: 960960 Change-Id: I15a3b4115644fe0d8674c7c00921b5560287e51d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665909Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#673409}
-
