1. 06 Apr, 2011 40 commits
    • enrica@apple.com's avatar
      REGRESSION: Drag & Drop Gmail Attachments doesn't work. · b73b711c
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57909
      <rdar://problem/9103220>
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      In WebKit2 we cannot rely on the value returned by platformData() that
      on Mac returns an NSDraggingInfo object. This is available only in the UI
      process. Therefore we should use m_pasteboard instead.
      We cannot change what platformData() returns on Mac, since there are
      delegate methods that receive a NSDraggingInfo object (only in WebKit).
              
      * platform/DragData.h:
      (WebCore::DragData::pasteboard): Added.
      * platform/mac/ClipboardMac.mm:
      (WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
      * platform/mac/DragDataMac.mm:
      (WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
      (WebCore::DragData::asURL): Same as above.
      
      Source/WebKit2: 
      
      Added _hitTest method to support drag and drop when the drag types cannot be matched.
      This is the case for elements that do not place content
      in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).
                     
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _hitTest:dragTypes:]): Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83070 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b73b711c
    • commit-queue@webkit.org's avatar
      2011-04-06 Steve Lacey <sjl@chromium.org> · 602477f7
      commit-queue@webkit.org authored
              Reviewed by Eric Carlson.
      
              fast/layer/video_layer.html has the same text output for all chromium mac platforms.
      
              [chromium] Fix fast/layers/video_layer.html expectations
              https://bugs.webkit.org/show_bug.cgi?id=57386
      
              * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
              * platform/chromium-mac/fast/layers/video-layer-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83069 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      602477f7
    • sergio@webkit.org's avatar
      2011-04-06 Sergio Villar Senin <svillar@igalia.com> · 02202918
      sergio@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] DumpRenderTree: do not try to free NULL SoupURIs
              https://bugs.webkit.org/show_bug.cgi?id=57932
      
              Some Layout tests have invalid URIs that do not generate valid
              SoupURI instances. Do not try to free those NULL SoupURIs.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (willSendRequestCallback):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83068 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      02202918
    • benjamin.poulain@nokia.com's avatar
      2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com> · 09b7d751
      benjamin.poulain@nokia.com authored
              Reviewed by Darin Adler.
      
              ClipboardWin has unused variables "ExceptionCode ec"
              https://bugs.webkit.org/show_bug.cgi?id=57952
      
              Remove the unused variable.
      
              * platform/win/ClipboardWin.cpp:
              (WebCore::ClipboardWin::declareAndWriteDragImage):
              (WebCore::ClipboardWin::writePlainText):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83067 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      09b7d751
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 206f5a00
      rniwa@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Split getBorderPaddingMargin into two functions
              https://bugs.webkit.org/show_bug.cgi?id=57947
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
              (WebCore::borderPaddingMarginEnd): Ditto.
              (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
              (WebCore::RenderBlock::findNextLineBreak): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83066 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      206f5a00
    • morrita@google.com's avatar
      2011-04-06 MORITA Hajime <morrita@google.com> · 6908d483
      morrita@google.com authored
              Reviewed by Dimitri Glazkov.
      
              [Refactoring] <progress> should not have manual layout code.
              https://bugs.webkit.org/show_bug.cgi?id=57801
      
              Updated progress-bar-value-pseudo-element.html to have wider coverage and
              follow pseudo class change.
      
              * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
              * platform/chromium/test_expectations.txt:
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
      2011-04-06  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              [Refactoring] <progress> should not have manual layout code.
              https://bugs.webkit.org/show_bug.cgi?id=57801
      
              - Simplified RenderProgress, removing its custom layout code
              - Introducing ProgressValueElement and ProgressBarElement, replacing
                ProgressBarValueElement.
      
              Now the structure is almost identical to <meter>,
              other than:
              - RenderProgress has animated painting, thus manages its own timer.
              - Both ProgressValueElement and ProgressBarElement has pseudo classes
                which don't changes during its lifetime.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * css/html.css:
              (progress):
              (progress::-webkit-progress-bar):
              (progress::-webkit-progress-value):
              * html/HTMLProgressElement.cpp:
              (WebCore::HTMLProgressElement::~HTMLProgressElement):
              (WebCore::HTMLProgressElement::create):
              (WebCore::HTMLProgressElement::attach):
              (WebCore::HTMLProgressElement::didElementStateChange):
              (WebCore::HTMLProgressElement::createShadowSubtree):
              * html/HTMLProgressElement.h:
              * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
              (WebCore::ProgressShadowElement::ProgressShadowElement):
              (WebCore::ProgressShadowElement::progressElement):
              (WebCore::ProgressShadowElement::rendererIsNeeded):
              (WebCore::ProgressBarElement::shadowPseudoId):
              (WebCore::ProgressValueElement::shadowPseudoId):
              (WebCore::ProgressValueElement::setWidthPercentage):
              * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
              (WebCore::ProgressBarElement::ProgressBarElement):
              (WebCore::ProgressBarElement::create):
              (WebCore::ProgressValueElement::ProgressValueElement):
              (WebCore::ProgressValueElement::create):
              * rendering/RenderProgress.cpp:
              (WebCore::RenderProgress::RenderProgress):
              (WebCore::RenderProgress::updateFromElement):
              (WebCore::RenderProgress::animationTimerFired):
              * rendering/RenderProgress.h:
              (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
              (WebCore::RenderProgress::canHaveChildren):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83065 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6908d483
    • mario@webkit.org's avatar
      2011-04-06 Mario Sanchez Prada <msanchez@igalia.com> · 0a919acc
      mario@webkit.org authored
              Reviewed by Chris Fleizach.
      
              [GTK] Do not reference AccessibilityRenderObject from platform dependent code
              https://bugs.webkit.org/show_bug.cgi?id=57955
      
              Do not reference AccessibilityRenderObject from platform specific code
      
              Added new virtual functions to AccessibilityObject.h and removed
              explicit references to AccessibilityRenderObject from GTK code.
      
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::renderer): New virtual method,
              returning 0 by default. Overriden by AccessibilityRenderObject.
              (WebCore::AccessibilityObject::correspondingLabelForControlElement):
              New virtual method, returning 0 by default. It complements the
              already present method correspondingControlForLabelElement().
      
              * accessibility/AccessibilityRenderObject.h:
              (WebCore::AccessibilityRenderObject::renderer): Made virtual.
      
              * accessibility/gtk/AXObjectCacheAtk.cpp:
              (WebCore::emitTextChanged): Reference  AccessibilityObject,
              instead of AccessibilityRenderObject.
              (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
              Ditto.
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_get_name): Do not reference
              AccessibilityRenderObject.
              (webkit_accessible_get_description): Ditto.
              (setAtkRelationSetFromCoreObject): Ditto.
              (optionFromList): Ditto.
              (optionFromSelection): Ditto.
              (webkit_accessible_selection_clear_selection): Ditto.
              (webkit_accessible_selection_get_selection_count): Ditto.
              (webkit_accessible_selection_select_all_selection): Ditto.
              (textForObject): Ditto.
              (webkit_accessible_text_get_text): Ditto.
              (getPangoLayoutForAtk): Ditto.
              (webkit_accessible_text_get_caret_offset): Ditto.
              (baselinePositionForRenderObject): Ditto.
              (getAttributeSetForAccessibilityObject): Ditto.
              (accessibilityObjectLength): Ditto.
              (getSelectionOffsetsForObject): Ditto.
              (webkit_accessible_text_set_selection): Ditto.
              (webkit_accessible_text_set_caret_offset): Ditto.
              (webkit_accessible_table_get_caption): Ditto.
              (getInterfaceMaskFromObject): Ditto.
      
              * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
              (getRangeLengthForObject): Ditto.
      
              Removed unused renderer() method from AccessibilityMenuList.
      
              * accessibility/AccessibilityMenuList.h: Removed unused method.
              * accessibility/AccessibilityMenuList.cpp: Removed unused method.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83064 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0a919acc
    • demarchi@webkit.org's avatar
      2011-04-06 Lucas De Marchi <lucas.demarchi@profusion.mobi> · 70f347e9
      demarchi@webkit.org authored
              cmake: Fix build for ARMv7
      
              * CMakeLists.txt: add missing file.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83063 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70f347e9
    • apavlov@chromium.org's avatar
      2011-04-06 Alexander Pavlov <apavlov@chromium.org> · fc8ca63e
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Javascipt warning link expand and overlap with icons in js console
              https://bugs.webkit.org/show_bug.cgi?id=57939
      
              * inspector/front-end/inspector.js:
              (WebInspector.linkifyURLAsNode):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83062 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fc8ca63e
    • apavlov@chromium.org's avatar
      2011-04-06 Alexander Pavlov <apavlov@chromium.org> · a870b685
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
              https://bugs.webkit.org/show_bug.cgi?id=57931
      
              * inspector/Inspector.json:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83061 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a870b685
    • commit-queue@webkit.org's avatar
      2011-04-06 Jia Pu <jpu@apple.com> · 152f1a32
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
              https://bugs.webkit.org/show_bug.cgi?id=57665
              <rdar://problem/7350477>
      
              We need to track how user modified an autocorrected word. If he changed it back to original
              text, we want to record AutocorrectionReverted response. And if he changed it to something
              else, we want to record AutocorrectionEdited response.
      
              To achieve this, we need to distringuish between text replacement caused by autocorrection
              from that due to other causes, such as reversion, text substitution, etc. So we added a new
              marker type "Autocorrected". We also need to be able to check for correction, even when we
              don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
              value, "CheckForCorrection".
      
              We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
              specified range, and of specified type.
      
              * dom/DocumentMarker.h:
              * dom/DocumentMarkerController.cpp:
              (WebCore::DocumentMarkerController::markersInRange):
              (WebCore::DocumentMarkerController::hasMarkers):
              * dom/DocumentMarkerController.h:
              * editing/Editor.cpp:
              (WebCore::markerTypesForAutocorrection):
              (WebCore::markersHaveIdenticalDescription):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
              (WebCore::Editor::changeBackToReplacedString):
              (WebCore::Editor::markMisspellingsAndBadGrammar):
              (WebCore::Editor::applyCorrectionPanelInfo):
              (WebCore::Editor::unappliedSpellCorrection):
              (WebCore::Editor::textCheckingTypeMaskFor):
              * editing/Editor.h:
              * editing/SpellingCorrectionCommand.cpp:
              (WebCore::SpellingCorrectionCommand::doApply):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83060 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      152f1a32
    • commit-queue@webkit.org's avatar
      2011-04-06 Liang Qi <liang.qi@nokia.com> · 8d658120
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              Correct a include file name.
              https://bugs.webkit.org/show_bug.cgi?id=57839
      
              * wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix
              builds on Unix hosts.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83059 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d658120
    • aroben@apple.com's avatar
      Build fix after r83056 · 4059a6e9
      aroben@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83058 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4059a6e9
    • enne@google.com's avatar
      2011-04-06 Adrienne Walker <enne@google.com> · 0755f8f7
      enne@google.com authored
             Unreviewed, add Chromium snow leopard baseline for meter-boundary-values
      
              * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83057 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0755f8f7
    • aroben@apple.com's avatar
      Move JavaScriptCoreGenerated's file-copying logic out to a new script · e0fe4d74
      aroben@apple.com authored
      Hopefully this will make it easier to modify this logic in the future. I also made the
      script much quieter than the old logic, since it didn't seem helpful to see long lists of
      filenames during the copying phase.
      
      If we like this new style, we could copy it for our other projects.
      
      Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
      modify and noisy
      
      Reviewed by Steve Falkenburg.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy
      files from here...
      * JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd
      for convenience.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83056 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e0fe4d74
    • ossy@webkit.org's avatar
      ORWT shouldn't generate diff files for tests without expected files · 4efbe80e
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57846
      
      Reviewed by Andreas Kling.
      
      * Scripts/old-run-webkit-tests:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83055 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4efbe80e
    • ossy@webkit.org's avatar
      Fix using UNUSED_PARAM introduced in r82907 · 25acfd35
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57940
      
      Reviewed by Darin Adler.
      
      * WebProcess/ResourceCache/WebResourceCacheManager.cpp:
      (WebKit::WebResourceCacheManager::clearCacheForOrigin):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83054 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      25acfd35
    • podivilov@chromium.org's avatar
      2011-04-06 Sheriff Bot <webkit.review.bot@gmail.com> · 307a5abc
      podivilov@chromium.org authored
              Unreviewed, rolling out r83045.
              http://trac.webkit.org/changeset/83045
              https://bugs.webkit.org/show_bug.cgi?id=57953
      
              Broke win layout tests (Requested by podivilov on #webkit).
      
              * inspector/debugger/script-formatter-expected.txt: Removed.
              * inspector/debugger/script-formatter.html: Removed.
              * platform/chromium/test_expectations.txt:
      2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r83045.
              http://trac.webkit.org/changeset/83045
              https://bugs.webkit.org/show_bug.cgi?id=57953
      
              Broke win layout tests (Requested by podivilov on #webkit).
      
              * GNUmakefile.am:
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype._addScript):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83053 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      307a5abc
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 06795487
      rniwa@webkit.org authored
              Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.
      
              * rendering/RenderBlock.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83052 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      06795487
    • diegohcg@webkit.org's avatar
      2011-03-27 Diego Gonzalez <diegohcg@webkit.org> · 4e507343
      diegohcg@webkit.org authored
          [Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
          https://bugs.webkit.org/show_bug.cgi?id=57007
      
          Reviewed by Kenneth Rohde Christiansen.
      
          * CodeGenerators.pri:
          * css/themeQtMobile.css: Removed.
          * platform/qt/QtMobileWebStyle.cpp:
          (drawRectangularControlBackground):
          (QtMobileWebStyle::drawPrimitive):
          (QtMobileWebStyle::drawComplexControl):
          * platform/qt/QtMobileWebStyle.h:
          * platform/qt/RenderThemeQt.cpp:
          (WebCore::RenderThemeQt::isControlStyled):
          (WebCore::RenderThemeQt::paintTextField):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83051 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4e507343
    • jberlin@webkit.org's avatar
      WebKit2: Implement TextChecker on Windows · 8040ceb5
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57862
      
      Reviewed by Anders Carlsson.
      
      Part 1: Get and set the state.
      
      * Shared/API/c/win/WKBaseWin.h:
      * Shared/APIObject.h:
      * UIProcess/API/C/win/WKAPICastWin.h:
       
      * UIProcess/API/C/win/WKTextChecker.cpp: Added.
      (WKTextCheckerSetClient):
      (WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
      (WKTextCheckerGrammarCheckingEnabledStateChanged):
      * UIProcess/API/C/win/WKTextChecker.h: Added.
       
      * UIProcess/TextChecker.h:
      * UIProcess/win/TextCheckerWin.cpp:
      (WebKit::TextChecker::state):
      Do the initalization for the state only once so that it is not necessary to call the client
      every time the state is requested.
      (WebKit::TextChecker::isContinuousSpellCheckingAllowed):
      Call the client.
      (WebKit::TextChecker::setContinuousSpellCheckingEnabled):
      Update the state and tell the client.
      (WebKit::TextChecker::setGrammarCheckingEnabled):
      Ditto.
      (WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
      Update the state.
      (WebKit::TextChecker::grammarCheckingEnabledStateChanged):
      Update the state.
      
      * UIProcess/win/WebTextChecker.cpp: Added.
      (WebKit::WebTextChecker::shared):
      Make the WebTextChecker available globally.
      (WebKit::WebTextChecker::WebTextChecker):
      (WebKit::WebTextChecker::setClient):
      (WebKit::updateStateForAllWebProcesses):
      (WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
      Tell the TextChecker that the state has changed, and then tell the
      WebProcessProxies to send the new state to the WebProcesses.
      (WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
      Ditto.
      * UIProcess/win/WebTextChecker.h: Added.
      (WebKit::WebTextChecker::client):
      (WebKit::WebTextChecker::type):
      
      * UIProcess/win/WebTextCheckerClient.cpp: Added.
      (WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
      (WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
      (WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
      (WebKit::WebTextCheckerClient::grammarCheckingEnabled):
      (WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
      * UIProcess/win/WebTextCheckerClient.h: Added.
       
      * win/WebKit2.vcproj:
      Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp.
      * win/WebKit2Generated.make:
      Copy over WKTextChecker.h.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83050 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8040ceb5
    • commit-queue@webkit.org's avatar
      2011-04-06 Jia Pu <jpu@apple.com> · 84799486
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
              https://bugs.webkit.org/show_bug.cgi?id=57800
              <rdar://problem/9218223>
      
              Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
              now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.
      
              * accessibility/AXObjectCache.h:
              * accessibility/chromium/AXObjectCacheChromium.cpp:
              (WebCore::AXObjectCache::postPlatformNotification):
              * accessibility/mac/AXObjectCacheMac.mm:
              (WebCore::AXObjectCache::postPlatformNotification):
              * editing/Editor.cpp:
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83049 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      84799486
    • mrobinson@webkit.org's avatar
      2011-04-06 Martin Robinson <mrobinson@igalia.com> · e3f3befa
      mrobinson@webkit.org authored
              Build fix for debug Cairo builds.
      
              * platform/graphics/cairo/PlatformContextCairo.cpp:
              (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83048 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e3f3befa
    • diegohcg@webkit.org's avatar
      2011-04-06 Diego Gonzalez <diegohcg@webkit.org> · 5c51d01c
      diegohcg@webkit.org authored
          [Qt] Style fix for QtMobileWebStyle.h
          https://bugs.webkit.org/show_bug.cgi?id=57708
      
          Reviewed by Antonio Gomes.
      
          * platform/qt/QtMobileWebStyle.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83047 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5c51d01c
    • abecsi@webkit.org's avatar
      2011-04-06 Andras Becsi <abecsi@webkit.org> · ecbbc938
      abecsi@webkit.org authored
              Reviewed by Darin Adler.
      
              Invalid color #{predefined colorName} is accepted by the CSS parser.
              https://bugs.webkit.org/show_bug.cgi?id=15360
      
              * editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid.
              * fast/css/invalid-predefined-color-expected.txt: Added.
              * fast/css/invalid-predefined-color.html: Added.
              * fast/css/script-tests/invalid-predefined-color.js: Added.
      2011-04-06  Andras Becsi  <abecsi@webkit.org>
      
              Reviewed by Darin Adler.
      
              Invalid color #{predefined colorName} is accepted by the CSS parser.
              https://bugs.webkit.org/show_bug.cgi?id=15360
      
              Test: fast/css/invalid-predefined-color.html
      
              * css/CSSGrammar.y: Remove superfluous hexcolor production.
              * css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83046 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ecbbc938
    • podivilov@chromium.org's avatar
      2011-03-30 Pavel Podivilov <podivilov@chromium.org> · e6ff3143
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              * inspector/debugger/script-formatter-expected.txt: Added.
              * inspector/debugger/script-formatter.html: Added.
              * platform/chromium/test_expectations.txt:
      2011-03-30  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: add test for script formatter worker.
              https://bugs.webkit.org/show_bug.cgi?id=57447
      
              Test: inspector/debugger/script-formatter.html
      
              * GNUmakefile.am:
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83045 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e6ff3143
    • mrobinson@webkit.org's avatar
      2011-04-06 Martin Robinson <mrobinson@igalia.com> · 4b82bf95
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Cairo] Hide the details of image masking in PlatformContextCairo
              https://bugs.webkit.org/show_bug.cgi?id=57878
      
              No new tests. This is just a refactor.
      
              * platform/graphics/GraphicsContext.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to
              do the actual cairo_save. Remove information about image masking.
              (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to
              do the actual cairo_restore. Remove information about image masking.
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
              * platform/graphics/cairo/PlatformContextCairo.cpp:
              (WebCore::PlatformContextCairo::restore): Added.
              (WebCore::PlatformContextCairo::save): Added.
              (WebCore::PlatformContextCairo::pushImageMask): Added.
              * platform/graphics/cairo/PlatformContextCairo.h:
              (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h.
              (WebCore::ImageMaskInformation::isValid): Ditto.
              (WebCore::ImageMaskInformation::maskSurface): Ditto.
              (WebCore::ImageMaskInformation::maskRect): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83044 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4b82bf95
    • diegohcg@webkit.org's avatar
      2011-04-02 Diego Gonzalez <diegohcg@webkit.org> · 969cac2f
      diegohcg@webkit.org authored
          [Qt] Radio buttons are showing wrong with mobile theme
          https://bugs.webkit.org/show_bug.cgi?id=57706
      
          Reviewed by Csaba Osztrogonác.
      
          * platform/qt/QtMobileWebStyle.cpp:
          (QtMobileWebStyle::drawRadio):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83043 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      969cac2f
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 594bf833
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
              https://bugs.webkit.org/show_bug.cgi?id=57943
      
              * rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83042 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      594bf833
    • diegohcg@webkit.org's avatar
      2011-04-05 Diego Gonzalez <diegohcg@webkit.org> · 02519d78
      diegohcg@webkit.org authored
          Buildfix after r82125.
      
          [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
          https://bugs.webkit.org/show_bug.cgi?id=57087
      
          * platform/qt/QtMobileWebStyle.cpp:
          (QtMobileWebStyle::findChecker):
          (QtMobileWebStyle::findRadio):
          (QtMobileWebStyle::findComboButton):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83041 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      02519d78
    • podivilov@chromium.org's avatar
      2011-04-06 Pavel Podivilov <podivilov@chromium.org> · f30c50df
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
              https://bugs.webkit.org/show_bug.cgi?id=57641
      
              * WebCore.xcodeproj/project.pbxproj:
              * gyp/streamline-inspector-source.sh:
              * inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
              * inspector/inline-javascript-imports.py: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83040 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f30c50df
    • rniwa@webkit.org's avatar
      2011-04-06 Ryosuke Niwa <rniwa@webkit.org> · 51c849b5
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
              because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
      
              r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
              avoiding the tab span.
      
              Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
      
              Test: editing/inserting/insert-paragraph-separator-tab-span.html
      
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
              separator into a paragraph separator.
      2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
              style to the paragraph separator or the text.
      
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83039 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      51c849b5
    • leviw@chromium.org's avatar
      2011-04-06 Levi Weintraub <leviw@chromium.org> · 94333d9d
      leviw@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Add member functions for determining line/paragraph separation to InlineIterator
              https://bugs.webkit.org/show_bug.cgi?id=57938
      
              Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
              InlineIterator, where it makes far more sense for them to be. Also moving
              shouldPreserveNewline to RenderObject and renaming it preservesNewline.
      
              No new tests as this provides no new functionality.
      
              * rendering/InlineIterator.h:
              (WebCore::InlineIterator::atTextParagraphSeparator):
              (WebCore::InlineIterator::atParagraphSeparator):
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::requiresLineBox):
              (WebCore::RenderBlock::findNextLineBreak):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::preservesNewline):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83038 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      94333d9d
    • apavlov@chromium.org's avatar
      2011-04-05 Alexander Pavlov <apavlov@chromium.org> · 92d97879
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Range insertNode function does not update content in the inspector
              https://bugs.webkit.org/show_bug.cgi?id=57829
      
              * inspector/elements/modify-chardata-expected.txt:
              * inspector/elements/modify-chardata.html:
      2011-04-05  Alexander Pavlov  <apavlov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Range insertNode function does not update content in the inspector
              https://bugs.webkit.org/show_bug.cgi?id=57829
      
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
              (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83037 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      92d97879
    • commit-queue@webkit.org's avatar
      2011-04-06 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> · dbfd8d4f
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Improve tests for QWebFrame::url() and related methods
              https://bugs.webkit.org/show_bug.cgi?id=57865
      
              * tests/qwebframe/tst_qwebframe.cpp:
              (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
              (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
              that fails and a load() that fails (for a different URL).
      
              (tst_QWebFrame::setUrlWithFragment_data):
              (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
              the URL in the frame before the test starts.
      
              (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
              the same URL as argument.
      
              (extractBaseUrl):
              (tst_QWebFrame::setUrlThenLoads_data):
              (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
              sequence of set and loads. Those tests are interesting because the properties
              react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
              is used or after the load() is committed and baseUrl() is similar to url() but also depends
              on the contents of the page when it loads.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83036 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dbfd8d4f
    • commit-queue@webkit.org's avatar
      2011-04-06 Nikolas Zimmermann <nzimmermann@rim.com> · 789b210f
      commit-queue@webkit.org authored
              Reviewed by Dirk Schulze.
      
              getComputedTextLength always returns 0 with tspan elements
              https://bugs.webkit.org/show_bug.cgi?id=19814
      
              Add a testcase showing that getComputedTextLength for <tspan> works fine.
      
              * svg/text/tspan-getComputedTextLength-expected.txt: Added.
              * svg/text/tspan-getComputedTextLength.svg: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83035 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      789b210f
    • alex@webkit.org's avatar
      2011-04-06 Alejandro G. Castro <alex@igalia.com> · 70919eb6
      alex@webkit.org authored
              Fix GTK3 compilation after r82962.
      
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::paintToggle):
              (WebCore::renderButton):
              (WebCore::RenderThemeGtk::paintMenuList):
              (WebCore::RenderThemeGtk::paintTextField):
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::paintProgressBar):
              (WebCore::paintSpinArrowButton):
              * platform/gtk/ScrollbarThemeGtk3.cpp:
              (WebCore::ScrollbarThemeGtk::paintTrackBackground):
              (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
              (WebCore::ScrollbarThemeGtk::paintThumb):
              (WebCore::ScrollbarThemeGtk::paintButton):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83034 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      70919eb6
    • caseq@chromium.org's avatar
      2011-04-06 Andrey Kosyakov <caseq@chromium.org> · 702fad24
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] remove inspectedPage.* events
              https://bugs.webkit.org/show_bug.cgi?id=57763
      
              - Removed webInspector.inspectedPage.* events
              - moved onNavigated to webInspector.resources
      
              * inspector/front-end/ExtensionAPI.js:
              (WebInspector.injectedExtensionAPI):
              (WebInspector.injectedExtensionAPI.InspectedWindow):
              * inspector/front-end/ExtensionAPISchema.json:
              * inspector/front-end/ExtensionServer.js:
              (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
              * inspector/front-end/inspector.js:
              (WebInspector.domContentEventFired):
              (WebInspector.loadEventFired):
              (WebInspector.inspectedURLChanged):
      
      2011-04-06  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Extensions API] remove inspectedPage.* events
              https://bugs.webkit.org/show_bug.cgi?id=57763
      
              - Removed webInspector.inspectedPage.* events
              - moved onNavigated to webInspector.resources
      
              * http/tests/inspector/extensions-test.js:
              (initialize_ExtensionsTest.runWhenPageLoads):
              * http/tests/inspector/inspector-test.js:
              (initialize_InspectorTest.InspectorTest.runWhenPageLoads.chainedCallback):
              (initialize_InspectorTest.InspectorTest.runWhenPageLoads):
              * inspector/extensions/extensions-api-expected.txt:
              * inspector/extensions/extensions-events-expected.txt:
              * inspector/extensions/extensions-events.html:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83033 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      702fad24
    • joepeck@webkit.org's avatar
      2011-04-06 Joseph Pecoraro <joepeck@webkit.org> · c3394ad3
      joepeck@webkit.org authored
              Reviewed by Antti Koivisto.
      
              Add <head> to the simpleUserAgentStyleSheet
              https://bugs.webkit.org/show_bug.cgi?id=57915
      
              * css/CSSStyleSelector.cpp:
              (WebCore::elementCanUseSimpleDefaultStyle): add head to the
              simple stylesheet, display:none.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83032 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3394ad3
    • mnaganov@chromium.org's avatar
      2011-04-05 Mikhail Naganov <mnaganov@chromium.org> · 3b5f538c
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
              https://bugs.webkit.org/show_bug.cgi?id=57856
      
              Test: inspector/profiler/detailed-heapshots-summary.html
      
              * inspector/front-end/DataGrid.js:
              (WebInspector.DataGrid):
              * inspector/front-end/DetailedHeapshotGridNodes.js:
              (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
              (WebInspector.HeapSnapshotGridNode.prototype._populate):
              (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
              (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
              (WebInspector.HeapSnapshotGridNode.prototype.sort):
              (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
              * inspector/front-end/DetailedHeapshotView.js:
              (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
              (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
      
      2011-04-05  Mikhail Naganov  <mnaganov@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
              https://bugs.webkit.org/show_bug.cgi?id=57856
      
              * http/tests/inspector/inspector-test.js:
              (initialize_InspectorTest.):
              (initialize_InspectorTest):
              * inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
              * inspector/profiler/detailed-heapshots-summary.html: Added.
              * inspector/profiler/detailed-heapshots-test.js: Added.
              * platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83031 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3b5f538c