- 16 Nov, 2018 40 commits
-
-
Reilly Grant authored
This change adds support for tracking device name changes in the WinRT Bluetooth Low Energy backend. This is done in two ways: * When advertisement packets are received for a known device the "local name" is updated if previous advertisements did not provide one. * BluetoothDeviceWinrt subscribes to the NameChanged event on the IBluetoothLEDevice. This tracks name changes once a connection is established. Bug: 902241 Change-Id: I489fc1b7fb86da3c28fde1ec4459d0c736f27326 Reviewed-on: https://chromium-review.googlesource.com/c/1328222Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608686}
-
Risan authored
source_path like drivefs:// should be ignored in Chrome instead of being published to Android. BUG=b:119122689 TEST=Manual. See that drivefs mount doesn't flown through ARC++ container. Change-Id: I0ff1c8af00ad83c7c968f6d9616353942290dc5d Reviewed-on: https://chromium-review.googlesource.com/c/1333268Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#608685}
-
Antonio Gomes authored
This CL is a follow up of [1], where production code was migrated away from using SigninManager APIs directly, in favor of IdentityManager (//services/identity). This is done as part of the servicification effort. After this CL, the last remaining step will be converting DiceResponseHandler (production code) away from using ProfileOAuth2TokenService directly, blocked of crbug.com/887870. [1] https://crrev.com/c/1318550 BUG=890790 Change-Id: Ifc54410bd7112c1e2fae01d6770ab6afa002481d Reviewed-on: https://chromium-review.googlesource.com/c/1316927 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#608684}
-
David Staessens authored
When decoding a jpeg the generated surface is reused when the video frame size doesn't change. When encoding a jpeg a new surface is created every time. This change enables reusing of surfaces for jpeg encoding. This also fixes a bug that causes the jpeg_encode_accelerator_unittest to always fail in debug, because surfaces are not properly destroyed before creating new ones. TEST=JPEG encode tests on nocturne BUG=905502 Change-Id: I9a6b0b5703813e518a3e82687b289e94745e1c62 Reviewed-on: https://chromium-review.googlesource.com/c/1337130 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608683}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9ee8bf96207..c30f45d3f9c1 git log d9ee8bf96207..c30f45d3f9c1 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 syoussefi@chromium.org Vulkan: Rename PipelineDesc/Cache to Graphics& Created with: gclient setdep -r src/third_party/angle@c30f45d3f9c1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3d8a04fb2eecc0d8f36cad29ea67017474d34d83 Reviewed-on: https://chromium-review.googlesource.com/c/1339321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608682}
-
Mike Frysinger authored
Unlike the other grit tools, these three weren't really checking the command line options that closely. Formalize it a bit so we reject all unknown options and too few/many arguments. Change-Id: Ifdd58be1b723ca8b09d5add0c3dcde7243a07ecc Reviewed-on: https://chromium-review.googlesource.com/c/1338469 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
|fileManagerPrivateNatives.GetEntryURL| fails if it receives a non-native entry, such as VolumeEntry. Previously I've worked around this by unwrapping VolumeEntry on |changeDirectoryEntry| however MyFiles changes is expanding the use of FilesAppEntry types, so this CL refactors the unwrapping to be performed on our custom bindings. Refactor |VolumeEntry.rootEntry| to be more generic to any FilesAppEntry renamed to |getNativeEntry| and added as part of FilesAppEntry interface. Add methods |getDirectory| and |getFile| to VolumeEntry, because after renaming this method is also called and was raising an error. Add a utility that unwraps an entry if necessary. The test below fails without unwrapping the entry before sending to fileManagerPrivate. MyFiles/FilesAppBrowserTest.Test/myFilesFolderRename: *FileManagerJsTest.FilesAppEntryTypes' Test: gtest_filter=' Bug: 873539 Change-Id: I0673ed7a8aaeefcec84ed2fc09fe3555c453ef4d Reviewed-on: https://chromium-review.googlesource.com/c/1338820 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#608680}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1f1482716167..d6eacbfadd07 git log 1f1482716167..d6eacbfadd07 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 saklein@chromium.org archive_hwqual: move to crostestutils Created with: gclient setdep -r src/third_party/chromite@d6eacbfadd07 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1745cb0ecaf5cfffb2d84c187c5db44e400e8b11 Reviewed-on: https://chromium-review.googlesource.com/c/1338871Reviewed-by:
-
Hayato Ito authored
This is a quick fix for tools/gdb/gdbinit so it can be used in Python 3 environment too. I don't think we need to support Python 3 in chromium development environment, however, this is a very small fix so it could be okay. The issue what this CL fixes is: If user's `gdb` embeds Python 3, instead of Python 2, tools/gdb/gdbinit fails as follows: Traceback (most recent call last): File "<string>", line 61, in newobj_handler File "<string>", line 35, in load_libcxx_pretty_printers File "/usr/lib/python3.5/posixpath.py", line 89, in join genericpath._check_arg_types('join', a, *p) File "/usr/lib/python3.5/genericpath.py", line 145, in _check_arg_types raise TypeError("Can't mix strings and bytes in path components") from None TypeError: Can't mix strings and bytes in path components The reason of the failure is that stdout of subprocess is |byte|, instead of |string|, and Python 3 doesn't allow mixing strings and bytes in the following |os.path.join|. We have to convert |byte| to |str| explicitly in Python 3, which is harmless in Python 2. Change-Id: I5e66be86b61f8e715dc0c2165eb7c427b56d648b Reviewed-on: https://chromium-review.googlesource.com/c/1338593Reviewed-by:Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#608678}
-
Makoto Shimazu authored
Previously these tests finish before the worker is started, and TearDownOnMainThread could be called during loading the script. After this CL, each tests waits until the worker is ready to ensure that no task is running on TearDownOnMainThread. Bug: 872742 Change-Id: I5fc33048f852f6c7088f5a971a4a7d4a4ffa410b Reviewed-on: https://chromium-review.googlesource.com/c/1337146Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#608677}
-
Etienne Pierre-Doray authored
base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 903957 Change-Id: Ib6f8a8c38d1de1673f2a465478c8f3aebb920a8a Reviewed-on: https://chromium-review.googlesource.com/c/1338491Reviewed-by:Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#608676}
-
Shawn Gallea authored
Move zcr_remote_shell interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: I4ed019e376e5c374315c6bd5c0dab330588376f5 Reviewed-on: https://chromium-review.googlesource.com/c/1324092 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608675}
-
Fergus Dall authored
This should have been done during https://chromium-review.googlesource.com/c/chromium/src/+/1331094, but better late then never. Bug: 703927 Change-Id: I851619d196968b3697ec56c97b3e24fcb15fb58e Reviewed-on: https://chromium-review.googlesource.com/c/1338819Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#608674}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0e195c5ac007..e0abe42b5a5e Created with: gclient setdep -r src-internal@e0abe42b5a5e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I28b56057d55ad4f88350b39084bef3df0e94b954 Reviewed-on: https://chromium-review.googlesource.com/c/1339320Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608673}
-
Findit authored
This reverts commit 6a1db25d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 608668 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZhMWRiMjVkNmEzZTYzZDE5ZDM1OTFhZjg1OGY2Mzg5ZmUyM2I3ZWUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4452 Sample Failed Step: compile Original change's description: > document: Use ElementCreationOptions in Document.createElement() > > We used (DOMString or Dictionary) type for |option| parameter, > but this CL replaces it with (DOMString or ElementCreationOpitons) > as the spec defined. > > > Bug: 904241 > Change-Id: I9416af83168e7c1f7456ffdbd3141fa97b510706 > Reviewed-on: https://chromium-review.googlesource.com/c/1333094 > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608668} Change-Id: I2e851f9c54e1327f7a0b62446ac8b24c7e7371e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904241 Reviewed-on: https://chromium-review.googlesource.com/c/1339360 Cr-Commit-Position: refs/heads/master@{#608672}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5dd873597e78..95ac6f04a8f7 git log 5dd873597e78..95ac6f04a8f7 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 bashi@chromium.org Append label to trace file name Created with: gclient setdep -r src/third_party/catapult@95ac6f04a8f7 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I7bd056074c424ae365ada8f1b4190751a05eb518 Reviewed-on: https://chromium-review.googlesource.com/c/1338956Reviewed-by:
-
Ben Kelly authored
This CL factors out the reference counting handle code into a new CacheStorageHandleType template. This is a first step towards referencing counting handles for both CacheStorageCache and CacheStorage objects. This CL also has the added benefit of removing a std::map in favor of storing the count directly on the target object itself. Bug: 902488 Change-Id: I75c0d86f57c338d3da1db33da40a893c120a720e Reviewed-on: https://chromium-review.googlesource.com/c/1331847 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608670}
-
Ken Rockot authored
Adds a |flushForTesting()| method to generated interface proxies. This requires use of interface control message bindings, which in turn requires union support. So union support is added here as well. Finally, this also required compiling the interface control message bindings into the mojo_bindings_lite.js binary, so some minimal changes were made to generated JS code to make it compiler-friendly. Net code size increase of about 2kB. Bug: 849993 Change-Id: Id44d2d0e5e85693937f5bcd5419429766d25e062 Reviewed-on: https://chromium-review.googlesource.com/c/1336065 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#608669}
-
Hitoshi Yoshida authored
We used (DOMString or Dictionary) type for |option| parameter, but this CL replaces it with (DOMString or ElementCreationOpitons) as the spec defined. Bug: 904241 Change-Id: I9416af83168e7c1f7456ffdbd3141fa97b510706 Reviewed-on: https://chromium-review.googlesource.com/c/1333094 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#608668}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e5bb81f640a1..dcdb6042002f git log e5bb81f640a1..dcdb6042002f --date=short --no-merges --format='%ad %ae %s' 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8f20452b0219..44994a88c9cc (1 commits) 2018-11-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 666818eacf79..d9ee8bf96207 (4 commits) Created with: gclient setdep -r src/third_party/skia@dcdb6042002f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I0ea81feb51d2ac890d935fb5a0224481a50d9974 Reviewed-on: https://chromium-review.googlesource.com/c/1338870Reviewed-by:
-
Shawn Gallea authored
Move xdg_shell interface out of server.cc This CL only moves code around. Bug: 896710 Test: Built on ChromeOS Change-Id: Idb117f086ffa995661291772b122b261aa869794 Reviewed-on: https://chromium-review.googlesource.com/c/1323901 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
-
Alexey Baskakov authored
We may reuse WebAppDataRetriever for new PendingAppManager implementation. Some subset of WebAppInstallManager will be used instead of BookmarkAppHelper (with a last step implemented in a specific for extensions way) Bug: 901226 Change-Id: I8b803b3c618309efd9452d1ca4f03a476e70575a Reviewed-on: https://chromium-review.googlesource.com/c/1335074Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b37886f4e33a..0e195c5ac007 Created with: gclient setdep -r src-internal@0e195c5ac007 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2b397e9e5bd73cd5099b3f0892a391f4b442bbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1338957Reviewed-by:
-
Austin Eng authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/0d55c88..5b6cbd7 Include suppressions for the following failures: conformance2/textures/misc/copy-texture-image.html On Mac Intel: deqp/functional/gles3/framebufferblit/rect_03.html deqp/functional/gles3/framebufferblit/rect_04.html Bug: 905531, 830046, 658724 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I61d36e9ffab9461ee81cce80f320ab9df095f408 Reviewed-on: https://chromium-review.googlesource.com/c/1335270 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608663}
-
Christopher Lam authored
iOS9 is no longer supported, so we can remove caveats in the style guide. Bug: 905929 Change-Id: I3e50de0ebd1069ac457f8203af4373aa3b32afc2 Reviewed-on: https://chromium-review.googlesource.com/c/1338588 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#608662}
-
Sammie Quon authored
Do not allow to show launcher if overview is still animating. Test: manual Bug: 905527 Change-Id: I1bc188600d038d4f2df20c224910ae10a8b61e59 Reviewed-on: https://chromium-review.googlesource.com/c/1338235Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#608661}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ic232d0ab89fdf87c3692035acdfaa67f5126c4e3 Reviewed-on: https://chromium-review.googlesource.com/c/1338965Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#608660}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d09518789d3f..1f1482716167 git log d09518789d3f..1f1482716167 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 zhuohao@chromium.org rammus: mark paladin as important (not experiment) Created with: gclient setdep -r src/third_party/chromite@1f1482716167 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia45ac33f6792401b9883ec73bee28a1094b6cd9c Reviewed-on: https://chromium-review.googlesource.com/c/1338953Reviewed-by:
-
Andrey Lushnikov authored
Change-Id: I558a3d897a56f3fb05e14a1525c8330199d023ec Reviewed-on: https://chromium-review.googlesource.com/c/1338947Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#608658}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 56f3274d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ida0fc9a4ab609f6bfc5f923ebf0a076d5ef3945e Reviewed-on: https://chromium-review.googlesource.com/c/1338726 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608657}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1a5e3e8c2a99..e5bb81f640a1 git log 1a5e3e8c2a99..e5bb81f640a1 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 reed@google.com remove def of flag -- rely on clients to do that Created with: gclient setdep -r src/third_party/skia@e5bb81f640a1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I4c6e587f6d5ad7669932c737048ee755e64a8220 Reviewed-on: https://chromium-review.googlesource.com/c/1338949Reviewed-by:
-
Kentaro Hara authored
This reverts commit 346efa24. Reason for revert: This broke compositing/video/video-poster.html on WebKit Mac10.13. Maybe we just need to rebaseline? https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20%28retina%29/6654 The trees are burning now, so allow me to be conservative and revert it just in case. Original change's description: > [Regression] Don't squash into content underneath a video tag. > > This works around a hard to fix bug in pre-BGPT Blink compositing > code that involves mismatches between clips in the property trees > and clips in the graphics layers. > > After BGPT launches, this patch can be reverted, and videos > changed to report ShouldClipOverflow() as true on their LayoutBox. > > Bug: 900602 > > Change-Id: I76f5d18f2ecd9a10120d96c4a7898b641b5f557a > Reviewed-on: https://chromium-review.googlesource.com/c/1337289 > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608505} TBR=pdr@chromium.org,chrishtr@chromium.org Change-Id: I0be4eb8f16d9bc5e0f05c02c57f63646ff048ba6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900602 Reviewed-on: https://chromium-review.googlesource.com/c/1338587Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/abd178f66131..b37886f4e33a Created with: gclient setdep -r src-internal@b37886f4e33a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If4b9a7a77fc2e99090403f8f11562eb857344480 Reviewed-on: https://chromium-review.googlesource.com/c/1338950Reviewed-by:
-
Kentaro Hara authored
This reverts commit 56f3274d. Reason for revert: This broke VideoFrameSubmitterTest on Linux ChromiumOS MSan Tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9636 Original change's description: > Reland "Fix video quad rect and surface output rect" > > This is a reland of 1dfd4418 > > Original change's description: > > Fix video quad rect and surface output rect > > > > Video surface output rect didn't take rotation into account so when > > SurfaceAggregator would stretch content to fill bounds, it would end up > > with the wrong scaling factors (squash in one dimension and expand in > > another) since the surface quad's bounds (in the embedder) were rotated. > > > > To work around this (or by accident), VideoFrameResourceProvider was > > passing the rotated size as the quad's rect which doesn't make sense > > intuitively. This also worked by accident with DirectComposition > > overlays because of applying another scaling which would fix the aspect > > ratio again. > > > > This change makes it possible to use the |quad_to_target_transform| as > > is, without having to apply an aspect ratio correcting scaling, and to > > assume that the quad's rect is in the pre-transform space. > > > > Bug: 904035 > > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > > Reviewed-by: enne <enne@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608495} > > TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org > > Bug: 904035 > Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1338418 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608596} TBR=kbr@chromium.org,enne@chromium.org,sunnyps@chromium.org,liberato@chromium.org Change-Id: I55b589ea5325317bc271928d9d2b388bec344174 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904035 Reviewed-on: https://chromium-review.googlesource.com/c/1338586Reviewed-by:
-
Ben Pastene authored
In preparation for their move from chromium.fyi to chromium.fuzz. Bug: 903591 Change-Id: Ia749e03db24092063592e3c26ab09c997eb3d974 Reviewed-on: https://chromium-review.googlesource.com/c/1338565 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608652}
-
Peter Kasting authored
Bug: none Change-Id: I18dab792fec5856e8511fd9d98e3b7234e1edb60 Reviewed-on: https://chromium-review.googlesource.com/c/1338661 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#608651}
-
Yutaka Hirano authored
It's no longer failing. Bug: 870173 Change-Id: Iad2a11e4d91f93fc13b52c0d93de01a84af12b61 Reviewed-on: https://chromium-review.googlesource.com/c/1337222Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608650}
-
David Benjamin authored
This is a reland of https://chromium-review.googlesource.com/c/1324878, but with the suppression added for macOS layout tests too. TLS 1.0 and 1.1 are deprecated. See: https://security.googleblog.com/2018/10/modernizing-transport-security.html https://groups.google.com/a/chromium.org/d/msg/blink-dev/EHSnAn2rucg/oiu0DoQ0CAAJ As part of that deprecation, show a console warning in DevTools and also add a Blink-level UseCounter. (We typically measure things at the connection or request level for network features, but since we're plumbing this in anyway, go ahead and add one.) I mirrored the plumbing and UseCounters for Symantec certificates. TBR=carlosil@chromium.org,kinuko@chromium.org,pfeldman@chromium.org Bug: 896013 Change-Id: I06c93e3ac82f9b07c92193ca75e4c2d8d711d34d Reviewed-on: https://chromium-review.googlesource.com/c/1338559 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#608649}
-
Steve Anton authored
Bug: 874296 Change-Id: I694325a0cc85ad520c18762e34ba05e2204e2c74 Reviewed-on: https://chromium-review.googlesource.com/c/1286902 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#608648}
-
Takashi Toyoshima authored
This is mechanical, but a large change set. As we discussed at a code review in the past, let's rename all CORS related names. Bug: 875759 Change-Id: I1d626f229ac3ddc7a1d83e921449db0d1472af1c Tbr: sky@chromium.org, mkwst@chromium.org, rdevlin.cronin@chromium.org, dalecurtis@chromium.org, mmenke@chromium.org, kinuko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1333018 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#608647}
-
