- 02 Nov, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d5f49275a2e..552f47beb892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerm@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142775,chromium:1143787,chromium:1144711,chromium:897470 Tbr: rogerm@google.com,tommycli@google.com Change-Id: Ibff7044290276fd21b26fdbe13128be87436e358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514701Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823291}
-
Sophie Chang authored
Bug: 1144811,1144812 Change-Id: I3b28456a40e9d553cff5c0ad85532a520fa1d2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512523Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#823290}
-
Etienne Pierre-doray authored
This includes: -Setup.Install.PeakPagefileUsage -Setup.Install.PeakWorkingSetSize -Setup.Install.CumulativeDiskUsage2 Bug: 1053133, 1104997 Change-Id: I9ed442897b9753ed32dc45dcf63194067dff6e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225263 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823289}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604318145-3b01fb5e7b79197c4a7ae82826a66d6b8766a4ea.profdata to chrome-mac-master-1604339911-496ad7cd0b2f151b52bf1dbd6e77aab393c02169.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I03c58c0213727e3de4df20403826ed3b7a45bd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514707Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823288}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I6a8579a21df1f06fac2ac37edc37a0eba8213e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503148 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823287}
-
Robert Kaplow authored
Bug: 1089551 Change-Id: If3701dd617bc8eab76e8e575b31de6ed0566b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511129Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823286}
-
Yashar Dabiran authored
this new metric records the minimum recorded value of Startup.Android.Cold.TimeToFirstContentfulPaint and Browser.PaintPreview.TabbedPlayer.TimeToFirstBitmap. It represents the time it takes for a user to see content. Bug: 1142922 Change-Id: Ic0f6571e3699d042a1a57bfcf9f9f54cba4cdc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500323Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#823285}
-
Michael Hansen authored
The original change was reverted because one of the sha files was actually a png file. This fix changes the contents of that file to an actual sha. Revert is here: https://chromium-review.googlesource.com/c/chromium/src/+/2514420 Original change is here: https://chromium-review.googlesource.com/c/chromium/src/+/2511852 Original change's description: > Removes the "Contacts" title and updates strings in the description > for each visibility mode to match the latest specs. > > Screenshots: > https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png > https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png > https://screenshot.googleplex.com/C48HQVfgouJrhHF.png > > Strings spec: > https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: I487d7d4614e6cfa8971fab3c7e5ee39c552ab4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514178Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#823284}
-
Daniel Rubery authored
The experiment is running on Windows, but the field trial testing config was landed when there were too many configs on Windows. The temporary workaround was to leave Windows out of the platforms. We can now undo that temporary workaround. Change-Id: Ifee05f28112cc8af9c87cc18816b10450f9fae44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512519Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#823283}
-
Francois Doray authored
We did not receive crash reports, so we are confident that the assertion is correct. We can convert it to a DCHECK to avoid the overhead in production. Fixed: 1078387 Change-Id: I5a14f215718cc1d9b12cd04f0e071094a575afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510776 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823282}
-
Eric Orth authored
*Allow empty alias names (indicates that a service does not exist). *Add the "mandatory" service param. Also added an IsCompatible() method to indicate if any listed keys are not handled by the parser. Normally I would consider that level of handling to be higher level than the wire-format stuff the parser should deal with, but the parser is the code that knows what params it can handle. *Also added some extra IP hint validation in the fuzzer while I was poking at it for the other changes. Bug: 1138620 Change-Id: I8172fb5cc9b6ba06d42e6f68c2d11517115f80e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508429Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#823281}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d35d2afddac..11789f5ed0cf 2020-11-02 me@heardanieljames.com Adjust tabindex of network summary links to 0 2020-11-02 aerotwist@chromium.org TypeScriptify CSSShadowEditor.js 2020-11-02 tvanderlippe@chromium.org Typecheck object_ui/CustomPreviewComponent.js with TypeScript 2020-11-02 bmeurer@chromium.org [formatter] Utilize available CPU cores. 2020-11-02 alexrudenko@chromium.org Enable TypeScript for ProfileSidebarTreeElement.js 2020-11-02 alexrudenko@chromium.org Add align-items icons to the styles panel 2020-11-02 aerotwist@chromium.org TypeScriptify IndexedDBViews.js 2020-11-02 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseProtocolService.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic451cc886da11b0c9299f100e4eefc77a3e5b88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514700Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823280}
-
dpapad authored
Previously scrollbars always appeared light, even if a WebUI page was otherwise respecting dark mode. The upcoming FormControlsDarkMode feature allows webpages to specify whether scrollbars should follow the system's theme, by specifying a new <meta name="color-scheme"> tag. Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Iaaea8427a88bdf7cb53559e5fed35d8d59df5ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513686Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#823279}
-
chrome://site-engagementKen Rockot authored
Bug: 1004256 Change-Id: Icf4818cd885e77549f50f01e3553c81034348381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506520 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#823278}
-
Jan Wilken Dörrie authored
This change allows the construction of a dictionary value from flat_map<string, Value>, while keeping unique_ptr<Value> as the mapped type of the underlying storage. This is in line of reducing heap allocations for Value, and simplifies its usage. It is still planned to eventually remove unique_ptr<Value> from the underlying storage as well. Bug: 646113 Change-Id: I3ebe11f11faef77e19a4610aba84c541e5f5b3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505980Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823277}
-
Stephen Sigwart authored
Bug: 1143104 Change-Id: I3a01e6a37b62fdf61f4393edbdf4521aec9fa238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511709Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#823276}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I06a9cfcb1fa781178d15770a26c9ac2fe1a42782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514704Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823275}
-
Fredrik Söderqvist authored
Introduce the SVGListablePropertyBase subclass and move the |owner_list_| member field to it. This facilitates slightly better type-safety for 'listable' property types. Since the most commonly occurring types (SVGLength for example) are also 'listable' this does not constitute any major memory savings, but it will trim off a few bytes (the size of a pointer) here and there. Bug: 1106762 Change-Id: Ia91ba222de07ed22bbde4b1550b565b591ed0041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514151 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#823274}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be169f63..fcca1a51 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I27344c17f5e9c7fa194c91f22bb70d8adadd745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512289Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823273}
-
Dave Tapuska authored
This is the browser side change of removing pepper throttling. Since flash is no longer loaded and the throttling code was specific for flash it can be removed. Renderer side was done in https://chromium-review.googlesource.com/c/chromium/src/+/2508289 BUG=1143755,993189 Change-Id: I8eed030decf312ba7e60874428d817ebf7983220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508430 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#823272}
-
Chait Pinnamaneni authored
Rebaselining test PR: https://chromium-review.googlesource.com/c/chromium/src/+/2504690 Original PR: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403841 Bug: 1137050 Change-Id: I64646db2b2a3980525aeb870dd7655b0a8d29eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510732Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Chait Pinnamaneni <cpinnamaneni@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823271}
-
Francois Doray authored
This CL adds an histogram which counts "pageloads" by type. The total count of this histogram should be equal to the "Total pageloads" on the stability dashboard, and can be used to diagnose changes to this value. In particular, it will be used to diagnose changes to "pageloads" with the "intensive wake up throttling" experiment. Context: https://groups.google.com/a/google.com/g/chrome-catan/c/3OafGFoj8Qc Bug: 1075553 Change-Id: Ib238b73e42b0d460f36b055808b425c5eebf9341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507515 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#823270}
-
Stephen Chenney authored
If there is a selection style but no text-decoration in it, and text decoration in another pseudo style that applies, then it is possible for the style to have text decorations but not the pseudo selection style. Avoid crashing in this case. Also improve selection decoration color by using just the color from the selection style if available. Bug: 1144134 Change-Id: Id09fbaeafcc7bdf187abcf6be5d542004e61a16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513825Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#823269}
-
Michael Thiessen authored
These tests "started" the same Activity instance multiple times, unnecessarily. Bug: 1144769 Change-Id: If64cbd0638a62273e98b6502112c6e7dbbba0de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514742 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823268}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/142cb87f803d..ed8bd0453f73 2020-11-02 jaebaek@google.com Do not use PropagateLineInfoPass and RedundantLineInfoElimPass (#2440) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I31a7b924290fc5579bf3fcbb903f6fe7683bfd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823267}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4307.0-r1 to 88-4296.0-1604316477-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I420b57b0ba773c8b83f9378e4f1f7fc1382cc3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514703Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823266}
-
kylechar authored
The test suite is failing on Win10 FYI x86 Release (NVIDIA) bot since it landed. Add rule to stop it from running there. Bug: 1144751 Change-Id: I69fac186a3eacb8dcd262ba88a0d3e29d927908f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512290 Commit-Queue: kylechar <kylechar@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#823265}
-
Xiaoqian Dai authored
Bug: 1142940 Change-Id: I79d58fcd6ac037b2fec36e33402e45943a644f4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508150 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#823264}
-
Dominique Fauteux-Chapleau authored
This also update tests to switch to ContentAnalysisResponse. Bug: 1103390 Change-Id: I1d4861706efa3750b16b828f49bdc74c4ed359af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510414Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#823263}
-
Friedrich Horschig authored
With https://crrev.com/c/2260639, the paddings weren't distributed evenly anymore (start/end padding) causing misalignments. Additionally, the non-square icon dimensions caused rounding errors increasing that effect. This CL ensures consistent paddings for RTL and LTR mode. Screenshots are in the linked bug. Bug: 1144629 Change-Id: Ied4af63de6d94abb2b6510cfd061a970f8f98da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513600Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#823262}
-
Rayan Kanso authored
Bug: 1138316, 1138317 Change-Id: Ib2ce5f4114643e3e463f413bd01cd0934d00c3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512897 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823261}
-
Mason Freed authored
TBR=chasej@chromium.org Bug: 937746 Change-Id: I002fc4bd42feb6e41dea6b8eefebc6f460f223f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514658Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#823260}
-
Alexandre St-Onge authored
Bug: 662752 Change-Id: I9524e40e3645f11841de4805980d905a5ac25143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500762Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alex St-Onge <alstonge@chromium.org> Cr-Commit-Position: refs/heads/master@{#823259}
-
rajendrant authored
Change-Id: Ifc8c20506e46c1be957bf551325d4bb4fd63678b Fixed: 1142526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514069 Commit-Queue: Robert Ogden <robertogden@chromium.org> Auto-Submit: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#823258}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/98b928fcfad7..dffd20efe95c 2020-11-02 kjlubick@google.com [canvaskit] Add unit tests to wasm_gm_tests 2020-11-02 csmartdalton@google.com Fix Wang's formula for cubics 2020-11-02 johnstiles@google.com Revert "heif: Add AVIF type and AVIF sniffing" 2020-11-02 vigneshv@google.com heif: Add AVIF type and AVIF sniffing 2020-11-02 johnstiles@google.com Split Texture test into separate 1D and 2D tests. 2020-11-02 robertphillips@google.com Add callback to thread-safe cache to resolve vertexData collisions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: bsalomon@google.com Change-Id: Ifd340bf5099bdfaf3a22a6bf1f95044e238ded68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513799Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823257}
-
Titouan Rigoudy authored
This retires ERR_INSECURE_PRIVATE_NETWORK_REQUEST in favor of the same scheme used by regular (non-RFC1918) CORS errors: ERR_FAILED along with a CorsErrorStatus to further explain the error. Fixed: chromium:1141851 Change-Id: Ie8356b63e5139c2bc0352f0e98dc17f90f287238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503510 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823256}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1c4431bb. With Chromium commits locally applied on WPT: 82e2bc96 "Support complex selectors in :not()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: Idf8bcd3e794ac07054e03cb8d74cf38cd3a62718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512603Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823255}
-
Sylvain Defresne authored
Add "arm64" architecture to simulator version of the clang runtime library to support `-target arm64-apple-ios*-simulator` (for Apple Silicon cpu mac). Bug: 1138425 Change-Id: I1f2cf794db72e9413090788ad75906837f38a983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490564 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823254}
-
Olga Gerchikov authored
CL [1] introduced performance regressions in number of benchmarks. The regression is caused by the fact of querying the value of kWheelEventRegions flag. This CL optimizes the querying. Most of the regressions partially or fully reverted. [1]https://chromium-review.googlesource.com/c/chromium/src/+/2419718 Bug: 1140321 Change-Id: Ib0cd7cfbafa0603579459e36853f993d2133a969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490327Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823253}
-
henrika authored
Contains additional changes and improvements proposed after landing by robliao@. Bug: 1133643 Change-Id: Ib05e3878b70fc10fa5255645d4551639e2c96587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514423 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#823252}
-