- 13 Mar, 2020 40 commits
-
-
Chong Gu authored
Fix fuchsia_telemetry_gpu_integration_test DEPS. Add fuchsia_telemetry_gpu_integration_test to gn_isolate_map. Add fuchsia_gpu_telemetry_tests test suite. Bug: 1058255 Change-Id: Iaaccc6d165ebf8e1c928eca032224a11a043fe95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099022Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#750189}
-
Josh Nohle authored
When setting host states, verify both legacy device ID and Instance ID. Bug: 1060859, 951969, 1019206 Change-Id: I8bcc27f4e228a9b1e468f887b91ff640ceb8837e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101733 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#750188}
-
Sylvain Defresne authored
Creating symlinks in src/ can mess with the build because some scripts incorrectly re-invoke `gn gen` as part of the build. Also, it does not make sense to create symlinks in src/ based on a gn variable that can have different value for different build directories. Bug: 1060666, 1061419 Change-Id: I2367aa6436489b77540454da8f7ae17d41c6f9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102649Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#750187}
-
Rune Lillesveen authored
Iframes where the color-scheme of the iframe element and the iframe document's root does not match, will get a backdrop matching the color- scheme of the iframe's root element. Also adjust existing test according to spec change. See: https://github.com/w3c/csswg-drafts/issues/4772 Bug: 1058822 Change-Id: I82fd3cc3c2bbf5b4835b157a7522cb22c459ff20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095112Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#750186}
-
Mark Schillaci authored
This CL continues the Android performance improvements for users that have accessibility features enabled. In this CL we delay the creation of AccessibilityEvents until we are ready/certain they will be sent. In previous work we throttled the amount of events being sent to the system, but we did not modify the creation of those events. This meant we were creating events that were sometimes discarded, or we were creating events before they needed to exist, and both of these negatively impacted performance. We now wait to create an event until immediately before it will be sent to the system. Change-Id: I35bc7f5b21990caa23bc80677823d3a46f9736a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100669 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#750185}
-
David Van Cleve authored
After adding Trust Tokens code to the network service led to a ~15K android binary size increase, we initially added platform-specific ifdefs excluding iOS to avoid a corresponding iOS binary size increase (since the code is the network service side of a new Web Platform feature, it's a no-op on iOS). It turns out iOS binary size is much less severely constrained than Android, and the conditional includes were leading to a bit of implementation complexity, so this change removes the buildflag and makes Trust Tokens code built in the network service on all platforms. R=mmenke Change-Id: I6d61a0711333157cac89a9392693cb6d810d05c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102587 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#750184}
-
Andy Paicu authored
The directive has been behind a flag for a year and we have received no [negative] feedback. Spec: https://w3c.github.io/webappsec-csp/#directive-navigate-to I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EJ4xF_DwZyk Bug: 805886 Change-Id: I746aed4032149b86a5f9974246e2ec35bf8eb356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856100Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#750183}
-
Yuke Liao authored
It's unclear why use_lld was there, but it prevents PGO from working on Mac and iOS because they don't use lld. Bug: 1058979 Change-Id: I0c984db2abe3bc8ff59f068221dd6de1edbf887d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101232Reviewed-by:
-
Mikel Astiz authored
Follow-up to https://crrev.com/c/2079641 which overlooked one calling site, now adopting the same workaround. SupervisedUserNavigationObserver should never be null for supervised profiles but crash reports indicate the opposite. Hence, the null case is handled to avoid a crash, and TODOs are introduced to follow up with the investigation. Change-Id: Ia1797168ff491cc500a5bf925e65f9d83eee8bc9 Bug: 1058914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102527 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#750181}
-
Maxim Kolosovskiy authored
This CL propagates a leaked username to the leak dialog (the password change copy). The copy of the dialog should be able to start a password change flow, therefore the dialog needs to know the username. Bug: 1057608 Change-Id: I66a7e696c28f1c672283e8bee390bcb7ff180436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100976 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#750180}
-
Rahul Arakeri authored
The CL adds new tests for rtl scrollbar manipulations. Bug: 1012590 Change-Id: I70ac4ac73cfb3b41683e56fd13da4b19fbbfb372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071904Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#750179}
-
Jose Lopes authored
This CL has been automatically generated by running the clang tool base_bind_rewriters on media/ and with a build config for Android because a lot of modules in media/ are only compiled for Android and therefore other build configs (e.g., Linux) don't see those modules. This clang tool automatically updates base::Bind calls to match the type expected by the callee. This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 714018 Change-Id: I7715444d131ab42aa754e185bbfe822ad3ce765a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100936 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#750178}
-
behdad authored
The PendingTreeDuration metric corresponds to the sum of a few existing stages of CompositorLatency metrics of: - .Commit - .EndCommitToActivation - .Activation Bug: chromium:1039312 Change-Id: I28c1b0c6d24c8613b988a2dd8082c87142c04106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101236Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#750177}
-
Maxim Kolosovskiy authored
The flag will be used Autofill Assistant to verify the password change flow is triggered by the password manager. Once the proper intent signing is implemented, these changes should be removed (b/151391231). The CL is an extracted part of https://chromium-review.googlesource.com/c/chromium/src/+/2074761 Bug: 1057608 Change-Id: Ib76314ff35c31c328e0df6d7243f1079e74ad774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102567 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Move the implementation into an AppShimHandlerDelegate. Also, while doing a bit cut-and-paste, rename many instances of app_id as a string to app_id as a web_apps::AppId. Bug: 1057501 Change-Id: Ief7177b0df70f842410774c1a68d0f9a4a831929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102068Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#750175}
-
Vladimir Levin authored
This patch is the first refactor patch out of a few that I have planned: - Remove budget functionality which was used for updateRendering, which we do not currently support - Move the logic from StyleAdjuster to DisplayLockContext, so that the values, activation masks, and style adjustments are all in the same place R=chrishtr@chromium.org Change-Id: I508f24312ff83346a72b3e0f98686071d2292ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100713Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#750174}
-
Sadrul Habib Chowdhury authored
The switch to INSTANT from STEP_INTO made the trace-events much less useful. The older trace-events were useful for tracking dropped frames (doc [1]). So replicate the older behaviour of STEP_INTO with some custom code. [1] https://chromium.googlesource.com/chromium/src.git/+/master/docs/speed/debug-janks.md#find-the-jank BUG=1034193 Change-Id: Ifc64e992b11d1eed60f7d40365a3b80ea6b3c8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102075Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#750173}
-
Andrew Grieve authored
This will let GN validate that deps are not missed. Bug: 1054892 Change-Id: Ie69f607847dfe22bc3e0e54ff86fbd339fd226dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102630Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#750172}
-
Mikel Astiz authored
By dropping support for the feature toggle kSyncUSSPasswords, which has been launched for some time now, the legacy SyncableService-based implementation of passwords sync can be deleted. Passwords were the last remaining user of GenericChangeProcessor as well as AsyncDirectoryTypeController, so a lot of code can be trivially deleted, representing the pre-USS codepath. This unlocks further code removal and refactorings in future patches. Change-Id: Iee49a10761fa32ccfe0c7f5ca45f88a365c5390c Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066900Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
George Steel authored
It previously returned the resolved value as produced by ValueForLineHeight (this property is unique in that the computed and resolved values differ even without a layout object). Introduce another serializer ComputedValueForLineHeight which produces the actual computed value. Change-Id: Ic27d9a4fe7c67cbbb577ec4e4efed14a88a846c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101858Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750170}
-
Ewann authored
Removes alert message saying "Start New Download?" if downloads are completed and persistents. Bug: 1059998 Change-Id: Icadffc087a372952c01142814541d74905b156ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100769Reviewed-by:
-
George Steel authored
Replaces previous usage of 2-item CSSValueList in these cases and makes the returned values consistent with those from ParseSingleValue. This does not change the serialization to string or any other web-exposed behavior. Change-Id: Ia52ce4008f79669d898543f3b8a347f53455495a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099241Reviewed-by:
-
Evan Stade authored
Bug: 1060986 Change-Id: Id13245c151a8d40df34d738c441792ec76967f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101350Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#750167}
-
Evan Stade authored
These can be replaced with use of //components APIs. Some removed includes were obsolete (unused). Bug: 1058600 Change-Id: Iffe1dcc78e670b6d3ff4db3ec6aa038a68391214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101233Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#750166}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7f2985f655ea..dba14f0f51b4 git log 7f2985f655ea..dba14f0f51b4 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@dba14f0f51b4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iff015ce88ce5227640d1fe0076b863984b060032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750165}
-
Javier Ernesto Flores Robles authored
Create a feature to experiment with a faster way for getting the first responder. The issue that prevented Chrome to get the first responder via -sendAction might have been fixed in iOS 12. Bug: 816427, 839842 Change-Id: I40d427fef50b1986161279ae834f96e7c10d45b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098665 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#750164}
-
Domenic Denicola authored
Although these tests use content security policy to test that the policy is not applied, they're really about testing what happens when the server does something wrong. Since we'll be adding more tests of that sort for https://crbug.com/1051170 and https://crbug.com/1042036, it makes sense to have a top-level directory for them. This also extends the test to use the new expectedIds test runner feature as an extra check that no policy was applied. Bug: 751996 Change-Id: I5a91eb7f97ed81b65b94fd67b44586e7c8f70e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101351Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750163}
-
Domenic Denicola authored
b0e8436e removed the origin policy virtual test suite. Unfortunately, TestExpectations was disabling the web platform tests under the expectation that they would be run as part of the origin policy virtual test suite. This reenables the web platform tests. It also moves the -expected.txt to their new location. Bug: 751996 Change-Id: I82e902bebf67ce0ba7b7949a3f5c4376bb1d7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101386Reviewed-by:
Domenic Denicola <domenic@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#750162}
-
Danyao Wang authored
Bug: 1050657,1050658 Change-Id: Idf102942cb3d2fddaa2d43e923aa0248bbce3a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095568 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#750161}
-
Marc-Antoine Desroches authored
The Intersects function had an inconsistent behavior. This CL is fixing the issue and adding tests for these cases. Without the fix: RangeF(0,0) contains RangeF(0,0) but they do not Intersects. Also, for these two ranges: r1 = gfx::RangeF(0, 1); r2 = gfx::RangeF(1, 2); r1 does not intersects r2 but r2 does intersect 1. Bug: 1025561 Change-Id: Ica96227b7b0cc2911fb9b37d2afc5f73b1f32195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096997Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#750160}
-
Andy Paicu authored
TBR=sauski@chromium.org Bug: 1061249 Change-Id: Ie6a81405b93d43d5b43a29f98487e22ede76cbc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102529Reviewed-by:
-
David Roger authored
Dice migration is now complete. The only values that are still recorded in this histogram are equivalent to the Signin.SigninAllowed histogram. This CL removes the recording code and deprecates the histogram. Fixed: 1059814 Change-Id: I382dbe1be6565dd5c87572b6c982138ba0bbc80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101011Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#750158}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61405b417ec9..5a115a24bfd7 Created with: gclient setdep -r src-internal@5a115a24bfd7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Icf58f4406888e8e087bc65f6e06babf47013401c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102361Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750157}
-
Daniel Cheng authored
This is a reland of f5fbaedd Original change's description: > Use base hooks to broker shared memory creation in sandboxed processes. > > Bug: 876525 > > Change-Id: Iaf48cc3a00390a72eff0730d0945e0a5838f01bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081573 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748826} Bug: 876525 Tbr: sky@chromium.org Change-Id: I8f59cea33ff6a513eb4f105aa0c50b0791d7d6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101829Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#750156}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3df19adcc342..c9ba12998fd2 git log 3df19adcc342..c9ba12998fd2 --date=short --first-parent --format='%ad %ae %s' 2020-03-13 treehugger-gerrit@google.com Merge "tp: add API for decompressing compressed trace packets" Created with: gclient setdep -r src/third_party/perfetto@c9ba12998fd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifa73acd51c67d683c8e4423143025ed2b9ac8a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102359Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie19df8672b713721b4c8c4c93f1756800f151a83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102467Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#750154}
-
Kei Nakashima authored
Implemented two functions, |NewLinkedHashSet::PrependOrMoveToFirst| and |AppendOrMoveToLast|. Also added those tests. Change-Id: I4a682ff79541a56cf245be27d4b21b9028eefe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100409 Auto-Submit: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kei Nakashima <keinakashima@google.com> Cr-Commit-Position: refs/heads/master@{#750153}
-
Richard Knoll authored
One of the flaky test results showed a data race after accessing the default StoragePartition. This CL now waits for tasks to finish before exiting tests that go through the image handling. Bug: 1060869 Change-Id: I62abc87d30e9262dca3a4d1b5fc4cb2914311949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100857 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#750152}
-
Paul Lewis authored
There have been a number of flakes in these tests (and more besides). In this particular case, though, the tests are suspected to fail because of a race condition where the showView Promise resolves sometimes, and not in others. This CL adds the appropriate awaits. Bug: 1046784 Change-Id: Ic24b0a1aad629d2a45899922af192e79a6c1dd24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095010Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#750151}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85037bca98cc..86eb5d9703db git log 85037bca98cc..86eb5d9703db --date=short --first-parent --format='%ad %ae %s' 2020-03-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 62bf27ac..3874769f (749837:750095) Created with: gclient setdep -r src/third_party/webrtc@86eb5d9703db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I49fa73b77d275822598b1e9f3d5586a94c6365e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102362Reviewed-by:
-
