GitLab

R=pkasting@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150051 0039d316-1c4b-4281-b951-d872f2087c98

This cl introduces a regression test for bug 138745, in which the
ftp_protocol_handler did not correctly return errors on requests with invalid
ports.

This bug was fixed in
http://codereview.chromium.org/10834053/

BUG=http://code.google.com/p/chromium/issues/detail?id=138735


Review URL: https://chromiumcodereview.appspot.com/10844004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150050 0039d316-1c4b-4281-b951-d872f2087c98

While registering the attached device path as file system, set the media
device name as file system name.

BUG=none
TEST=none
TBR=gbillock@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150046 0039d316-1c4b-4281-b951-d872f2087c98

Change 143421 - Revert 142809 to re-enable Chrome to Mobile by default on trunk (after M21 branch).

Change 142809 - Revert 135840 to disable Chrome to Mobile by default on trunk (for M21 branch).

Change 135840 - Revert 135442 to re-enable Chrome to Mobile by default on trunk.
We passed the M20 branch point with Chrome to Mobile disabled, as intended.

Change 135442 - Disable Chrome To Mobile by default; enable via chrome://flags.
This feature should be disabled-by-default on M19; for immediate merge.

Don't revert http://crrev.com/130312 to keep the AboutFlags_disable-chrome-to-mobile UMA bin.
Note: Mac's ViewIDTests don't yet support VIEW_ID_CHROME_TO_MOBILE_BUTTON.

BUG=102709, 120905
TEST=Chrome To Mobile is disabled on trunk (for the M22 branch point).
TBR=msw@chromium.org,sky@chromium.org,nyquist@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150041 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://wkb.urg/93186
TBR=tony

Review URL: https://chromiumcodereview.appspot.com/10852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150037 0039d316-1c4b-4281-b951-d872f2087c98

R=atwilson@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10831155

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150036 0039d316-1c4b-4281-b951-d872f2087c98

It appears that the crash occurs when the V8ValueConverter is passed an object
that has a named callback (v8::Object::HasRealNamedCallbackProperty()) that
is an internal property (something that is not defined in JS, but intercepted by
the c++ side).

Something like a DOM input element is a good example of this.
The crash doesn't happen with every object that has internal properties and
named callbacks, but so far I am unable to figure out how to programatically
differentiate between the ones that will crash and the ones that won't.

My current solution is to not convert any named callback.
BUG=139933


Review URL: https://chromiumcodereview.appspot.com/10837066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150035 0039d316-1c4b-4281-b951-d872f2087c98

The menu item ("Clear Local Cache") is on the menu only when pressing Ctrl key, as discussed at crbug.com/135197.

BUG=135197
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10850038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150034 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83382


Review URL: https://chromiumcodereview.appspot.com/10826153

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150033 0039d316-1c4b-4281-b951-d872f2087c98

TBR=finnur@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10832132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150032 0039d316-1c4b-4281-b951-d872f2087c98

No idea why this doesn't work sometimes. It works for me but
not for others. Maybe which verison of XCode?

BUG=83382


Review URL: https://chromiumcodereview.appspot.com/10826152

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10829184

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150028 0039d316-1c4b-4281-b951-d872f2087c98

This change reduces ~800 lines from gdata_file_system.cc
Along the way move some functions to gdata_util.h, which
are needed for gdata_file_system.cc and gdata_wapi_feed_loader.cc

BUG=138268
TEST=none; just move code around. should not change the behaviors
TBR=ben@chromium.org
for chrome_browser.gypi

Review URL: https://chromiumcodereview.appspot.com/10834170

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150027 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150026 0039d316-1c4b-4281-b951-d872f2087c98

This reinstates r150007, which was reverted in r150009.

TBR=piman@chromium.org
BUG=140412


Review URL: https://chromiumcodereview.appspot.com/10827173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139853,140628
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10831171

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150023 0039d316-1c4b-4281-b951-d872f2087c98

* Add methods InitFromDB and SaveToDB to GDataDirectoryService, along with other helper methods to save/load the directory service from level db instead of from a proto file.
* Add a wrapper class GDataDirectoryServiceDB to hold the level db, with methods Create, Save, Read, Truncate, etc. This object lives on the blocking thread.
* Add CreateDBParams to facilitate creation of GDataDirectoryServiceDB on the blocking thread.
* Add GDataDirectoryService::FromProtoString to create a GDataEntry from a string saved in the db.
* Add unit tests for the db methods.
* Move LoadRootFeedParams to gdata_params. Move typedefs before struct definitions.
* Add a timer to measure the time to restore the filesystem from db or proto. For hugefileman, it's 3000 msec for db, and 2500 for proto, with debug code on a z600. Measurements on device TBD.

BUG=127856
TEST=unit tests, manual tests with hugefileman.
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10800092
Patch from Achuith Bhandarkar <achuith@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=zelidrag

Review URL: https://chromiumcodereview.appspot.com/10823122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150021 0039d316-1c4b-4281-b951-d872f2087c98

2. Fixed another bug in CustomHistogram ranges counting

Review URL: https://chromiumcodereview.appspot.com/10823137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150020 0039d316-1c4b-4281-b951-d872f2087c98

See also http://crbug.com/96032

BUG=124339
TBR=antrim@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10834169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150018 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133766


Review URL: https://chromiumcodereview.appspot.com/10823173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:31955
TEST=Played on linux CrOS build.
Review URL: https://chromiumcodereview.appspot.com/10835028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150016 0039d316-1c4b-4281-b951-d872f2087c98

The chromium compositor code will be imported from WebKit into this directory
soon. Since it's WebKit style, it doesn't currently adhere to all of the clang
style checks. This adds a temporary exemption so we don't spam the heck out of
everyone while we clean things up.

BUG=none
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10853012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150013 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132686
TEST=Visually tested


Review URL: https://chromiumcodereview.appspot.com/10823025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150012 0039d316-1c4b-4281-b951-d872f2087c98

Some configurations almost certainly need 3 (at least for Pepper audio).

BUG=136624

Review URL: https://chromiumcodereview.appspot.com/10837115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150011 0039d316-1c4b-4281-b951-d872f2087c98

This CL does some cleanups and fixes:
- Destroy vaapi buffers after we're done drawing.If we do this before we're done drawing, the memory can be
reclaimed by other threads in the meantime and result in
interesting use-after-free bugs.
- Don't leak buffers when we go through the error path.
- Don't leak buffers when we Reset().
- Fix a small indentation.

BUG=chromium-os:33170,chromium:139755
TEST=by hand

Change-Id: Icd44bd52c5b6c8f32d904ad2980d19a090f01e38


Review URL: https://chromiumcodereview.appspot.com/10843058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150010 0039d316-1c4b-4281-b951-d872f2087c98

Revert 150007 - Only dlopen() OMX/VAAPI libs in the GPU process, and only lazily dlsym() their symbols.

Broke several cros bots:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28daisy%29/builds/1752/steps/cbuildbot/logs/stdio
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28tegra2%29/builds/8653/steps/cbuildbot/logs/stdio
http://build.chromium.org/p/chromium.memory/builders/Chromium%20OS%20ASAN%20Builder/builds/1212/steps/compile/logs/stdio
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/38398/steps/compile/logs/stdio

BUG=140412


Review URL: https://chromiumcodereview.appspot.com/10829182

TBR=fischman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10836098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150009 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/10805002/.

BUG=137087


Review URL: https://chromiumcodereview.appspot.com/10828158

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150008 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140412


Review URL: https://chromiumcodereview.appspot.com/10829182

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150007 0039d316-1c4b-4281-b951-d872f2087c98

With this change, all branding happens to the props file which is read
by the signing script.

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10825193

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150006 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133279

Review URL: https://chromiumcodereview.appspot.com/10834081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150005 0039d316-1c4b-4281-b951-d872f2087c98

Add support for suppressing error logging, and don't log errors due to cached host information or client device suspend.

BUG=139389


Review URL: https://chromiumcodereview.appspot.com/10825187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150004 0039d316-1c4b-4281-b951-d872f2087c98

When toggling between different versions of a website by changing user agents,
we often need to reload using an earlier URL in a redirect chain to avoid
redirects caused by user-agent detection.

* Adds a new type of reload that hooks into WebFrame::reloadWithOverrideURL,
added in https://bugs.webkit.org/show_bug.cgi?id=89788

* Changes the original request URL we were saving before to be the URL sent
back as part of WebKit's original request.  This URL often differs from
the URL stored at the beginning at the redirect chain.  It's sent back as
a new field when the renderer navigates.

Part of upstreaming Chrome for Android.
Internal BUG=6272286
BUG=112923

TEST=


Review URL: https://chromiumcodereview.appspot.com/10704048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150003 0039d316-1c4b-4281-b951-d872f2087c98

Since we a) have a PRESUBMIT check for wstring in new code and b) this code isn't used any more.... might as well kill it.

TBR=rsesek@chromium.org
R=mark@chromium.org

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10818016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150002 0039d316-1c4b-4281-b951-d872f2087c98

[sync] Add a polling mechanism to CredentialCacheService for on-the-fly sign in / sign out / reconfigure detection

With sync credential caching on Win 8, if Metro and Desktop are both
running at the same time, and the user signs in / signs out / reconfigures
sync in one mode, the other mode gets updated only after restart.

This patch implements a polling mechanism to enable first-time
auto-sign-in, first time auto-sign-out, and sync setting / credential
reconfigurations without the need for browser restart.

BUG=139200
TEST=Launch clean Desktop and Metro chrome, sign in / sign out / reconfigure one mode, watch for a minute and the other mode should catch up

Review URL: https://chromiumcodereview.appspot.com/10828108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140368
Review URL: https://chromiumcodereview.appspot.com/10823168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149998 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149997 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10836096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149996 0039d316-1c4b-4281-b951-d872f2087c98

Instead of fetching whole drive  search result feed at once, do it incrementally, (max) 100 documents at the time.

This way we get some results sooner (while the rest of the results is being fetched), so search feels more smooth.

BUG=138274
TEST=manual

TBR=darin

Review URL: https://chromiumcodereview.appspot.com/10634020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149995 0039d316-1c4b-4281-b951-d872f2087c98