- 20 May, 2020 40 commits
-
-
Åsa Persson authored
- WebRTC.Video.AdaptChangesPerMinute.Quality - WebRTC.Video.AdaptChangesPerMinute.Cpu - WebRTC.Video.AdaptChangesPerMinute - WebRTC.Video.Encoder.CodecType Bug: 1075637 Change-Id: Ieaeb1532a9108a4ca9b7755e3b1c8a6cf0ed146a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208974Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Åsa Persson <asapersson@chromium.org> Cr-Commit-Position: refs/heads/master@{#770531}
-
Yifan Luo authored
Change-Id: Ic948638ce9641d58fd734fdbc0ec05e031b92fb5 Bug: 1064598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2201217Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: Yifan Luo <lyf@chromium.org> Cr-Commit-Position: refs/heads/master@{#770530}
-
Yoshifumi Inoue authored
This patch changes "extend-selection-bidi.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: If09b8ac1691ce739dd4c0f058eca2850c1660a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209776 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770529}
-
Makoto Shimazu authored
The experiment will be resumed, and this CL is to reflect the latest state of the experiment. Bug: 824858 Change-Id: Id3d31140a623cde26fe8de8436c23406d248bc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208581Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6ae0b83914c0..b3bb9d3aa2c5 2020-05-20 tvanderlippe@chromium.org Fix registerDispatcher types in Closure 2020-05-20 yangguo@chromium.org Seed more owners to front_end directories 2020-05-20 wolfi@chromium.org [Issues] Fix margin for affected resource list 2020-05-20 beaufort.francois@gmail.com Fix nit in releases notes 2020-05-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1072335,chromium:1081686,chromium:1082687,chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2a50e93d32779ccdc3e64eef3243ff7665551da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210218Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770527}
-
Matthias Körber authored
Change-Id: I6113a2bc0b7724c880ca3c686206eac035594de7 Bug: 1084903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209211 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#770526}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1589903980-ca5fa5e99fa1c661edfdfa4ab3f1c52b9013445e.profdata to chrome-win64-master-1589961590-b5238e477e88144b4ee977d3e9b375905cf319c2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: If8a7afcf994cfdf150eda6721146a510e181b769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209326Reviewed-by:
-
Andrew Walbran authored
This is a third-party USB game controller for the Nintendo Switch, but doesn't seem to work with or require the special Switch controller initialisation. Windows and Mac OS use the same mapping but Linux is different for some reason. Change-Id: I889e7fbe84c9e126d73c65e3be88bab3976f3941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203383Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Andrew Walbran <qwandor@google.com> Cr-Commit-Position: refs/heads/master@{#770524}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I836e77c23be591459d5f2769116b1d7e0869e7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210213Reviewed-by:
-
Henrique Ferreiro authored
Change-Id: Iea8ecbca185da46169fb23e1b2ea35a82d6ac626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203198Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#770522}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1589947115-56f4011405e4eeb70dd293d8da98a761636dbc3e.profdata to chrome-mac-master-1589961590-5bcd8ca24d15822b25b9ab44f061677dc2856648.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I59006a54ae8d9ad2d9628994c0be0ff99347bab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209323Reviewed-by:
-
Dominic Battre authored
This CL introduces just a few helper functions to simplify debugging automated autofill tests. Bug: 1079488 Change-Id: I90f3b1f608a8bfb4303eee0ab8830972634440d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209451 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#770520}
-
Zach Trudo authored
PluginVmLicenseValidator ensures that a user has a valid license. File Changes: ~ chrome/browser/chromeos/ | ~ BUILD.gn | | Add PluginVmLicenseValidator to the buildable target. | ~ plugin_vm/ | | + plugin_vm_license_validator.cc/h | | | Create PLuginVmLicenceValidator | | ~ plugin_vm_util.cc/h | | | Include PluginVmLicenseValidator as part of the checks. Change-Id: I4974f0904b43fb8ec40fcd54e9bc89a16e7d2d6c Bug: b/152619375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207942 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770519}
-
Roman Sorokin authored
The function is not used (anymore?). Thus removing it. Also replaced LoginDisplayHostMojo::SetUsers with SetUserCount. As only the number of users used in the class Fixed: 1084533 Change-Id: I301c6a768ca95bacb94882f16c512c8f2e59f674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207385Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#770518}
-
Christian Dullweber authored
Remove some usages of the old third party cookie preference. Observe settings changes though CookieSettings instead of listening to preferences directly. Change-Id: I1f863e391867ce86dbaf2ecb7a53569a20c0e8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2181289 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#770517}
-
tby authored
Bug: 1076270 Change-Id: Ia9c2cac890d0288211e399734f0fae70603bf866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208839 Auto-Submit: Tony Yeoman <tby@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#770516}
-
Omer Katz authored
HTMLVideoElement inherits from both HTMLMediaElement and Supplementable, both of which inherit from GarbageCollectedMixin. HTMLVideoElement should have used USING_GARBAGE_COLLECTED_MIXIN to override GetTraceDescriptor for both parents. Change-Id: Iad6464ef9c0fba7bd113ef14f72a8229b196e9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207466Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#770515}
-
Morten Stenshorne authored
Hook up more tightly with the existing fragmentation machinery, so that we can make better decisions on whether or not to push a float to the next fragmentainer. Said machinery is made to consult and update the fragment builder, but we need to skip that part when it comes to floats, since they establish parallel flows. Update the exclusion space correctly when determining that we need to push a float to the next fragmentainer. The broke_before_float_ flag in the layout algorithm was too simplistic. We need to keep track of whether there'll be left floats and whether there'll be right floats in the next fragmentainer to be aware of, for the sake of clearance. We used to just add the floats to the exclusion space as if they were not going to be pushed to the next fragmentainer, which would affect in-flow formatting context roots (since they are not allowed to overlap with floats). Bug: 829028 Change-Id: I0cc2086b1743cab4a13898a4e29d8b8042bc1103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207161 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#770514}
-
Alex Ilin authored
This CL adds the frontend implementation to a new chrome://signin-reauth webUI page that will be displayed in a tab modal dialog as part of the account password storage opt-in flow. A screenshot of the mock is available at [1]. The signin reauth webUI has the following features: - Static illustration - Gaia avatar picture - Confirm and cancel buttons - Loading spinner [2] after clicking on the confirm button (not implemented) After a click on the confirm button, the dialog should display the Gaia reauth page that is served from the web. The current version omits this second stage and registers an opt-in right after the user clicks the confim button. To test this UI in a modal dialog: - Run Chrome with --enable-features=EnablePasswordsAccountStorage flag - Sign-in to any Google web-site - Do not enable Chrome Sync - Navigate to chrome://settings/passwords - Click on the "Opt-in to account storage" button [1] https://screenshot.googleplex.com/kfy0wxUZ5b2.png [2] https://screenshot.googleplex.com/VA5rVztQwXL.png Bug: 1045515 Change-Id: I5b9f751349a69f26a51cb8ee89c0d13d77f5f2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193667 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#770513}
-
Shakti Sahu authored
This CL adds end-to-end Integration tests for query tiles. The network layer is substituted by a embedded test server that serves a fake server response. Added omnibox javatests that use this mechanism to test the full flow. Bug: 1083807 Change-Id: Ida65dd9e093ce2311def892158c6bbe4de1fe3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206153 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#770512}
-
Alex Ilin authored
This CL contains backend changes in preparation to adding a new chrome://signin-reauth webUI page. This page is going to be displayed in a tab modal dialog as part of the account password storage opt-in flow. This CL puts the reauth webUI page as a replacement for the fake reauth dialog. A proper integration with Gaia Reauth will be implemented in following CLs. This CL should be submitted together with https://crrev.com/c/2193667, which adds a proper frontend implementation of chrome://signin-reauth. Bug: 1045515 Change-Id: I043f8c0bf1a460828e38663537ddef201ea1e1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199146 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#770511}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13322c0999a3..b1bfa636e36a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I8a6aec629c1cda506edc0aca3c0763b6135bf20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210116Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#770510}
-
François Beaufort authored
This CL makes sure the value of whether the PTZ permission is granted is used directly in the ImageCapture constructor to avoid a potential race condition introduced in previous CL. This is done by forwarding this value in multiple calls from getUserMedia in the browser process to the renderer. Change-Id: I5dcbd97e1e1f7533f29fc6309395de884501ecd3 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159211Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#770509}
-
Yoshifumi Inoue authored
This patch changes "execCommand/forward-delete-no-scroll.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ia3f5aa974cffc9665b2074e812304b4ba9d428ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208845 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Victor-Gabriel Savu authored
Add python3 compatibility to policy_testserver.py. Python 2 support is maintained for autotest. TEST=tast run <ip> policy.AllowDinosaurEasterEgg with python 2 and 3 Bug: chromium:1041448 Change-Id: If8e7d5163d9bc753c17f5dae8731f64652810675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206636Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#770507}
-
chrome://settings/manageProfileMonica Basta authored
When 'Allow Chrome sign-in' is turned off, navigating to chrome://settings/manageProfile' by typing it in the omnibox leads to an empty page. The reason for that is a failure assert in |getEditPersonAssocControl_|. |profile-row| is inside a 'dom-if' template with the condition |!shouldShowSyncAccountControl_|. In polymer v3, this function gets called when at least when of its arguments is defined. In the time where the manage profile page is loaded, |syncStatus.syncSystemEnabled| is not defined and |profile-row| is null. This CL ensures that |getEditPersonAssocControl_| is not called before |syncStatus.syncSystemEnabled| gets defined. Bug: 1083879 Change-Id: Iff6a0f3fc0ebd474c2cbf0022a524358c3f2d0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207533Reviewed-by:
-
Victor-Gabriel Savu authored
Make testserver_base compatible with both python 2 and 3. This will allow policy_testserver to be compatible with both python 2 and 3. Bug: chromium:1041448 Change-Id: Id044980918baa69cdb10e26a09b9f601aab7b7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206677Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Victor-Gabriel Savu <vsavu@google.com> Cr-Commit-Position: refs/heads/master@{#770505}
-
François Degros authored
Used vector::push_back() instead of vector::emplace_back() in test code, since there is no type conversion happening here. BUG=None TEST=browser_tests --gtest_filter="*FilesApp*" Change-Id: Ib8ec996d47eeed6b128b9a4bbfe9f8bb898e0790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210077Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#770504}
-
Glen Robertson authored
Add IsPromotableWebApp to avoid using missing data during navigation. Test re-enabled. Bug: 1083215 Change-Id: Id7af8c5fd78748df614cbaa0e7ff7f0604e1f536 Fixed: 1083215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206937Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#770503}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7bbbb99d46bc..6ae0b83914c0 2020-05-20 beaufort.francois@gmail.com Add app shortcuts to releases notes for M84 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:955497 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2f7067fd118f4ea87c74e34500ea98c9c84a9baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210120Reviewed-by:
-
Tarun Bansal authored
Record the data use repported by Android sliced by foreground vs. background Chrome state. Also, improve the accuracy of tracking the Chrome's app state (foreground vs. background) as well as the network state (metered vs. not) by checking for the initial values of these states in the constructor. Change-Id: I0544b33483666a332d35a8fc5b41eb4f2ddc0dea Bug: 1084218,1084220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191977 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#770501}
-
Koji Ishii authored
This patch chagnes |AsDisplayItemClient| to return |DisplayItemClient|. This is to prepare for making |NGFragmentItem| not a |DisplayItemClient|. There should be no behavior changes. Bug: 982194 Change-Id: I2361b0c316b3625ee85004b42480ca37e980d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208840 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#770500}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/258d94f61ed1..d45b30b5a554 2020-05-20 rafael.cintron@microsoft.com Enable allowClearForRobustResourceInit for AMD drivers 2020-05-20 m.maiya@samsung.com Vulkan: Acquire a new BufferHelper from the pool based on a threshold If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ia34fc8ac543d6508298f236398a1898547be3172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210054Reviewed-by:
-
Xiaocheng Hu authored
FontDescription may hold negative zero float members. In this case, it compares equal to positive zero, but the hash values are different. This patch converts negative zero to zero before hashing, so that the hash values are the same, and the common assumption that equal values have equal hash is ensured. Bug: 1081017 Change-Id: Ibc02993967d7638a065d045a138e4d966a20b2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2194912Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#770498}
-
Daniel Libby authored
The routed version of SimulateMouseClick and SimulateMouseEvent should be preferred, since it exercises the real codepath taken when handling input (and can target OOPIF). Remove the non-routed implementations and replace existing implementations with the routed version. Also remove a couple of 'Routed' methods that are not currently used. - RouteMouseEvent is the same (now) as SimulateMouseEvent - Taps are not aura specific, so new tests should use SimluateTap* APIs Bug: 708651 Change-Id: Ic1c5f3702a81ec6f65195d03cb08a38efa81ee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200427Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "move-selection-back-line-rtl.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: Ie55dea9237cb667460be97d706a9b838a718a7b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208881 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Glen Robertson authored
Issue was the async origin-history check in daily_metrics_helper. Ensure this has time to complete by flushing the running thread. Bug: 1083813 Change-Id: Iae5fbb1475e1fb6f1cc447fdc4c11a827edb4b1c Fixed: 1083813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208326 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
-
Mason Freed authored
This is part of a multi-CL set that will move all "Web Components v0 only" tests into a separate folder. This will make landing the eventual removal of WCv0 easier, because this entire folder can simply be skipped rather than requiring file-by-file changes. There should not be any tests in this folder that are needed for testing Web Components VERSION 1 features. While this CL does not change any behavior or testing now, care should be taken in reviewing the list of tests, since when WCv0 is removed, all of these tests will be deleted. So any tests being moved here that are required for testing a non-WCv0 feature should *not* be included in this move. This set should only include tests of the (Shadow DOM v0 specific) ::content pseudo element. Bug: 937746 Change-Id: Ib588ddab29730c8356764dc51f71ac97065142c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209565 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#770494}
-
Andy Paicu authored
Bug: 935900 Change-Id: I7409f86b2fa5c53cec7d901cbfad85187463dff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203004Reviewed-by:
-
Tomasz Śniatowski authored
Outputs newer than the stamp must have been modified outside of the build or in another configuration without CallAndWriteDepfileIfStale, and so should not be trusted. CallAndWriteDepfileIfStale records a stamp file with some metadata to avoid re-running a potentially expensive action if the invocation and dependencies did not change. Setting aside the question of why ninja knowledge of the build is not sufficient for that, one issue that can catch people by surprise is if a build output switches from a simple action to one based on CAWDIS, without changing the output filename. The problem can manifest as follows: The pre-CAWDIS build builds just the output. Incrementally switching to a CAWDIS action succeeds. Going back in history to before the change also succeeds to build incrementally. However, going forward again to after CAWDIS change can result in a build break or miscompile. Ninja correctly tries to re-run the action, but CAWDIS incorrectly treats an old output as up-to-date. That is because the pre-CAWDIS build does not use the stamp file, and so does not touch it at all when rebuilding the real action output. A stale stamp file, one that does not correspond to the output, can remain in the build directory. The post-CAWDIS action then sees the old stamp file, sees that the checksums match, and assumed the output next to the stamp file is therefore up to date. This is not theoretical: bisecting across https://crrev.com/c/2110431 and building Chromium for android can trigger a build break around lib.java/base/jni_java.interface.jar because interface jars switched to a CAWDIS turbine.py helper. A failure can be seen trying to build c7ac5f96 (a recent master), then 5cbd0735a05c (4068 branch), and then c7ac5f96 again (which will try to use a stale jar). The issue can be mitigated if we assume that whenever an output file is newer than the stamp file, it is stale and the whole action needs to be re-run. This should be a sane assumption, because CAWDIS always runs the actual build action first, and then records the depfile. The stamp should always therefore have mtime greater or equal to that of any outputs, unless the build outputs were modified outside the build or outside a CAWDIS action. That should trigger the action again. Change-Id: I62196a9428ebc075c613c8b91b313f67ad31944d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204775Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#770492}
-
