GitLab

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 874080
Change-Id: I2d289daff2684837a6be032e5ca1e5acf37ad3cf
Reviewed-on: https://chromium-review.googlesource.com/c/1194105
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600392}

https://webrtc.googlesource.com/src.git/+log/4744e5b896a5..5a464d3ee56a


git log 4744e5b896a5..5a464d3ee56a --date=short --no-merges --format='%ad %ae %s'
2018-10-17 danilchap@webrtc.org Add resolution to generic frame descriptor extension


Created with:
  gclient setdep -r src/third_party/webrtc@5a464d3ee56a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I289152f6b317197a530715de3ffab0fccb01a998
Reviewed-on: https://chromium-review.googlesource.com/c/1286215Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600391}

This resolves a 7-year-old TODO in sync_prefs.h :)

Bug: none
Change-Id: I5d337ee116e8fbce60758b0c23fdd70be19a8d60
Reviewed-on: https://chromium-review.googlesource.com/c/1286417
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600390}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4e423c45bcbb..15255d3e71b1


Created with:
  gclient setdep -r src-internal@15255d3e71b1

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ife15752f95e14928fce33366231a228f4616fa85
Reviewed-on: https://chromium-review.googlesource.com/c/1286691Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600389}

This is a reland of 530a1ad5

The CL was reverted by the sheriff with
https://chromium-review.googlesource.com/c/1286465
but this resulted in even more failures

TBR=fmalita@chromium.org,brianosman@google.com,mtklein@chromium.org
Bug: 896205

Original change's description:
> Stop using color space xform canvas in Skia's picture backed images
>
> Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62
> Reviewed-on: https://chromium-review.googlesource.com/c/1280786
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Brian Osman <brianosman@google.com>
> Cr-Commit-Position: refs/heads/master@{#599979}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Ic5fe8658f90f4688833d567b04d3026929ae55bf
Reviewed-on: https://chromium-review.googlesource.com/c/1286655Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600388}

With OOP-D, we no longer have draw call pressure inducing flushes.
https://crbug.com/c/875319 suggests that there are cases where we
reuse tiles enough in the UI compositor that we never hit the
 unused_resources_.empty() condition in the EvictExpiredResource method.

This CL adds a deadline for the flush, so that we wait at most 1 second.

Bug: 875319
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ifa8d516699be7ae1eff47db01f8be55a0aae92c8
Reviewed-on: https://chromium-review.googlesource.com/c/1284435
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600387}

https://pdfium.googlesource.com/pdfium.git/+log/190645c34266..b01628451a54


git log 190645c34266..b01628451a54 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 thestig@chromium.org Do more selection checks in form fill embedder tests


Created with:
  gclient setdep -r src/third_party/pdfium@b01628451a54

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1ad8dbf11b252ed61c054d5ab51d11cb67e6cfa9
Reviewed-on: https://chromium-review.googlesource.com/c/1286214Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600386}

In QUIC, on server side, when a session is created, only a single version is provided to the connection and received packets with mismatched version will be dropped. Protected by FLAGS_quic_restart_flag_quic_no_server_conn_ver_negotiation.

Merge internal change: 215728318

R=rch@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I3fbc8e96393424539ebdb8996ce6cde422646ddb
Reviewed-on: https://chromium-review.googlesource.com/c/1283831
Commit-Queue: Fan Yang <fayang@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600385}

- Update more scoped enums to use kMaxValue instead of defining a dummy
  COUNT enumerator.
- Update more UMA enumeration histograms to use the two-argument version
  of the macro, which autodeduces the boundary value.
- Use base::UmaHistogram* where appropriate instead of manually
  expanding the corresponding macros.

Bug: 742517, 857134
Change-Id: I0feb837ecb41a780c8d3234e9d2e75c23229a24b
Reviewed-on: https://chromium-review.googlesource.com/c/1283250
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600384}

Move self.showing update from -viewDidAppear to -viewWillAppear.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2be12224f8ac9156f16c87665aa22a84c221bf1d
Reviewed-on: https://chromium-review.googlesource.com/c/1283832Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600383}

Extracting refresh token from iOS seems to require more effort, don't know if it is worth it.

Change-Id: Iff6fd7d1f694785d60d9c5d6fde026a088e2625b
Reviewed-on: https://chromium-review.googlesource.com/c/1257930
Commit-Queue: Valeriya Sinevich <valeriyas@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600382}

If none of the scripts within the set of runnable have initialPrompt
(all of them are empty), then we shouldn't clean the current status message.

Usually in the chain of Scripts that form an execution path, only the first
Script contains the status message. Next scripts don't, and the
assumption is that the previous status message should stay as long as it is
not explicitly changed by next tell action.

Bug: 806868
Change-Id: I4431c2b33db83ec3bdbc2f8fb71096cc8b4a3149
Reviewed-on: https://chromium-review.googlesource.com/c/1283610Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Lukasz Suder <lsuder@google.com>
Cr-Commit-Position: refs/heads/master@{#600381}

Decrease scheduler flakes of layout tests which can incorrectly infer
console message line numbers depending on execution scheduling. Do this
by ignoring line numbers of console messages which do not have an
associated discovered source file.

Bug: 894792
Bug: 894795
Bug: 896194
Change-Id: Ic8565ba7ac4a2e036f9d333c319544efdc8a3601
Reviewed-on: https://chromium-review.googlesource.com/c/1283037
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600380}

https://skia.googlesource.com/skia.git/+log/483536c242f3..0b8fcbcfa3d5


git log 483536c242f3..0b8fcbcfa3d5 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 scroggo@google.com Add fuzzers for SkAndroidCodec & incrementalDecode


Created with:
  gclient setdep -r src/third_party/skia@0b8fcbcfa3d5

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: Idc0680878c5771580534f0c80d151f2e7327cbe9
Reviewed-on: https://chromium-review.googlesource.com/c/1286629Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600379}

Bug: 885099
Change-Id: I3685726603ae9ba050d1316d227a0a8f77d3e3cc
Reviewed-on: https://chromium-review.googlesource.com/c/1283257
Commit-Queue: Anna Malova <amalova@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600378}

This behavior was accidentally lost when onion souping and caused a
memory leak.

Bug: 891018, 787281
Change-Id: Ib41155660b72548582f809e75c7ca3c596234b65
Reviewed-on: https://chromium-review.googlesource.com/c/1284391Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600377}

This reverts commit 6f65bd26.

Reason for revert: Speculative revert
Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
on Linux ChromiumOS MSan

Note: resolved conflicts with ES6 refactoring, therefore running tests...

Bug: 896219

Original change's description:
> Files app: Select My files when there are no volumes
>
> Make Files app select "My files" when there are no available volumes,
> this to allow Files app to behave properly when volumes subsequently
> become available.
>
> Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> non-null |displayRoot| before trying to change to |displayRoot|. This
> fixes the error "Cannot read property 'getParent' of null" when Drive
> volume becomes available before the (default) Downloads volume/root.
>
> Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> DriveFsTestVolume can re-mount itself.
>
> Changes since revert:
> 1. Add a new function |getVolumesCount| to return the number of volumes
> available in the background page.
> 2. Add the new function above to wait for background page to have all
> volumes before un-mounting and wait it to unmount all volumes.
> 3. Change some logs from error to warn because errors are expected and
> handled when initializing volumes that are unmounting/unmounted in the
> backend.
> 4. Change selector used to click on Drive to actually wait for
> "My Drive" to be available.
> 5. A bit of more info in some logs around volume initialization.
>
> Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> Bug: 893161, 884967, 894799
> Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600282}

TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org

Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
Bug: 893161, 884967, 894799
Reviewed-on: https://chromium-review.googlesource.com/c/1286146
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600376}

liblcang 6.0 chokes on -march=armv7-a with a message
"ClangParseError: Failed to parse the translation unit."
In this CL flag '-march' is filtered off for all arm architectures.

Change-Id: I6d7074c7b337b0a07633d728d0779ec3559652fa
Reviewed-on: https://chromium-review.googlesource.com/c/1278633
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600375}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/deda0b4d..a63809a3

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia9231153a6f3d775bb957c486d1e8441ed47f653
Reviewed-on: https://chromium-review.googlesource.com/c/1286436Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600374}

Let's try adding these from the recipes while we figure out a
better solution.

Tbr: kbr@chromium.org
Bug: 888429
Change-Id: I1a3c8c4a7ba326dbcb2c4c3058a0f3272198ab0d
Reviewed-on: https://chromium-review.googlesource.com/c/1286134Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600373}

It's been way to long since I touched that code. :-(

Bug: NA
Change-Id: Ib56da5e0b1a44782bd5833047cf3824c5b244e43
Reviewed-on: https://chromium-review.googlesource.com/c/1283752Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600372}

Changed "Allow third-party cookies" (default-checked), to "Block third-party cookies"
(default-unchecked) in Android, to match the Desktop option.

"Block..." language was chosen, due to expressing direct intent of the user using
this option.

Link to the slides where this bug was discussed (s6):
https://docs.google.com/presentation/d/1ZFtyGpfeZxCIXPYftwyvB5pnOiGhMJenDX3KbDbyINQ/edit?usp=sharing

Bug:882382

Change-Id: I05339306646e0f50b5cb50628a8fb93465a80f1e
Reviewed-on: https://chromium-review.googlesource.com/c/1238461
Commit-Queue: Kamila Hasanbega <hkamila@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600371}

Bug: 891908
Change-Id: If954e2ea4309578b50d987db8a7ce4db31845057
Reviewed-on: https://chromium-review.googlesource.com/c/1283251Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600370}

bindings: Drop use of V8CallBoolean in generated dictionary code in favor of a lambda that uses v8::MaybeLocal::To.

Bug: 670615
Change-Id: Ib4f1b5674cec44a328b484510b4b197b2afec21d
Reviewed-on: https://chromium-review.googlesource.com/c/1281087
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600369}

This is a reland of 5628afcc

Original change's description:
> Enable the DriveFS experiment in fieldtrial_testing_config.json.
>
> Bug: 819822, 891197
> Change-Id: Ie8daa2f97af0c0eadd4661ea4b28bbaa6a326839
> Reviewed-on: https://chromium-review.googlesource.com/c/1278431
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Sergei Datsenko <dats@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600222}

Bug: 819822, 891197
Tbr: holte@chromium.org, dats@chromium.org
Change-Id: I26be26774dda39607a10b2b2ba243b9d8fe5480d
Reviewed-on: https://chromium-review.googlesource.com/c/1286106Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600368}

ListPrefUpdate is used in this file. It fails to compile with some build
configurations.

Change-Id: Icebb5b6f0ab59d4fad05ce3c1d2b6b64225f77ea
Reviewed-on: https://chromium-review.googlesource.com/c/1286467Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600367}

This CL fixes out of range access, when by some reasons during the
phone parsing, libphonenumber returns that national code is longer that
the parsed string. Probably the reasons are some incorrect treating of
non-ASCII characters.

Bug: 895578
Change-Id: I2f0a7622453191778907a8f54e74e35a1484765b
Reviewed-on: https://chromium-review.googlesource.com/c/1286136
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600366}

The rewrite simplifies the code and serves as preparation for addition
of resizeMode support.
The only behavior change is in tie-breaking among candidates that are
equally good at satisfying constraints.
The new approach uses a single tie braking distance that combines the
ideal value and the allowed range, whereas the old code used separate
distances for allowed ranges and ideal values.

This CL is in preparation for resizeMode support.

Bug: 854980
Change-Id: Ie90d5aa8fe029ca1848bf19c232523bab91beadf
Reviewed-on: https://chromium-review.googlesource.com/c/1277797Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600365}

Bug: 806868
Change-Id: I583c91fbce85ffb0d7a780a2a3adc7c197d59b78
Reviewed-on: https://chromium-review.googlesource.com/c/1283091
Commit-Queue: Lukasz Suder <lsuder@google.com>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600364}

Using wpt-import in Chromium 9ac699ea.
With Chromium commits locally applied on WPT:
612705b6 "Only update intrinsic_content_logical_height_ if we don't have an override height"
a7da8836 "Convert 'Sec-Metadata' dictionary values to identifiers."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26352

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/encoding

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I75559fb7437a083b730714554c5d7d80975011a0
Reviewed-on: https://chromium-review.googlesource.com/c/1286435
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600363}

This limit is a remnant from the old constraints-processing algorithm.
With this change, the minimum aspect ratio will be determined by the
capabilities of the devices.

This CL serves as preparation for support for the resizeMode
constrainable property.

Bug: 854980
Change-Id: Ib67bf57a81a780ee6377b9efb5a93c329fd47216
Reviewed-on: https://chromium-review.googlesource.com/c/1276650Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600362}

Unqualified usage of make_optional causes a compile error if:
 - It's compiler in C++17 mode and <optional> is included.
 - The parameter of make_optional is in std namespace, such as
   std::string.
As std::make_optional is pulled by ADL rule and conflicts to
base::make_optional in this situation.

This CL replaces them with qualified base::make_optional, and
replaces others for consistency.

Change-Id: I2045e9eac0e4466dce266112eab5bf7c8555c2ef
Reviewed-on: https://chromium-review.googlesource.com/c/1282512Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600361}

https://webrtc.googlesource.com/src.git/+log/dbb47b8f7685..4744e5b896a5


git log dbb47b8f7685..4744e5b896a5 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 brandtr@webrtc.org Reland "Remove old video_bitrate_allocator.h"


Created with:
  gclient setdep -r src/third_party/webrtc@4744e5b896a5

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5bc31079f145e13d5bc74b3ff7cf1693c6c3ecc4
Reviewed-on: https://chromium-review.googlesource.com/c/1286474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600360}

This CL handles the scenario of DMServer reporting a 410 status code
(missing/unknown/purged client ID) by trying background
re-registration. If this fails, the user is marked as requiring an
online sign-in.

DD: go/handle-purged-user-sessions

Bug: 870616
Change-Id: I4a4c2370c36f5464752029d755d23221cd064b0e
Reviewed-on: https://chromium-review.googlesource.com/c/1227939
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600359}

InitializeDeprecated should be removed after ToT of ARC-P and ARC-N have
upreved to use new Initialize API.

BUG=867799
TEST=build and deploy chrome on Grunt

Change-Id: I6d2215b9fe735fbb4e1dd4aa179a55187ec908db
Reviewed-on: https://chromium-review.googlesource.com/c/1282518Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600358}

DriveIntegrationService calls Unmount in its implementation of
DriveFsHost::MountObserver::OnMountFailed(). DriveFsHost isn't prepared
for this re-entrancy, causing a use-after-free. Unmount first to avoid
this problem.

Bug: 891197
Change-Id: I61056193847dfdd1dc1ca4c91ccdc80566815744
Reviewed-on: https://chromium-review.googlesource.com/c/1286105Reviewed-by: Sergei Datsenko <dats@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600357}

This CL augments IdentityTestEnvironmentProfileAdaptor with a static
method that creates and returns a TestingProfile that is configured
with the factories that IdentityTestEnvironment requires. This API
can be used to convert unittests that use TestingProfile::Builder. It
is preferable to use this API if possible rather than the lower-level
AppendIdentityTestEnvironmentFactories() as this API is less fragile.
That API is still required for tests that do not create the
TestingProfile internally but simply supply the list of TestingFactories
to configure it (e.g., to some common superclass).

This CL converts one unittest as an example and validation.

Bug: 882865
Change-Id: Ia7cfa648e0086385f4d1506ca4afda80866240b2
Reviewed-on: https://chromium-review.googlesource.com/c/1280764
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600356}

This reverts commit da688ad0.

Reason for revert: test is flaky. See bug for details.

BUG=896198

Original change's description:
> [Feed] Add FeedNewTabPageTest#testClickSuggestion
> 
> + Add test on Feed NTP to simulate click on a test card
> 
> Bug: 860055
> Change-Id: Ibf8f4b1ab46ed34dc77346dd19680df876c2d6aa
> Reviewed-on: https://chromium-review.googlesource.com/c/1260485
> Commit-Queue: Becky Zhou <huayinz@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600166}

TBR=twellington@chromium.org,huayinz@chromium.org

Change-Id: I4db05a0448e12ef2c09d296dc9411dd0c83496a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 860055
Reviewed-on: https://chromium-review.googlesource.com/c/1286650Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600355}

This CL:
- Removes the restriction of frame rates to no less than 1Hz.
  This limit is a remnant from the old constraints processing
  algorithm. There is no reason to keep this restriction,
  especially because applyConstraints did not have any lower limit.
- Use a new minimum frame rate of numeric_limits<float>::min(),
  equivalent to allowing any positive value and enforce it in
  both getUserMedia() and applyConstraints(). Prior to this,
  applyConstraints allowed zero and ideal negative values. Zero
  was interpreted by VideoTrackAdapter to mean the native frame
  rate of the source, and negative values caused a renderer crash
  due to a CHECK in VideoTrackAdapter.

This CL also serves as preparation for support for the frameRate
constrainable property.

Bug: 814131,854980
Change-Id: I7f45fe2862f636100d408a136fe5038fe0994afb
Reviewed-on: https://chromium-review.googlesource.com/c/1276506Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600354}

https://swiftshader.googlesource.com/SwiftShader.git/+log/71e256c..847fc0b

BUG=chromium:881334

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I04a81f1daaa962a3a2510d76784dcb3e0f704e17
Reviewed-on: https://chromium-review.googlesource.com/c/1285480
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600353}