- 29 Jun, 2018 40 commits
-
-
Peter Kasting authored
Bug: 855729, 856667, 846430 Change-Id: Id2c9da22f671c94ffce1995477cab0899217ea2b Reviewed-on: https://chromium-review.googlesource.com/1119538 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571607}
-
Katie D authored
Also refactors a common helper class into test_utils. Bug: 840576 Change-Id: Ia6ca2d6af641864ef1a508f6121f9aa1cd523117 Reviewed-on: https://chromium-review.googlesource.com/1106999 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#571606}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a19649b86b3d..a4dec94a1aa3 git log a19649b86b3d..a4dec94a1aa3 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 iannucci@chromium.org Add download_archive to gitiles module. 2018-06-29 sergiyb@chromium.org Prune VirtualEnv's python from environment before running GN Created with: gclient setdep -r src/third_party/depot_tools@a4dec94a1aa3 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790650,chromium:793687 TBR=agable@chromium.org Change-Id: I5d633dd5be22cb2f5ab1ea4de1d6a9c7332359d2 Reviewed-on: https://chromium-review.googlesource.com/1120946Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571605}
-
Scott Chen authored
Changing tabindex=-1 for a readonly field that is not intended to be focused. Screen-readers can still navigate to it, so it will still read the value if there's any. This essentially turns the input into a <div> that may contain text, except you can drag to the right to see more text if the value is very long and overflows. Bug: 856994 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id210c48c7b63182bd6369d5bc1c87c72742cb193 Reviewed-on: https://chromium-review.googlesource.com/1117310Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571604}
-
Orin Jaworski authored
Omnibox entity suggestions with two lines of text will layout as before, but now if the second line description is absent, the primary content text line will be vertically centered. This CL is identical to 1118788 but with const string moved from anonymous namespace to within function using it. Bug: 856703 Change-Id: Ib3b7127b3bc91b7d1caa175e49da45dc7f299f13 Reviewed-on: https://chromium-review.googlesource.com/1119225Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#571603}
-
Min Qin authored
The newly created in-progress download can get removed by user. In this case, DownloadItem::OnDownloadUpdated() is never called, and DownloadDBCache will never be informed of the removal. This causes DownloadDBCache to store the download info forever. This CL fixes that behavior by allowing DownloadDBCache to listen to all the events once the DownloadItem is created. BUG=842245 Change-Id: I560071a32ec376ae2c6ebe8f72f62a9527bb3362 Reviewed-on: https://chromium-review.googlesource.com/1119504 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571602}
-
Jochen Eisinger authored
BUG=809433,857494 R=blundell@chromium.org,khorimoto@chromium.org Change-Id: I934a03314db1d998eb64adb443d1c2f1eac3cdb3 Reviewed-on: https://chromium-review.googlesource.com/1113180Reviewed-by:
James Hawkins <jhawkins@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571601}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7a29426142dd..deee55b3d522 git log 7a29426142dd..deee55b3d522 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 xz4215@gmail.com Calculate all audio samples in AudioMixerCalculateEnergy. 2018-06-29 kwiberg@webrtc.org Turn rtc::{Make,Wrap}Unique into aliases for their Abseil counterparts 2018-06-29 terelius@webrtc.org Revert "Unit test for case where the number of active and configured spatial" Created with: gclient setdep -r src/third_party/webrtc@deee55b3d522 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd9adc6d6de3e6c4e87fb06067437cb139d922c9 Reviewed-on: https://chromium-review.googlesource.com/1120877Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571600}
-
Fady Samuel authored
This test appears to be running fine locally now. I suspect the hang was caused by the incorrect flag being checked that was fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1119191 Bug: 855920, 672962 Change-Id: Ic9b27c80b3070011e5a06c3ba9153a7d464108e4 Reviewed-on: https://chromium-review.googlesource.com/1120147Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#571599}
-
Stefan Zager authored
BUG=823365 R=skobes@chromium.org,pdr@chromium.org Change-Id: I7b47fe3b3ac33b93c9b1a8fc118b154169d48c3a Reviewed-on: https://chromium-review.googlesource.com/1119770Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#571598}
-
Yi Gu authored
TBR=wez@chromium.org NOTRY=true Bug: 859151 Change-Id: I5ed4767890dc5da367564a393521f24c0fcf3e3c Reviewed-on: https://chromium-review.googlesource.com/1121040Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571597}
-
Stefan Zager authored
Miscellaneous fixes to tests that still used LocalFrameView as a ScrollableArea. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I10e5a2d6c3519a127cb315ffee80d5bfe05dfaca Reviewed-on: https://chromium-review.googlesource.com/1119769Reviewed-by:
-
Bill Orr authored
Devices are converted over to XrRuntime. Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 Reviewed-on: https://chromium-review.googlesource.com/1093386 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#571595}
-
wutao authored
This cl fixes a logic in OnBlur in MdTab. If it is not kHighlight, the focus ring should be cleared. Bug: 858951 Test: manual. Change-Id: I0799ad506ce71e1a77de6be0332523cffad5959d Reviewed-on: https://chromium-review.googlesource.com/1120682Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#571594}
-
Chris Harrelson authored
Not sure why there is no PaintLayer in this case, but harmless to add the check. Bug:856399 Change-Id: Iaecb8e7dcb6b6d2932bae21a4ce428208c8c7653 Reviewed-on: https://chromium-review.googlesource.com/1119636Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571593}
-
Marijn Kruisselbrink authored
SessionStorageContextMojo uses an in-memory database if base::nullopt is passed as path for the DB, but DOMStorageContextWrapper never actually passed nullopt, so we'd still always be writing session storage to disk. Bug: 859010 Change-Id: I3555cf3961adcfe6766fdb46d71699490e01c371 Reviewed-on: https://chromium-review.googlesource.com/1120440 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#571592}
-
Yi Gu authored
This reverts commit b035cfda. Reason for revert: Failing DistillablePageUtilsBrowserTestAlways.TestDelegate on Linux dbg. See crbug.com/859162 for crash log. Original change's description: > Disallow QuitCurrent*Deprecated() on RunLoops with Quit*Closure()s. > > Use of RunLoop::QuitCurrent*Deprecated() is deprecated, and risky, > potentially causing unexpected early-exits if run under a different > RunLoop to the one intended. > > If a caller has taken a Quit*Closure() from the RunLoop then we now > assume that they intend to use it to quit the loop, and therefore use > of QuitCurrent*Deprecated() with it must be unintentional. > > Bug: 844016 > Change-Id: Ib181d0cb34cdba2af29f557646cbe631101bc6b0 > Reviewed-on: https://chromium-review.googlesource.com/1082980 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571499} TBR=wez@chromium.org,gab@chromium.org,thakis@chromium.org Change-Id: Ib5e62d0ae045dd7014d3b546d5970c9dac92edd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844016, 859162 Reviewed-on: https://chromium-review.googlesource.com/1121037Reviewed-by:
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/55f82fcc1297..ae82b696f236 git log 55f82fcc1297..ae82b696f236 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 tsepez@chromium.org Use more UnownedPtr<> in cxfa_ffwidget 2018-06-29 thestig@chromium.org Limit image size in CJBig2_PDDProc. Created with: gclient setdep -r src/third_party/pdfium@ae82b696f236 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:857106 TBR=dsinclair@chromium.org Change-Id: Ia392e59a6839c03500d35c9bc2bf5b9ce6fa7104 Reviewed-on: https://chromium-review.googlesource.com/1120413Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571590}
-
Robbie McElrath authored
This is a reland of 3ebcc06d Original change's description: > Implement and wire in NetworkServiceClient::OnFileUploadRequested. > > This checks ChildProcessSecurityPolicy before opening the requested > files for upload. > > Bug: 845612 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I16538e38bcb0a44acaf8c6dab4342dea8872f81f > Reviewed-on: https://chromium-review.googlesource.com/1098150 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570986} Bug: 845612 Change-Id: I47a0ad37a7e2e219aa68d11e8c3f141029496dc3 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1118786 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#571589}
-
Ryan Sleevi authored
Cronet had an experimental cache serializer/deserializer for certificate verification. However, this API baked into the serialization format internal API assumptions (such as flags' semantic meaning), rather than translating them. To support cleanup of this API (in which the flags will be removed in favor of explicit configuration), remove the serialization/deserialization logic. BUG=590875 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4af8ab8167ab2b7d909dba8d76535b8a584bec4b Reviewed-on: https://chromium-review.googlesource.com/1117036Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrei Kapishnikov <kapishnikov@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#571588}
-
Fredrik Söderquist authored
This reverts commit b56e2510. Reason for revert: Test flaky on cast_shell_linux Original change's description: > Suspend SVG image animations when the page is hidden > > Check Document::hidden() in LayoutObject::WillRenderImage, > thus pausing animations on pages that are not visible. > To resume animations, we may need to explicitly resume the > timeline, so a hook is added in Page::SetVisibilityState to > allow calling StartAnimation() on the relevant SVGImages. > > Bug: 856082 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I4a0b008730ec3e6c2af26e15d52eebb26020ad32 > Reviewed-on: https://chromium-review.googlesource.com/1115130 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#571543} TBR=fs@opera.com,chrishtr@chromium.org Change-Id: I53a07f59bf48095c21ccf6eb357162786012ad1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856082 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1120976Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#571587}
-
Sarah Hu authored
1. Use next_unlock_time as display time in lock screen. 2. Refresh screen time usage based on GetExpectedResetTime 3. Save time related states in kScreenTimeLastState since these are used by the processor. Bug: 823536 Change-Id: I9eae909ac79397cd3d0d61d7b5e85127292f7105 Reviewed-on: https://chromium-review.googlesource.com/1115759Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571586}
-
Matt Menke authored
Bug: none Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I0a15905c1b83db78a9b5dc58e46b19c278a076e2 Reviewed-on: https://chromium-review.googlesource.com/1120348Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#571585}
-
Dominic Mazzoni authored
Recent changes to LUCI and the buildbucket interfaces made the old code stop working. The fixed version seems slightly less brittle at least, it no longer depends on parsing a url from the result of 'git cl try-results' but instead just pieces together fields from it. TBR=aleventhal@chromium.org NOTRY=true Bug: none Change-Id: I44d2908c6a2030d1eede2c772722b0f67b9a6fce Reviewed-on: https://chromium-review.googlesource.com/1120952Reviewed-by:
-
Tiger Oakes authored
Zero-width spaces (https://en.wikipedia.org/wiki/Zero-width_space) have been added to improve usage of supersize on small screens. They hint at where line breaks should be placed when the screen width is too small for the entire text to be shown on one line. These characters are added after ":" (for C symbol names), "#" (for Java symbol names), and "/" (for paths in symbol names or compressed nodes). Before: https://screenshot.googleplex.com/3cmsuPO0A97.png After: https://screenshot.googleplex.com/4Sfsj1RrGRW.png Additionally, as source_paths of files are always unique, I removed the source_paths IndexedSet and store the paths inside the symbol object in the JSON data. Finally, the byte representation in JSON has been truncated 2 digits after the decimal point, which is the max depth used by the UI. If a float is a whole number, it is written as an int instead. (214.0000003 -> 214) (2435.454353 -> 2435.45) (12.0 -> 12) Bug: 847599 Change-Id: Ifc388f19fe0c5402c0093af0d6c1d30bea20bb5e Reviewed-on: https://chromium-review.googlesource.com/1120736 Commit-Queue: Tiger Oakes <tigero@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571583}
-
Nasko Oskov authored
Error page process is locked to origin in practice and it should be more thoroughly enforced by existing tests. This CL adds such additional checks. Bug: 838161 Change-Id: If38845a67f9d1905d37b54e7dc5d53e90bbaabbe Reviewed-on: https://chromium-review.googlesource.com/1120837Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#571582}
-
Jacob Dufault authored
Change-Id: I95210caacd3ec104ddd77410436b4b438f74efaa Reviewed-on: https://chromium-review.googlesource.com/1108546Reviewed-by:
-
Shakti Sahu authored
Provided implementation for DownloadOfflineContentProvider::OpenItem. It will call DownloadItem::OpenDownload and eventually hits ChromeDownloadManagerDelegate. We will also need to pass DownloadOpenSource to this interface later for UMA purposes. Bug: 855727 Change-Id: I86f4f802ab8711ea2162e512e18cbcbf93c1822f Reviewed-on: https://chromium-review.googlesource.com/1114068 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#571580}
-
Ken Rockot authored
This prevents Chrome from attempting to spin up an instance of the download_manager service on non-Android platforms, where it doesn't exist. Stops spam from the service manager regarding the service. Bug: 859111 Change-Id: Ie2eef9d5d8dfa7bf6573fae1768fe7a9f5b61a85 Reviewed-on: https://chromium-review.googlesource.com/1120644 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#571579}
-
Xiangjun Zhang authored
To support the new media remoting UI, for each cast session, permission is checked once at the first time render requests to start remoting. TBR=imcheng@chromium.org Bug: 849020 Change-Id: I0663190707e2fed9ae5cf2392a57c0b79475dd0c Reviewed-on: https://chromium-review.googlesource.com/1099267 Commit-Queue: Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571578}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e33bdbe1d4a1..f028e346c07f git log e33bdbe1d4a1..f028e346c07f --date=short --no-merges --format='%ad %ae %s' 2018-06-29 xixuan@chromium.org chromeos_config: Enable skylab_hwtest for reef. Created with: gclient setdep -r src/third_party/chromite@f028e346c07f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:854862 TBR=chrome-os-gardeners@chromium.org Change-Id: I366e565516ba4e43459db34eab77d73052f65794 Reviewed-on: https://chromium-review.googlesource.com/1120836Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571577}
-
S. Ganesh authored
* This change exposes individual elevator class factories via the Elevator. * A more tenable approach as compared to the former commands-based approach. Design document: Design document link will be added to the linked bug soon. Bug: 833687 Change-Id: Iea4b981c7b4375788c8333a4fe5dc0ac51c1585d Reviewed-on: https://chromium-review.googlesource.com/1106045Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: S. Ganesh <ganesh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571576}
-
Wenzhao Zang authored
A combination of several small fixes: 1) Use the image title as the aria-label of each image. 2) Add role attribute to all buttons. 3) The "Explore" button should be hidden when the url is empty. 4) Enable selecting the entire image collection by using Tab key only (previously user has to use the up and down arrows). Bug: 779449, 857585, 857567 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I36d2a15de494ad4294d67aab15e897d69b9c3faa Reviewed-on: https://chromium-review.googlesource.com/1119645Reviewed-by:
-
Christian Fremerey authored
Fixes an issue where takePhoto would occasionally fail due to a Java object being released too early. In particular, an ImageReader instance is created and its Surface object is held on to and used asynchronously while the ImageReader goes out of scope and may get garbage collected. The fix is to hold on to the ImageReader instance for as long as the Surface may be used. Bug: 846576 Change-Id: Icb0e3b247a1a75af8ce86c44774960c2b036083b Reviewed-on: https://chromium-review.googlesource.com/1117854Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#571574}
-
Sky Malice authored
Also updated DownloadServiceImpl's pending tasks and actions to use OnceClosure and fixed lint errors in modified files. Bug: 714018 Change-Id: I3efdae52913657519dfca2bd1aa7b46aa98ae45d Reviewed-on: https://chromium-review.googlesource.com/1117311Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
-
Nico Weber authored
On most bots, we don't know why the test is disabled. Worst case, we'll find out and redisable it on bots where it doesn't yet work for some reason. On Mac 10.13 and Win 7, we do know why it's disabled, but the Win 7 bug has been fixed, and the 10.13 bug was spurious and I have put in better debug logging if it were to fail again, and I haven't seen any failures in the last 200 builds on the main waterfall. Bug: 846729,813163,843511 Change-Id: Ibd14dea1c5fb72bc4d298b53f55e87be05aa211e Reviewed-on: https://chromium-review.googlesource.com/1120225 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571572}
-
Nico Weber authored
The currently disabled set of tests on that bot is fairly arbitrary. Since the bot is currently red anyway and has been for a while (see 2nd bug), let's run all tests there, and when we get around to greening it up we can then disable suites that turn out to be unamenable to fixing. It likely won't be the suites that are currently disabled. Bug: 843511,851705 Change-Id: Ifabc504fe56ebdbdab32609055cdaf39d8d73d11 Reviewed-on: https://chromium-review.googlesource.com/1120227 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Yi Gu authored
TBR=wez@chromium.org NOTRY=True Bug: 859151 Change-Id: I00ade2e948eab9a7b6d76457cea2659ff0ef0a9b Reviewed-on: https://chromium-review.googlesource.com/1120936Reviewed-by:
-
Mathieu Perreault authored
Bug: 856604 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie75cdf7ccb3743f09632a305fec0bca00a78e19b Reviewed-on: https://chromium-review.googlesource.com/1114687Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#571569}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/1117628 Reverted: crrev.com/c/1118945 The test output just needed to be rebaselined because another change that landed at around the same time eliminated some of the extra table nodes from the AX tree. TBR=aleventhal@chromium.org Bug: 856277 Change-Id: I6c22a0ff4af5322378207253fc260365f0efcbe4 Reviewed-on: https://chromium-review.googlesource.com/1120636Reviewed-by:
-
