- 25 Sep, 2020 40 commits
-
-
Yi Gu authored
The test used to count on base::StatisticsRecorder::FindHistogram() to test the metric is not logged. However, FindHistogram() is static and it may observe values from previous test runs. The proper way should be using ExpectTotalCount(0) [1] which takes this situation into consideration. [1] https://source.chromium.org/chromium/chromium/src/+/master:base/test/metrics/histogram_tester.cc;l=70 Bug: 1132038 Change-Id: I3134c6bccba0670a583e3ec97972a358f68fef9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430123 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#810579}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I08d46bb90a1b958e0e14e9ed9c23cb716313748e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430089Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810578}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f1c8428..c325a422 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2ece51ff6a4d95ff0f62bec56237782eb2b01e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428731Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810577}
-
Maksim Ivanov authored
Change tests in webview_login_browsertest.cc to calculate the expected fingerprint dynamically at runtime, rather than hardcode it as hex strings in the test code. This simplifies the tests maintenance and also makes them more readable, by replacing magic hex blobs with human-readable cert file names. The main purpose of these tests is anyway the login-screen behavior, and not the cert fingerprint calculation, therefore it's presumably not very important to have "golden" data hardcoded in these tests. Bug: 905994 Change-Id: Ie8ee63d6a54087fa77ae64e7c487b19b0c884be9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426705Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#810576}
-
Reda Tawfik authored
1. Sends the origin of current focused field from native to Java. 2. Shows a warning message in a `ModalDialog` when 'Use other password' button is clicked. 3. Adds a controller test for the warning dialog. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1129351#c7 Bug: 1129351, 1104132 Change-Id: I921b679898ac9c0e84dd9310c38d957d3f31e294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416358 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810575}
-
Miguel Casas authored
Encoding for Vaapi has 4 parts: (1) copying the video frame contents, (2) submitting some buffers, (3) executing the encode, and finally (4) downloading the encoded chunk. During crrev.com/c/2344526 I was taking a look at the chrome traces for it and reckoned it'd be good to split out some of them, namely this CL adds more targeted metrics for: - In part 1, for the libyuv copy-conversion that takes the majority of the time. - In part 4, for the SyncSurface (largest part), with a smaller share taken by copying the encoded chunk out. No new functionality intended. Bug: b/166646505 Change-Id: Id0f6dbcb4c119e2692c2fa7ab999100e1cac77b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427069Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#810574}
-
Mikel Astiz authored
These tests experience setup slowness on Mac leading to flakiness, so let's add a few traces to confirm this hypothesis and narrow down the source of the slowness. Bug: 1131588 Change-Id: Idc077fab344c17d64a98cdc4146dd049d37b02f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431026Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810573}
-
Christian Dullweber authored
Bug: 1077766 Change-Id: Ia20915a0be0be09ef6567c9d418b8778f7887437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424291Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810572}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ib94a4fb458f271ab2e4ec9f9d20844c46cbbf175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430204Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810571}
-
Bence Béky authored
Bug: 1113661 Change-Id: Id9f1ed865f308c30b7b3279c0f2f25da81d32754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427062Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810570}
-
Gyuyoung Kim authored
This CL changes all uses of PointerType|HoverType to ui::PointerType|HoverType directly in order to reduce unnecessary type conversions. Additionally this CL fixes the layer violation in //third_party/blink/common by this replacement. It should not have //third_party/blink/public/web dependency. Bug: 1097943 Change-Id: I552e477965bbbbbc7cbcf6ac7300b12767f6115a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430447 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#810569}
-
Jérôme Lebel authored
Set no milestone expiration for force-startup-signin-promo flag. This flag is used to test the startup sign-in promo . Change-Id: Ie0bd4655afd66cb6c1a75220f4ee5bec489e99e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421657Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810568}
-
jchen10 authored
The workaround doesn't actually work as DWM still performs the NV12->RGB conversion indicated from the presentation history. Bug: 1131041, 1079393 Change-Id: I3549a4410af5ba6c6210a4c52511c2708988d00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427152 Commit-Queue: Jie A Chen <jie.a.chen@intel.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#810567}
-
Ulan Degenbaev authored
The result of performance.measureMemory() now includes the memory usage of dedicated workers running in the same site-isolated renderer process. Example entry of the result: { bytes: 1000000, attribution: [], userAgentSpecificTypes: ["DedicatedWorkerGlobalScope","JS"] } The worker URLs are not available in this implementation because it does not go through PerformanceManager in the browser process. Instead, it directly queries V8WorkerMemoryReporter implemented in renderer/controller/performance_manager. Since renderer/core cannot depend on renderer/controller, V8WorkerMemoryReporter is injected during initialization. The upcoming mojo-based implementation will add URLs. Bug: 1085129 Change-Id: I53f34c1136192c9156e2bb74e41327b5a60e0f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421707Reviewed-by:Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Karandeep Bhatia authored
Prevent the extension background page from undergoing a navigation away from its initial url since this effectively makes the extension non-functional. Note this doesn't prevent navigations for which the NavigationThrottles are skipped (e.g. crbug.com/1036603). BUG=1130083 Change-Id: Ieba83f16520d8631662969c07402e0a49c2bce0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419659 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810565}
-
Fredrik Söderqvist authored
Check if the container has a filter effect property (with a reference filter) before ensuring a paint chunk. This both robust against paint-from-prepaint (crbug.com/848056) as well as achieving the goal of the SelfWillPaint() check. This also eliminates the last user of SelfWillPaint() so it and SVGLayoutSupport::HasFilterResource() which it uses can be removed. Bug: 109224, 848056, 1131498 Change-Id: Ic3da600c011d0a48bf562d9fea013e258d436e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424187 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810564}
-
Mikel Astiz authored
This scenario verifies that, if a user ends up with corrupt data consisting of tabs without their corresponding header entity, nevertheless those tabs will eventually be subject to garbage collection. Change-Id: I50cec71a46e02731580b2c1ddb2a448533a0757c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431024 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#810563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I66416d90a4e228cf06bca9903699a2700808536c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430860Reviewed-by:
-
Koji Ishii authored
|CurrentFragment| is known to return |nullptr| if |IsSingleUse|, which is set in multicol, and that it does not recalculate ink overflow at all. This patch fixes |LayoutBlockFlow::RecalcInlineChildrenVisualOverflow| by replacing it with |PhysicalFragments|. Note, all other callers have the same risk, but replacing all of them failed many tests. We need to look into each of them. This fix is required not to regress ~600 tests in `virtual/layout_ng_block_frag` for <crrev.com/c/2428530>. Bug: 1061423, 829028, 1130856, 1128199 Change-Id: I78149f0dde7fe8bcf532fc6a335109b97daef789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428516 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810561}
-
David Bertoni authored
Bug: 1093066 Change-Id: I678072e496d37812aad610fdef4772e7bb5621db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408212Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810560}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I989bed9f38ab5528d92cb9196026d6b2c2b4e544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431104 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1600905490-fdb2e7b3449a423d26d1d15a08c032508e6d13fa.profdata to chrome-mac-master-1601013503-1a040f21faaa1854749ef6dccdae69339bbb905f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic6f1eed11bb093bdcffd1f124867b24e842e2b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430863Reviewed-by:
-
Chong Gu authored
If port is not defined, don't use it when running ssh commands. Bug: 1113300 Change-Id: I14681d2b7576f20bc66362cd37cec8cb1dae5137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417464 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#810557}
-
Ehimare Okoyomon authored
Update the description in order to provide context for translators on how to handle the case with languages with adjective gender agreements. Bug: 1077766 Change-Id: Ib6721105f2192e46167ece437d69822326501b15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428890 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#810556}
-
harrisonsean authored
Cancel reverts to previous state, for unfinished checks, instead of blank state. Bug: 1078782 Change-Id: Ia643389a6e1844d62d22be145b6ddeb9a53d7ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401164 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#810555}
-
Findit authored
This reverts commit adc862b0. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810545 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FkYzg2MmIwOTRjMmQ5MTg5YjE3NWFiM2Q1ZjlkNmJiNDQ1NzNiMTgM Sample Failed Build: https://ci.chromium.org/b/8868191608621476032 Sample Failed Step: compile Original change's description: > [Android] Show signed in account in sync promo > > Sync promo always shows the first account returned by AccountManagerFacade > which might not be signed in. This cl makes sure that the account that > is shown is the first signed in account. > > This cl also refactors some of the tests regrading sync promos. The > behavior of the tests are not changed. > > Bug: 1131465 > Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Reviewed-by: Alice Wang <aliceywang@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810545} Change-Id: I5fc911e9f5175b65d10ff045dfd48103ed08b099 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430974 Cr-Commit-Position: refs/heads/master@{#810554}
-
Renato Silva authored
The marketing opt-in screen does not show an option to subscribe to enterprise and supervised users. Since it does not provide any value and requires the user to click on 'Get Started' there was a request to skip it altogether. Bug: 1128918 Change-Id: Iaf40322824b8d75d738e3f58b9a8cce0316c8349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414228 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600991906-4a92707280f1746bc65f64969bacfc1c677580e0.profdata to chrome-linux-master-1601013503-f7b4ef4ea11cbf75355e6e56711fd1614dd080c3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I3ae3142b139adec7e4ca40820482f86d065f90c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430663Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e11be3c4ad04..d4499bd576da 2020-09-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If9d4abe09c005149a31d2ad5fb367cbb1c8ac45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430353Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f0759378. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc iclelland@chromium.org: external/wpt/feature-policy jsbell@chromium.org: external/wpt/resources lanwei@chromium.org: external/wpt/infrastructure/testdriver/actions nzolghadr@chromium.org: external/wpt/pointerlock NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I568c48ca68952a65c16500d747e4ab973ba04fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429591Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810550}
-
Ehimare Okoyomon authored
Screenshot: https://crbug.com/1077766#c54 Bug: 1077766 Change-Id: I623a2b2e206b5b9471ed11c46af811c7786ba4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428895Reviewed-by:
-
Clemens Arbesser authored
This is done in preparation for an upcoming new UKM where we need to know not just when the UI was shown, but also when the lite script started. I opted to rename the existing callback instead of introducing a new one. This is a refactoring only and should have no user-facing changes. Bug: b/169052568 Change-Id: I44d4033e20a8c7dfd4cca96be5a3c36388c8b1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424319 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#810548}
-
Jan Wilken Dörrie authored
This reverts commit 404b7cc4. Reason for revert: Breaks tests on Win 7 Builder: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/108048 Original change's description: > FontAccess: Sort fonts in lexicographical order > > This change ensures fonts are sorted before being cached. This change is > due to a concern about fingerprinting: > https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 > > This change ensures that fonts are sorted in lexicographical order. > > Bug: 1043306 > Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810519} TBR=jsbell@chromium.org,oyiptong@chromium.org Change-Id: I75926b99ebb7e663875e0eae3d89d877f623a6ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431025Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ic882d1902635a141a73ea1d2248842ef70dc8ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429649Reviewed-by:
-
Tanmoy Mollik authored
Sync promo always shows the first account returned by AccountManagerFacade which might not be signed in. This cl makes sure that the account that is shown is the first signed in account. This cl also refactors some of the tests regrading sync promos. The behavior of the tests are not changed. Bug: 1131465 Change-Id: I46f2e607494c68d3b0608543095da4b22471f710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426485 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#810545}
-
Ravjit Singh Uppal authored
Add metrics that will record - Elapsed time between grant and permission use - Elapsed time between grant and revoke Only for Geolocation, mic and camera permission Bug: 1119738 Change-Id: Ia01cee7921b246844e90d789761f3beebebb98de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367832 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#810544}
-
David Schinazi authored
This CL exists to work around an issue where some users are being configured with an outdated Finch config. It will ensure that we cannot accidentally configure Chrome to use these old obsolete versions. This CL includes an escape-hatch, it will be possible to add the obsolete_versions_allowed flag in Finch in case we want to intentionally enable obsolete versions for some future reason. This CL also applies to cronet, though with the exception that cronet currently allows Q043 as some cronet applications currently rely on it. R=renjietang@chromium.org Change-Id: I275e1797c3cab1e0ddd411520e113cb957365896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429868 Commit-Queue: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#810543}
-
Jit Yao Yap authored
Sync server-side changes from cl/331193690. Change-Id: I52afbafc55b5dc3804034acaaea08a31aa9cfd23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418660 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#810542}
-
Taylor Bergquist authored
Previously, this calculation used LayoutManager::GetAvailableSize, which relied on cached information that was cleared during layout. An extra layout was added to fill this cache, which caused no end of complexities in tabstrip layout. This is totally unnecessary, as all of the siblings of TabStrip are simple fixed-width controls - NTB, grab handle, tab search button, and scroll controls. A wee bit of arithmetic suffices. Bug: 1093972 Change-Id: I7758bd80ba37b31d5efeeafd208e093094ef5e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426978Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810541}
-
Richard Knoll authored
This test passes on local machines that have a real display attached to them but fail on bots without. Disable them for now until we find a way to run them without needing a display. The tests seem to be happy on Linux at least so keeping them for coverage. TBR=peter Bug: 1132058 Change-Id: I0b54d975957c4bc2ff3186a512f04f8f01135768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428899 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810540}
-
