- 02 Jul, 2020 40 commits
-
-
Mikel Astiz authored
A lot of code around SyncedBookmarkTracker can be simplified if Entity::has_final_guid() can be assumed to always return true. This would also unblock further steps to adopt client tags for bookmarks, in particular the adoption of the GUID (or client tag hash) as key in the entity tracker, instead of the currently-used sync ID. The absence of final GUIDs only affects bookmarks that are already being sync-ed, since new remote updates always include this information. Therefore, the missing piece to achieve the desired invariant (all final GUIDs known) is the validation of persisted sync metadata upon startup. This patch introduces the logic to make this validation more strict, behind a feature toggle disabled by default. If the new validation fails, sync metadata for bookmarks will be discarded and all bookmarks will be redownloaded from the server (initial merge). Change-Id: I837587fdce3fa92a96e5cc830edad66b03161904 Bug: 1032052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278250 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#784800}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/60421845f430..ee1b328d6a78 2020-07-02 aerotwist@chromium.org [Watch] Changes autoninja target If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098694 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6c21a816a94f76424fce7adc8699521024550f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279189Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784799}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/cbcc500fa426..45c2272230c0 2020-07-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 7ff733fd65d7 to bda422c594d4 (5 revisions) 2020-07-02 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from dca47063ccd2 to 57002d0447df (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I86917d7e7c8479ba493df841186485d6f675cf75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279173Reviewed-by:
-
Christian Dullweber authored
To display the number of cookies in use, pass this number to observers. Bug: 1077766 Change-Id: I3bea652cccf013e38c88884fb6c7c8adfebb047d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275444 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#784797}
-
Fredrik Söderqvist authored
Cut away the overhead of the CSSComputedStyleDeclaration "wrapper" and and eliminate the "use override computed style" mechanism in favor of just calling the appropriate method directly. This also means that we can remove the override of VirtualEnsureComputedStyle on SVGElement. Bug: 1017723 Change-Id: Iea3dfb024ab2e421e493ab0bdeb9e893dbaa5442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274616Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#784796}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: Ia467310f7afcdfbf2055d8b551eb9ef4df30d5d4 Fixed: 1076786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279194Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784795}
-
Colin Blundell authored
When I changed embedder-initiated navigations to be of type link rather than user typing, I also changed the ExternalNavigationTest case that tested handling of intents initiated via onLoad() in a page that is reached via an embedder-initiated navigation to expect an intent being launched rather than blocked. This makes sense since it is only for navigations initiated by user typing that such intents would be blocked. I should have also changed this test to expect that the visible URL would revert to that of the original URL, since in this case WebLayer eliminates the navigation entry that corresponds to the intent being launched. I neglected to do this and the test itself didn't complain because it wasn't set up to wait long enough for the navigation to the page launching an intent to fully complete, including the elimination of the corresponding navigation entry. There is no production problem here; this is simply a matter of test precision that nator@ uncovered. Change-Id: If1443d202cffd0863af2600094bd46a2663bf2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279200Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#784794}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/57002d0447df..a70f7dea7718 2020-07-02 johnkslang@users.noreply.github.com Merge pull request #2268 from lriki/hlsl-pack_matrix 2020-07-02 johnkslang@users.noreply.github.com Merge pull request #2303 from ben-clayton/limit-public-2 2020-07-02 cepheus@frii.com Bump revision. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Icaaac1021d269b27207e0ec68e41ce5e8168c4fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279182Reviewed-by:
-
Yuki Shiino authored
Implements property installation APIs for V8 context snapshot and also fixes the export declaration. Bug: 839389 Change-Id: I2bc83495960f139f28e134480b9bbe5e8a9acbd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277656Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#784792}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2dc51d54..8c0bb99a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I83cd8c838afa8fab2c820721dd78ec06a847cfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278893Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784791}
-
Miguel Casas authored
This CL changes the switch kEnableUseHDRTransferFunction to a base::FeatureFlag kUseHDRTransferFunction which is more adequate to after-launch, where users will like to see the hdr-ness state as "disabled" "enabled" or "default", as opposed to having a naked flag where the correspondence chrome:flags<->feature status is non-intuitive. This CL also disables kUseHDRTransferFunction with the idea of fixing the current quirks (e.g. b/158777601, b/158781255, b/159224397) and enabling it very soon. This CL also takes the chance to remove the unused entry display::features::kUseMonitorColorSpace. TBR=achuith@chromium.org for chrome_restart_request.cc Bug: 958166, b:159919063 Change-Id: I10e48aee423924cfa7eea7c72d5455f1ffe72648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276516 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#784790}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4d2429b2e74962e0f50026d4d93a42813b44b6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279178Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ied9df0f470c6a55e659d021686e2aefba1402e09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278849Reviewed-by:
-
Mikel Astiz authored
No behavioral changes. Most callers to the former GetMessagesForAvatarSyncError(), now renamed, were not interested in the string IDs returned by the function. The only exception is ProfileMenuView which not only ignored one of the two IDs, but can also infer the second (the button's string) from the returned enum. This avoids API redundancy and aligns better with existing assumptions in ProfileMenuView, such as OnSyncErrorButtonClicked() using the enum to determine what the button's action should be. The side effect is that some strings can be cleaned up. Change-Id: I2c3b47c47e06e0a4a79d3efa3d3ecda498ef489c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278249 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#784787}
-
Mikel Astiz authored
This prevents future bugs if new values are added to the enum, which the compiler would issue errors for. Change-Id: I8c5d8b4052599645370c37f9792d39f0763583e3 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279213 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Matthias Körber authored
Change-Id: Ibaedf7fc5c0cbe6050f8bdb69169d9ac3051ad2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277821 Commit-Queue: Matthias Körber <koerber@google.com> Commit-Queue: Alex Ilin <alexilin@chromium.org> Auto-Submit: Matthias Körber <koerber@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784785}
-
Anastasiia Nikolaienko authored
ArcProvisioningResult enum didn't have a value for CHROME_SERVER_COMMUNICATION_ERROR = 18. Change-Id: I40bac4684814905eba89e9881231410df3430d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277886Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#784784}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2ab19f6c9ced..a5e8178b385e 2020-07-02 primiano@google.com docs: improve docs about SDK releasing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I92d72576efec4c526d458b980c1c4c9f31f6ac0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279174Reviewed-by:
-
alexanderhartl authored
Added the functionality to reply to client_cert_provisioning requests required for certain policies, i.e. RequiredClientCertificateForDevice. A certificate is generated based on the public key recieved from the requestor and a hard coded private key. The certificate is then sent as a reply to the requestor. BUG=None TEST=tast run <ip> policy.RequiredClientCertificateForDevice Change-Id: I88f6bb0b7a0c06cb4984da36e35e29cf2e84b806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267159 Commit-Queue: Alexander Hartl <alexanderhartl@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#784782}
-
Sigurd Schneider authored
DevTools CL: https://crrev.com/c/2277986 Bug: chomium:1011811 Change-Id: Id22525bb005f28576da2796142b2d1728354b5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#784781}
-
Guido Urdaneta authored
This reverts commit 3d22849f. Reason for revert: Suspect of causing failure in Win7 Tests (dbg) bot. Failed test: TwoClientWebAppsBMOSyncTest.SyncDoubleInstallationDifferentUserDisplayMode First failed run: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/83326 Original change's description: > dpwa: Fix IsInstalled() if an app is already in the user's sync library. > > The regression was introduced here: > https://chromium-review.googlesource.com/c/chromium/src/+/2251563/6/chrome/browser/web_applications/web_app_registrar.cc#42 > > The bug is that installing a web app in |is_in_sync_install| state > may take take a long time if the queue is too long. > > The omnibox UI may display (+) icon and mark the web site as > installable even if the web app is already added into user's synced > library. If the user presses (+) button, we enqueue a second install > task which produces a non-locally installed app (i.e. some bad state). > > Bug: 1098309 > Change-Id: Ibdcefaeeee2516921fd562055ac8b613aa336d15 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275512 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784715} TBR=alancutter@chromium.org,loyso@chromium.org Change-Id: I5304c1884b887edb3e2bf4908be6dceb27eb69c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1098309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279195Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784780}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8071998e. With Chromium commits locally applied on WPT: 7a3863e5 "Update bug references in docs and comments: s/891872/1098938/." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I6c1720e93cc37d651a350d17fee46021f15585b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277674Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784779}
-
Anatoliy Potapchuk authored
Since the architecture of data load for Web kiosks have changed, data fetcher is now crated inside the WebKioskAppData and not controlled by WebKioskAppManager directly. Bug: 1015383 Change-Id: Ic786c3c9e48b849355672930446a2e550e2d7229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279116Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#784778}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fcd54f0d797a..60421845f430 2020-07-02 tvanderlippe@chromium.org Implement devtools_entrypoint 2020-07-02 sigurds@chromium.org Type histogram name argument of recordEnumeratedHistogram If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098730,chromium:1098736 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I635437d4eb5678b52efe9408400a5d3b965b4581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279172Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 6cabb581. Reason for revert: Speculative revert to see if it fixes a failure in the win-asan bot. First failure: https://ci.chromium.org/p/chromium/builders/ci/win-asan/13067 Original change's description: > base/synchronization: Always Try() in LockImpl::Lock(). > > The current implementation of base::Lock on Windows and POSIX assumes > that base::LockImpl::Try() performs a kernel call, which is not true on > Linux, macOS and Windows at least, since they all use a variant of "fast > user-space mutexes" (e.g. futex() on Linux). > > Since these calls are cheap (On Android for instance, an external call > to libc and a compare-and-exchange with acquire ordering), do them all > the time. An alternative is to remove the branch altogether, as > base::debug::ScopedLockAcquireActivity checks whether it is enabled as > well. However it still does a non-zero amount of work, so we may as well > avoid it, assuming that locks are mostly uncontended. > > All in all, assuming that the lock is not held and that ActivityTracker > is not enabled, this replaces: > - 2 acquire loads (for the if, and then in ScopedLockAcquireActivity) > - A predictable branch > - A call to to Try() > > with a single call to Try() (as the native lock() call will effectively > try() first). > > Change-Id: Ie77392db4008966b6379eaadb5d20d1ebfcbc276 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270203 > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784736} TBR=wez@chromium.org,bcwhite@chromium.org,brucedawson@chromium.org,lizeb@chromium.org Change-Id: I852b5565512ef12fe8ce324193846c18a2a03aca No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279118Reviewed-by:
-
Alice Wang authored
This CL renames SyncTestRule.setUpTestAccount() to addTestAccount() to make it more consistent with the other method addAccount() in SyncTestRule. Bug: 1094298 Change-Id: Ic5d60a36e05cfdcc33e015af5f5d76f85c299cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279212Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784775}
-
Carlos Caballero authored
Followup patches will migrate code to the new names and header files. Bug: 891670 Change-Id: I35c3aa51236f8d0934d87d699e6298494ded14b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270327 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#784774}
-
Hajime Hoshi authored
Subtarcting the navigation-start time from the first-input-delay time delta value doesn't make sense. This CL fixes this. Bug: 1101295 Change-Id: I31a9b6242e913876a30fc61da986f87023ce384c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279251Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784773}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. Bug: 1007635 Change-Id: Ife1f7b670258542df396807aadf14c6a1a8c70dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277421Reviewed-by:
-
Roman Aleksandrov authored
1) Build Chrome and copy it to the fresh (not activated) device. 2) Login, trigger feedback form (from Setting/About Chrome OS). 3) Put in the form's textfield tag to ease searching. (my tag was #TestFirstSeenDate) 4) Search here https://listnr.corp.google.com/product/208/reports 5) Download and open system_logs.zip from your report. 6) Search for ONBOARDING_TIME in the system_logs.txt. Bug: 1081888 TEST: Tested manually on the Krane device: Change-Id: Ic307de4649a3ad2367dd5b0c5e15e1a90a2c641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247886Reviewed-by:
Greg Levin <glevin@chromium.org> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#784771}
-
Christian Dullweber authored
Fix crash and add test to catch similar issues in the future. Bug: 1100312, 1077766 Change-Id: Ia45d375705d763b30c4a483c797a31c1205fe4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276270Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#784770}
-
Yuki Shiino authored
Allows the empty |instance_object| in context-dependent property installers of IDL interface, and automatically sets it to the global object if the interface is [Global]. Bug: 839389 Change-Id: Ib7c76b4fa63a5e2aa9c370c4fad8ad5272bd0c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275983Reviewed-by:
-
Mark Brand authored
Move away from overloading the enable_ipc_fuzzer flag for mojo fuzzers since the original ipc fuzzer is incompatible with is_component_build, and we would like to be able to build MojoLPM targets with is_component_build for ClusterFuzz. Bug: 1076336 Change-Id: Ib9956b1b060a4bef19ce5dd7d867e0043205408c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249978 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Auto-Submit: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#784768}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I68437aa52f58472a4107233e10e4fb9ae5df578e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279005Reviewed-by:
-
Nidhi Jaju authored
The method GetInstalledRegistrationOrigins() currently uses |registered_origins_| which is initialized on the UI thread in ServiceWorkerContextWrapper, and thus should only be accessed from the UI thread. This means that a task should also be posted to the UI thread. However, the ServiceWorkerStorage also has |registered_origins_| which can be used by calling ServiceWorkerStorage::GetRegisteredOrigins() from ServiceWorkerContextWrapper::GetInstalledRegisteredOrigins() on the Core thread. Hence, this was deemed to a better solution to the problem as this avoids thread hopping. This CL implements this change. Bug: 807440 Change-Id: Ib6d9b2adee7daaf7b3560774caf17295e5d1a707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277689 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784766}
-
Nazerke authored
As a tabmodel was decided to be deprecated, this CL is moving TabUsageRecorderBrowserAgent usage from TabModel. At this stage the tabmodel deprecation is still an on-going work. Bug: 1045575 Change-Id: Ia4910c1c077d8423c7792edfad7c6ddf158c611e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275958Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#784765}
-
Xida Chen authored
This is a code health CL, no behavior change is expected. TBR=benwells@chromium.org Bug: 1007635 Change-Id: I0c19fded2c00aaf597c823ebd1c4867c14e589ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278802 Commit-Queue: Xida Chen <xidachen@chromium.org> Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/509b811a75c2..16ca52cc16ab 2020-07-02 hao.x.li@intel.com Roll third_party/shaderc/ caa519ca5..f4025c1cd (2 commits) 2020-07-01 idanr@google.com Vulkan: Enable robust buffer access if validation is on If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iebd3ff68e732fd0ea8fa2bc0a84057c4a692153a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278939Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5dd8a62dc322..2ab19f6c9ced 2020-07-01 primiano@google.com Add CHANGELOG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4a199557eaa32191a0711fd3366425e843ae572c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279015Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e31c3a2b..2dc51d54 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9a54e0ca2c3d674c99d904ca18228c66134c160b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275748Reviewed-by:
-
