GitLab

BUG=25927
TEST=none

Review URL: http://codereview.chromium.org/334046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30197 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/338038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=18862
TEST=none

Review URL: http://codereview.chromium.org/337030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98

couple of crashes we're getting.

BUG=24132, 13707
TEST=thorougly test tab dragging on windows and make sure there are no
regressions.

Review URL: http://codereview.chromium.org/337013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30193 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that Helvetica, if installed, is used instead of Arial. This should be an effective defense against the Mac fontheads zombie uprising.

BUG=http://crbug.com/21458
TEST=navigate to any HTML-as-UI page (about:credits, etc) on a Mac; ensure Helvetica-ness


Review URL: http://codereview.chromium.org/333032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/21458
TEST=when badging comes to the Mac, make sure it uses Helvetica.

Review URL: http://codereview.chromium.org/328033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30189 0039d316-1c4b-4281-b951-d872f2087c98

of versioned directory awesomeness.
Review URL: http://codereview.chromium.org/334040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/data-race-test/issues/detail?id=11
TEST=net_unittests should become green on TSAN Mac bot
TBR=dank
Review URL: http://codereview.chromium.org/339025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30187 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30186 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/338036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30185 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/339007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25917
TBR=dank
Review URL: http://codereview.chromium.org/339023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24715
TBR=dank
Review URL: http://codereview.chromium.org/339022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30182 0039d316-1c4b-4281-b951-d872f2087c98

This race was already suppressed, but the existing suppression doesn't
work if the order of accesses is different. We can prepare a suppression to make TSAN bots silent
but it will be way too wide. I think adding one line of annotation with comment (twice) is better in terms of precision.
BUG=25841
Review URL: http://codereview.chromium.org/339008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25915
TBR=dank
Review URL: http://codereview.chromium.org/340001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30180 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/328029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25913
TBR=dank
Review URL: http://codereview.chromium.org/333047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30178 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=net_unittests passes

Review URL: http://codereview.chromium.org/330016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30176 0039d316-1c4b-4281-b951-d872f2087c98

This issue is caused by my another mistake that I forgot changing test_shell to apply my input-code refactoring. (Since my refactoring, EventSendingController::keyDown() doesn't need platform-dependent code.)
This change just removes the platform-dependent code in EventSendingController::keyDown() and updates 'test_expectations.txt'.

BUG=23745
TEST=run-webkit-tests.sh LayoutTests/fast/events/node-event-anchor-lock.html
Review URL: http://codereview.chromium.org/258032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30175 0039d316-1c4b-4281-b951-d872f2087c98

Landing http://codereview.chromium.org/334026.

BUG=20825,23780,24200
TEST=none
Review URL: http://codereview.chromium.org/338039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30174 0039d316-1c4b-4281-b951-d872f2087c98

Times New Roman of Windows XP doens't have a glyph for U+1E3F though
Windows Vista has.  It makes different results for U+1E3F rendering.

BUG=25617
TEST=none
Review URL: http://codereview.chromium.org/333025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30173 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24472

Review URL: http://codereview.chromium.org/337035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30172 0039d316-1c4b-4281-b951-d872f2087c98

>	chrome.dll!`anonymous namespace'::OnNoMemory()  Line 126	C++
	chrome.dll!_invalid_parameter_noinfo()  Line 99 + 0xc bytes	C++
	chrome.dll!RefCountedBytes::front()  Line 67 + 0x1b bytes	C++
	chrome.dll!BookmarkModel::OnFavIconDataAvailable(int handle=8, bool know_favicon=true, scoped_refptr<RefCountedBytes> data={...}, bool expired=true, GURL icon_url={...})  Line 652 + 0x2b bytes	C++

It seems RefCountedBytes data has no data. If data size is 0, accessing front
of data would cause crash.
By checking its size, fixes this crash.

BUG=25803
TEST=no crash on startup

Review URL: http://codereview.chromium.org/328037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30171 0039d316-1c4b-4281-b951-d872f2087c98

(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase


TBR=rolandsteiner@chromium.org
Review URL: http://codereview.chromium.org/337042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30170 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/333042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30169 0039d316-1c4b-4281-b951-d872f2087c98

(see discussion and history there)

BUG=10876
TEST=FilePathTest.MatchesExtension.CompareIgnoreCase


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30168 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/334033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25873
TEST=unittest


Review URL: http://codereview.chromium.org/330026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30165 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=25354
Review URL: http://codereview.chromium.org/329033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30164 0039d316-1c4b-4281-b951-d872f2087c98

Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread.  If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching.  With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354
Review URL: http://codereview.chromium.org/306032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98

Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to collect extensions API usage
for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/333040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30162 0039d316-1c4b-4281-b951-d872f2087c98

Revert (3 of 4) 30154 - Fix build bustage by adding dependency back on sync_proto from sync_unit_tests.

TBR=nick

Review URL: http://codereview.chromium.org/334038

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/333039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30161 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333037

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/337039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30160 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333038

TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/328036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30159 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30157 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/333037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30156 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nick

Review URL: http://codereview.chromium.org/334038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30154 0039d316-1c4b-4281-b951-d872f2087c98

for correlation to sync commit requests.  Add ChromiumExtensionsActivity to sync.proto
to allow passing this data to sync servers.

BUG=25323
TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in
ChromiumExtensionsActivity for each such extension showing up in CommitMessages.

Review URL: http://codereview.chromium.org/325001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30153 0039d316-1c4b-4281-b951-d872f2087c98