- 18 Jul, 2014 40 commits
-
-
dnicoara@chromium.org authored
BUG=none NOTRY=true Review URL: https://codereview.chromium.org/407603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284176 0039d316-1c4b-4281-b951-d872f2087c98
-
waffles@chromium.org authored
TBR=gavinp BUG=395152 Review URL: https://codereview.chromium.org/406603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284175 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
Revert of [DevTools] Move DevToolsWindow testing code to a separate class. (https://codereview.chromium.org/395783002/) Reason for revert: Mac 10.7 has become flaky for ViewIDTest.Basic (http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%282%29?numbuilds=100) and this CL is suspected as it touches this exact test. Example crash stack trace below: BrowserTestBase signal handler received SIGTERM. Backtrace: 0 browser_tests 0x0132e9ba base::debug::StackTrace::StackTrace() + 26 1 browser_tests 0x04e5ecb8 _ZN7content12_GLOBAL__N_1L27DumpStackTraceSignalHandlerEi + 72 2 libsystem_c.dylib 0x9090259b _sigtramp + 43 3 ??? 0xffffffff 0x0 + 4294967295 4 browser_tests 0x01328f56 base::AtExitManager::RegisterCallback(void (*)(void*), void*) + 102 5 browser_tests 0x02614bb4 Singleton\u003Ccc::TaskRunnerPairs, DefaultSingletonTraits\u003Ccc::TaskRunnerPairs>, cc::TaskRunnerPairs>::get() + 276 6 browser_tests 0x026141e7 cc::BlockingTaskRunner::current() + 23 7 browser_tests 0x02614762 cc::BlockingTaskRunner::CapturePostTasks::CapturePostTasks() + 18 8 browser_tests 0x026404eb cc::SingleThreadProxy::Stop() + 59 9 browser_tests 0x02619e04 cc::LayerTreeHost::~LayerTreeHost() + 132 10 browser_tests 0x0261a2c1 cc::LayerTreeHost::~LayerTreeHost() + 17 11 browser_tests 0x04011e94 ui::Compositor::~Compositor() + 148 12 browser_tests 0x040120c1 ui::Compositor::~Compositor() + 17 13 browser_tests 0x03fa8dfd -[BrowserCompositorViewCocoa .cxx_destruct] + 173 14 libobjc.A.dylib 0x995863bf object_cxxDestructFromClass + 104 15 libobjc.A.dylib 0x99583204 objc_destructInstance + 40 16 browser_tests 0x021dd2c2 (anonymous namespace)::ZombieDealloc(objc_object*, objc_selector*) + 98 17 AppKit 0x96b68b39 -[NSResponder dealloc] + 156 18 AppKit 0x96b66fee -[NSView dealloc] + 74 19 libobjc.A.dylib 0x9958254e _objc_rootRelease + 47 20 browser_tests 0x03fa7f16 base::LazyInstance\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa>, base::DefaultLazyInstanceTraits\u003Cbase::scoped_nsobject\u003CBrowserCompositorViewCocoa> > >::OnExit(void*) + 38 21 browser_tests 0x013291e2 base::internal::Invoker\u003C1, base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid (*)(void*)>, void ()(void*), void ()(void*)>, void ()(void*)>::Run(base::internal::BindStateBase*) + 18 22 browser_tests 0x01328e27 base::AtExitManager::ProcessCallbacksNow() + 119 23 browser_tests 0x01328ec2 base::AtExitManager::~AtExitManager() + 34 24 browser_tests 0x013bbb20 base::TestSuite::~TestSuite() + 48 25 browser_tests 0x00b5f783 ChromeBrowserTestSuiteRunner::RunTestSuite(int, char**) + 51 26 browser_tests 0x012fd642 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 34 27 browser_tests 0x04e97e42 content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 738 28 browser_tests 0x012fd5f3 LaunchChromeTests(int, ChromeTestSuiteRunner*, int, char**) + 67 29 browser_tests 0x00b5f73d main + 77 30 browser_tests 0x00039635 start + 53 31 ??? 0x0000000b 0x0 + 11 Original issue's description: > [DevTools] Move DevToolsWindow testing code to a separate class. > > This change: > - allows for proper docking testing (including toolbox); > - removes all test friends from DevToolsWindow; > - unifies testing approach to use load callback instead of notifications; > - adds simple toolbox tests. > > BUG=393566 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284050 TBR=pfeldman@chromium.org,lushnikov@chromium.org,sky@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=393566 Review URL: https://codereview.chromium.org/403833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284174 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284173 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
6256a14 Fix pdfium building issue on VS2010 5eb9f7b pdfium: Fix all -Wdelete-non-virtual-dtor violations on Mac. a9c29e0 Fix garbled text when loading linearized pdf document c7cd3c8 Fix building pdfium for x64 with ninja under windows. 3fb18f4 Hook up the default v8::Platform implementation to pdfium BUG=260112, 249006, 275281, 354966, 365302, 236952 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/398273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284172 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
1. Moved actual device indicator to config.json 2. Wireless interface now part of config.json 3. LED path now part of config.json 4. udhcpd config now generated by script This should make the script a fair bit more robust and allow it to work on any machine. In addition, updated the SSID to the new format. BUG= NOTRY=true Review URL: https://codereview.chromium.org/405483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284171 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
This also introduce the notion of message header to allow routing. R=rmcilroy@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767 Review URL: https://codereview.chromium.org/371603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284170 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
BUG=318977 Review URL: https://codereview.chromium.org/399573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284169 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284168 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
The ICU update does the following among other things: - Update EUC-JP (no more JIS X 212 round-trip coverage) per WHATWG encoding spec. - Add CP866 - Add far better/more extensive support for plural, format, etc - Numerous locale data update - Khmer/Lao line/word-breaking support - More compact Chinese/Japanese dictionary (now a part of the upstream instead of our local patch) - Better plural support that we plan to use right away. - Update icu/BUILD.gn : file list update, new defines, etc. - Update tests a. icu_string_conversions_unittests : drop iscii (nobody uses it) and remove JIS X 212 code points from the round-trip test b. l10n_util_unittests: Display names for zh-*. c. ThaiSnippet's expected result. (due to a Unicode grapheme definition change). d. Update Expected results in file_manager_browsertest/test_util.js (see http://crbug.com/383930) - Update SpellcheckerWordIterator a. Add U+0027 back to MidNumLet b. Add Lao and Khmer scripts to the list of scripts requiring dictionary-based word-breaking. - l10n_util : alias 'tl' to 'fil' (Tagalog to Filipino) - Update IdentityInternalsSingleTokenWebUITest.verifyGetters (DateTimeFormat-Full has 'at' before time, which is not handled by Date.parse() - update license.py because we don't have a separate Chinese/Japanese dictionary any more. It's now a part of ICU Note to Sheriff : 1. 140 ~ 200 kB size increase is expected for all platforms. This size increase was singed off by laforge@. The expected size has to be updated with both reva/revb pointing to the revision corresponding to this CL. 2. http://codereview.chromium.org/348913002 has to be applied before running make_expectations.py to update tools/perf_expectations/perf_expectations.json after this CL is landed. BUG=132145,277023,136148,360433,364072 TEST=base_unittests:*ICU*, net_unittests:*IDN*, ui_unittests:*Lang*, browser_tests (encoding related, Iden*verifyGet*), unit_tests:Ext*L10*, unit_tests:*Lang*, component_tests:*Snipp*, layout tests (encoding, date/calendar, line breaking, and others), build 'base_i18n_nacl', GN build bots. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277111 R=arv@chromium.org, brettw@chromium.org, fgorski@chromium.org, groby@chromium.org, hirono@chromium.org, tony@chromium.org, toyoshim@chromium.org Review URL: https://codereview.chromium.org/265613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284167 0039d316-1c4b-4281-b951-d872f2087c98
-
hyunki.baik@samsung.com authored
Don't need to do Un-premultiplying operation, if alpha value equals to 0 or 255. BUG=none Test(DONE)=gfx_unittests --gtest_filter="ColorAnalysisTest*" Review URL: https://codereview.chromium.org/399053002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284166 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@chromium.org authored
Currently, bionic only build a subset of the examples. This changes turns on all the examples and tests compiling those examples. BUG=344574 R=sbc@chromium.org, binji@chromium.org Review URL: https://codereview.chromium.org/339393005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284165 0039d316-1c4b-4281-b951-d872f2087c98
-
aelias@chromium.org authored
Unlike when this method was originally written, there can now be a second child, a readback layer. If the root layer happens to change while a readback is active, it will never complete, hanging the rendering. NOTRY=true BUG=386337 Review URL: https://codereview.chromium.org/407433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284164 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284163 0039d316-1c4b-4281-b951-d872f2087c98
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia/+log/19eb3b2f0aa6dce5c0335230a8930e90733e5d5d..63f413ce94358e3e76dca66218c7da20fec18569 CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel TBR=halcanary@google.com BUG= Review URL: https://codereview.chromium.org/401713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284162 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
This change makes IndexedDBFactory a virtual base class, and what was IndexedDBFactory is now IndexedDBFactoryImpl. This change will allow tests to create proper mock factories and not require them to instantiate the "real" factory (which often doesn't work) in the test. It will also take us one step closer to eliminating special cases in IDB's other classes where having a factory is optional (because tests don't create them). BUG=393974 R=ericu@chromium.org, jochen@chromium.org, jsbell@chromium.org, michaeln@chromium.org Review URL: https://codereview.chromium.org/313883003 Patch from cmumford@chromium.org <cmumford@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284161 0039d316-1c4b-4281-b951-d872f2087c98
-
ahernandez.miralles@gmail.com authored
NOTRY=True Review URL: https://codereview.chromium.org/407613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284160 0039d316-1c4b-4281-b951-d872f2087c98
-
rlarocque@chromium.org authored
Adds support for non-blocking initial sync to the sync protocol. This allows some types to request an initial sync without having the scheduler enter configure mode. The protocol changes are necessary to keep the server informed that the request is due to an initial sync request. The remainder of the changes in this CL were required to plumb information about the cause of the sync cycle through the SyncScheduler. This CL also includes some new tests. At the moment, there are no types in use that support this feature. This CL will not affect behavior in any way. BUG=351005 Review URL: https://codereview.chromium.org/387983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284159 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
In preparation for migrating to TimeSource, StartPlayingFrom() is renamed to StartPlaying() with renderers expected to fetch the current time instead of being provided the time. AudioRenderer::SetMediaTime() is temporarily added until we can migrate the interface to being based on TimeSource. BUG=370634 R=xhwang@chromium.org Review URL: https://codereview.chromium.org/400853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284155 0039d316-1c4b-4281-b951-d872f2087c98
-
changwan@chromium.org authored
BUG=384803 NOTRY=true Review URL: https://codereview.chromium.org/397873003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284152 0039d316-1c4b-4281-b951-d872f2087c98
-
pasko@chromium.org authored
(trybots are probably useless anyway) Review URL: https://codereview.chromium.org/399053004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284151 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
Traceback (most recent call last): File "tools/perf/../telemetry/telemetry/decorators.py", line 50, in wrapper func(*args, **kwargs) File "/b/build/slave/Android_Tests/build/src/tools/perf/benchmarks/benchmark_unittest.py", line 51, in BenchmarkSmokeTest self.assertEqual(0, SinglePageBenchmark().Run(options), File "tools/perf/../telemetry/telemetry/benchmark.py", line 84, in Run results = page_runner.Run(test, ps, expectations, args) File "tools/perf/../telemetry/telemetry/page/page_runner.py", line 346, in Run possible_browser = browser_finder.FindBrowser(finder_options) File "tools/perf/../telemetry/telemetry/decorators.py", line 26, in Cacher cache[key] = obj(*args, **kwargs) File "tools/perf/../telemetry/telemetry/core/browser_finder.py", line 73, in FindBrowser curr_browsers = finder.FindAllAvailableBrowsers(options) File "tools/perf/../telemetry/telemetry/core/backends/chrome/android_browser_finder.py", line 214, in FindAllAvailableBrowsers pids = [p.pid for p in psutil.process_iter() if 'adb' in p.name] File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 161, in name cmdline = self.cmdline File "/usr/lib/python2.7/dist-packages/psutil/__init__.py", line 188, in cmdline return self._platform_impl.get_process_cmdline() File "/usr/lib/python2.7/dist-packages/psutil/_pslinux.py", line 327, in wrapper raise NoSuchProcess(self.pid, self._process_name) NoSuchProcess: process no longer exists (pid=13764) Observed here: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/14626/steps/telemetry_perf_unittests/logs/stdio BUG= Review URL: https://codereview.chromium.org/394423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284144 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
NOTRY=true TBR=ericu@chromium.org Review URL: https://codereview.chromium.org/406643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284143 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
View::RemoveChildView() does not delete the child view. So make sure they are destroyed correctly. BUG=none R=jennyz@chromium.org Review URL: https://codereview.chromium.org/400983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284140 0039d316-1c4b-4281-b951-d872f2087c98
-
sayan.nayak@samsung.com authored
Make behavior uniform with other apps on Android, where after a Cut from an editable field, the insertion handle is hidden and only the cursor remains visible. https://codereview.chromium.org/394953005/ BUG:394781 Review URL: https://codereview.chromium.org/399613008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284138 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Previously the GN Windows build specified the symbol file $pdbfile but this variable was never defined, so the command like would just say "/Fd" and the default one would be used. This patch defines some per-target variables in the ninja file for the toolchain to use. The Windows toolchain uses these to construct C- and C++-specific pdb files (the MS tools can't share between these two) for the current target. BUG= R=scottmg@chromium.org Review URL: https://codereview.chromium.org/406453002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284137 0039d316-1c4b-4281-b951-d872f2087c98
-
ksakamoto@chromium.org authored
No longer tracked after Blink r162391. BUG=246492 NOTRY=true Review URL: https://codereview.chromium.org/400913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284136 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284135 0039d316-1c4b-4281-b951-d872f2087c98
-
rmcilroy@chromium.org authored
This pulls in the following CLs: - r1346 Don't free pointer in BasicCodeModules::BasicCodeModules before possibly using it - r1347 Stringify minidump stream_type constants in minidump_dump output - r1348 Ensure C:/Dumps/ exists in crash_generation_app - r1349 Change some ELF utils to return the length as a size_t - r1350 Add frame pointer recovery to the AMD64 Stackwalker. - r1351 [Android]: Remove __system_property_get(ro.build.fingerprint) from WriteOSInformation. BUG=394841,393903 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284101 R=mark@chromium.org Review URL: https://codereview.chromium.org/400203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284134 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=395172 R=miu@chromium.org, thestig@chromium.org TBR=miu@chromium.org, thestig@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/408483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284133 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
Revert of Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/399353007/) Reason for revert: Not the issue... re-landing. Original issue's description: > Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/) > > Reason for revert: > Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...). > > I'll reland if that's not it. > > Thanks for your understanding! > > Original issue's description: > > Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000 > > TBR=rockot@chromium.org,sammc@chromium.org > NOTREECHECKS=true > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284087 TBR=rockot@chromium.org,sammc@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/404823003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284132 0039d316-1c4b-4281-b951-d872f2087c98
-
aurimas@chromium.org authored
Applications targeting this or a later release will get these new changes in behavior: - AlertDialog might not have a default background if the theme does not specify one. BUG=393019 TBR=stgao@chromium.org,blundell@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/402613008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284131 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=395169 R=rouslan@chromium.org, thestig@chromium.org TBR=rouslan@chromium.org, thestig@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/408483002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284130 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Make DeriveFont() fall back to "sans" if it doesn't find an SkTypeface matching the requested family, as InitFromDetails() already did. Also make InitFromDetails() pass through the requested style. BUG=394860 Review URL: https://codereview.chromium.org/399113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284125 0039d316-1c4b-4281-b951-d872f2087c98
-
kolczyk@opera.com authored
It simply forwards the flag from v8::FunctionCallbackInfo and allows the function handler that accept gin::Arguments argument to distinguish between normal function invocation and call as an object construction. BUG= Review URL: https://codereview.chromium.org/401823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284123 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
TimeSource represents the canonical source of time and will eventually replace the time-updating callback from AudioRenderer and VideoRenderer. A wall-clock based implementation is also provided for media pipelines that do not contain any audio. BUG=370634 Review URL: https://codereview.chromium.org/379343005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284122 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Use GtkSettings's gtk-xft-dpi property to convert Pango font descriptions from points to pixels. Previously PangoContext's default resolution, which is sometimes (always?) unset, was used, resulting in 96 DPI being used for conversions regardless of the value reported by X. BUG=375824 Review URL: https://codereview.chromium.org/406493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284121 0039d316-1c4b-4281-b951-d872f2087c98
-
dzhioev@chromium.org authored
Removed "disable-saml-signin" flag and non-SAML auth extension manifest. Now SAML is always enabled for both desktop and Chrome OS. Plus: * Prevented potential races during extension initialization. * Made "manifest_keyboard.json" up to date with "manifest.json". BUG=394342 TEST=none TBR=jochen (c/b/browser_resources.grd) Review URL: https://codereview.chromium.org/384003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284120 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
Introduced SnapToPixelLayoutManager and used where it makes sense. WorkspaceLayoutManager uses WindowState, so it's the property is manually set there. This depends on the following CL: https://codereview.chromium.org/375693006/ BUG=391822 Review URL: https://codereview.chromium.org/357063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284119 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284118 0039d316-1c4b-4281-b951-d872f2087c98
-