GitLab

BUG=423555
TEST=None

Review URL: https://codereview.chromium.org/652613003

Cr-Commit-Position: refs/heads/master@{#299946}

Revert of Ensure that the browser’s copy of page id is in sync with the renderer’s. (patchset #1 id:1 of https://codereview.chromium.org/657233002/)

Reason for revert:
It's crashing... drat.

Original issue's description:
> Ensure that the browser’s copy of page id is in sync with the renderer’s.
>
> This might-maybe-hope-not crash, and so has debugging statements.
>
> BUG=407376
> TEST=no crashing, we hope
>
> Committed: https://crrev.com/b49b70f26e6d0f2f54bb87cf374f30a339c7d7c6
> Cr-Commit-Position: refs/heads/master@{#299822}

TBR=rsesek@chromium.org,creis@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407376

Review URL: https://codereview.chromium.org/661823002

Cr-Commit-Position: refs/heads/master@{#299945}

According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
meter tag should have MSAA+IA2 Role as ROLE_SYSTEM_PROGRESSBAR.
And for mac, the AX Mappings should be copy of ARIA role progressbar.

This CL depends on https://codereview.chromium.org/652663003/

This CL also takes care of small fixes related with details tag and div tag.

BUG=421376

Review URL: https://codereview.chromium.org/657513002

Cr-Commit-Position: refs/heads/master@{#299944}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2606d14..481d9a8

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/665453002

Cr-Commit-Position: refs/heads/master@{#299943}

BUG=413863

Review URL: https://codereview.chromium.org/646773005

Cr-Commit-Position: refs/heads/master@{#299942}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/644913003

Cr-Commit-Position: refs/heads/master@{#299941}

On suspend, Easy Unlock app gets disabled. When waking up, it takes some
time for the app to reload ( a second or two). During theat time there
is no Easy Unlock icon in the user pod. To improve user experience,
show connecting icon during that time.

BUG=421970
TEST=With Easy Unlock enabled, lock the screen and close the lid (so the
device suspends). When opening the lid spinner icon should be visible
immediately on the user pod.

Review URL: https://codereview.chromium.org/644873002

Cr-Commit-Position: refs/heads/master@{#299940}

There is a race condition in the current state of the code where in cross-process navigation we swap the existing RenderFrameHost with a new RenderFrameHost. If the existing host sends an IPC message to create a new child frame, it arrives on the IO thread, allocates a routing id based of the existing process (p1) and does a PostTask to the UI thread. If there is a CommitPending event either executing on the UI thread or in the task queue before the task posted from the IO thread, it will end up putting the existing RenderFrameHost in swapped out state (or waiting for swapped out). When the task to create a child frame is executed after that, it creates a new RenderFrameHost, but it uses the "current" process (p2), which is different than the process that sent the message (p1). This manifests sometimes as adding duplicate routing ids to RenderProcessHost and is in general really bad bug.

BUG=415059, 423691, 381990

Review URL: https://codereview.chromium.org/642813007

Cr-Commit-Position: refs/heads/master@{#299939}

In order to better integrate the IRT Extension API into NaCl IO, the
first implementation mirrors the other kernel_wrap_* files. All the
unit tests should therefore still be valid. Eventually it may be
easier to just have a separate version of kernel_intercept which
utilizes the IRT extension API directly.

Currently the IRT Extension interface is only supported within newlib,
so I have enabled it for newlib only.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3918
TEST= trybots

Review URL: https://codereview.chromium.org/608913003

Cr-Commit-Position: refs/heads/master@{#299938}

BUG=None
R=nkostylev@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/660613002

Cr-Commit-Position: refs/heads/master@{#299937}

BUG=skia:2889

Review URL: https://codereview.chromium.org/662623003

Cr-Commit-Position: refs/heads/master@{#299936}

BUG=423134

Review URL: https://codereview.chromium.org/662503003

Cr-Commit-Position: refs/heads/master@{#299935}

BUG=423134

Review URL: https://codereview.chromium.org/658993002

Cr-Commit-Position: refs/heads/master@{#299934}

Not sure in which condition this can be triggered, my environment is linux x64 with plain "component=shared_library clang=1", the actual linker invoked is "third_party/binutils/Linux_x64/Release/bin/ld.gold"

Here is the error log from linker:
/usr/lib64/gcc/x86_64-unknown-linux-gnu/4.9.1/../../../../include/c++/4.9.1/bits/stl_tree.h:1543: error: undefined reference to 'message_center::CompareTimestampSerial::operator()(message_center::Notification*, message_center::Notification*)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)

BUG=None

Review URL: https://codereview.chromium.org/654093003

Cr-Commit-Position: refs/heads/master@{#299933}

In order to support GL_TEXTURE_RECTANGLE_ARB, cc::GLRenderer needs to
know the size of the mask texture to unnormalize the texture
coordinates.  This has already been done for TileDrawQuad.

As an optimization, rather than adding two more members onto the already
bloated RenderPassDrawQuad, turn mask_uv_rect into mask_uv_scale.  The
position of the mask is now assumed to always be at the origin of the
quad's transform, which it always is in cc.  This is equivalent to
saying that the mask is always attached to the owning layer of a render
surface (since that's what defines the transform origin of the render
surface).

By making this assumption, the old mask_uv_rect can be calculated in
a helper function from just quad->rect and quad->mask_uv_scale.

With this patch, mask_texture_size is currently unused, but its values
are unit tested.

Depends on https://codereview.chromium.org/652393002/

R=danakj@chromium.org,jamesr@chromium.org
BUG=423533

Review URL: https://codereview.chromium.org/659683002

Cr-Commit-Position: refs/heads/master@{#299932}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7851a56..2f912f3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/640263003

Cr-Commit-Position: refs/heads/master@{#299931}

R=sergeyu@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/660703003

Cr-Commit-Position: refs/heads/master@{#299930}

BUG=423621

Review URL: https://codereview.chromium.org/657333002

Cr-Commit-Position: refs/heads/master@{#299929}

Other embedded content, such as plug-ins, is also prevented from incurring
auto-log-in requests.

BUG=334230
TEST=You still get the auto-log-in infobar when the requesting site is the
top-level frame, but never otherwise.

Review URL: https://codereview.chromium.org/131483010

Cr-Commit-Position: refs/heads/master@{#299928}

This was blocked on http://crbug.com/423873 which is now fixed.

BUG=414808
R=jam@chromium.org

Review URL: https://codereview.chromium.org/645033003

Cr-Commit-Position: refs/heads/master@{#299927}

Adds these targets:
//chrome/android:chrome_javatests
//chrome/android:chrome_shell_test_java
//chrome/android:chrome_shell_test_apk
//chrome/android:chrome_sync_shell_test_apk
//chrome/android:uiautomator_tests_java
//chrome/android:uiautomator_tests
//chrome/test/android:chrome_java_test_support
//chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_apk
//chrome/test/chromedriver/test/webview_shell:chromedriver_webview_shell_resources

depends on https://codereview.chromium.org/570203002/

TBR=ben
BUG=359249

Review URL: https://codereview.chromium.org/586383002

Cr-Commit-Position: refs/heads/master@{#299926}

Changing previous experiment that made 50% of users on canary
use stable configs to instead not create any experiments.

Experimenting with this to see impact of experiments on
stability.

BUG=421481

Review URL: https://codereview.chromium.org/662663002

Cr-Commit-Position: refs/heads/master@{#299925}

It looks like there are a few edge cases when the BrowserActionView in
BrowserActionsContainer::ToolbarExtensionUpdated() could be NULL. Check the
view before using it.

BUG=424050

Review URL: https://codereview.chromium.org/640373005

Cr-Commit-Position: refs/heads/master@{#299924}

The Java class org.chromium.content.browser.WebContentsObserverAndroid
is incorrectly named and should be WebContentsObserver to follow
the same pattern as for other classes.

The current WebContentsObserverAndroid is deprecated and it extends
new class WebContentsObserver inorder to delegate all method calls.
This is done for external repositories to adapt new class name to
WebContentsObserver after this change.

Once this is done WebContentsObserverAndroid will be removed in
next patch.

BUG=396118

Review URL: https://codereview.chromium.org/589113002

Cr-Commit-Position: refs/heads/master@{#299923}

BUG=304341
TEST=browser_tests
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/639033004

Cr-Commit-Position: refs/heads/master@{#299922}

The default umask() implemented by libnacl returns 0777, which if actually
used, would create files with 0 mode.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/643543004

Cr-Commit-Position: refs/heads/master@{#299921}

Nukes LayoutItems and folds into Layout as that is the only place
calling into it. Removes early out if parent() is NULL in Layout. No
point in doing that.

BUG=416641
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/656033007

Cr-Commit-Position: refs/heads/master@{#299920}

It is legal to create a file with mode bits that conflict with the open flags,
e.g.:

   open("foo", O_WRONLY | O_CREAT, 0444);

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/659513002

Cr-Commit-Position: refs/heads/master@{#299919}

BUG=419287

Review URL: https://codereview.chromium.org/633273002

Cr-Commit-Position: refs/heads/master@{#299918}

All callers of OAuth2ApiCallFlow in the codebase do not use the refresh token
flow, preferring to obtain the access token in other ways.

The access token and URL request context are also refactored from the
constructor to the Start(), so an OAuth2ApiCallFlow object can be passed around
without first knowing the access_token needed to make the request.

BUG=421982
TEST=updated existing tests

Review URL: https://codereview.chromium.org/654123002

Cr-Commit-Position: refs/heads/master@{#299917}

Finally, we can revert the temporary hacks for using Blink UTF conversion
routines, as we implemented a similar fast path in the routines from  base::.

I have double-checked that this doesn't regress performance on the benchmark
that we were using.

This reverts commit ed921a04.

BUG=391492

Review URL: https://codereview.chromium.org/660843002

Cr-Commit-Position: refs/heads/master@{#299916}

Fix indentation issues to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/660603002

Cr-Commit-Position: refs/heads/master@{#299915}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c8ee2ce..2606d14

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/664473003

Cr-Commit-Position: refs/heads/master@{#299914}

Revert of [Telemetry] Always use ephemeral port chosen by Chrome. (patchset #1 id:1 of https://codereview.chromium.org/650963003/)

Reason for revert:
Possibly caused flake. Will reland if mistaken.

BUG=424245

Original issue's description:
> [Telemetry] Always use ephemeral port chosen by Chrome.
>
> This reduces a potential source of flake for desktop Chrome. The
> reference builds are now M37 (and I've verified they behave properly)
> and stable is now M38.
>
> BUG=379980
>
> Committed: https://crrev.com/f71a95de8adcd6cab36f87d669feda3fb1984896
> Cr-Commit-Position: refs/heads/master@{#299621}

TBR=kbr@chromium.org,dtu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=379980

Review URL: https://codereview.chromium.org/659923003

Cr-Commit-Position: refs/heads/master@{#299913}

BUG=422730

Review URL: https://codereview.chromium.org/651113002

Cr-Commit-Position: refs/heads/master@{#299912}

BUG=423621

Review URL: https://codereview.chromium.org/657313002

Cr-Commit-Position: refs/heads/master@{#299911}

BUG=none
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/659103002

Cr-Commit-Position: refs/heads/master@{#299910}

BUG=

Review URL: https://codereview.chromium.org/606853002

Cr-Commit-Position: refs/heads/master@{#299909}

Fix indentation issue to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/652173003

Cr-Commit-Position: refs/heads/master@{#299908}

R=bulach@chromium.org
BUG=

Review URL: https://codereview.chromium.org/660683002

Cr-Commit-Position: refs/heads/master@{#299907}