- 26 Nov, 2019 40 commits
-
-
Daniel Rubery authored
Now that the necessary tests have been added, we can safely add the new endpoint URL. Fixed: 1020434 Change-Id: Ib1b3073a1368d9e794104a4e8df5449cc3c4ef4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927571 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719235}
-
Primiano Tucci authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b62621c1dd8e..1b1f18689958 git log b62621c1dd8e..1b1f18689958 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 primiano@google.com Fix chromium build, remove some assert_no_deps 2019-11-26 treehugger-gerrit@google.com Merge "Refactor: define oom_score_adj span once" 2019-11-26 fmayer@google.com Merge "Handle DeobfuscationMapping." 2019-11-26 treehugger-gerrit@google.com Merge "perfetto-ui: Changing picture in the record page for heap profiling" 2019-11-26 primiano@google.com Merge "Remove libprotobuf from IPC layer" 2019-11-26 primiano@google.com Merge "tools(tmux): correctly find ninja" Change-Id: I3d771fa153e89ac0b8edf1a7c40b27f3d151bb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937169 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#719234}
-
David Bokan authored
This CL adds back the source bit on injected ACTION_SCROLL motion events. This got lost when [1] tried to make this bit a parameter and then subsequently removed the option due to performance regressions in [2]. The reason this breaks is because in ContentUiEventHandler.java, onGenericMotionEvent only dispatches a wheel event if the ACTION_SCROLL event comes from a Pointer source[3]. [1] https://crrev.com/02cd150c24de8bdebb14d88c1a144b921a47756f [2] https://crrev.com/14e88d0ddbdd58d346bc9c3bb0629af3fdf56f0f [3] https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentUiEventHandler.java?rcl=3df6abb639be7564b7743ade8db455a3564e7d32&l=67 Change-Id: I1ba4143f61ad889173735b0a168d7790a00d0865 Bug: 1025789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935432Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#719233}
-
Erik Staab authored
Bug: 1007744 Change-Id: Iad1c2de0d2f611feec63175905254d9a739e0a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931917Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#719232}
-
Matt Wolenetz authored
BUG=920044 Change-Id: Idb03f2bc1d2a2f7fb9f9ebd6247259ca097e2ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933385 Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719231}
-
Tomasz Wiszkowski authored
TBR=pkotwicz@chromium.org Bug: 1028636 Change-Id: I749bc375a59582d6369edfa05910cea5e6849692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935368 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#719230}
-
Ayu Ishii authored
Bug: 1007736 Change-Id: I2304f4f2bb6b031f1834fa23054027a315ef9781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934887Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#719229}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. These are the last instances in //content/renderer/ entirely. R=liberato@chromium.org TBR=dpranke Bug: 953861 Change-Id: Ib32ab468dcdf835e4b8fa08c19cf569a03a50144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934833Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719228}
-
Egor Pasko authored
Bug: 1021524 Change-Id: I1b15ac40c3930e650ae54306d4ac358dea6f60d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936295 Auto-Submit: Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719227}
-
Christopher Cameron authored
Prior to this change, we were asynchronously poking around in the filesystem to see what apps are installs for which profiles. Just use the AppShimRegistry. Delete all of the asynchronous profile loading code, and rename some of the menu functions to be more clear in their meaning. TBR=dominickn Bug: 1001213 Change-Id: I27ec96b2ddcfcd0169fa7663a30b8dc8eb113819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929846Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#719226}
-
Friedrich Horschig authored
Before this change, the keyboard accessory (and the settings pages it stole these icons from) were using old icons. This CL adds modern icons and replaces pngs with smaller vector assets: ic_vpn_key.xml: 777B -> 767B infobar_autofill_cc.xml: 1289B -> 661B permission_location.xml: 2505B -> 773B The images have been compressed with avocado for ~22% space gain: ic_vpn_key.xml: 0.987 Kb - 24.1% = 0.749 Kb infobar_autofill_cc.xml: 0.831 Kb - 22.3% = 0.646 Kb permission_location.xml: 0.977 Kb - 22.7% = 0.755 Kb Screenshots for all affected surfaces are attached to the linked bug. Bug: 1028107 Change-Id: Ia66e7ae71f73a2e620969dd87ee74813cf9a9752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937007Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#719225}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/704d5408dbf0..17096c763c24 git log 704d5408dbf0..17096c763c24 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 emircan@google.com Revert "Disable VkProtectedContext_DDLMakeRenderTargetTest" 2019-11-26 brianosman@google.com Remove ResourceProvider and ImageAsset sample impls from skottie Created with: gclient setdep -r src/third_party/skia@17096c763c24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I62b1e2f2dbd4f030a0cadee6c3b8fdc7b627d070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936901Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719224}
-
Olivier Li authored
The test part of this change is necessary to support running HistoryBackend on the ThreadPool.(Feature:HistoryServiceUsesTaskScheduler) On the ThreaPoool we cannot FastForwardUntilNoTasksRemain() for tasks using repeating timers. Regardless of the new feature this change is intended to be a no-op and has the added benefit of being more explicit in the time related expectations. Bug: 661143 Change-Id: I1dcd2f3e2d1e5a5455953b0555c6475b2d0fdafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932417Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
CSVPassword already has the method Parse(PasswordForm*), which parses the associated CSV row. It returns the success/failure of the parsing and stores the corresponding PasswordForm into the location passed as the only argument. If the argument is null, Parse() only checks that the CSV row is a correct serialization of a credential and then does not create the PasswordForm. This is often used in the code. This CL introduces the TryParse() method, which is equivalent to calling (the old) Parse(nullptr). Its purpose is to improve readability of the code: with Parse(nullptr) the reader might wonder what the type and meaning of the "nullptr" is, whereas with TryParse() it is clear that this is some kind of check that parsing works. Parse() now DCHECKS that the passed PasswordForm* is not null. Bug: 934326 Change-Id: I92578ac1f87798535a7e8ba11bd7b464dd724629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932776 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#719222}
-
Peter Beverloo authored
Bug: 1028344 Change-Id: Iba393d02c795f32b9b1341cdf9ef12037fd9126c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937069 Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#719221}
-
Sinan Sahin authored
Bug: 1022804 Change-Id: Ifdd7c6abaa0abbacc911c744884e0162f838db41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931107Reviewed-by:
-
Owen Min authored
The test has been disabld on Mac already, but it's also flaky on win, linux and chromeos. Disable the tests on all platforms. Bug: 877109 Tbr: hcarmona@chromium.org Change-Id: I8e2d1e205b5d4077194898ee82337656135e299a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935838Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719219}
-
Matt Jones authored
See bug for details. TBR: pkotwicz@chromium.org Bug: 1028628 Change-Id: If6e85886a4c6572fa4874a77f443dcd716fbe72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937129Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#719218}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4cef8a49b49d..fe2d3ddde90a git log 4cef8a49b49d..fe2d3ddde90a --date=short --first-parent --format='%ad %ae %s' 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader afc52b0b26d7..663dcefa22ea (10 commits) 2019-11-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 5efc3922e3e8..8c954d5a413d (3 commits) 2019-11-26 xinyi.he@arm.com Vulkan: Large builtins overflow during string construction in glslang Created with: gclient setdep -r src/third_party/angle@fe2d3ddde90a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: cwallez@google.com Change-Id: I69f86c9fae7bf9907af7dc3cdd0f86960dc9dd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936893Reviewed-by:
-
David Van Cleve authored
This patch adds a boolean global which, when enabled, causes the default referrer policy to retain its current default value of no-referrer-when-downgrade even when the ReducedReferrerGranularity base::Feature is enabled. This is a temporary addition that will back an enterprise policy for a couple milestones (targeting M82 for deletion). In multi-process mode, the value propagates to the renderer process through a command-line switch added by RenderProcessHostImpl. Bug: 1021277 Change-Id: Icb4905715467a4f1baacd9e762dd6c0358b38a35 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904231Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#719216}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=estark@chromium.org Bug: 1023677 Change-Id: I749cc58adb7de03c55d90527f1276368dc4996af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925739 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#719215}
-
Mia Glaese authored
Bug: 982018 Change-Id: If3abc60b1a7f911e76a655886979d572664c9abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930142Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#719214}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b71b5729688e..978d58b7ae4d Created with: gclient setdep -r src-internal@978d58b7ae4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5453e84b66f71a14e17fa1844c5b047148617256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936930Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719213}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bcda22bca456..b5a297f389e0 git log bcda22bca456..b5a297f389e0 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 vapier@chromium.org unittests: use 0.1.2.3 for device IPs 2019-11-26 vapier@chromium.org osutils: WriteFile: add automatic encoding support 2019-11-26 vapier@chromium.org cros_build_lib: align CommandResult with subprocess.CompletedProcess 2019-11-26 vapier@chromium.org cros_build_lib: align RunCommandError with subprocess.CalledProcessError 2019-11-26 vapier@chromium.org auto_updater_unittest: rework mocks 2019-11-26 vapier@chromium.org flash_unittest: rework mocks 2019-11-26 engeg@google.com chromium: Trivial cros lint fixes 2019-11-26 vapier@chromium.org cbuildbot_launch: get unittests passing under Python 3 2019-11-26 vapier@chromium.org release_stages: fix channel pickling 2019-11-26 vapier@chromium.org failure_message_lib: tweak dict usage for Python 3 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-26 jacobraz@google.com flash_ap: integrate ap flashing with cros commands. 2019-11-26 vapier@chromium.org flash: fix encoding handling of files/programs 2019-11-26 vapier@chromium.org config: delete all Chrome PFQ related builders 2019-11-25 vapier@chromium.org cros_sdk: fix download under Python 3 2019-11-25 vapier@chromium.org cros_sdk_unittest: rework skipping logic for python3 2019-11-25 vapier@chromium.org wrapper: inrease min python version to 3.5 2019-11-25 vapier@chromium.org vm_test_stages_unittest: fix mock return 2019-11-25 manojgupta@google.com config_lib: Fix Lab name mapping for ARM64 boards. 2019-11-25 vapier@chromium.org signer_payloads_client_unittest: fix mock typo Created with: gclient setdep -r src/third_party/chromite@b5a297f389e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If9bd826fb2add1208170133ec6c0f836ac03bd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936894Reviewed-by:
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I8656ee4a72e3da131e0e1a31c799fd6b697c7e1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929826 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#719211}
-
Kevin Ellis authored
PlayStateInternal is being phased out as it relies on an extended play state that includes a non-spec-compliant pending state. This patch cleans up the implementation of UnlimitedCurrentTimeInternal. The DCHECK code was previously used as a sanity check to ensure that an update to the timing calculations did not change the value of current time. This check is no longer being performed. The unlimited time may deviate from the current time for a finished animations since the hold time is not being used in the calculation when a start time is set and not paused. Bug: 960944 Change-Id: Ie8bd77b8cf770dc79fa65a08ed66c88fd6327c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933123 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#719210}
-
Daniel Rubery authored
This change isolates the core code for deep scanning into its own directory, and adds an OWNERS file for that directory. Change-Id: Ia7c1c04fba88628aed6303382f29297aa9139eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925451 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719209}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1da43bc4..5a069fea Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icabb70bea6250a52f82f98465c72edb03d6e1fb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936987Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719208}
-
David Roger authored
This is minor cleanup, to make the code clearer or remove small bits of dead code. Change-Id: Ibf5e2253988c8a5638e69a6ae7e99af0d00a1e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932548 Commit-Queue: Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719207}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fdaba6cf16f3..68c657298074 git log fdaba6cf16f3..68c657298074 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 ivoc@webrtc.org Add a CreateNetEq method that takes an AudioDecoderFactory Created with: gclient setdep -r src/third_party/webrtc@68c657298074 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I751a9185cd2c48f129521f5a6538d59a6853d794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936896Reviewed-by:
-
Eric Robinson authored
This CL adds a metric to determine the priorities of frames seen during the life of the RenderProcessHost. This can be either no frames seen, mixed priorities, only low, or only normal. This metric will be useful in determining which hosts remain low priority over their lifetime. While it's not an exact metric (it doesn't measure time spent with mixed/low/normal), it is expected that most processes in architectures with site isolation will have only low or only normal priorities attached to them in their lifetime. We also plan on going back and adding a more in-depth metric in the future. Bug: 1026606 Change-Id: I252505cfc5424fef151e6cfd90ba437000cd2683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924689 Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719205}
-
Vasilii Sukhanov authored
Bug: 1028095 Change-Id: I4f954414aa51f67f38185eca3df4595e0a8b77d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936255Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#719204}
-
Monica Basta authored
The profile info cache relies now on the AccountFetcherService to fetch the account info as well the account image. The AccountFetcherService downloads the image on signin or every 24 hours. The profile info cache used to rely on the profile_downloader to download 256 image while the AccountFetcherService used to download 64 image. The AccountFetcherService currently downloads 256 images but for existing profiles there is a delay of 24 hours until the image of size 256 is downloaded. To eliviate this case, the GaiaInfoUpdateService will do the following: (1) If the image's size is equal to |kAccountInfoImageSize|, it means it is a newly downloaded image either for a new signin event or a 24 hour refresh, so we should save it to the profile info cache. (2) Else, it means it is an old image and should not override the existing one. Bug: 1028328 Change-Id: I2c77b2bf803b60aa98b46a80649697707e223005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936313Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#719203}
-
John Abd-El-Malek authored
It keeps flaking, e.g. see https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97387 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97381 https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/97370 In the last 100 runs it has flaked 7 times. TBR=falken@chromium.org Bug: 868667 Change-Id: Ib0a809f85eb919ec098f7c80b8b47e2944e6a72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937127Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#719202}
-
Christopher Cameron authored
Restructure how shims connect to be as follows * (the shim process connects and creates an AppShimHostBootstrap) * OnShimProcessConnected is called with the bootstrap, and then split to two paths * OnShimProcessConnectedForLaunch if we should open a new window * (e.g, user clicked on the icon) * Use the AppShimRegistry to create a list of windows to open * Potentially-asynchronously load the profiles, and then * OnShimProcessConnectedForLaunch will go through those profiles and create new app windows for them * If the app shim is an "old" shim that specified a profile, then only open the specified profile * OnShimProcessConnectedForRegisterOnly if not * (e.g, Chrome created an app window on its own and we're starting the shim to display it in its own process) * Search for an existing AppShimHost to connect to * Create one if needed only because tests want this (that cleanup can come later) * OnShimProcessConnectedAndAllLaunchesDone is then called by both of the above branches. This function will * If the above-branch found or created an AppShimHost, then connect the bootstrap to it * Otherwise, tell the bootstrap that it should quit. The big difference in structure here is how we load profiles. Prior to this change, we - Had OnShimProcessConnected asynchronously load the list of profiles for which the app is installed - Then selected one profile, send it to LoadProfileAndApp, and only attached the shim to that one profile. By contrast, we now - Read profiles from the AppShimRegistry - Load all profiles we may want to launch via a chain of calls to LoadProfileAndApp TBR=dominickn Bug: 1001213 Change-Id: I4b4355cc79606fc33a6de926af00bce48c086100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928016Reviewed-by: -
Brian Salomon authored
Change-Id: I07d87ac4c414203a47d1d41ffdf7faefb6130711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935255 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by:
Brian Osman <brianosman@google.com> Auto-Submit: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#719200}
-
Sorin Jianu authored
That means handling the network errors by primarily looking at net_error. Bug: 1028369 Change-Id: I8181bced25f8b56144ea336a03883d0dceea5108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935428Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719199}
-
Sebastien Marchand authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1882203 https://chromium-review.googlesource.com/c/chromium/src/+/1898106 fixed the underlying issue and it should now be safe to land this. Original change's description: > [PM] Freeze Origin Trial - Remove the unknown state > > Most frames won't set a freeze origin trial policy and so making > kDefault the default state when a frame gets created will reduce the > number of IPC calls. This could cause pages to be frozen before all > their frames have reported their policy, a following CL will unfreeze > frozen pages that receive an opt-out OT token. > > Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637 > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708808} Change-Id: I15440c8f7d8f23584553f924ffc66051fc7cf713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933451Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#719198}
-
Andreas Haas authored
StaticBitmapImage returned 0 to indicate an invalid image size (e.g. integer overflow). This case was not handled properly by the caller. With this CL we add handling for the 0-case and throw an exception. R=jbroman@chromium.org Bug: chromium:1027522 Change-Id: I755ea7b3e9c50a73d20487397d9862f3ca67dd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932441 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719197}
-
Robert Sesek authored
Bug: 981129 Change-Id: I83d914dca778400f64fff340ea2872e8fbfe0834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929858Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719196}
-
