GitLab

This patch removes StyleBackgroundData.cpp, and moves all its contents
to be inline in StyleBackgroundData.h

This is prework for generating StyleBackgroundData.

BUG=628043

Review-Url: https://codereview.chromium.org/2860663002
Cr-Commit-Position: refs/heads/master@{#468937}

Blink recently went through a style guide change and renamed variables
and functions. However, comments were not updated. So when a comment
mentioned a variable or function, that comment became outdated.

This patch fixes comments inside Blink's image-decoders/.

BUG=717642

Review-Url: https://codereview.chromium.org/2856993002
Cr-Commit-Position: refs/heads/master@{#468936}

The browser already has all the defaults and ignores the returned pref
store connection so this is just wasting time at startup.

Bug: 654988
Change-Id: I05a6af935fd44f5ea9d37cef71e3acf3d782e4d4
Reviewed-on: https://chromium-review.googlesource.com/494407Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468935}

Revert of Roll googletest to 1.8.0. (patchset #3 id:40001 of https://codereview.chromium.org/2852613002/ )

Reason for revert:
Seems to have caused all content_browsertests on ChromiumOS to crash.

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25582

I'll run the revert through trybots so that it doesn't break anything else.

Original issue's description:
> Roll googletest to 1.8.0.
>
> This is a re-land of http://crrev.com/2779193002 which was reverted due to
> build errors on Mac.
>
> GoogleTest (gtest) and GoogleMock (gmock) are now hosted into the same
> googletest repository. In order to cope with this, the googletest
> repository is now sourced at third_party/googletest.
>
> The file/directory layout of Google Test is not yet considered stable.
> To minimize disruption while Google Test stabilizes, Chromium code will
> be insulated from third_party/googletest.
>
> * testing/gtest/include/gtest/ and testing/gmock/include/gmock have
>   been populated with headers that forward into the appropriate locations of
>   third_party/googletest
>
> * testing/BUILD.gn has been populated with the targets
>   //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main), which
>   depend on the appropriate //third_party/googletest targets.
>
> All Chromium code should keep depending on the targets and headers
> in testing/{gtest,gmock} for now.
>
> BUG=630705
> TESTED=ninja -C out/Default/ ced_unittests && ninja -C out/Default
> TBR=rkc,dpranke,agl
>
> Review-Url: https://codereview.chromium.org/2852613002
> Cr-Commit-Position: refs/heads/master@{#468860}
> Committed: https://chromium.googlesource.com/chromium/src/+/dbcef9bdc1edd32d62c6de0bd382cdc78ce385da

TBR=dpranke@chromium.org,thakis@chromium.org,rkc@chromium.org,agl@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630705

Review-Url: https://codereview.chromium.org/2856963003
Cr-Commit-Position: refs/heads/master@{#468934}

if OneGoogleBarOnLocalNtp is enabled.
This achieves two things:
- More robust if things change server-side
- Allows staging instances

BUG=583292

Review-Url: https://codereview.chromium.org/2856133002
Cr-Commit-Position: refs/heads/master@{#468933}

Headless chrome needs this information because we wish to know
which frames resources came from.

BUG=715541
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2830753004
Cr-Commit-Position: refs/heads/master@{#468932}

The "Delete this password" button gets a separate section. Before this CL it
shares the section with the password value (separate from username and site),
but the deletion affects the whole credential, so it should be separate.

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c40

BUG=159166

Review-Url: https://codereview.chromium.org/2722783003
Cr-Commit-Position: refs/heads/master@{#468931}

In order to serialise the state of the application, it is necessary
to track creation and destruction of WebStateLists. This is done
by adding a BrowserListObserver to track the creation of owning
Browsers.

BUG=710848

Review-Url: https://codereview.chromium.org/2831363002
Cr-Commit-Position: refs/heads/master@{#468930}

Currently PowerMonitorMessageBroadcasterTest is just an unit test for
PowerMonitorMessageBroadcaster class, this CL revises it to be a service
test:
 - Keep all the existing test cases verifying internal impl logic of
   PowerMonitorMessageBroadcaster.
 - In addition, verify that PowerMonitorBroadcastSource(in power monitor
   client library) can interact correctly with the
   PowerMonitorMessageBroadcaster instantiated inside a real Device Service
   instance.

BUG=715985
TEST=service_unittests

Review-Url: https://codereview.chromium.org/2857913002
Cr-Commit-Position: refs/heads/master@{#468929}

Review-Url: https://codereview.chromium.org/2855873002
Cr-Commit-Position: refs/heads/master@{#468928}

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c39

This also marks a lot of constants indeed as const in the unittest, and removes one leak (allocation of PasswordForm by new without calling delete on it).

BUG=159166

Review-Url: https://codereview.chromium.org/2722853003
Cr-Commit-Position: refs/heads/master@{#468927}

The tests:
virtual/stable/webexposed/element-instance-property-listing.html
virtual/stable/webexposed/global-interface-listing.html

are failing on all Blink bots.

NOTRY=True
TBR=alph@chromium.org,pfeldman@chromium.org
BUG=717914

Review-Url: https://codereview.chromium.org/2854213003
Cr-Commit-Position: refs/heads/master@{#468926}

R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2854913003
Cr-Commit-Position: refs/heads/master@{#468925}

Revert of [Identity Service] Add service tests of IdentityManager (patchset #1 id:1 of https://codereview.chromium.org/2854083002/ )

Reason for revert:
Causing compile failure, looks like race with CL that landed between bot runs and commit of this CL:

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder%2F83130%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

Original issue's description:
> [Identity Service] Add service tests of IdentityManager
>
> This CL adds service tests to test basic functionality of the implementation
> of identity_manager.mojom. Note that if/as service tests of other
> interfaces are added, the utility code that sets up the Identity Service
> can and should be split out of this test into a base class.
>
> BUG=683120
>
> Review-Url: https://codereview.chromium.org/2854083002
> Cr-Commit-Position: refs/heads/master@{#468921}
> Committed: https://chromium.googlesource.com/chromium/src/+/1a4c6321d2ab77267160bfb0297411e43d0daaab

TBR=rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=683120

Review-Url: https://codereview.chromium.org/2857103003
Cr-Commit-Position: refs/heads/master@{#468924}

BUG=656015

Review-Url: https://codereview.chromium.org/2816733002
Cr-Original-Commit-Position: refs/heads/master@{#468209}
Committed: https://chromium.googlesource.com/chromium/src/+/83c9f3f4faeb35a3a2607446def65f1a8da7aa49
Review-Url: https://codereview.chromium.org/2816733002
Cr-Commit-Position: refs/heads/master@{#468923}

This was a bug introduced in:

https://codereview.chromium.org/2848043002

BUG=717444

Review-Url: https://codereview.chromium.org/2854863002
Cr-Commit-Position: refs/heads/master@{#468922}

This CL adds service tests to test basic functionality of the implementation
of identity_manager.mojom. Note that if/as service tests of other
interfaces are added, the utility code that sets up the Identity Service
can and should be split out of this test into a base class.

BUG=683120

Review-Url: https://codereview.chromium.org/2854083002
Cr-Commit-Position: refs/heads/master@{#468921}

StyleDidChange set the first column position to the horizontal border
spacing value regardless of whether this value changed or not.

I am not familiar with how table layout works in Blink and haven't
debugged this extensively, but when we re-layout a table cell because
it has out-of-flow content which needs layout, the first effective
column position is set wrongly. It gets its initial value from the line
removed in this CL by a style recalc on the table element prior to the
re-layout, which is the h_spacing_, but the spacing is subtracted once
more in http://bit.ly/2pBB7x1

R=eae@chromium.org,mstensho@opera.com
BUG=716006

Review-Url: https://codereview.chromium.org/2855853002
Cr-Commit-Position: refs/heads/master@{#468920}

Design doc: go/jgdrc, screenshots https://crbug.com/159166#c38

BUG=159166

Review-Url: https://codereview.chromium.org/2719023005
Cr-Commit-Position: refs/heads/master@{#468919}

Currently, the accessibilityLabel for the CollectionViewTextCell is always
composed from the text and detailText attributes. Instead, if present,
accessibilityLabel on the item should be copied over to the cell.

BUG=717864

Review-Url: https://codereview.chromium.org/2856113002
Cr-Commit-Position: refs/heads/master@{#468918}

CL#2 Plumbs through snackbar manager from Infobar container to
TranslateCompactInfobar, and shows a snackbar on actions like
always / never translate.

BUG=713514
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2840933003
Cr-Commit-Position: refs/heads/master@{#468917}

This CL abstracts out much of the surface-switching logic from AVDA
into AndroidVideoSurfaceChooser.  It also handles talking to overlay
factories that will be provided by the renderer.

AndroidVideoSurfaceChooser notifies AVDA about when to transition to
/ from an overlay.  Currently, this is based only on whether the
renderer has provided an overlay factory or not.  In the future,
this will look at compositor feedback and other hints to decide.

This CL also adds lots of tests for this behavior.  Previously, it
wasn't easy to test surface transitions since (a) they were bundled
into AVDA itself, and (b) they directly depended on hard-to-mock
classes like ScopedJavaSurface.  Now, AndroidVideoSurfaceChooser
abstracts the logic, and AVDA no longer directly deals with any of
those hard-to-mock objects.

BUG=710204
TEST=AndroidVideoDecodeAcceleratorTest, AndroidVideoSurfaceChooserImplTest
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2813303003
Cr-Commit-Position: refs/heads/master@{#468916}

Revert of [Media Router] Custom Controls 3 - add plumbing through MRUI and MRWebUIMessageHandler (patchset #11 id:360001 of https://codereview.chromium.org/2731033002/ )

Reason for revert:
Breaks unit_tests on all OSes:

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/11182/steps/unit_tests%20on%20Windows-10-10586

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/38007/steps/unit_tests

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/40693/steps/unit_tests

Original issue's description:
> [Media Router] Custom Controls 3 - add plumbing through MRUI and
> MRWebUIMessageHandler
>
> When the route details view is opened, MediaRouterUI will instantiate an
> observer for the controller obtained via MediaRouter::GetRouteController().
> MediaRouterUI will send media commands (e.g. play/pause) to the controller
> through the reference held by the observer. The observer will be destroyed when
> the route details view is closed.
>
> MediaRouterWebUIMessageHandler will parse media commands from the WebUI and pass
> them on to MediaRouterUI. It will also forward status updates from the
> controller observer to the WebUI.
>
>
> The Chromium-side implementation of custom controls will be done in these
> patches:
> 1. Mojo/MediaStatus/MediaRouteController:     http://crrev/2727123002
> 2. MediaRouter::GetRouteController():         http://crrev/2728543009
> 3. MRUI/MRWebUIMessageHandler:                this patch
> 4. Custom controls WebUI:                     http://crrev/2725503002
>
> Custom controls design doc:
> https://docs.google.com/document/d/1_8QxdFIiiJX39jR1Wi1Zn9FW-Y66EMvX1GmQZvjN4G0/edit
>
> BUG=684638
>
> Review-Url: https://codereview.chromium.org/2731033002
> Cr-Commit-Position: refs/heads/master@{#468864}
> Committed: https://chromium.googlesource.com/chromium/src/+/e91ca334b8194bc324044057aa6b9f8bf898b1a7

TBR=mfoltz@chromium.org,imcheng@chromium.org,takumif@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=684638

Review-Url: https://codereview.chromium.org/2862513002
Cr-Commit-Position: refs/heads/master@{#468915}

StyleRareInheritedData contains a few members stored as RefPtr<> or
Persistent<>. To compare these members, we can't use == because that
performs a pointer comparison, so instead we use a helper method called
DataEquivalent that checks both the pointer and the data itself.

For some members, DataEquivalent is being used like this:

  DataEquivalent(foo.Get(), o.foo.Get())

However, DataEquivalent is overloaded for RefPtr and Persistent, so we
can do this instead:

  DataEquivalent(foo, o.foo)

This patch removes .Get() calls on DataEquivalent to take advantage of
the overloads.

BUG=628043

Review-Url: https://codereview.chromium.org/2852873002
Cr-Commit-Position: refs/heads/master@{#468914}

This CL adds keyboard navigation to the bookmark manager sidebar by
making only a single focus target for the sidebar which is changed by
keypresses.

BUG=692844
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2820153003
Cr-Commit-Position: refs/heads/master@{#468913}

This patch fixes the jinja templates to generate accessors for fields on
groups. It then uses the generated accessors in ComputedStyle.h

https://gist.github.com/nainar/f2816c46b990a49db3e2c3990cc9cdb1/revisions

BUG=710938

Review-Url: https://codereview.chromium.org/2855583002
Cr-Commit-Position: refs/heads/master@{#468912}

mash_session startup has been racing with the manual
content_packaged_services instance registration done by the browser
test framework. This can and almost always does cause the service
manager to launch a new browser process instance which in turn prevents
the test browser process from getting hooked up as a service instance.

This change ensures that a connection to mash_session is only initiated
after the test browser process is successfully launched and registered,
thus avoiding the race.

BUG=717028

Change-Id: I8240f2dab0aa9248b5065e597ae9cf8f2b140235
Reviewed-on: https://chromium-review.googlesource.com/493800
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468911}

This adds a basic integration test for saving on a test page, and also a test
for copy-password confirmation toast, which is not coverable by the unittests (yet).

BUG=159166

Review-Url: https://codereview.chromium.org/2846253002
Cr-Commit-Position: refs/heads/master@{#468910}

The interface taking a raw pointer is deprecated and being removed.

BUG=690937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2853663002
Cr-Commit-Position: refs/heads/master@{#468909}

BUG=none
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2852413002
Cr-Commit-Position: refs/heads/master@{#468908}

In StyleSurroundData, the border longhand properties are stored in a
single BorderData. This makes it difficult to generate because the
generator assumes that properties don't share storage.

This patch splits the LenthSize objects maintaining the border-*-radius
into individual properties stored directly on the surround group
instead.

Generated files diff here: https://gist.github.com/nainar/3192118aab7de3831137a4ae2cc73958/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2850173003
Cr-Commit-Position: refs/heads/master@{#468907}

use USVString for URLs instead of DOMString
at CSSURLImageValue.idl.

https://drafts.css-houdini.org/css-typed-om-1/#cssurlimagevalue
https://github.com/w3c/css-houdini-drafts/issues/244

BUG=545318

Review-Url: https://codereview.chromium.org/2858553002
Cr-Commit-Position: refs/heads/master@{#468906}

This patch:
- Removes its getters.
- Makes it inherit from RefCountedCopyable.
- Renames color_ to background_color

This is to set up for generating StyleBackgroundData.

BUG=628043

Review-Url: https://codereview.chromium.org/2854183003
Cr-Commit-Position: refs/heads/master@{#468905}

This CL rolls the instrumented libraries after the addition of
libgnutls26 in https://codereview.chromium.org/2851493005/

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_chromeos_msan_rel_ng
BUG=716118
R=eugenis@chromium.org

Review-Url: https://codereview.chromium.org/2847033002
Cr-Commit-Position: refs/heads/master@{#468904}

- Removes media-router+watch@
- Adds watchlists for cast_channel, dial, and presentation
- Updates watchlist for media_router

BUG=

Review-Url: https://codereview.chromium.org/2859583003
Cr-Commit-Position: refs/heads/master@{#468903}

This change removes the deprecated raw pointer version of
base::DictionaryValue::SetWithoutPathExpansion in //chrome and replaces
it with the unique pointer version or other convenience functions where
appropriate.

BUG=646113

Review-Url: https://codereview.chromium.org/2845113002
Cr-Commit-Position: refs/heads/master@{#468902}

This CL re-enables the ability to create start menu shortcuts from the
create shortcut view in chrome://apps which was disabled in Win8+
because Win8 shortcut creation doesn't work properly. Since things work
again in Win10, just exclude Win8.

BUG=717388

Review-Url: https://codereview.chromium.org/2851303005
Cr-Commit-Position: refs/heads/master@{#468901}

Network traffic annotation is added to network request of:
net/url_request/url_request_data_job_fuzzer.cc

BUG=656607

Review-Url: https://codereview.chromium.org/2851483002
Cr-Commit-Position: refs/heads/master@{#468900}

This CL makes battery impl be completely only part of the implementation
of the Device Service.
  - Moves //device/battery to //services/device/battery
  - Makes //services/device/battery visible in GN only to
    //services/device

BUG=684422
TBR=stevenjb@chromium.org, tsepez@chromium.org, boliu@chromium.org

Review-Url: https://codereview.chromium.org/2818673003
Cr-Commit-Position: refs/heads/master@{#468899}

The Isolate Extensions project/feature shipped on by default in M56.
This CL removes the support for disabling Isolate Extensions, which
includes field trial config, supporting code, command line parameter,
and tests that are no longer relevant.

BUG=545200
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2850793005
Cr-Commit-Position: refs/heads/master@{#468898}