GitLab

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/538403002

Cr-Commit-Position: refs/heads/master@{#293559}

After implementing this optimization I found that it had no
impact on performance. Changing the TODO into a comment in
case we need to revisit this in the future.

BUG=
TBR=vmpstr
NOTRY=true

Review URL: https://codereview.chromium.org/544863008

Cr-Commit-Position: refs/heads/master@{#293558}

password manager python tests.
Automatically wait for DOM element visibly at the beginning of
actions (click, submit) in the password manager python tests.

BUG=411325

Review URL: https://codereview.chromium.org/538403003

Cr-Commit-Position: refs/heads/master@{#293557}

R=estade@chromium.org
BUG=407979
TEST=visual
NOTRY=true

Review URL: https://codereview.chromium.org/500613004

Cr-Commit-Position: refs/heads/master@{#293556}

Reland: Issue 446203002: Initialize the now_function to the HighResNowWrapper in case High Res is supported

https://codereview.chromium.org/446203002/

The reland avoids using a static initializer for now_function, it initializes the function pointer on the first call instead.

I incorporated maruel@'s suggestions.

jam for
chrome/browser/
content/app/

willchan,maruel for
base/time/

BUG=400627
R=cpu@chromium.org, jam@chromium.org, maruel@chromium.org, thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a7c8e5e3411d6a3d32f4e1a61f8baa3e438fee52

Review URL: https://codereview.chromium.org/530293002

Cr-Commit-Position: refs/heads/master@{#293555}

This change pulls in the following changes:

7bdec13 Export pqueue functions.
c92c2d7 Prune some dead quirks and document the SSL_OP_ALL ones.
859ec3c Add SSL_CTX_set_keylog_bio.
1f20799 Fix ARM build with OPENSSL_NO_ASM.
df90a64 Remove MD5, SHA-224, and SHA-512 handling from s3_cbc.c.
39ebf53 Check the server did not use a TLS 1.2 cipher suite pre-TLS 1.2.
120a674 Fix the return values for most of SRTP.
5c24a1d Add a test for SSL_OP_TLS_D5_BUG.
f852599 Fix doc.config for header files being moved.
f0fd373 Remove remnants of EVP_CIPHER-based AES_GCM cipher.
8a5825e Don't export obj_dat.h.
b2cb0ec Fix minor issues found by Clang's analysis.
ed8270a Fix crash as server when resuming with SNI.
04dbb7f Add tests for pqueue

BUG=none

Review URL: https://codereview.chromium.org/540523002

Cr-Commit-Position: refs/heads/master@{#293554}

Review URL: https://codereview.chromium.org/520793002

Cr-Commit-Position: refs/heads/master@{#293553}

Causing intermittent tab crashes, blocking CQ.

BUG=411372
TBR=skyostil@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/548583002

Cr-Commit-Position: refs/heads/master@{#293552}

There is a race condition in the way that match rules get set up for object
proxies created in response to GetManagedObjects that may cause us the miss
PropertiesChanged signals if they're received before the match rule and filter
function get added by ObjectProxy.

This patch changes this to work the "intended" way: ObjectManager now adds a
single match rule for its corresponding service name, and specifically for the
org.freedesktop.DBus.Properties.PropertiesChanged signal. Once it receives the
signal, ObjectManager dispatches the signal to the corresponding PropertySet.

BUG=407109,400768
TEST=dbus_unittests

Review URL: https://codereview.chromium.org/510863002

Cr-Commit-Position: refs/heads/master@{#293551}

In the current code of Android Chromium we have scattered all the NavigationController functionalities inside ContentViewCore.
I have started to migrate the ownership to respective class for handling specific functionalities.

In this patch I have taken ownership of NavigationController functionalities to drop in NavaigationController classes.

BUG=398263
R=avi@chromium.org, boliu@chromium.org, nasko@chromium.org, yfriedman@chromium.org

Review URL: https://codereview.chromium.org/406023002

Patch from ajith.v  <ajith.v@samsung.com>
.

Cr-Commit-Position: refs/heads/master@{#293550}

BUG=407777
R=yoz@chromium.org, oshima@chromium.org, sky@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/535373002

Cr-Commit-Position: refs/heads/master@{#293549}

This causes ExtensionUpdater to scan the contents of
installed extensions prior to initiating update queries. If
any extensions are found with a _platform_specific
directory that does NOT contain a subdirectory which
corresponds to the current NaCl arch, that extension is
placed into forced-update mode.

An extension in forced-update mode will be treated as
version 0.0.0.0 when querying the update server.

BUG=409948

Review URL: https://codereview.chromium.org/540673002

Cr-Commit-Position: refs/heads/master@{#293548}

using TBR because Darin told me he defers to James' judgement. Using NOTRY because there is one presubmit error (dump_file_system.cc was moved and it spews printf).

BUG=338338
TBR=darin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/539143002

Cr-Commit-Position: refs/heads/master@{#293547}

The connection is only needed during sandbox warmup to initialize the default
color space. It was formerly needed by scrollbar NSAnimations, but that was
replaced via https://codereview.chromium.org/529103002/.

BUG=397642,306348
TEST=Manually tested on 10.6-10.10.
R=avi@chromium.org

Review URL: https://codereview.chromium.org/545603002

Cr-Commit-Position: refs/heads/master@{#293546}

This patch adds support for zoom open pdf parameter. If user
opens pdf with zoom parameter in url then pdf should be opened
at zoom level mentioned by user.

BUG=64309, 319910

Review URL: https://codereview.chromium.org/420063002

Cr-Commit-Position: refs/heads/master@{#293545}

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #4 id:60001 of https://codereview.chromium.org/504823003/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=411330

Original issue's description:
> Try backing SkPicture with SkRecord in Chromium.
>
> This is our first attempt, mostly to feel this out.  Performance and
> correctness problems are both possible.  Please revert this if a benchmark even
> smells funny.
>
> That said, we've been working on this a while, are pretty confident it's good
> stuff, and have had Skia's internal testing entirely switched over for a week.
> Parts of Chromium that serialize and deserialize SkPictures are already
> switched over.  This CL finishes things off by switching the default
> recorded-from-scratch SkPicture to use SkRecord too.
>
> BUG=408985,409110,409138,411330
>
> Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c
>
> Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30
>
> CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan
>
> Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58
>
> Committed: https://chromium.googlesource.com/chromium/src/+/96730ee0419e528d8d3eac360e9319a871d20e43

TBR=reed@google.com,mtklein@google.com,senorblanco@chromium.org,eroman@chromium.org,fmalita@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408985,409110,409138,411330

Review URL: https://codereview.chromium.org/544263002

Cr-Commit-Position: refs/heads/master@{#293544}

BUG=306341
NOTRY=True

Review URL: https://codereview.chromium.org/532903002

Cr-Commit-Position: refs/heads/master@{#293543}

This reverts commit 5dde0685.

Broke a bunch of builds:

FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/sync/internal_api/attachments/sync_core.attachment_service_proxy.o.d -DSYNC_IMPLEMENTATION -DCHROMIUM_BUILD -DENABLE_NOTIFICATIONS -DENABLE_EGLIMAGE=1 -DENABLE_BACKGROUND=1 -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1 -DENABLE_FULL_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1 -DUSE_X11=1 -DUSE_XI2_MT=2 -DDISABLE_NACL -DENABLE_EXTENSIONS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_REMOTING=1 -DENABLE_GOOGLE_NOW=1 -DENABLE_ONE_CLICK_SIGNIN -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -I../.. -Igen -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../net/third_party/nss/ssl -I/usr/include/nss -I/usr/include/nspr -I../../third_party/zlib -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/protobuf -fno-strict-aliasing -fstack-protector --param=ssp-buffer-size=4 -m64 -funwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -Wall -Wsign-compare -Wendif-labels -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-char-subscripts -Wno-covered-switch-default -Wno-deprecated-register -Wno-unused-function -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -fno-ident -fdata-sections -ffunction-sections -O2 -g2 -Wexit-time-destructors -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c ../../sync/internal_api/attachments/attachment_service_proxy.cc -o obj/sync/internal_api/attachments/sync_core.attachment_service_proxy.o
../../sync/internal_api/attachments/attachment_service_proxy.cc:96:3: error: invalid argument type 'scoped_refptr<base::SequencedTaskRunner>' to unary expression
  DCHECK(wrapped_task_runner_);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../base/logging.h:622:51: note: expanded from macro 'DCHECK'
  LAZY_STREAM(LOG_STREAM(DCHECK), DCHECK_IS_ON && !(condition))   \
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
../../base/logging.h:355:5: note: expanded from macro 'LAZY_STREAM'
  !(condition) ? (void) 0 : ::logging::LogMessageVoidify() & (stream)
    ^
1 error generated.
ninja: build stopped: subcommand failed.

BUG=none
TBR=maniscalco

Review URL: https://codereview.chromium.org/546873003

Cr-Commit-Position: refs/heads/master@{#293542}

It lives in src/extensions now, but has src/chrome dependencies and tests
code implemented in src/chrome. Attempting to refactor it to split out the
src/chrome dependencies just made a mess of the code. Since it tests Chrome
concepts, put it there.

BUG=397164
TEST=unit_tests

Review URL: https://codereview.chromium.org/546633003

Cr-Commit-Position: refs/heads/master@{#293541}

Fixes several clang/win errors like
..\..\sandbox\win\sandbox_poc\pocdll\registry.cc(24,10) :  error(clang): value of type 'HKEY' (aka 'HKEY__ *') is not implicitly convertible to 'LONG_PTR' (aka 'long')
    case HKEY_USERS:
         ^~~~~~~~~~

Also fix a format string warning while here.

No intended behavior change.
BUG=82385

Review URL: https://codereview.chromium.org/542863002

Cr-Commit-Position: refs/heads/master@{#293540}

Deprecation messages are added in:
* getChannelId function - displayed to console
* documentation of chrome.pushMessaging/GCM for Chrome V1

BUG=403952

Review URL: https://codereview.chromium.org/476883003

Cr-Commit-Position: refs/heads/master@{#293539}

https://skia.googlesource.com/skia/+log/7675fb23a0448448662567bf1d100e39bf7b5e65..a1ae66d252edf6da932caed1fe43d11216e56c0e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/543083002

Cr-Commit-Position: refs/heads/master@{#293538}

Since '\0' delimited concatenation of header field values is not allowed any
more in HTTP/2 draft-14, but servers might prepare such headers, the HPACK
encoder should split them into multiple headers with identical names.

This lands server change 74384948 by bnc.

BUG=400336

Review URL: https://codereview.chromium.org/533073004

Cr-Commit-Position: refs/heads/master@{#293537}

This change is lays groundwork for making attachment upload operations
persistent.

Make GenericChangeProcessor responsible for writing attachments to the
AttachmentStore and calling UploadAttachments.  In a future CL, datatype
code will be responsible for writing attachments to the store.

Queue up attachments for upload inside of AttachmentService.  In a
future CL we'll add rate limiting, retry, and back-off logic.

Expose AttachmentService's AttachmentStore via GetStore method.

BUG=

Review URL: https://codereview.chromium.org/512413003

Cr-Commit-Position: refs/heads/master@{#293536}

The Lock and Guest functions currently try to close all browser windows for their profiles, and any OnBeforeUnload dialogs can cause that closing to fail. This CL takes inspiration from the BrowserCloseManager that is used when an entire browser window is closed.

Methods are added to BrowserList that will trigger all OnBeforeUpload handlers, wait for the user's response, and then close the profile's browsers and perform an appropriate success callback. A abort callback is permitted and will be used when ProfileDeletion also uses this flow.

Guest and Lock will now only open the User Manager (and lock the profile, for Lock) if no OnBeforeUnload event is canceled.

BUG=368497, 289390
TEST=Open a guest profile. Navigate to http://www.4guysfromrolla.com/demos/OnBeforeUnloadDemo1.htm. Click "Exit Guest" in the User Menu. Select "Stay on this page". The window should stay open and the User Manager should not be shown.
Open a signed-in and lockable profile. Navigate to the above URL. Lock the profile from the User Menu. Select "Stay on this page". The User Manager should not be shown. Manually opening the User Manager should show that the Profile has not been locked.

Review URL: https://codereview.chromium.org/471763008

Cr-Commit-Position: refs/heads/master@{#293535}

Treat a header block with a pseudo-header field following a regular one as
malformed, as required by HTTP/2 draft-14 Section 8.1.2.1.

This lands server change 74067938 by bnc.

BUG=400336

Review URL: https://codereview.chromium.org/531253004

Cr-Commit-Position: refs/heads/master@{#293534}

BUG=352654

Review URL: https://codereview.chromium.org/547653002

Cr-Commit-Position: refs/heads/master@{#293533}

It should be refreshed but it was not by bug. This patch fixes this.

BUG=none
TEST=manual
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/543103002

Cr-Commit-Position: refs/heads/master@{#293532}

depends on blink CL https://codereview.chromium.org/540033002/

TBR=jochen

Review URL: https://codereview.chromium.org/545513002

Cr-Commit-Position: refs/heads/master@{#293531}

The parentheses were wrong previously in this if-statement:
if ((wcsstr(str_ptr, L"(VFW)") == NULL) &&
     lstrlenW(str_ptr) < name_length ||
    (!(LowerCaseEqualsASCII(str_ptr, str_ptr + name_length,
                                   kGoogleCameraAdapter))))
The condition lstrlenW(str_ptr) < name_length should be grouped with the condition LowerCaseEqualsASCII(...), not wcsstr(str_ptr, L"(VFW)") == NULL.

The check lstrlenW(str_ptr) < name_length is redundant, so I removed it.

Review URL: https://codereview.chromium.org/541603002

Cr-Commit-Position: refs/heads/master@{#293530}

BUG=405449
TEST=Forced WebRtcAudioCapturer::Initialize() to return false and verified log.

Review URL: https://codereview.chromium.org/545203002

Cr-Commit-Position: refs/heads/master@{#293529}

1. Add retry to http_client.
2. Make Findit more robust for unrecognized chromium revision.
3. Workaround a harmless bug in python 2.7
4. Give a better error message for check failure.

NOTRY=true

Review URL: https://codereview.chromium.org/538383002

Cr-Commit-Position: refs/heads/master@{#293528}

BUG=410446
TEST=manual. launch webstore app from home card.

Review URL: https://codereview.chromium.org/544813002

Cr-Commit-Position: refs/heads/master@{#293527}

TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/544173002

Cr-Commit-Position: refs/heads/master@{#293526}

Chromium is only using a Service Provider, and not an Application. Moreover
chromium should only depends on mojo_base.gyp, not mojo.gyp.

R=darin@chromium.org,davemoore@chromium.org,blundel@chromium.org

Review URL: https://codereview.chromium.org/531513003

Cr-Commit-Position: refs/heads/master@{#293525}

The code that copies cookies set by a SAML IdP on subsequent logins is
wrong as it uses a method which modifies the cookie being copied by
prepending a dot to the domain name. This CL fixes the problem by
switching to the method that is used during initial login. The method
is also renamed to make it clearer that it may be used on subsequent
logins too.

BUG=410416
TEST=unit_tests updated to detect this problem

TBR=dbeam (wallet_signin_helper_unittest.cc)

Review URL: https://codereview.chromium.org/538543003

Cr-Commit-Position: refs/heads/master@{#293524}

BUG=410891
TBR=henrika
NOTRY=true

Review URL: https://codereview.chromium.org/542173002

Cr-Commit-Position: refs/heads/master@{#293523}

NWVM was using the ScopedCaptureClient to attach a capture controller. The problem with this is that the window manager already made one, and there is only one capture controller when you use SCC and this was screwing with event dispatch as coordinate systems between the different root windows were different (not sure this is a condition we've ever really designed for in aura). Anyway. Made NWVM use DefaultCaptureClient directly.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/541013002

Cr-Commit-Position: refs/heads/master@{#293522}

Review URL: https://codereview.chromium.org/536533004

Cr-Commit-Position: refs/heads/master@{#293521}

BUG=380349

Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822

Review URL: https://codereview.chromium.org/479873002

Cr-Commit-Position: refs/heads/master@{#293520}