GitLab

BUG=118301
TEST=no segfaults


Review URL: http://codereview.chromium.org/9705042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=117418
TEST=none


Review URL: http://codereview.chromium.org/9701038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126929 0039d316-1c4b-4281-b951-d872f2087c98

Remove the experimental support for MAC cookies, as defined in
http://tools.ietf.org/html/draft-hammer-oauth-v2-mac-token . Support
for strongly-bound cookies will be provided by support for TLS
channel-bound cookies, as defined in
http://tools.ietf.org/html/draft-balfanz-tls-obc

BUG=none
TEST=none
R=abarth@chromium.org


Review URL: http://codereview.chromium.org/9700056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114288
TEST=ProtectedPrefsWatcherTest.*; no user-visible changes

Review URL: http://codereview.chromium.org/9620010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126927 0039d316-1c4b-4281-b951-d872f2087c98

Remove tab_contents_view_gtk.h include from chrome. I tried to find a way to not have to expose the FocusStore to the delegate, but I couldn't find any other way.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9705053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126926 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113089
TEST=about:gpu page
Review URL: https://chromiumcodereview.appspot.com/9706037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126925 0039d316-1c4b-4281-b951-d872f2087c98

This prevents the re-enable prompt (and/or long app/extension names) from making
the dialog too wide.

BUG=118279

Review URL: http://codereview.chromium.org/9700043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126924 0039d316-1c4b-4281-b951-d872f2087c98

Retry landing "Enable users change desktop background image from settings page in Chromeos Aura build"

Enable user change background image in settings page in Aura build.

Only support change between default background images currently.

This is a second try to land, last time it fails on win_aura build.
The original CL is here: http://codereview.chromium.org/9580023/

TBR=flackr,ben,jhawkins
BUG=105508
TEST=Go to settings page and click "set wallpaper" button to change background image.

Review URL: https://chromiumcodereview.appspot.com/9703031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126923 0039d316-1c4b-4281-b951-d872f2087c98

1) Got an upstream diff 411:412 from svn
2) Applied
3) Modified protobuf.gyp to make it platform independent thanks to the new
   guards added in atomicops_internals_x86_gcc.cc and
   atomicops_internals_x86_msvc.cc.
   Note that the previous change adding atomicops added a significant
   complexity to protobuf.gyp to handle platform-specific source files. Because
   it was using target_arch only, it did not even work properly. Indeed
   protobuf_lite needs to deal with the host architecture when it is built to
   be used by protoc.


Review URL: http://codereview.chromium.org/9706016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126922 0039d316-1c4b-4281-b951-d872f2087c98

Add a call to WebWidget::instrumentBeginFrame() in
RenderWiddget::doDeferredUpdate() so DevTools can mark
frames on timeline.

Related issue upstream:
https://bugs.webkit.org/show_bug.cgi?id=80127

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9592006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126921 0039d316-1c4b-4281-b951-d872f2087c98

File manager updated commands availablility before roots loaded. Handling code exxpects a nonempty list that cause an exception.

BUG=None.
TEST=Check DevTools log.


Review URL: http://codereview.chromium.org/9705058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126920 0039d316-1c4b-4281-b951-d872f2087c98

XIB changes:
* Change ExtensionInstalledBubbleController to have BaseBubbleController as a 
  parent class.
* Set the bubble_ outlet on the new base class and delete infoBubbleView_.

BUG=36366
TEST=Install an extension with a browser action. Bubble appears at browser action and behaves as before.
TEST=Install bundled extensions and make sure the bubble appears at the wrench menu.
TEST=Install an omnibox keyword extension and bubble appears at the lock icon.

Review URL: http://codereview.chromium.org/9705038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126919 0039d316-1c4b-4281-b951-d872f2087c98

https://chromiumcodereview.appspot.com/9689047/

with fix to allow for special conditions under test
BUG=115650
TEST=LauncherUpdaterTest.*
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/9702072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126917 0039d316-1c4b-4281-b951-d872f2087c98

Member variables was renamed. It should clear up the logic.

BUG=None
TEST=focus doesn't get stolen from pod; gaia prompt is focused on "add user"


Review URL: http://codereview.chromium.org/9617003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126916 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126915 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9704053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126914 0039d316-1c4b-4281-b951-d872f2087c98

This was added back when we were using a 32bit linker, as a manual hint
to ld. Now that webcore is split up and we use a 64bit linker, it's no longer
necessary.

It also breaks the component build, which relies on everything just depending
on libwebkit.dylib.

BUG=43791,90078
TEST=things still build
TBR=mark

Review URL: http://codereview.chromium.org/9700055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126913 0039d316-1c4b-4281-b951-d872f2087c98

For now, the notification only shows the message "This device is managed
by xyz.com." In the future, we will include a "Learn more" link, and a
message about device status reporting if it is enabled.

BUG=chromium-os:26625
TEST=Manual. Test that the butter bar appears on the login screen on
a previously-enrolled device, and immediately after enrolling.

Review URL: https://chromiumcodereview.appspot.com/9416097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126912 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36366
TEST=Everything about extensions works as before.

Review URL: http://codereview.chromium.org/9699045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9708002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126910 0039d316-1c4b-4281-b951-d872f2087c98

BUG=118319
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9703063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116213
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9705039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126908 0039d316-1c4b-4281-b951-d872f2087c98

There were some places that we didn't catch with
https://chromiumcodereview.appspot.com/9447086/

BUG=117407
TEST=

Review URL: https://chromiumcodereview.appspot.com/9695038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126907 0039d316-1c4b-4281-b951-d872f2087c98

This CL ensures that a valid profile image is set when a demo user
logs in. Additionally, the code paths taken by UserManager::LoggedIn()
for the different classes of users are cleaned up a bit.

BUG=chromium-os:27645
TEST=unittest UserManagerTest*
TEST=manual login test in a Chromium OS VM


Review URL: http://codereview.chromium.org/9703022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126906 0039d316-1c4b-4281-b951-d872f2087c98

Also handle unselecting the current selection when the Find dialog is dismissed.

BUG=112193
TEST=Open the find dialog in CF, search for the same string twice.


Review URL: http://codereview.chromium.org/9700053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113771
TBR=bradchen
Review URL: https://chromiumcodereview.appspot.com/9700057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126902 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa
BUG=118387
Review URL: https://chromiumcodereview.appspot.com/9705059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126901 0039d316-1c4b-4281-b951-d872f2087c98

This patch is trying to revive some of the behavior that the Audio Player had in the old panel manager, specifically it puts it in the lower right corner of the screen.

This is likely to be a temporary solution.

BUG=chromium-os:27701
TEST=


Review URL: http://codereview.chromium.org/9704052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92608
TEST=


Review URL: http://codereview.chromium.org/9203001

TBR=keishi@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126899 0039d316-1c4b-4281-b951-d872f2087c98

New stuff:
* ObjC number, array, dict literals
* ASan fixes, visibility fixes (see bugs)
* (c++11: User-defined literals)
* -Wstring-plus-int

BUG=114996,112539
TEST=none

Review URL: http://codereview.chromium.org/9703027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126898 0039d316-1c4b-4281-b951-d872f2087c98

Test=Manual
Bug=None
TBR=zmo

Review URL: https://chromiumcodereview.appspot.com/9706039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126897 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27837
TEST=ran try


Review URL: http://codereview.chromium.org/9699067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126896 0039d316-1c4b-4281-b951-d872f2087c98

BUG=30704,118384
TBR=dhollowa
Review URL: https://chromiumcodereview.appspot.com/9702069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126895 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126893 0039d316-1c4b-4281-b951-d872f2087c98

TBR=abarth

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9699066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126892 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9700011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126891 0039d316-1c4b-4281-b951-d872f2087c98

I found a need to look at the implementation to confirm that process_handle would never be assigned to if the call failed. So I added a comment for future readers.

While doing so, I found an edge case where I think the process handle could be leaked.

BUG=None
TEST=Ask a random developer whether they must check process_handle if LaunchProcess returns false. If they look at process_util_*.cc, fail.


Review URL: http://codereview.chromium.org/9689081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126890 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92608
TEST=


Review URL: http://codereview.chromium.org/9203001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126889 0039d316-1c4b-4281-b951-d872f2087c98

So it can self-destruct if Chrome (or Chrome Frame) was the last Omaha-managed product on the system.

BUG=114786
TEST=Install Google Update 1.3.21.105 or later and Chrome w/ --verbose-logging.  Uninstall Chrome and see that Google Update vanishes immediately.  Take a look at chrome_installer.log and look for messages related to Launching Google Update's uninstaller.


Review URL: http://codereview.chromium.org/9693055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126888 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126887 0039d316-1c4b-4281-b951-d872f2087c98