- 16 May, 2019 40 commits
-
-
Maksim Ivanov authored
Remove the "continueUrl" parameter from the cr.login.Authenticator's load() method, and remove associated code. This parameter has been unused since crrev.com/c/1605419. Bug: 470893 Test: existing tests, manual test: checking that OOBE enrollment, OOBE login, adding a new user on Chrome OS and desktop platforms work Change-Id: Ic6dfd663f22fc792fe6da2c7102f0f2548b769e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604274Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#660619}
-
Cathy Li authored
Also make sure that "All apps" icon is in the center when there are no other tiles. Bug: 962749 Change-Id: If8032326baa0a5747af1d9c6380a8e7b3b4969a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614626Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#660618}
-
liberato@chromium.org authored
In preparation for adding a pool of SharedImages, this CL moves most parts of VideoFrame creation to the MCVD thread. There aren't supposed to be any functional changes. The only thing that might differ slightly is that a scoped refptr to |texture_owner| is now being sent MCVD => GPU => MCVD thread, while before it was going MCVD => GPU only. While TextureOwner is DeleteOnSequence, so it's okay to drop it on any thread, the small change in lifetime might do something because threads are weird. Otherwise, almost everything is identical, just refactored. Change-Id: Ia0f5ecf393a886e8bc1a0572cbe494f26a9a236b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612600 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#660617}
-
Robert Liao authored
This allows ObserverList checking for ComboboxModel subclasses, which have also been updated. BUG=963982 Change-Id: Idc3b8a853261a1afd8f0c9132d34d1a681b10204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614756Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660616}
-
Victor Costan authored
All the necessary data has been collected. This CL undoes the parts of https://crrev.com/c/1180530 and https://crrev.com/c/1183786 that were not general code health improvements. Bug: 875538 Change-Id: Ibd604c69996072db71c47b18b99f79962f389c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612266 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#660615}
-
Wez authored
This test sometimes hangs on Fuchsia, so add diagnostics to show us where. Bug: 959245 Change-Id: Id09d68d089fcf7eac1fbe6b2fe760767ad337c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614707 Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#660614}
-
Lukasz Anforowicz authored
kEnforceRequestInitiatorLockForCorb has been enabled by default since 73.0.3661.0 and there are no known issues associated with this feature. SiteIsolation.XSD.NetworkService.InitiatorLockCompatibility metric shows that kBlockingWhenIncorrectLock is encountered in practice, but only for 0.01% of requests. Bug: 871827 Change-Id: I46d5eea647bde5408482cb21441e260df83a78e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612357Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#660613}
-
Mounir Lamouri authored
This is a reland of c097ed0a Original change's description: > Picture-in-Picture: implement OnStopped() in session observer. > > This is removing the latest IPC for Picture-in-Picture and solves one bug that > had the element not notified of the Picture-in-Picture state change if the > window was closed after the src was reset and therefore the media player wasn't > able to get the IPC. > > Bug: 919860, 940694 > Change-Id: I3f2badd7724fc9037d360bf88fb22adc3b7f14a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611509 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659655} TBR=dcheng@chromium.org,dalecurtis@chromium.org Bug: 919860, 940694 Change-Id: Ie503d9a1ed2bbbaf0b2502d827c6922aef574054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613368Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#660612}
-
Ryan Hamilton authored
Change-Id: Iae28c97538f406f27d44181ba280d995e8d276c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615833 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#660611}
-
Bo Liu authored
Low rank connections often rebind because their group or importance in group needs to be updated. This means the low rank group is often considered the most recently used by activity manager. This however is the exact opposite of desired behavior though. Instead, add a rebind method and rebind high rank connections, with a delay, after group is updated. Bug: 946216 Change-Id: I5c3ad1c07083daceab37bc3ec14e2450480cbc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606184Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#660610}
-
Alexander Alekseev authored
This Cl fixes regression added in https://crrev.com/c/1554042 moving DISPLAY_TYPE enum back to global space. Bug: 952223 Change-Id: If7dde9e34b18d282e2c258a69d107c7edb7951a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614108Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#660609}
-
Peter K. Lee authored
This adds a delegate method to ContentSuggestionsHeaderViewControllerDelegate protocol specify how user's avatar image would be processed. New Tab Page uses this delegate method to add/update the avatar for the current user's identity and display at the top right corner of NTP. Bug: 961120 Change-Id: I19abd5eab02481214a605de4b6321aa9a22ea79f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612091Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#660608}
-
Brandon Wylie authored
Bug: 954404 Change-Id: I76c44b4cca9f8c442de4ac2c0a1154cb8e2938dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610598 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#660607}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ea05691e76b6..a2e4f03e8e6a git log ea05691e76b6..a2e4f03e8e6a --date=short --no-merges --format='%ad %ae %s' 2019-05-16 crouleau@chromium.org [Telemetry] Save shard index in test results JSON. Created with: gclient setdep -r src/third_party/catapult@a2e4f03e8e6a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:960951 TBR=simonhatch@google.com Change-Id: I2a96855cbac186d91922d9d27bae9d8e973c0750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615878Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660606}
-
Christopher Cameron authored
The FormControlsRefresh feature will make macOS use the Aura theme (and the refresh theme, where it is implemented). Add a runtime feature, FormControlsRefresh, to control this in blink. Update and dedupe tests. TBR=pbr,avi Bug: 846357, 956778 Change-Id: If274aab5b5ac2169758e50d12c27d8772263b45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613755Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660605}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3df392d69c9..0391cd9d0f6b git log c3df392d69c9..0391cd9d0f6b --date=short --no-merges --format='%ad %ae %s' 2019-05-16 evanhernandez@chromium.org tree_status: Move health alerting to lib/alerts Created with: gclient setdep -r src/third_party/chromite@0391cd9d0f6b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I9c056f97d9b6552331d4d35350cb26574fc84244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614251Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660604}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6cf65f671c1d..ab1e2b49fe88 git log 6cf65f671c1d..ab1e2b49fe88 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 chrisforbes@google.com Unbreak some synchronization edge cases Created with: gclient setdep -r src/third_party/swiftshader@ab1e2b49fe88 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132897411 TBR=swiftshader-team+autoroll@google.com Change-Id: I200aab9d2c2a4f8f9c47adf93992322f303cb2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660603}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/04e389d15481..aefbea29626b git log 04e389d15481..aefbea29626b --date=short --no-merges --format='%ad %ae %s' 2019-05-16 jmadill@chromium.org Fix Clang warning in dEQP-KHR tests. 2019-05-16 syoussefi@chromium.org Add a note regarding RenderDoc+Android+Vulkan+dEQP 2019-05-16 jmadill@chromium.org Add KHR-GLES dEQP tests. Created with: gclient setdep -r src/third_party/angle@aefbea29626b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I0bdd0e86a5fdb5ca6cc99dcd997f4e3befda0ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614527Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660602}
-
Scott Violet authored
There was still some random code in ash depending on services/ws. This removes most of it (some constants are still used and need to be moved out of mojoms). BUG=960503 TEST=none Change-Id: I32dcc593bd1f680fc39fbbee45840b08903bfa29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615642Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#660601}
-
Caitlin Fischer authored
When the use improved label disambiguation desktop experiment is enabled and profile suggestions are available, the assumption is that this will not--or will very rarely--happen. However, bizarrely-structured forms exist, so it is not impossible that the experiment is enabled, suggestions are available, and a formatter failed to create them. This logging is a sanity check to verify that this rarely happens. Screenshot of chrome://histograms https://screenshot.googleplex.com/OTSdHFUKmmM Bug: 961334 Change-Id: I471e9c6078f11d46a972eaa2486d43b14830124f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603242Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#660600}
-
Daniel Libby authored
This reverts commit ad9e4dc5. Reason for revert: reverting original change this one built on, due to regressions Original change's description: > Add device parameter to scroll injection API > > The newly introduced mechanism for injecting scroll gestures on the > main thread can also be extended to be used for keyboard scrolls. > However, we don't want these to show up as scrollbar scrolls (which the > API currently is hardcoded to assume). > > Instead pass the WebGestureDevice along with the injection request. > > Bug: 954007 > > Change-Id: If550d39158bc6a161d17ca18733b0ac94b850ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600483 > Commit-Queue: Daniel Libby <dlibby@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660193} TBR=dcheng@chromium.org,bokan@chromium.org,dlibby@microsoft.com Change-Id: Ib5518ba3d67b6c08978dac12fc5e64b89f48948a Bug: 954007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615676 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#660599}
-
Archana Simha authored
The keycode for CTRL+V is needed to simulate a paste event to test whether PhishGuard captures passwords when the users pastes their password (https://chromium-review.googlesource.com/c/chromium/src/+/1576118) Change-Id: I92b7c669232a95f29f4ae26773524e9675936f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593031 Commit-Queue: Archana Simha <archanasimha@google.com> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#660598}
-
Vlad Tsyrklevich authored
Land field trial for GWP-ASan PartitionAlloc support now that it's been enabled on canary/dev. Bug: 960532 Change-Id: Ide91a31547894edfbb5ba796f768deae88134ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614024 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#660597}
-
Darren Shen authored
New expiry at end of the year. Bug: 960093 Change-Id: Iad8ab4a45e9dc62beaa2a8c3e4868591bc50d685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607712 Auto-Submit: Darren Shen <shend@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#660596}
-
Devlin Cronin authored
The original CL forgot to add a scoped channel override, which is necessary since the "action" key is restricted to trunk. Make a common utility method for creating it for the ActionInfo::TYPE_ACTION action type, and use it in ExtensionActionManagerTest and MultiActionAPITest. Bug: 963832 Change-Id: Id2605dcff67fdd59d8e07d6722f8bf4ae79e529d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615621 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#660595}
-
Tommy C. Li authored
For historic reasons, ZeroSuggestProvider is configured via a field trial param "ZeroSuggestVariant" that hangs off of a fixed field trial name: "OmniboxBundledExperimentV1". This CL migrates to using a "ZeroSuggestVariant" param that hangs off a new base::Feature called "OmniboxOnFocusSuggestions". This feature is Enabled by default. It's not really meant to be disabled, just a place to store the variant parameter. This has two main advantages: 1) Can configure ZeroSuggestProvider outside of the bundled experiment. 2) Can potentially change the mode with a multi-value option using chrome://flags. Bug: 963173 Change-Id: Ib3bbb2bb352017c0e70e03c30a96ca58ba736825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612401Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#660594}
-
Cliff Smolinsky authored
According to the owner of the VirtualDesktopManager, it is incorrect to assume that VirtualDesktopManager will always be available, even on Win10. The virtual desktop stuff is always best-effort and the browser should not crash if retrieving the manager fails. Bug: 963189 Change-Id: Icf8a0c8e7c4b4a6528772f79edb4b1eccbb30d9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612119Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#660593}
-
Caitlin Fischer authored
Bug: 963157 Change-Id: I756625c263bc92297ad5341188d4797955a59776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612222Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#660592}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6901330cf32a..67c4781f205b Created with: gclient setdep -r src-internal@67c4781f205b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: I62690ac51d1fb9d41fb5586e06fabd6494d60f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614529Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660591}
-
Becky Zhou authored
Temporarily fix the tint (for M-75) by explicitly defining AppCompatImageView in XML, because the XML is somehow inflated as ImageView instead of AppCompatImageView after some version in M-75 or M-76. Bug: 939681 Change-Id: Id826eae247a5685435aa9b3d0b1293609d298f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614768Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#660590}
-
Kyle Milka authored
Screenshot: http://screen/1VdOUYaAkz9 Bug: 939274 Change-Id: I0a459c273121061f8ad4a7e881ed8c9acd67230b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613753Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#660589}
-
Peter K. Lee authored
This allows more reuse of this class in cases where UI calls for avatars resized to different size. Change-Id: Ifeacb85292972cbf8d82f1fa591f541e0025ec95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614089 Commit-Queue: Peter Lee <pkl@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#660588}
-
Tommy C. Li authored
This CL makes a base::Feature based equivalent to GetValueForRuleInContext. We do this because in the near future, we want to be able to use our page-context based rules system without necessarily being tied to the bundled field trial. A followup CL will migrate the ZeroSuggestProvider to use GetValueForRuleInContextByFeature for the ZeroSuggestVariant parameter. Bug: 963173 Change-Id: I00ae9cb8507b34d386fffd67dc447d5a3f0c61d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613791 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#660587}
-
Robert Ma authored
TBR=ortuno Bug: 805756 Change-Id: I02a6c506c014b287cf9dc9a4255269179c43b899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615981Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#660586}
-
Eric Roman authored
Bug: 959020 Change-Id: Ib3d1d9c068bb36bf6f9ec43ca3ed211324d03e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613746 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#660585}
-
Ehsan Karamad authored
With MimeHandlerViewInCrossProcessFrame the input should directly be routed to the guest WebContents and not the embedder. Bug: 961786 Change-Id: Ie44d09e7412d56686212c68f94ad7ded64c23258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615488 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#660584}
-
Eric Roman authored
Bug: 646113,901525 TBR: stevenjb@chromium.org Change-Id: I15e551d238bb0180061561bc92788ff21d640c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595017 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#660583}
-
Erik Luo authored
Chromium's UserActivation rules affect behavior, e.g. 'window.open()' popups without a user gesture may be blocked. Console currently treats all evaluations as user gestures, which means they affect navigator.userActivation regardless of the expression. This CL introduces a setting to stop treating evaluations as gestures, to enable debugging of UserActivation-dependent logic. Screenshot: https://imgur.com/a/2Wo6J7j Bug: 960404 Change-Id: Iabe33b6551dba95e13b1bc515be3134894c4dac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615668Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#660582}
-
Yuly Novikov authored
gpu-fyi-try-linux-amd-rel gpu-fyi-try-linux-intel-ozn gpu-fyi-try-mac-amd-10.14 gpu-fyi-try-mac-intel-10.14 gpu-fyi-try-mac-nvidia-10.14 Since running these trybots causes CI bot to timeout. TBR=kbr Bug: 908949 Change-Id: Ib9f8ee685fde23236fe7021752c025900ba69cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615496Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#660581}
-
Sadrul Habib Chowdhury authored
If getting the timestamp for EGL_DISPLAY_PRESENT_TIME_ANDROID fails, then instead of using Now() as the timestamp, attempt to get the timestamp of EGL_FIRST_COMPOSITION_START_TIME_ANDROID. BUG=none Change-Id: Ie410943dc0eb6a1ae0c2510cb1cb0171967962eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607261 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660580}
-