GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243449 0039d316-1c4b-4281-b951-d872f2087c98

TBR=spang
BUG=318315

This reverts commit af01a3b5.

Review URL: https://codereview.chromium.org/127223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332148
TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/key_silk_cases_000.wpr; tools/perf/run_benchmark silk.key_silk_cases -v; mv ~/.boto.bak ~/.boto

Review URL: https://codereview.chromium.org/126093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243447 0039d316-1c4b-4281-b951-d872f2087c98

This makes gyp_chromium pass defines defined via -D on the command line to GN.

Fixes double-escaping of strings from supplemental.gypi files.

Pass use_goma to the GN build.

Handle "use_goma" and "use_goma=1" (same for other boolean values). Previously values with no equals sign were getting converted to 'true', which doesn't match '1' which we look for.

Output goma wrappers in the GYP header for Windows toolchains.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/123463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243446 0039d316-1c4b-4281-b951-d872f2087c98

This CL removed a deadlock on camera removal, but created a new one
on shutdown while a camera is running.

> When stopping QTKit video capture, call stopRunning before removeInput:.
> 
> Empirically, this prevents a browser hang when the active camera is
> unplugged.  The unplug event triggers both stopping the capturer and
> enumerating the available input devices at the same time.  It seems
> that calling removeInput: on a running capturer after an error
> produces a deadlock, but stopping the capturer first resolves the
> problem.
> 
> BUG=285053
> 
> Review URL: https://codereview.chromium.org/120963003

TBR=bemasc@chromium.org

Review URL: https://codereview.chromium.org/126883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243445 0039d316-1c4b-4281-b951-d872f2087c98

This enables imports to use the built-in programatic variables like root_build_dir.

R=scottmg@chromium.org, scottmg

Review URL: https://codereview.chromium.org/126033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243444 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: breaks license checker

TBR=darin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=318315

Review URL: https://codereview.chromium.org/127133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243443 0039d316-1c4b-4281-b951-d872f2087c98

Revert 243438 "Revert 243413 "Resize the widget when top level p..."

> Revert 243413 "Resize the widget when top level popup windows cr..."
> 
> > Resize the widget when top level popup windows created by the content layer are resized.
> > 
> > The content layer creates top level popup windows, for select items on a page for e.g. When these
> > windows are resized we need to resize the parent widget hosting them.
> > 
> > BUG=330596
> > TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest
> > R=sky@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/125203005
> 
> TBR=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/127073003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/127163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243442 0039d316-1c4b-4281-b951-d872f2087c98

The use of a '.' in a trace name only breaks the telemetry value result if it
occurs in a value which does not have a trace_name.  This CL moves the assert
into the Value object so that the assert doesn't fire in other situations
(such as the media.tough_media_cases benchmark), where the use of the '.' is
actually ok.

BUG=332041,329845

Review URL: https://codereview.chromium.org/126013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243441 0039d316-1c4b-4281-b951-d872f2087c98

For better memory ownership.

BUG=none

Review URL: https://codereview.chromium.org/115523011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243440 0039d316-1c4b-4281-b951-d872f2087c98

ToplevelWindowEventHandler::HandleMousePressed() has some comments about only handling events post target. Those comments are untrue so remove them.
It is also non trivial to get the originally desired behavior, namely getting mouse events to HTML elements with the "-webkit-app-region" CSS style applied. 

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/108723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243439 0039d316-1c4b-4281-b951-d872f2087c98

> Resize the widget when top level popup windows created by the content layer are resized.
> 
> The content layer creates top level popup windows, for select items on a page for e.g. When these
> windows are resized we need to resize the parent widget hosting them.
> 
> BUG=330596
> TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/125203005

TBR=ananta@chromium.org

Review URL: https://codereview.chromium.org/127073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243438 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: this introduced a package dependency bug where ia32-libs cannot be installed on ubuntu precise systems

TBR=kkimlabs@chromium.org,cjhopman@chromium.org,pschmidt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=290225

Review URL: https://codereview.chromium.org/126543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243437 0039d316-1c4b-4281-b951-d872f2087c98

DrMemory: Disable IEImporterBrowserTest.IEImporterMalformedFavoritesRegistry which times out occasionally.

BUG=332219
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/127053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168996
TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane.

Review URL: https://codereview.chromium.org/126123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=jzern@chromium.org

Review URL: https://codereview.chromium.org/126863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243433 0039d316-1c4b-4281-b951-d872f2087c98

This moves all lazy initialization code out of cc/base/switches.cc. Code
that needs the value of these switches in a critical path should not rely
on lazy initialization in cc/switches.cc but instead handle this on its own.

Thread-safe lazy initialization code of impl-side painting status has
been added to WebLayerImpl.

This also removes the cc::switches::IsGPURasterizationEnabled() function,
which for consistency should not exist unless the logic to determine the
value is more complicated than HasSwitch(kEnableGPURasterization). This
function was never used in performance sensitive code so lazy initialization
was never necessary.

BUG=330937
TBR=jamesr

Review URL: https://codereview.chromium.org/122063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243432 0039d316-1c4b-4281-b951-d872f2087c98

remove AddressValidator; the functionality will be added to AddressValidator

BUG=none

Review URL: https://codereview.chromium.org/125633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243430 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer used.

BUG=
TBR=binji

Review URL: https://codereview.chromium.org/123933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243429 0039d316-1c4b-4281-b951-d872f2087c98

[Android] Fixes app crash when using both enable and disable delegated renderer command line switch.

The function UsingDelegatedRenderer should also check for command line switch
--disable-delegated-renderer's presence while determining the usage of
delegated renderer.

BUG=330714

Review URL: https://codereview.chromium.org/110913010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243428 0039d316-1c4b-4281-b951-d872f2087c98

Currently as soon as we see an uncheckable include (like ipc/*macros.h or
windows.h) we stop checking the file. Instead we should just skip that line
and continue checking.

Review URL: https://codereview.chromium.org/105633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98

In the current gyp rules, the unittests depend on the following three
children: (1) java, (2) native and (3) jni generation. This is not
correct as (2) has a functional dependency on (2). Having (3) being a
sibling of (2), as it is now, introduces a race when building the
unittest target from clean.
This change fixes the problem making the jni generation step a
dependency of the native build, rather than a sibling.

BUG=None
TEST=ninja -C out/Debug android_webview_unittests_apk
NOTRY=true

Review URL: https://codereview.chromium.org/116043010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328080
NOTRY=true

Review URL: https://codereview.chromium.org/103213015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243424 0039d316-1c4b-4281-b951-d872f2087c98

This will allow app_shell to use it without an ExtensionService

BUG=none
TEST=added unit_tests ExtensionRegistryTest.GetExtensionById
R=yoz@chromium.org
TBR=pkotwicz@chromium.org for chrome/browser/themes

Review URL: https://codereview.chromium.org/125573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243423 0039d316-1c4b-4281-b951-d872f2087c98

Windows was automatically doing this for us before. I can't think of a
good reason not to do it every where.

BUG=331209
TEST=covered by unit test
R=varunjain@chromium.org

Review URL: https://codereview.chromium.org/113923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243422 0039d316-1c4b-4281-b951-d872f2087c98

Cursor prefetch caches must be discarded when other
requests are made to ensure proper request sequencing.
Two edge cases were handled improperly if new records
was written just ahead of the cursor.

* A reset occurring before the prefetch results were
received would be ignored; since the newly records
weren't in the prefetch data, the cursor wouldn't see
them.

* A reset occurring after the results are received
would back up the cursor to before the new records,
even though the prefetch itself is a "continue"
and advanced past them already.

The fix is to reset the cache on receipt if necessary,
and to ensure the reset state accounts for the implicit
advance.

BUG=331570

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243344

Review URL: https://codereview.chromium.org/124323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243421 0039d316-1c4b-4281-b951-d872f2087c98

This reverts 240379..

BUG=311373
TBR=stevenjb

Review URL: https://codereview.chromium.org/126213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243420 0039d316-1c4b-4281-b951-d872f2087c98

The fontconfig repository moved to from third_party/fontconfig to third_party/fontconfig/src.

TBR=darin@chromium.org
NOTRY=true
BUG=318315

Review URL: https://codereview.chromium.org/126823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243418 0039d316-1c4b-4281-b951-d872f2087c98

Canceling a history swipe with the magic mouse would fail to hide the swipe
arrow. Previously, the arrow was dismissed in `dealloc`, and I moved the
animation to `dismiss` in a previous change (107343008). Unfortunately, the
logic for magic mouse history swiping was failing to call `dismiss` if the
history swipe was cancelled.

BUG=330312

Review URL: https://codereview.chromium.org/115693012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243417 0039d316-1c4b-4281-b951-d872f2087c98

Remove RemotePtr<S>::SetPeer method in favor of an optionally NULL second constructor argument. (The reset method also gains an optionally NULL second argument.)

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/109103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243416 0039d316-1c4b-4281-b951-d872f2087c98

by value. Subsequent patches will clean up all the gfx structs to be
passed by ref.

BUG=159273

Review URL: https://codereview.chromium.org/126073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308651

Review URL: https://codereview.chromium.org/102433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243414 0039d316-1c4b-4281-b951-d872f2087c98

The content layer creates top level popup windows, for select items on a page for e.g. When these
windows are resized we need to resize the parent widget hosting them.

BUG=330596
TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest
R=sky@chromium.org

Review URL: https://codereview.chromium.org/125203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243413 0039d316-1c4b-4281-b951-d872f2087c98

R=ccameron@chromium.org
BUG=NONE
TEST=NONE(no functional change)

Review URL: https://codereview.chromium.org/125203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243412 0039d316-1c4b-4281-b951-d872f2087c98

All desktop platforms now show the tab tooltip on mouse hover, regardless of whether the page title text entirely fits within a tab.

Also, fixed a subtle bug where View::TooltipTextChanged() was not being called when the data model was changed.  This allows a tooltip to be updated while still hovering over the tab with the mouse.

BUG=310947

Review URL: https://codereview.chromium.org/120163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243411 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly mechanical, the only difference is that in places that rely
on the content context support the code now downcasts the cc::ContextProvider
pointer instead of downcasing the blink::WebGraphicsContext3D pointer.

BUG=181120

Review URL: https://codereview.chromium.org/120043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243410 0039d316-1c4b-4281-b951-d872f2087c98

    
Currently synthetic delays use an Activate/Apply scheme were Activate
can be called several times and a single call to Apply will execute the
delay. Both calls need to happen on the same thread.
    
This patch changes this to a Begin/End model where the delay start point
is designated with Begin and executed with End. Both calls can happen on
any thread for a given delay. Calls can also be nested so that the inner
Begin/End pairs do nothing and only the outermost End will apply the
delay.
    
This change is primarily to make it easier to integrate synthetic delays
to asynchronous tasks such as texture uploads. One only needs to call
Begin for every queued task and then End in each individual tasks to
apply the delay automatically to a "burst" of work.
    
This patch also introduces parallel versions of Begin and End. They are
useful for several applying independent instances of the same delay.
    
We also add a function for resetting all registered synthetic delays.
This is needed for telemetry tests to reset delays to a clean slate
between pages.

Review URL: https://codereview.chromium.org/104613003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243409 0039d316-1c4b-4281-b951-d872f2087c98

In most cases SingleThreadTaskRunner can be used instead.

BUG=315922
R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/101503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243408 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/123833007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243407 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321878

Review URL: https://codereview.chromium.org/123283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243406 0039d316-1c4b-4281-b951-d872f2087c98