- 19 May, 2015 40 commits
-
-
anthonyvd authored
This design is based on this mock: https://drive.google.com/a/chromium.org/file/d/0B-DVbqI3huZGZGhIcTFtRWRTSTA/view?usp=sharing BUG=458664 TEST= 1. Launch chrome and make sure there is more than one available profile. 2. Left-click on the Avatar Button. 3. A tutorial bubble should be displayed informing the user they can right-click the button to see other users. 4. Close the bubble without dismissing the tutorial, for example by clicking in the content area. 5. Reopening the Avatar Menu should still display the tutorial until it is explicitly dismissed (clicking the X or the "Ok, got it!" button) or until the user right clicks the button. 6. Once dismissed, the tutorial should never be shown again. Review URL: https://codereview.chromium.org/1120013003 Cr-Commit-Position: refs/heads/master@{#330565}
-
gangwu authored
Do not let the invalidations service to fall back to XMPP if GCM is disabled, since we already finished traansite from GCM to XMPP, and XMPP do not have prepare for such load spike. Since Sync have backoff mechanism, so if GCM server some how disabled, sync will retry it later. BUG=479300 Review URL: https://codereview.chromium.org/1127393005 Cr-Commit-Position: refs/heads/master@{#330564}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/55b88ca..89aeb69 TBR=hiroshige@chromium.org,szager@chromium.org Review URL: https://codereview.chromium.org/1142233002 Cr-Commit-Position: refs/heads/master@{#330563}
-
lliabraa authored
The callback updates the |visible| property to NO so clients can correctly determine if the context menu has been dismissed. BUG=489121 Review URL: https://codereview.chromium.org/1144873002 Cr-Commit-Position: refs/heads/master@{#330562}
-
enne authored
A number of cc unit tests have started checking property tree output, primarily visible_rect_from_property_trees but also needs_rebuild on the trees. Because of this, these tests now depend on running the property tree code, so setting verify_property_trees=false forces these tests to run only CDP code which causes them to fail. Therefore, convert these specific tests to use property tree updates directly. This also requires a PrecalculateMetaInformation function for LayerImpl, as LayerTreeHostCommonTest.SkippingSubtreeImpl touched LayerImpl properties that could only theoretically be changed from the main thread. In the future, I think all layer tree host common tests will need to go down the property tree update path, but (in my opinion) it's not worth doing that until we have property trees everywhere. This patch is just a step in that direction to unblock property trees for the compositor thread first. R=ajuma@chromium.org,vollick@chromium.org BUG=481585 Review URL: https://codereview.chromium.org/1136643006 Cr-Commit-Position: refs/heads/master@{#330561}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/9b4b91f5..4b91f76 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=bungeman@google.com Review URL: https://codereview.chromium.org/1130763009 Cr-Commit-Position: refs/heads/master@{#330560}
-
estade authored
1) file manager's chrome web store widget 2) wallpaper gallery spinner BUG=485779 Review URL: https://codereview.chromium.org/1140403002 Cr-Commit-Position: refs/heads/master@{#330559}
-
grt authored
This makes the build/test cycle easier for Release builds. BUG=none R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1144543008 Cr-Commit-Position: refs/heads/master@{#330558}
-
wzhong authored
By default, OnSSLCertificateError() just cancels current request. For connectivity_checker, it needs to cancel the current request and starts next check. In particular, this handles the case that SSL cert fails when device system time is changing (syncing to NTP server). BUG=internal b/20775908 Review URL: https://codereview.chromium.org/1145723004 Cr-Commit-Position: refs/heads/master@{#330557}
-
gunsch authored
R=byungchul@chromium.org,lcwu@chromium.org BUG=internal b/21262248 Review URL: https://codereview.chromium.org/1134183004 Cr-Commit-Position: refs/heads/master@{#330556}
-
reveman authored
4 raster threads improve performance on 8 core machines. 8 core machines might not be a priority but it seems like an unnecessary limitation to have. BUG= Review URL: https://codereview.chromium.org/1143473002 Cr-Commit-Position: refs/heads/master@{#330555}
-
primiano authored
The test is failing due to the lack of WebGL support. See crbug.com/488059#c24 Link to failing step: https://build.chromium.org/p/chromium.perf/builders/Win%20XP%20Perf%20%284%29/builds/3243/steps/blink_perf.canvas/logs/stdio BUG=488059 TBR=skyostil@chromium.org NOTRY=true CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Review URL: https://codereview.chromium.org/1123153004 Cr-Commit-Position: refs/heads/master@{#330554}
-
jeremyim authored
BUG=467734 Review URL: https://codereview.chromium.org/1147743002 Cr-Commit-Position: refs/heads/master@{#330553}
-
vabr authored
The tools/git/move_source_file.py tool relies on the alphabetic ordering, and will mess up changes if the gypi files are not initially sorted. BUG=486739 Review URL: https://codereview.chromium.org/1139603006 Cr-Commit-Position: refs/heads/master@{#330552}
-
bcwhite authored
BUG=484139 Review URL: https://codereview.chromium.org/1138103003 Cr-Commit-Position: refs/heads/master@{#330551}
-
jam authored
With this change, closing the window shuts down Mandoline cleanly. This is split off https://codereview.chromium.org/1139673003 BUG=484234 Review URL: https://codereview.chromium.org/1131933009 Cr-Commit-Position: refs/heads/master@{#330550}
-
robert.bradford authored
Following https://codereview.chromium.org/1129863003/ which added support for loading an apply an ICC file based on EDID product id a new entry was added to the chromeos paths switch statement. Unfortunately the break statement was missing in the newly added case. Failing to break from the switch statement triggered a DCHECK failure in path_service.cc which would result in in asserts in builds where DCHECK is fatal. BUG=489643 TEST=None Review URL: https://codereview.chromium.org/1145793002 Cr-Commit-Position: refs/heads/master@{#330549}
-
lanwei authored
In order to avoid the touch event queue keep growing when render handles async touchmove events longer than 200ms, which is the async touchmove interval, we keep coalesce touch moves and send the next touchmove until passing the async touchmove interval and receive the ACK from render. BUG=448760 Review URL: https://codereview.chromium.org/997283002 Cr-Commit-Position: refs/heads/master@{#330548}
-
rdevlin.cronin authored
When an extension is removed, if an element was focused, the analogous element on the previous/next extension should be focused. BUG=479092 Review URL: https://codereview.chromium.org/1138973005 Cr-Commit-Position: refs/heads/master@{#330547}
-
rch authored
Also clarify the split between Deterministic and non-Deterministic socket data providers. Review URL: https://codereview.chromium.org/1142893003 Cr-Commit-Position: refs/heads/master@{#330546}
-
jam authored
This is a followup to r329965 Review URL: https://codereview.chromium.org/1131753005 Cr-Commit-Position: refs/heads/master@{#330545}
-
sdefresne authored
BUG=None Review URL: https://codereview.chromium.org/1146673002 Cr-Commit-Position: refs/heads/master@{#330544}
-
spang authored
There are no remaining call sites for either BlitContextToCanvas or BlitCanvasToContext. Also remove some leftover #includes. TEST=Linux built compiles & links. Review URL: https://codereview.chromium.org/1138753003 Cr-Commit-Position: refs/heads/master@{#330543}
-
mtomasz authored
The capabilities section is a map, not an array. This CL fixes the example snippet. TEST=Testing docs server. BUG=489217 Review URL: https://codereview.chromium.org/1130943006 Cr-Commit-Position: refs/heads/master@{#330542}
-
halliwell authored
This test fails (same symptoms as bug 443352) on hardware with <= 256MB of RAM. BUG= internal b/21093117 Review URL: https://codereview.chromium.org/1140813005 Cr-Commit-Position: refs/heads/master@{#330541}
-
erg authored
mojo.ContentHandler is a core thing used by the shell, and thus should be part of the Application interface. This should enable further refactoring. BUG= Review URL: https://codereview.chromium.org/1139883006 Cr-Commit-Position: refs/heads/master@{#330540}
-
phoglund authored
Sheriffs: if WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo flakes, revert this patch. It shouldn't flake after this fix. Instead of looking at color values of individual pixels, see if we can get more reliable results by looking at luma values instead. This way we can detect black frames more reliably in the tests. This is a partial re-land of codereview.chromium.org/1108803002. This is essentially the black frame algorithm used in testrtc. BUG=477498 Review URL: https://codereview.chromium.org/1132333006 Cr-Commit-Position: refs/heads/master@{#330539}
-
scheib authored
Review URL: https://codereview.chromium.org/1144713003 Cr-Commit-Position: refs/heads/master@{#330538}
-
jdonnelly authored
These will be used in an upcoming CL implementing the iOS version of the card unmask prompt view. BUG=484806 Review URL: https://codereview.chromium.org/1138653003 Cr-Commit-Position: refs/heads/master@{#330537}
-
bauerb authored
In addition to simplifying the code, ScopedObserver ensures that the object is unregistered as an observer if and only if it has been registered. BUG=488642 Review URL: https://codereview.chromium.org/1123283011 Cr-Commit-Position: refs/heads/master@{#330536}
-
mtomasz authored
TEST=Tested manually. BUG=474146 Review URL: https://codereview.chromium.org/1149443002 Cr-Commit-Position: refs/heads/master@{#330535}
-
dnicoara authored
On a hotplug event we configure the displays regardless of the state. However if we're in software mirror mode the configuration was skipped if the previous configuration was extended mode. We want to have a consistent approach to display configuration, so make sure we configure the displays if the configuration was triggered by a system event. Otherwise (if the configuration was requested by the user) we'll just skip the configuration so we don't perform unnecessary modesets. BUG=488736 Review URL: https://codereview.chromium.org/1133743005 Cr-Commit-Position: refs/heads/master@{#330534}
-
enne authored
Rather than converting everywhere from ScrollOffset to Vector2dF, instead just store the scroll offset directly. R=ajuma@chromium.org,vollick@chromium.org Review URL: https://codereview.chromium.org/1142853003 Cr-Commit-Position: refs/heads/master@{#330533}
-
glevin authored
BUG=488666 Add spoken feedback but no visible text to button that leads to "Add supervised user" Review URL: https://codereview.chromium.org/1125373004 Cr-Commit-Position: refs/heads/master@{#330532}
-
jbudorick authored
BUG=476410 Review URL: https://codereview.chromium.org/1126543009 Cr-Commit-Position: refs/heads/master@{#330531}
-
msramek authored
This component previously had no OWNERS file. It makes sense to populate OWNERS from this component's counterpart in chrome/, i.e. chrome/browser/renderer_context_menu/OWNERS. Review URL: https://codereview.chromium.org/1148543004 Cr-Commit-Position: refs/heads/master@{#330530}
-
jdonnelly authored
See https://chromereviews.googleplex.com/193957013/ for the associated downstream changes. BUG=484806 Review URL: https://codereview.chromium.org/1137403002 Cr-Commit-Position: refs/heads/master@{#330529}
-
hans authored
In r237368, Clang started warning about mismatched operator new[] and delete calls. This pacifies the warning by moving the operator new-call to a separate function. BUG=none Review URL: https://codereview.chromium.org/1131513006 Cr-Commit-Position: refs/heads/master@{#330528}
-
mnaganov authored
This code is not used anymore. BUG=486158 Review URL: https://codereview.chromium.org/1147773002 Cr-Commit-Position: refs/heads/master@{#330527}
-
sergiyb authored
They are not needed since Chromium has been moved to Git and no relpath needs to be computed anymore. R=akuegel@chromium.org BUG=471767 Review URL: https://codereview.chromium.org/1141383003 Cr-Commit-Position: refs/heads/master@{#330526}
-