GitLab

This is critical to make sure that forced reenrollment check is not skipped
in case of critical updates.

BUG=372368
TEST=browser_tests

Review URL: https://codereview.chromium.org/296713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273195 0039d316-1c4b-4281-b951-d872f2087c98

> Add image for new SSL interstitial
> 
> This adds the image that Issue 294343004 is dependent on.
> 
> BUG=331453
> R=bauerb@chromium.org
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/293363002

TBR=felt@chromium.org

Review URL: https://codereview.chromium.org/293403011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true
TBR=mvanouwerkerk
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/297203011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273190 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
It broke this build:
http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/16352/steps/cbuildbot/logs/stdio

Sorry for the trouble.

Original issue's description:
> Merge HarfBuzz kerning support from Blink
> 
> Original CL: https://codereview.chromium.org/69513002
> 
> BUG=321868
> R=msw@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273181

TBR=msw@chromium.org,ckocagil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=321868

Review URL: https://codereview.chromium.org/299313009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273189 0039d316-1c4b-4281-b951-d872f2087c98

> Changed android toolchain to use GCC 4.8
> 
> BUG=359106
> 
> Review URL: https://codereview.chromium.org/218633007

TBR=fdegans@chromium.org

Review URL: https://codereview.chromium.org/303493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273188 0039d316-1c4b-4281-b951-d872f2087c98

On fetching metadata, after sending a request, JS is just waiting results and nothing is running in JS side.

With this patch, the next job can be run in such an idle time.

BUG=367123
TEST=filelist can be shown correctly

Review URL: https://codereview.chromium.org/298823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273185 0039d316-1c4b-4281-b951-d872f2087c98

This will allow Wrapper::Shutdown to drop all process references synchronously
in a future change, which will make it possible to shutdown Chrome with service
workers running and without hitting the DCHECK in
ProfileDestroyer::DestroyProfileWhenAppropriate().

This relands http://crrev.com/272839 (reverted by http://crrev.com/272858), and
fixes the breakage in
ServiceWorkerDispatcherHostTest.EarlyContextDeletion. The breakage happened
because I changed ContextWrapper::Shutdown to always PostTask instead of
running inline when CurrentlyOn(BrowserThread::IO). I haven't uncovered why the
breakage only happened on slow bots.

BUG=368570

Review URL: https://codereview.chromium.org/303733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273184 0039d316-1c4b-4281-b951-d872f2087c98

The cell was changed from GradientButtonCell to ImageButtonCell. GradientButtonCell 
has setMouseInside:animate:, but for ImageButtonCell this method is called setIsMouseInside:

BUG=373662

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/299633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273183 0039d316-1c4b-4281-b951-d872f2087c98

Looks like the next version of privet will be version 3, not version 2. Updating
accordingly.

BUG=372843

Review URL: https://codereview.chromium.org/305533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273182 0039d316-1c4b-4281-b951-d872f2087c98

Original CL: https://codereview.chromium.org/69513002

BUG=321868
R=msw@chromium.org

Review URL: https://codereview.chromium.org/290993011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273181 0039d316-1c4b-4281-b951-d872f2087c98

This patch gets rid of unused API function WebViewClient::didExecuteCommand(),
which is used for counting part of |document.execCommand|. We provide another
counter for |document.execCommand| which counts all commands and partial
counter is no longer used.

This patch is chromium/content part of removing API. Blink part is done by: http://src.chromium.org/viewvc/blink?view=rev&rev=174631

BUG=376154
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/297333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273180 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354046
R=pam@chromium.org

Review URL: https://codereview.chromium.org/251733007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273179 0039d316-1c4b-4281-b951-d872f2087c98

This patch cleans up returned error codes. And now:
- base::File::FILE_ERROR_SECURITY is for policy errors, or not handled events.
- base::File::FILE_ERROR_ACCESS_DENIED for all writing operations.
- base::File::FILE_ERROR_INVALID_OPERATION for invalid arguments to operations
    or operations which are read-only but not yet implemented.

TEST=browser_tests, unit_tests: *FileSystemProvider*
BUG=373151

Review URL: https://codereview.chromium.org/298003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273178 0039d316-1c4b-4281-b951-d872f2087c98

We now support ADTS demuxing in via src attribute, so lets enable
it for Media Source as well.

BUG=371633
TEST=existing tests

Review URL: https://codereview.chromium.org/294403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273177 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114092

Review URL: https://codereview.chromium.org/292383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273176 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344769

Review URL: https://codereview.chromium.org/298003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273175 0039d316-1c4b-4281-b951-d872f2087c98

This is not hooked up yet, migration code from Json-backed stores is needed, among other things.

BUG=362814

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271602

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272671

Review URL: https://codereview.chromium.org/169323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273174 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273173 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to break compile step:
http://build.chromium.org/p/chromium/builders/Linux/builds/50125/steps/compile/logs/stdio#error1
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18148/steps/compile/logs/stdio#error1

> Move geometry to mojo/services, extract input events to their own mojom
>
> R=sky@chromium.org
> TBR=sky@chromium.org
> http://crbug.com/365012
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273161

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/304673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273172 0039d316-1c4b-4281-b951-d872f2087c98

This plumbs through keys like backspace and enter and arrow keys.
It also provides Unicode characters for displays with query keyboards etc.

BUG=310285
R=dtseng@chromium.org, kalman@chromium.org

Review URL: https://codereview.chromium.org/297833015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273171 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375023

Review URL: https://codereview.chromium.org/298993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273169 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273168 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174896:174924&mode=html
TBR=alph@chromium.org,esprehn@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/298293006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=wibling@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/306473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273166 0039d316-1c4b-4281-b951-d872f2087c98

Testing fences does not work there.

BUG=371530

Review URL: https://codereview.chromium.org/303473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/303493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273164 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371530

Review URL: https://codereview.chromium.org/304643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273163 0039d316-1c4b-4281-b951-d872f2087c98

Some pages may have state not reflected in the URL, such as the history page's
modal dialog. If the reuse the frame, when going back away from the history
page and forward to it again, the modal dialog stays there. To match what would
happen were the history page the top-level, load the page anew if not the
current.

This reverts the changePage/selectPage split from r271538 since it's no longer
needed.

BUG=377386
TEST=See bug, initial report.

Review URL: https://codereview.chromium.org/300033009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273162 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
TBR=sky@chromium.org
http://crbug.com/365012

Review URL: https://codereview.chromium.org/298253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273161 0039d316-1c4b-4281-b951-d872f2087c98

SetVolume is called before the media player bridge is created, so the
volume(muted) is not set correctly.

BUG=377737

Review URL: https://codereview.chromium.org/296393007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273160 0039d316-1c4b-4281-b951-d872f2087c98

Also simplifies text run direction logic.

BUG=321868
R=msw@chromium.org

Review URL: https://codereview.chromium.org/299313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273159 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374686

Review URL: https://codereview.chromium.org/300063014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273158 0039d316-1c4b-4281-b951-d872f2087c98

Add tests whether ScheduledActionShouldUpdateVisibleTiles() is executed
or not when Scheduler::SetSwapUsedIncompleteTile() is called.
Then, checks draw operation in the next deadline.

R=brianderson@chromium.org
BUG=377641
TEST=cc_unittests --gtest_filter=SchedulerTest.ShouldUpdateVisibleTiles

Review URL: https://codereview.chromium.org/303573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375462

Review URL: https://codereview.chromium.org/294393010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273153 0039d316-1c4b-4281-b951-d872f2087c98

This test is also highly flaky on Windows (failed 5/7 recent runs).
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%286%29

[3504:128:0527/154657:FATAL:thread_restrictions.cc(38)] Function marked as IO-only was called from a thread that disallows IO!  If this thread really should be allowed to make IO calls, adjust the call to base::ThreadRestrictions::SetIOAllowed() in this thread's startup.
Backtrace:
	base::debug::StackTrace::StackTrace [0x100A9DC1+33]
	logging::LogMessage::~LogMessage [0x101495BE+94]
	base::ThreadRestrictions::AssertIOAllowed [0x102962A6+246]
	base::File::Close [0x10135082+34]
	base::File::~File [0x1011551C+60]
...
	fileapi::FileSystemOperationImpl::DidOpenFile [0x238518A3+179]
...
	fileapi::`anonymous namespace'::RunCreateOrOpenCallback [0x237F9104+180]
...
	base::MessageLoop::RunTask [0x10184201+881]
...
See full stack in http://crbug.com/378046

BUG=377599,378046
TBR=hidehiko@chromium.org,bbudge@chromium.org

Review URL: https://codereview.chromium.org/301723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273152 0039d316-1c4b-4281-b951-d872f2087c98

- Fix a problem that could not drop at the last position when dragging
  an item out of a folder;
- Fix a case view_model_.Move is called with an out of range target index
  when dragging the last item out of folder;
- Add a test for dragging last item and drop it at last slot;
- Speculative fix to protect using an index from data model to modify
   view_model_;
- A few more DCHECKs to catch the out-of-bound case; 

BUG=370064
TEST=AppListMainViewTest.DragLastItemFromFolderAndDropAtLastSlot

Review URL: https://codereview.chromium.org/298963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347425
TEST=./unit_tests --gtest_filter="DriveBackendSyncTest.*"

Review URL: https://codereview.chromium.org/296893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273150 0039d316-1c4b-4281-b951-d872f2087c98

The CL fixed a memory leak when requests are cancelled, but
caused crashes under certain circumstances.  The leaks will
still need to be fixed after this lands.

BUG=chrome-os-partner:27911,328092


> Fix a long standing leak on cancellation of renderer-
> initiated URLRequests.  ResourceDispatcher was not calling
> peer->OnCompletedRequest on cancellation of async requests,
> despite it being expected by WebURLLoaderImpl::Context
> (The only ResourceLoaderBridge::Peer).
>
> This shouldn't impact externally visible behavior at all,
> other than fixing the leak, because once
> WebURLLoaderImpl::Context::Cancel() is called, it will never
> call back into WebURLLoaderImpl.
>
> BUG=328092
>
> Review URL: https://codereview.chromium.org/113893007

Review URL: https://codereview.chromium.org/301753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273149 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273148 0039d316-1c4b-4281-b951-d872f2087c98