- 29 Jan, 2018 40 commits
-
-
Christian Dullweber authored
The feature shipped in M63 so the old code is not required anymore. This CL removes the old CBD dialog and the kTabsInCBD flag as well as migration code for preferences. Users that have not been migrated will get default values for selected checkboxes in the basic tab. Bug: 800184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If9325462be1bf652206b7956d5d25dcfec717078 Reviewed-on: https://chromium-review.googlesource.com/857059Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#532393}
-
Matthew Cary authored
VrShellTransitionTest#testExitPresentationWebVrToVrShell and VrShellNavigationTest#test2dFullscreenToWebVr continue to fail and keep the bot red. Bug: 804808 TBR: bsheedy@chromium.org,mthiesse@chromium.org Change-Id: I1721df42012b11662998f54627a8dd561c1a3253 Reviewed-on: https://chromium-review.googlesource.com/890182Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#532392}
-
Matthew Cary authored
The test harness has working directory /, which is not readable in this test. Bug: 804348 TBR: aberent@chromium.org,brettw@chromium.org,thestig@chromium.org Change-Id: I31f02bef8aa61f62e2e07c94279e875d8b6d9570 Reviewed-on: https://chromium-review.googlesource.com/891158Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 777962 Change-Id: I6cf85600830ddd6c2398a15e4a1c4c74aa9fbfd9 Reviewed-on: https://chromium-review.googlesource.com/886830Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532390}
-
Eric Noyau authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I26f97dba5a0bb07f83df184db59b8f610c220877 Reviewed-on: https://chromium-review.googlesource.com/888750Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#532389}
-
Bhagirathi Satpathy authored
Added stringifier to support MediaList |toString| method. Specification: https://drafts.csswg.org/cssom/#the-medialist-interface Bug: Change-Id: I0dd14cd1843a5d3fde424021a443669db374df85 Reviewed-on: https://chromium-review.googlesource.com/890959Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com> Cr-Commit-Position: refs/heads/master@{#532388}
-
Raphael Kubo da Costa authored
We want to remove Nullable.h, but UnionTypeConversionMode needs to remain. Move it to V8BindingForCore.h, as the enum is generally used in ToImpl() calls. While here, document it a little bit. Bug: 798464 Change-Id: Iecbb481114ad934264dcfb0efffc248bcc420981 Reviewed-on: https://chromium-review.googlesource.com/891019Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#532387}
-
Keishi Hattori authored
Bug: None Change-Id: I9fbb01166c6dbf6f5dc58de116c9de1a739b904e Reviewed-on: https://chromium-review.googlesource.com/890143Reviewed-by:
-
Gauthier Ambard authored
This CL fixes the OmniboxPerfTest.TestTypeOneCharInTextField test which was failing because it was using the WebToolbarController even if the flag to disable it is turned on. It was creating a conflict. Bug: 806685 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If846ac3ecf0963700da4e1dd71156037c87653c4 Reviewed-on: https://chromium-review.googlesource.com/891018Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532385}
-
Mikhail Pozdnyakov authored
DeviceSingleWindowEventController::DidAddEventListener() is not called if {deviceorientation|deviceorientationabsolute|devicemotion} events are blocked by feature policy. A console message referencing to https://github.com/WICG/feature-policy/blob/gh-pages/features.md is send to warn the user. Bug: 796894 Change-Id: I350ff75ca55766b7ebb42944d66470ecd2b8a4c1 Reviewed-on: https://chromium-review.googlesource.com/870510Reviewed-by:Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#532384}
-
Max Morin authored
Only mechanical changes in this CL. Presubmit (correctly) complains about Time::Now() usage AudioInputSyncWriter. This is pre-existing, but only for logging, and will be fixed in a followup to keep this CL completely trivial. Bug: 803102 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I422f80e376f89428ed8f69a1de1a5751c31bf4bb Reviewed-on: https://chromium-review.googlesource.com/886345 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#532383}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55129433. With Chromium commits locally applied on WPT: 9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11260 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=leon.han@intel.com No-Export: true Change-Id: Icd58b44866f3a48702a2a31ea839489ce0c202a7 Reviewed-on: https://chromium-review.googlesource.com/889803 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532382}
-
Niels Möller authored
Bug: none Change-Id: I995b5edbce2969313424fc71ef6dc240c268dd24 Reviewed-on: https://chromium-review.googlesource.com/885806Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#532381}
-
Javier Fernandez authored
The CSS WG resolved in May 2017 to replace the 'auto' keyword by 'legacy' in the CSS syntax of the justify-items property. https://github.com/w3c/csswg-drafts/issues/1318 According to the spec, the 'auto' (now 'legacy') value applied to the justify-items property should be resolved, during the style resolution phase before layout, with its inherited value if this includes the 'legacy' keyword (plus 'left', 'right', or 'center'). There is no behavior change in the affected property due to this syntax change. Since 'auto' (now 'legacy') is the default value of the justify-items property, this change has a relative big impact. However, we are only interested on evaluate the use of the 'legacy' alignment, which has to be explicitly set in the parent element. Change-Id: Id2ae6735fb28ac44062aaec79828ce97d7edd5d6 Reviewed-on: https://chromium-review.googlesource.com/886365Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#532380}
-
Mike West authored
Bug: 588931 Change-Id: Ie1118c0efa0cc3e274d3f66ce4ea536979014aa0 Reviewed-on: https://chromium-review.googlesource.com/875964 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532379}
-
Christian Dullweber authored
When deleting a profile, the profile will be marked as deleted and all browsing data is removed but the profile folder will remain until shutdown and it still contains some data like bookmarks and settings. Using command line arguments it is possible to open a new window for this profile. This CL changes the profile manager to not return profiles that have been deleted. Instead of opening a window for a deleted profile, Chrome will refuse to open the window. Bug: 803643 Change-Id: Iae3caf93b2895d23b90aeb6550197a81038a1ec6 Reviewed-on: https://chromium-review.googlesource.com/883342Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#532378}
-
Christian Dullweber authored
When the ClearBrowsingDataDialog is opened, a CBDPreferences is created for each of the tabs. Each preference queries for information about browsing history and fetches important sites. As these are non-trivial operations, a class is introduced to only request both infos once and share them between preferences. Bug: 804839 Change-Id: I8495bc2e2ebeaeb8640d9d0775f701911d0045c8 Reviewed-on: https://chromium-review.googlesource.com/883783 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#532377}
-
Benoit Lize authored
Also convert another trace event in WarmupManager to TraceEvent.scoped(). Bug: 804302 Change-Id: I1e21c4ccfeb8310fe7a412d9cef308bc479320af Reviewed-on: https://chromium-review.googlesource.com/886845Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#532376}
-
Christian Dullweber authored
In order to remove tab history correctly, we need to know the time range that was specified for a history deletion. Otherwise there can be edge cases, where a NavigationEntry could not be removed because it doesn't have a corresponding history. This CL replaces the boolean all_time parameter of HistoryServiceObserver::OnURLsDeleted with a DeletionTimeRange object. Bug: 407074 Change-Id: Id0fc5535e6cfd0874edb83fe75f61e6d112666e7 Reviewed-on: https://chromium-review.googlesource.com/800932 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
vitaliii authored
This reverts commit 3d3a5267. Reason for revert: Causes UnhandledEventOnPeeking to fail constantly (see crbug.com/806690). Original change's description: > cros: Don't dismiss AppList on right click/two finger tap > > UX request: > - Don't dismiss AppList if the right click/two finger tap > is on the shield of the AppList. > > - Added a test. > > Bug: 805937 > Change-Id: Id38b5872c3836680d08adbcb84922fe62201be19 > Reviewed-on: https://chromium-review.googlesource.com/887282 > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532023} TBR=jennyz@chromium.org,newcomer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 805937, 806690 Change-Id: I4acd4bbea8a85988224efa7573b719655628e445 Reviewed-on: https://chromium-review.googlesource.com/890264Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532374}
-
Sylvain Defresne authored
There is a global comparison operator allowing to check whether a GURL is equal to a constant URL. This avoid needlessly parsing the constant to a GURL everytime the comparison is done. Bug: 655467 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9c876b542f09235042c36026b32977d88c2f0d0b Reviewed-on: https://chromium-review.googlesource.com/886421 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532373}
-
Juan Antonio Navarro Perez authored
- Add explicit calls to SetUp-/CleanUpEnvironment. TBR=tengs@chromium.org Bug: 804292,801578 Change-Id: I54d0925b308867020ed69b4330abd529beb61d77 Reviewed-on: https://chromium-review.googlesource.com/881142Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#532372}
-
Niels Möller authored
Bug: webrtc:8504 Change-Id: I8e227e17c521cb2825cdda909e8071ba0366e69f Reviewed-on: https://chromium-review.googlesource.com/870119 Commit-Queue: Niels Möller <nisse@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#532371}
-
Yoichi Osato authored
GetLocalSelectionEndpoints uses a boolean argument |selection_start| to compute a selection bound. This patch refactors the function by removing the argument and splitting the function into GetLocalSelectionStartpoints and GetLocalSelectionEndpoints for code health. Bug: 789870 Change-Id: I7a2f3e7ab9f086c286c0f60bd1e8ce8a1d1c94a8 Reviewed-on: https://chromium-review.googlesource.com/890695Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532370}
-
Gabriel Charette authored
https://chromium-review.googlesource.com/c/chromium/src/+/878825 didn't cause as big of a spike as I expected (~250 instead of ~1000), will wait for it to settle a bit more before landing this CL (to confirm whether this one still causes havoc and there's more to uncover or not) R=asvitkine@chromium.org Bug: 804345 Change-Id: Iee2d1f52d55dff2e840420c28e6af7c80d526ca1 Reviewed-on: https://chromium-review.googlesource.com/883122Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#532369}
-
Gauthier Ambard authored
This CL constrains the OmniboxLayoutGuide so it is positioned on the omnibox of the adaptive toolbar. Bug: 806248 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I84a19370868ff152402a6039c626acb28cc6a26c Reviewed-on: https://chromium-review.googlesource.com/888640Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#532368}
-
Yoichi Osato authored
This patch changes the function to use a SelectionInDOMTree instance rather than VisibleSelection one. This patch is a preparation for removing VS canonicalization: crrev.com/c/872811(WIP) Bug: 789870 Change-Id: I38388e01b3262bc3a8abf455dfb9f566ef9cf510 Reviewed-on: https://chromium-review.googlesource.com/890574Reviewed-by:
-
Kent Tamura authored
The purpose of this function is to reduce the number of callsites for FooElementFactory::createFooElement(), which don't support prefixes correctly and contain unnecessary custom element processing. The implementation of CreateRawElement() is equivalent to Document::createElement(qname, flags) without custom-element processing. * Document::createElement(local_name, options, exception_state): Replace createElement(local_name, exception_state) with CreateRawElement(). createElement(local_name, exception_state) contains V0 custom-element processing, but it isn't necessary here because it's already done before calling createElement(). * Document::createElementNS(ns, qname, exception_state): Replace createElement(qname, flag) call with V0 custom-element processing and CreateRawElement(). createElement(qname, flag) does V0 custom-element processing in this path. This CL adds the custom-element processing here, and use CreateRawElement(). * Document::createElementNS(ns, qname, options, exception_state): Replace createElement(qname, flag) call with CreateRawElement(). createElement(qname, flag) contains V0 custom-element processing, but it isn't necessary here because it's already done before calling createElement(). Bug: 806641 Change-Id: Ib3d0f3e8cc05b17c69945594b307d76988a840ea Reviewed-on: https://chromium-review.googlesource.com/890958Reviewed-by:
-
Yutaka Hirano authored
A request with keepalive set should continue working after the associated FetchContext is detached, but no one cares its status after it gets response. With this change such requests will be cancelled. Bug: 764589 Change-Id: I9a5b9de6d658311bab27ab85fee3dea406457488 Reviewed-on: https://chromium-review.googlesource.com/885702Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532365}
-
Takuto Ikuta authored
/d2Zi+ is replaced by /Zo and /Zo is enabled by default. https://docs.microsoft.com/en-us/cpp/build/reference/zo-enhance-optimized-debugging clang-cl ignores this option. https://github.com/llvm-project/llvm-project-20170507/blob/fdd1e44ea4b98dd1c02d5f2181cca6bbb854aadd/clang/include/clang/Driver/CLCompatOptions.td#L319 Change-Id: I35d24b6d3c5d7e3c3dbd2e0c37f41683b062f650 Reviewed-on: https://chromium-review.googlesource.com/890572Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#532364}
-
Nico Weber authored
Bug: 177475 R=msarda@chromium.org Change-Id: Iab13eae6474e49f9890fc55f9ecf66b4ae11879d Reviewed-on: https://chromium-review.googlesource.com/889724Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#532363}
-
Yuki Shiino authored
This patch removes use of filesystem's FileWriterCallback. The motivation is the same as https://crrev.com/844307 . Bug: 778580 Change-Id: I69866c23290627a84ddedbaceaeae80b584b46e7 Reviewed-on: https://chromium-review.googlesource.com/886762Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#532362}
-
Donna Wu authored
This is a preparation work for MTP servicification. BUG=769630 Change-Id: I4ff39ddf9968ef35328c17b3ffefd6165b85725b Reviewed-on: https://chromium-review.googlesource.com/846659 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#532361}
-
Nico Weber authored
This CL was uploaded by git cl split. R=hbos@chromium.org Bug: 177475 Change-Id: I9bf72aa8640eb2d566687d126e89b0d1c24f2606 Reviewed-on: https://chromium-review.googlesource.com/889729Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#532360}
-
Nico Weber authored
This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 177475 Change-Id: Ia487f9629a4b9c129d6361a6720fd9782819ef80 Reviewed-on: https://chromium-review.googlesource.com/890064Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#532359}
-
Nico Weber authored
This CL was uploaded by git cl split. R=tzik@chromium.org Bug: 177475 Change-Id: Ibe37c2986bded10b271c0548b5fe375285504acb Reviewed-on: https://chromium-review.googlesource.com/889946Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#532358}
-
Gauthier Ambard authored
This CL cleans up the SideSwipeView, moving from trailing underscore for ivar to leading underscore. It also moves the ivar declaration from the public header to the private implementation. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4310bbb9a078668d96720fd01111d3522418a7bb Reviewed-on: https://chromium-review.googlesource.com/887201 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL invalidates the layout of the collection view displayed by the NTP (the content suggestions' one) when the frame changes. It allows to have a snapshot with the correct layout when opening a tab from the stack view. Bug: 806069 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2e79a0f9ec72e753d552006f1f31013f51173523 Reviewed-on: https://chromium-review.googlesource.com/888580Reviewed-by:
-
Gauthier Ambard authored
This CL adds the action to focus the omnibox from the omnibox button in the bottom toolbar. Bug: 804717 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id03a2aea1572bb2b23b2aa6733a5cdc1b96ccc33 Reviewed-on: https://chromium-review.googlesource.com/888583Reviewed-by:
-
Nico Weber authored
This CL was uploaded by git cl split. R=alancutter@chromium.org Bug: 177475 Change-Id: I691a0d422f4d22065d4d686be190efaeda0b97d5 Reviewed-on: https://chromium-review.googlesource.com/890065Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#532354}
-
