- 16 Jan, 2020 8 commits
-
-
Andrew Xu authored
The current code fails to adapt gesture scroll on scrollable shelf under RTL. This CL fixes the issue by inverting the sign of the scroll offset under RTL. Bug: 1042119 Change-Id: I1db81df09b6f0b4d54097c7bd5e746e84e6e903f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931438Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732198}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d5e7c35c508..737bab4e36f5 Created with: gclient setdep -r src-internal@737bab4e36f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042278 Tbr: jbudorick@google.com Change-Id: Ie8f4a80144483aaafa5c713c86b29e03f09f0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003748Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732197}
-
Robert Ma authored
In addition to console errors/warnings, we now accept alert/confirm/prompt as well. Also remove the temporary workaround added in crrev.com/c/1995474. Bug: 1041588 Change-Id: Ife40be2466db2b0d807d55252ca3c08b24889cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003608Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#732196}
-
Nick Harper authored
Change-Id: I293601adfc78aa56b52faa0dbed32ea5319256db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002942Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#732195}
-
Philip Rogers authored
This patch updates the CompositeCrossOriginIframes feature to promote (composite) cross-origin iframes. The original patch for this feature (https://crrev.com/708336) had a subtle bug because it did not change the self-painting status of the iframe's layer. To be composited, PaintLayers must be marked as self-painting (see: PaintLayerCompositor::CanBeComposited). This patch builds on the existing iframe compositing reason by adding a check for cross-origin frames in LayoutEmbeddedContent::RequiresAcceleratedCompositing. Because cross-origin changes now affect compositing, a call to Element::SetNeedsCompositingUpdate has been added when the cross-origin status changes in DocumentLoader::InstallNewDocument and LocalFrameView::CrossOriginStatusChanged. Bug: 1014273 Change-Id: I096fbad4921345df836b2a61c338cb4f4b5f79d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997639Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732194}
-
Klaus Weidner authored
Update the "source" link in samples to point to the Chromium modified versions. (The "View source on GitHub" link at the bottom still goes to the upstream immersive-web version.) For proposals/index.html, add a "variants" array that supports creating links to variants of the page with added query options, i.e. input source debugging for the AR samples. Change-Id: Iadba3107b18ebcb262ce10f46d708853ca119e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003396 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#732193}
-
Reid Kleckner authored
Clang recently disabled lax vector conversions by default, but Chromium relies on them. Add this flag until we can clean up the conversions. Skipping try bots because none of them should set llvm_force_head_revision, so this has no effect. TBR=thakis@chromium.org No-Try: True Bug: 1042470 Change-Id: Ibbb1c054f8bf72098e43694de2b22153bbc63fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003921Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#732192}
-
James Vecore authored
The test OSSettingsBluetoothPageTest.AllJsTests started being flaky after https://crrev.com/c/1954273 landed. This CL re-enables the test suite while skipping the single flaky js test for now. There is a simple fix for the failing test of repeating the await waitForListUpdateTimeout() however it is not well understood why this is necessary so it needs further investigation. See bug https://crbug.com/1042352 for the followup. Fixed: 1035378 Change-Id: I161165c01650c58fb74c2710e2957ad83add0a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999065Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#732191}
-
- 15 Jan, 2020 32 commits
-
-
Peter Boström authored
Bug: chromium:1038731 Change-Id: I9762a30586a86b5bfef9ae4a234e952923f95cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002894 Commit-Queue: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#732190}
-
Mike Dougherty authored
This reverts commit 534ab452. Reason for revert: Fails to compile on device. See https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/120373 Original change's description: > Disable testKeyboardHideState on iPhone > > Bug: 1041878 > Change-Id: Iae445f1161e1bd6d3de32de61921b70a9c1ffa7e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001197 > Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732187} TBR=rohitrao@chromium.org,lindsayw@chromium.org,javierrobles@chromium.org Change-Id: Id2e2cab9737ba9d9bb3ff5bfedeb4c0595bb35a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1041878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003918Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732189}
-
sangwoo authored
It seems .cc file was included by accident. Bug: NONE Change-Id: I09db820dcd46b6898b5da07ddb7baba0a20d1376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002270 Auto-Submit: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#732188}
-
Lindsay Pasricha authored
Bug: 1041878 Change-Id: Iae445f1161e1bd6d3de32de61921b70a9c1ffa7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001197 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#732187}
-
Manu Cornet authored
Let the callers just get them from the nav widget. Change-Id: Ie872e82b893f762f65839dbe5daf2a7cd0c9d24d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003392 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732186}
-
Tommy Li authored
In the omnibox, we've long had this niche feature, where if the user types "example" and presses Ctrl+Enter, we will navigate the user to "example.com". The way we implemented this was not sensitive to URL elision, so a side effect is that if the user was on "https://www.example.com", and the omnibox is displaying an elided "example.com", and the user presses Ctrl+Enter, the omnibox would downgrade the HTTPS to HTTP, navigating the user to "http://example.com". This isn't very exploitable, but kind of annoying, and not quite our intent. This CL makes it so that if the URL has not been edited, we will use the full unelided URL for Ctrl+Enter desired-TLD navigations. I don't anticipate merging this, as this is kind of a niche case. Bug: 1038746 Change-Id: Idf0c5295e09dc0c055333efaeba181949121fbdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001403 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#732185}
-
Becca Hughes authored
Add a playback sessions table to record media session data to media history. This also has a marker about whether this was complete or not and can return the most recent not complete playbacks. BUG=1041662 Change-Id: Icef42a4978b10ba9d9abd1a7bb2ea23e2f090b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999261Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#732184}
-
Jeevan Shikaram authored
This CL introduces a fix for tablet form factor devices. These devices have app list sync turned off, resulting in some sync code not running. This lead to an issue of default app ordering not being applied properly, specifically the default page breaks. Default page breaks are now installed when the model is built for app list, however this is only done so if the device is a tablet. Bug: 1031410 Change-Id: If4fb23b6f67a5de094e88bc478870f971ebf9a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997423Reviewed-by:
-
Henrique Nakashima authored
This is a part of FeatureUtilities that has no cohesion with the rest of its responsibilities. Bug: 1012975 Change-Id: Iaef2b7c7b2e57ec5a43eb8ff168e832bf567e8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999332Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#732182}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=ryansturm@chromium.org Bug: 1041419 Change-Id: I5c64a562b5a91207b51204fe58d679b1106d1425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994071 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732181}
-
Alex Cooper authored
Flag definitions were removed in crrev.com/c/1988967; however, a few declarations were missed. This change removes those missed declarations. Bug: 1039499 Change-Id: Ide42e71ed35df98f3bb7aec5aeda5c196b7d97ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002939 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
-
Mounir Lamouri authored
Bug: 1032394 Change-Id: I1694d8bc289a98ca366d9fdfb06ea148fbd400b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959792 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Stephen Chenney authored
In the process of fixing test crashes with the original patch, the metric was disabled because the reporter was getting cleared before the code that reported. Reorder things to fix it. Bug: 1041453 Change-Id: Iadb12ae73e113930ea36c03e3cfc097736632495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001188 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732178}
-
rbpotter authored
This test was flaking by timing out, particularly on the Mac 10.13 dbg bot. This indicates it was likely taking too long to run, and the test contains a very large number of sub-tests, so it is likely that the test was working correctly but was too slow. Split out the sub-tests into their own TEST_F calls, so that each test is much shorter to run, and re-enable the tests. This will also allow us to discover if there are certain subtests that are particularly slow or that hang, so we can disable/fix them individually without disabling the entire suite. Bug: 1038991 Change-Id: Ic3d1419f2c8d6cdc10f97a7cb9eb75354f87d16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001756Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#732177}
-
Alex Cooper authored
While previously purging WebVr from the repo, it seems like this file got missed. Change-Id: I2249874f65752ed3c143afa545ba5bb10cfbefbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003296 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#732176}
-
Fabrice de Gans-Riberi authored
Fuchsia build and tests have been run as part of Chromium CQ for some time now. This CL explicitly lists the platform as being supported. Bug: 10411459 Change-Id: I356835d344a1788eb300927d84ebbabdd5125ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995990Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=jrummell@chromium.org Bug: 1041419 Change-Id: I476454a428344042303d09daaa009e756f2dc4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995793 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732174}
-
Vasiliy Telezhnikov authored
This CL implements BeginFrameSourceWebView as a wrapper around parent BeginFrameSource and provide {Before/After}BeginFrame callbacks to support synchronous scrolling for WebView. It also implement subclass of it RootBeginFrameSourceWebView to replace WindowBeginFrameObserver. This essentially: * Finishes moving BeginFrame handling for WebView to WebView specific code as the all other code uses BeginFrames from viz. * Prepares BeginFrame code to be used with viz as it needs synchronous behaviour too. Bug: 805739 Change-Id: I189607907a323ee557337807fd1a835f033abf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997626Reviewed-by:Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#732173}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I96bf4e908fdf55a4dce471d3fb35469068326c68 Binary-Size: AR moving back into base apk crbug.com/1031623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002787 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#732172}
-
Caleb Rouleau authored
Fix the path to point to browser_tests since that is the name of the binary. Bug: 1039019 Change-Id: Ie9a9dc0671f2cf9a16b6ef2162adafb4176620df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003250 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
-
danakj authored
The RenderWidget is now deleted instead of being made undead, so drop all the code branches around undead state. This leaves a couple TODOs to be addressed in more followups. R=avi@chromium.org Bug: 419087 Change-Id: I579e4762bf1813c6e12229b8c81901b6e54cd1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001062Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#732170}
-
Alex Newcomer authored
If a page loads during a drag operation on the shelf, the shelf would hide. Remove an unnecessary call to UpdateVisibilityState which causes this. Bug: 1033259 Change-Id: If875ef4da5a3c6411640e9a77a0a32c112cd2aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995638Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#732169}
-
Nicolás Peña Moreno authored
This is a reland of 400050e6 Original change's description: > Fix toJSON in WindowPerformance and PerformanceResourceTiming > > Per https://heycam.github.io/webidl/#es-default-tojson, it is correct to > directly add the attribute values of the interface to the builder > instead of adding the results of toJSONForBinding(). > > Change-Id: I07f7ee5992de59938c0116f90dc4b5229c5d6e9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982792 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728540} Change-Id: I17040d340904260b1594c11dbfd4253c05412450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989577Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#732168}
-
Lindsay Pasricha authored
Bug: 1041873 Change-Id: I3d8a2a6a9eed43fe5d12680fc061eda880037da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000958 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#732167}
-
Kevin Schoedel authored
The ack status from blink needs to be fed to the gesture recognizer in order for javascript preventDefault() to work. Bug: b/145376493 Change-Id: I77317be12c8ca8154f4d0e31a94e5677499e4bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001341Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#732166}
-
Stephen McGruer authored
An incoming test, html/cross-origin-opener-policy/blob-popup.https.html, has non-deterministic output on failure. Add a TestExpectations-level expectation for it to make the importer pass. Bug: 1042347 Change-Id: I71067863e6938edf05a193d1c605e46c60022cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003438 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#732165}
-
Esmael El-Moslimany authored
Bug: 1032333 Change-Id: Ie9251367a335bff1c9da554c5b31e84a4816167a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995717 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#732164}
-
Daniel Nicoara authored
We need to observe this since this is how the cast apps size is updated from the renderer. For a slow loading page RenderHostFrame may not exist when the cast app is being shown so the EXO surface won't be sized when the WebContents are attached to the EXO surface. Since it wasn't observing we would never get a resize update. Bug: b/147376354 Test: None Change-Id: Idddf3cdadbf8a58b7b2506f3af8c4e5f16c92e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003609Reviewed-by:
-
Brian White authored
Disable flaky AppCacheNetworkServiceBrowserTest.VerifySubresourceFactoryClearedOnNewNavigation test. Bug: 1042385 Change-Id: I9ae218eaf185cc072e996babcbf260981e5589bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002759Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#732162}
-
Theresa Wellington authored
TBR=harringtond@chromium.org BUG=1042215 Change-Id: I493316c8277e6517c196e3bffd6422454cf1edbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003190Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#732161}
-
Charlene Yan authored
bubble title field when empty. Translation screenshots followed from these instructions: https://g.co/chrome/translation Bug: 1031660 Change-Id: If85035785653b7c452a6721ed49f057ed8f7922c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003208 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#732160}
-
Sammie Quon authored
The issue was the window was created on startup, then OnGetSwitchStates triggers TabletMode to start and create the screenshot since it detects a window animating. But the window doesn't destroy the screenshot because a |fps_counter_| is not detected on animation end because it is created in on animation schedules which happened before entering tablet mode. This CL aims to prevent this and similar bugs by not taking the screenshot if a window is already animating, so the only observed animation is the one triggered by entering tablet mode. This may have missed data or performance in some cases, but will prevent similar bugs. Test: ash_unittests TabletModeControllerScreenshotTest.EnterTabletModeWhileAnimating Bug: 1035356 Change-Id: I601d08ef50f214dbd262e5eea6baed40e5596270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999241 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
