- 23 Dec, 2020 40 commits
-
-
Ella Ge authored
make ReadCallback and WriteCallback use base::OnceCallback Bug: 1152282 Change-Id: Ie7c52a762e04c368fbecd0ed1dcec3c0ae8ab1c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600384Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839056}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/74788951af42..5c0ba5437be0 2020-12-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 54509765b18d to b29bf0434c16 (15 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: If4f32c0e2b4ac7e1b7b98c02319d8a41d8553b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601613Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839055}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0af374b04bee..ec8371fe0222 2020-12-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5eb6144f77ebd3abf7cad5bc166c29d8d3611b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601838Reviewed-by:
-
Xianzhu Wang authored
The crash happened when we committed from the main thread and the high res tiling was dropped because its scale was out of the range of min and max scales. To avoid the crash, remove SanityCheckTilingState() from CleanUpTilingsOnActiveLayer() to avoid the DCHECK failure at the beginning of UpdateTiles(), and call SanityCheckTilingState() from the original callsites after updating the tilings. Bug: 1160003 Change-Id: Id9cfb65158dc6c540e2316e4f062fe6299cd1842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599471Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839053}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I968023e15a7cce8e2a4b8b612d4224bbdc5fd5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601520Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#839052}
-
Josh Simmons authored
As we intend to merge this into 88, this check is controllable via the VoiceSearchAudioCapturePolicy feature. To keep this change small, hiding the mic is best-effort. There are cases where the user's profile is not yet available when layout decisions are being made. In those cases, we will continue to show the voice search mics, but will not initiate a voice search when the mics are pressed. Future CLs will add observers so the mic surfaces can be hidden as soon as the profile is available. Bug: 1161022 Change-Id: I772788288dc41b610f996c0b631e83e5cba117ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598008 Commit-Queue: Josh Simmons <jds@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#839051}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1608649072-95a4cf9b59101d6f6ea631f49afe5baa9a8b257b.profdata to chrome-win64-master-1608669833-81935a5ef3eac5be8a1967fe04891c8cf8108546.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I0af25cd5790276938575405efb3d5316a2395767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596894Reviewed-by:
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I784f58acb01fd54cc3efadf526ae0df5a5e9865f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600418 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#839049}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: I40255c5e8f4329fdf2fd7d2cb659890a0b9c308f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599569 Commit-Queue: Shengsong Tan <sstan@google.com> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Adds examples of creating a WebUIConfig and an UntrustedWebUIController for chrome-untrusted:// WebUIs. Bug: 1080384 Change-Id: I8927c134ecdf015524b34a5cb5c88f1c03bccde7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596900Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#839047}
-
Andrey Kosyakov authored
Bug: v8:11268, 1101897 Change-Id: I39bca561c0cf3daaf900648bf45c6d7989a36242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600273Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#839046}
-
Pavel Yatsuk authored
This CL introduces a logic to block trigering future Save Password messages for the current site. This logic is similar to "Never button" in Save Password infobar. For M88 Save Password message shows a menu with a single "Never" item. In the future we will introduce a modal dialog with other options. BUG=1160393 R=twellington@chromium.org Change-Id: Idecfb30827b123197a5ad5af06433e6a96dfad2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599118 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#839045}
-
Michael Hansen authored
This just updates the return value of registerForegroundReceiveSurface() to return an enum. The result is not currently used in any tests, but this change brings FakeReceiveManager inline with the mojo definition. Fixed: 1159672 Change-Id: I3e9e8925f7dd497e5590b75e4cdf308c4fb88838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601645Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#839044}
-
Frank Liberato authored
Tries to match existing behavior: - "ExternalDecoder" for hardware decode - "libvpx" or similar for software decode Bug: 1157225 Change-Id: If265a1d2b1036fa4d54cf64d31c4bf94c794ed46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596437Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johannes Kron <kron@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#839043}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.60. R=jam@chromium.org, rmhasan@google.com Bug: 1041619 Change-Id: If768786e3f80263d1cc2647c82a5cb87daa25270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601211 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#839042}
-
Noel Gordon authored
The ui/file_manager/file_manager/foreground/images directory contains the files app icons, including icons used by {Audio,Video} player and the Gallery extension. Update the local generate_image_html.sh script to look for SVG in the root sub-directories only: not the 2x sub-directories since they only contain "2x" PNG images. SVG images do not need / have "2x" variants. No-try: true Bug: files-app-icon-health Change-Id: I278d34cb5c2a7208b02f3fbd84248bbae028f584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599575Reviewed-by:Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#839041}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: If189e6aadc19fac405cd3eb08fc997902b0d3080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600322Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#839040}
-
Shengsong Tan authored
This is part of the "Views Posse" effort. See this document: https://docs.google.com/document/d/1Rst3792TjXtVA8k8GXaPD8MnuB1JAneSOpIILdA4268/edit?usp=sharing Bug: 1159562 Test: build Change-Id: Ifdff40cd0fc2a03e01c48accac9b452c55ff3ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600421Reviewed-by:
-
Findit authored
This reverts commit dbfed21f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 838974 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2RiZmVkMjFmOTQ4ODFhMjkxODIyMzc5MmViZGUzNDc2YjhmZDY5ZTYM Sample Failed Build: https://ci.chromium.org/b/8860163671563368608 Sample Failed Step: webkit_unit_tests Original change's description: > Fix several crashes when nested slots are removed from a ShadowRoot > > There were some crashes caused by nested slots (e.g. > <slot><slot>Content</slot></slot>) being removed from the tree. > These crashes were triggered by [1], which removed Shadow DOM v0, but > my theory is that due to the old V0 shadow root code, more calls were > being made to SlotAssignment::RecalcAssignment(). Now that the V0 code > is gone, it has exposed some missing code. > > Three issues are being fixed here: > 1. In Node::CheckSlotChange(), while removing the inner nested slot, > the parent_slot will have already been removed from the tree, so we > only need to call DidSlotChange if not. This used to be a DCHECK. > 2. In TreeOrderedMap::Get(), while removing a key that previously had > more than one element, we may walk the tree and find that none of > the pre-existing elements are present. I.e. we're in a RemoveScope. > In this case, the key should be removed from the map. > 3. In SlotAssignment::DidRemoveSlotInternal(), given #2 above, we can > just early-out if the slot isn't present in the map. > > I added a test for the crash conditions (variations on removing nested > named and unnamed slots), plus I added a test for the TreeOrderedMap > class, since there was none previously. The last test in the set > documents the new Get() behavior. I also tried to improve some of the > comments along the way. Finally, this CL rolls back a mitigation [2] > previously landed for this crash. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/2586019 > [2] https://chromium-review.googlesource.com/c/chromium/src/+/2595967 > > Bug: 1159328, 1159727 > Change-Id: I47fbf33b2313b9ae2efe229443af6e8c9a1920a9 > Cq-Do-Not-Cancel-Tryjobs: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597040 > Commit-Queue: Mason Freed <masonfreed@chromium.org> > Reviewed-by: Yu Han <yuzhehan@chromium.org> > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838974} Change-Id: I97202c545f74df090124e82775fe79ce978d3d63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1159328, 1159727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601758 Cr-Commit-Position: refs/heads/master@{#839038}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1608659974-90bda9b569e2cfcf8d7da1dcfbdd3d98c384729b.profdata to chrome-mac-master-1608681510-8927c83b5ccd266ea3bc0bb5c167b260db8cc2a2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib2c6fdcdb2522c78e158ba000ddf0ec96e23505a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601648Reviewed-by:
-
Sammie Quon authored
Fixed: 1158004 Test: manual Change-Id: I0254d28ff9a545cadb80d42b487b7f0e3514082f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599246Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#839036}
-
Sammie Quon authored
It was double counting because it recorded one visible desk change per root window. This CL keeps the same logic, but moves it to DeskActivationAnimation, so that the metric is only counted once. Also, extend the time fast forward in a flaky test. Bug: 1151856 Test: manual Change-Id: Ica101a25df867ce5b37bfce08699c2d4715a9230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587974Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1608659974-f24a1edbf2ebfb03ebc2935c99ccb8534f3f4c71.profdata to chrome-linux-master-1608681510-4320e883495a51de0d4ab86a576926e78aba732a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic3708045761951d11ad6a2210b50d71540d1f980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601649Reviewed-by:
-
Ella Ge authored
Bug: 1152282 Change-Id: Ic60eb67049d49e55f07314d1728a50b54d99115e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601221Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839033}
-
Andrey Kosyakov authored
This temporarily removes the newly added field from objects being dumped, so that the test expectations do not change when upstream CL lands. Bug: v8:11268, chromium:1101897 Change-Id: I8caa2bcf4a5b71250fb0712129771215c3a215bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601547Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#839032}
-
evliu authored
This CL adds a histogram metric to capture the percentage of Live caption users using the Speech On-Device API(SODA). Bug: 1159105 Change-Id: Ia67c60b59c5f5f9e670c8a8e531c11cbf40f7e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594171Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#839031}
-
Dale Curtis authored
Without this, these ImageBitmaps can't be shown on a canvas. R=eugene Fixed: 1161353 Change-Id: Iec73030e12c1f4149c2ea2bcfdb954b6f9bae6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601279 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#839030}
-
Lukasz Anforowicz authored
Code handling allowlisted extensions can be removed, because the allowlist has been deprecated and removed in M87 which started shipping to the stable channel on 2020-11-17 and was shipping to 100% of desktop users since 2020-12-07 (CrOS since 2020-12-09). Bug: 1098410 Change-Id: Ia14d40db668604da9bab0c784e6b7d54955e3b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556380 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#839029}
-
Frank Liberato authored
InitializeSignalingThread reads from `worker_thread_`, without synchronizing with InitializeWorkerThread which writes it. This CL moves the wait for IWT to before IST can run. Bug: 1160469 Change-Id: I9fd5f6341f900c1b9d43386c427b4086333e6f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601044 Auto-Submit: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
David Tseng authored
This is a reland of 39716b26 Original change's description: > Refactor intent usage in ChromeVox > > This is a purely refactoring change to set up ChromeVox to use all > possible intents. IntentHandler, the newly introduced class, will > cleanly process all intents, along with whatever computed metadata is > needed (e.g. EditableLine). > > R=akihiroota@chromium.org, nektar@chromium.org > > AX-Relnotes: n/a > Test: existing browser_tests --gtest_filter=ChromeVoxEditing*.* > Change-Id: I74d9454794fc6a40075bbf56fb0037b607c2b974 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594240 > Commit-Queue: David Tseng <dtseng@chromium.org> > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838241} TBR=akihiroota@chromium.org, nektar@chromium.org, dtseng@chromium.org Change-Id: I4fa306dc747cd623cdbb38f11c8ace144730af57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601639 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#839027}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/03d0309255ea..33bf309c1d45 2020-12-22 enga@chromium.org Update OpArrayLengthTests to use WGSL 2020-12-22 enga@chromium.org Update DepthStencilSamplingTests to use WGSL 2020-12-22 enga@chromium.org Update BufferZeroInitTests to use WGSL 2020-12-22 enga@chromium.org Update ViewportOrientationTests to use WGSL 2020-12-22 enga@chromium.org Update ViewportTests to use WGSL 2020-12-22 enga@chromium.org Update CreateReadyPipelineTests to use WGSL 2020-12-22 enga@chromium.org Update PrimitiveTopologyTests to use WGSL 2020-12-22 bclayton@google.com dawn_native/vulkan: Use EmitVertexPointSize transform If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibe5fc44f19c35dfffe7b907f08ae591f3888add3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600924Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f202babd6a03..3624aba91f44 2020-12-22 johnstiles@google.com Enforce additional restrictions on opaque types. 2020-12-22 johnstiles@google.com Implement bitCount intrinsic on SPIR-V and Metal. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Ice241db5f978544591fde7199b7c247bfbb271c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596893Reviewed-by:
-
Jérémie Boulic authored
Cleanup dependencies for targets: - main_background.m - main.m - test_util.m Bug: 1133186 Change-Id: I588eb808ee8f42ae6b211910c5da285d92179ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598090 Auto-Submit: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
As a part of clean up code related to ServiceWorkerOnUI, this CL removes RunOrPostTaskOnCoreThread() in ServiceWorkerContextWatcher. Bug: 1138155 Change-Id: Icce0ab49209026e6323d79d0541840e023a30b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600756 Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#839023}
-
Lan Wei authored
virtual/controls-refresh-hc/fast/forms/color-scheme/search/ search-appearance-basic.html is flaky on MAC bots Mac10.14 Tests. TBR=tkent@chromium.org Bug: 1161352 Change-Id: Iafc773f678633b29f4b662966e5421d8a7a3e724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601226Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/85707f7f7524..74788951af42 2020-12-22 syoussefi@chromium.org Vulkan: Fix assertion in xfb of indirect calls 2020-12-22 syoussefi@chromium.org Vulkan: GS tests that demonstrate gl_Position bugs 2020-12-22 jmadill@chromium.org Use Android API to get storage path. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1094062 Tbr: ynovikov@google.com Change-Id: I731ab7d4bc061211a06a2405126e6bc9a7adcc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601450Reviewed-by:
-
Bailey Herms authored
Added VLOG statements to client_side_detection_host.cc. These VLOG statements output the classification score, target digest, phash score, and emd score when phishing is detected. Bug: b/176131789 Change-Id: Ib19f35020e6d49f2a2ed4e2a6b1a9a40bba785f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600556Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bailey Herms <baileyherms@google.com> Cr-Commit-Position: refs/heads/master@{#839020}
-
Ken MacKay authored
This saves ~60 microseconds per posted task (~90% of posted task overhead). Bug: internal b/167285412 Change-Id: I1b644c0d5a68799e0852768078841831b6d437b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599583 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#839019}
-
Lei Shi authored
When a user resize or change a webpage, the selected inline nodes may be invalidated. To address this issue, we reuse the prior STS logic, which converts all selected content into node groups. Then, we send the node groups to TTS one by one. The only entry point for reading new content will be startSpeechQueue_, which uses updateNodeGroups_ to convert nodes into node groups, and start TTS using startCurrentNodeGroup_. This CL also refactored the names of variables and removed unnecessary variables. The prior CLs (http://crrev.com/c/2582524, http://crrev.com/c/2587799, and http://crrev.com/c/2587820) have modified navigation features so that they do not rely on navigationState_ anymore.Thus I implement the following rename and refactor: 1. Rename this.currentNode_ to this.currentNodeGroupItem_ since the variable is actually for a node group item. 2. Rename this.currentNodeGroupIndex_ to this.currentNodeGroupItemIndex_ since the variable is meant to be the index for node group item. 3. Add this.currentNodeGroups_ and this.currentNodeGroupIndex_, which are used for tracking the selected node groups and the current speaking node group. 4. Refactor this.navigationState_.currentCharIndex and this.navigationState_.isUserSelectContent. to this.currentCharIndex_ and this.isUserSelectContent_ to keep code concise. Also, we added a test for the case of invalidated nodes. Test credits to joelriley@google.com. Bug: 1160004 Change-Id: I92e0a1acc25265df476ea248be39d05ec06726d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587565 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#839018}
-
Ella Ge authored
Bug: 1152282 Change-Id: I136f70d9899f978da94f7793dc060c7f4ffcd468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601337Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#839017}
-
