- 10 Jul, 2018 40 commits
-
-
Fredrik Söderquist authored
Use CSSValue::Create(const Length&, ...) to produce values in unzoomed coordinates. This handles for instance calc(...) expressions correctly. Bug: 860204 Change-Id: I30e639c38dc49795d44a5e28cc1bf01734543730 Reviewed-on: https://chromium-review.googlesource.com/1126307Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#573893}
-
Fernando Serboncini authored
The underlying problem is still unsolved, but tracked here: http://crbug.com/862304 Bug: 861544 Change-Id: Iaa7fb137398520ead7f4fe2c1b6778251c1034f0 Reviewed-on: https://chromium-review.googlesource.com/1131829 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#573892}
-
Peter Mayo authored
This test no longer fails. I don't think it is testing the referenced bug very well either, since the positioning is not asserted by the test - just the presence. Bug: 847274 Change-Id: I9213f4d5cbc136027246b56b5d12837e6418775e Reviewed-on: https://chromium-review.googlesource.com/1131229 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573891}
-
Andrey Kosyakov authored
These are no longer used. Change-Id: I3f11ba4cd817e42022a13fcf2cb198ff9aef414c Reviewed-on: https://chromium-review.googlesource.com/1131923Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#573890}
-
Scott Haseley authored
Previously when a renderer died, e.g. crash/sad tab or OOM killed on Android, there was not a transition to UNLOADED. In these cases the WebContents is not destroyed, so the LOADING/LOADED tab counts would be inflated. Bug: 861800 Change-Id: I9d216d16d89d32a5ca11d1e1b901a1168c80d624 Reviewed-on: https://chromium-review.googlesource.com/1129373 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#573889}
-
Brian Salomon authored
This reverts commit 841c0dde. Reason for revert: Have to revert Chrome change Original change's description: > Avoid testing antialiased boundary in ScreenshotSyncIntegrationTest. > > Skia currently has a driver workaround that performans antialiased > rectangle edge equation evalution in the fragment shader rather than > vertex shader on Adreno 3xx GPUs. This was done because the interpolation > of values computed in the vertex shader lacks enough precision to pass > these tests. However, doing so has a negative performance impact. Skia > tests run with the workaround removed show that in practice the visual > difference is insignificant. Moreover, cc::GLRenderer also incurs these > same errors as it uses the same antialiasing approach without the > workaround and has shipped on Adreno 3xx devices for years with no known > complaints about antialiasing quality/accuracy. We're better off > reclaiming the performance and accepting a small hit to antialiasing > accuracy. > > Bug: 847984 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: If1e62e0780a752179a75ddd57ccc7b24128c68ac > Reviewed-on: https://chromium-review.googlesource.com/1129041 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Brian Salomon <bsalomon@google.com> > Cr-Commit-Position: refs/heads/master@{#573695} TBR=bsalomon@google.com,zmo@chromium.org,kbr@chromium.org Change-Id: Ib787aba372282504f047c129a9f0b3750668d1b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847984 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1132274Reviewed-by:
Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#573888}
-
Reilly Grant authored
Bug: 844953 Change-Id: I5a36a254228e1f5a13e1b24a11875f79be330464 Reviewed-on: https://chromium-review.googlesource.com/1123275Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573887}
-
rbpotter authored
Print Preview's cr-dialogs (destinations, advanced, and provisional) need to use the Print Preview text colors instead of the standard dialog text colors. The mixins overridden to do this were renamed in https://crrev.com/c/1121336 without changing their names in search_dialog_css.html, which caused the colors to regress again. Also add some checks in the destination dialog test to ensure this issue does not recur. Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I26ac07b57eae83ea8b5f4b3470cb4e2b1ba88373 Reviewed-on: https://chromium-review.googlesource.com/1130820Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#573886}
-
Francois Doray authored
A LifeycleUnit transitions to that state after a call to Unfreeze(). It stays in that state until the unfreeze actually happens. Having this intermediate state instead of transitionning directly to ACTIVE is important to be able to track when the renderer never notifies the browser that it ran the "onresume" callback. Bug: 775644, 855874 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Icf578cd12d113e569b017b604e4e835beeb331bf Reviewed-on: https://chromium-review.googlesource.com/1131845Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573885}
-
Joshua Pawlicki authored
TBR=dpranke@chromium.org Bug: 862215 Change-Id: I43022e2c46393e6cc5369bcef80993544f36660b Reviewed-on: https://chromium-review.googlesource.com/1132126Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#573884}
-
Antonio Gomes authored
This is a preparation CL that adds a way for tests to get a network::SharedURLLoaderFactory instance from BrowserProcess. Particularly, TestingBrowserProcess class can also set a SharedURLLoaderFactory instance for testing. It is used in [1]. [1] https://crrev.com/c/1066370 BUG=773295 Change-Id: I07fe87550abb63e0225b552f4b44ba865997534c Reviewed-on: https://chromium-review.googlesource.com/1130616Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#573883}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1d784ceafa9e..b77822b4442d git log 1d784ceafa9e..b77822b4442d --date=short --no-merges --format='%ad %ae %s' 2018-07-10 herb@google.com Remove the SkGlyphRunInfo code Created with: gclient setdep -r src/third_party/skia@b77822b4442d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I27ff14f3be6ef31a8b5f2ed79886b13536857378 Reviewed-on: https://chromium-review.googlesource.com/1131954Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573882}
-
Andrey Kraynov authored
Clean unused includes and add forward declarations for classes when possible to reduce size of headers. * Move implementation of the |Policy::UpdateContainerPolicy| function to the policy.cc file to avoid including SecurityOrigin header to policy.h. Bug: 242216 Change-Id: Ib8923f7715b5f321d52c58ca96a7a4bbaa0dcdc5 Reviewed-on: https://chromium-review.googlesource.com/1125935 Commit-Queue: Andrey Kraynov <iceman@yandex-team.ru> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#573881}
-
Alexei Filippov authored
BUG=803276 Change-Id: I60d7925104b8614aa68c135d52f6089a76675d22 Reviewed-on: https://chromium-review.googlesource.com/1128630Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#573880}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e02abc47..d07c1948 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d59161e3c34e7178cf87e478e914d42deb7094f Reviewed-on: https://chromium-review.googlesource.com/1131839Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573879}
-
Tim Dresser authored
First Input Delay was reporting bogus values in > 0.0006% of cases. The data suggests that this is due to invalid event timestamps. Bug: 861855 Change-Id: Ib3e6bb22348546f60dc6b98c6955e8620e87672b Reviewed-on: https://chromium-review.googlesource.com/1129843 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573878}
-
Sam Maier authored
We are shutting down Android's built-in AsyncTask.THREAD_POOL_EXECUTOR for all ChromeApplication processes, and having the Runnables sent there fall through to our own ThreadPoolExecutor. Currently, this ThreadPoolExecutor just matches the behavior of the framework's ThreadPoolExecutor, but having all Runnables fall through to our own ThreadPoolExecutor gives us flexibility to implement special functionality on the thread pool. Bug: 843745 Change-Id: Ie6d426601abc9a3bac975c28093f5d93d048d8be Reviewed-on: https://chromium-review.googlesource.com/1128161 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#573877}
-
Dominic Mazzoni authored
It was causing too many problems like being unable to inspect background tabs in chrome://accessibility and losing your place when switching tabs. We should come up with a better fix. Original change: crrev.com/c/1107207 TBR=nektar@chromium.org Bug: 854411, 856163, 856160 Change-Id: Iaef9b8ccbd47defba02e4e887f8219d00e77a808 Reviewed-on: https://chromium-review.googlesource.com/1131846Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#573876}
-
chrome://flagsCarlos IL authored
The previous description contained a long URL that was not wrapping, causing a scrollbar to show up in chrome://flags when the window for some window sized. The description was reworded to remove the URL. Bug: 860215 Change-Id: I687997b9eae09eb827a5483cf67ce9e0960a67b6 Reviewed-on: https://chromium-review.googlesource.com/1132083Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#573875}
-
Tiger Oakes authored
Updates to the infocard to improve style, readability and performance. An icon has been added to the center of the pie chart on container cards, similar to the icon shown on symbol cards. Text to describe the container type has also been added ("File", "Directory", etc) in the same style as the symbol type text. The infocard code has been rewritten to be class based, and the two types of cards inherit from the same base class. This improves readability of the code. The previous icon shown on the card is now cached. This means that if the next node displayed is of the same type (such as moving from a directory to another directory), then the corresponding icon will be reused instead of being cloned again. This improves performance by avoiding unnessecary garbage collection from the identical icon clones. Bug: 847599 Change-Id: Iabe9b5eca2173338aed3d99025d2cbd917aa7d0f Reviewed-on: https://chromium-review.googlesource.com/1132123Reviewed-by:agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#573874}
-
Thomas Guilbert authored
It appears that we can receive a null MediaTaskRunner when trying to create WMPI when the media thread is stopped. This causes a crash immediately after in HTMLMediaElement::StartPlayerLoad, when we try to post to |media_task_runner_| in PipelineImpl::SetVolume. It is unclear why the media thread would fail to start. The stack traces tied to the linked bug all show the Load timers being fired. This and the low crash rate suggest that it is an edge case of the defer load firing when the renderer is already going away. This CL checks for the value of MediaTaskRunner, and fails WMPI creation if we cannot acquire one. Bug: 775393 Change-Id: I05c4b1b4a191ac71f62eb69f9b0d11c1f5eb26e2 Reviewed-on: https://chromium-review.googlesource.com/1117645Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#573873}
-
Peter Mayo authored
Some of css/css-writing-modes sizing-orthog tests are passing. Let's latch in the successes. Bug: 626703 Change-Id: I9b065a8e03da4954a9737285ef7093330bc47ef3 Reviewed-on: https://chromium-review.googlesource.com/1131516Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Peter Mayo <petermayo@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#573872}
-
Khushal authored
The renderer drops the GrContext cache after a second of idle period, where idle period is identified as a continous period where the ContextProvider backing a GrContext is not used. Implement the same optimization for OOP raster in the GPU process. R=ericrk@chromium.org Bug: 859419,859635 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic2ae533212b94320cd8c1b8b1149cf5ba4ce686e Reviewed-on: https://chromium-review.googlesource.com/1123775Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#573871}
-
Kurt Horimoto authored
Bug: 861944 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I94b5233b12dab4809b7901d084c0aa76e02e4f35 Reviewed-on: https://chromium-review.googlesource.com/1130465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#573870}
-
Zhongyi Shi authored
Connection Migration V2: split the QuicChromiumPacketWriter's write blocked status into two separate invariants. - |write_in_progress_| is tracking writer status, and is set when an asynchronous write doesn't complete, or HandleWriteError/MaybeRetryAfterWriteError is in progress. - |force_write_blocked_| is tracking whether writer should be forced blocked regardless of |write_in_progress_|. QuicChromiumClientSession will set force_write_blocked to true when no alternate network is available or connection migration is in progress to complete to ensure no packets can be written until migration completes. QuicChromiumClientSession::WriteToNewPacket will undo force writer blocked. If packet writer becomes unblocked immediately or after the in-flight write completes, QuicChromiumClientSession::OnWriteUnblocked will be invoked to send a packet after migration. The packet can be a cached packet if |packet_| is set. If there's no cached packet, a queued packet will be sent if there's any, and a ping packet will be sent if writer is still unblocked. See http://crbug.com/859674 for detailed motivations. Bug: 859674 Change-Id: Icdbbb5e14f8439c6601e2c19d9a03f05f17d4bc0 Reviewed-on: https://chromium-review.googlesource.com/1125286 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#573869}
-
Christian Fremerey authored
Follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/1043646. Here we extend the support for raw file descriptors to the virtual device functionality. There is an incompatibility in the serialization of shared memory handles between the Mojo libraries used in Chromium vs. the older ones used in ChromiumOS. As a workaround, this CL allows clients of the virtual device API of the video capture service to ask it to use raw file descriptors for sharing shared memory handles instead. Note, this is only supported on platforms that use file descriptors for base::SharedMemoryHandle, i.e. Posix platforms. Design Doc: https://docs.google.com/document/d/1cmtWA8yua5sqjZC0tswVUZwJeQR-KSZBr3Mj1jUagKk/edit?usp=sharing Bug: 847598 Change-Id: I8a49e5181a622e14ea050cde27ad91ff7feda30d Reviewed-on: https://chromium-review.googlesource.com/1053210 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#573868}
-
Fernando Serboncini authored
Bug: 563816 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If09eece47845488c3da241b10bceb0e63aa06f7d Reviewed-on: https://chromium-review.googlesource.com/1131221 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573867}
-
Esmael El-Moslimany authored
Bug: 860699 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I16d40d0b7dbebffc6af6cf88d8f82cda39f42d47 Reviewed-on: https://chromium-review.googlesource.com/1130501 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#573866}
-
danakj authored
WebImage is a wrapper for SkBitmap, which we can just use everywhere so create and pass around SkBitmaps directly, instead of WebImages. WebImage only has static methods left then, which are mostly used from outside of blink, though FromData() is used internally as well, so it seems it should stay in public/platform/ for now. Image gains Image::AsSkBitmapForCurrentFrame() as a means to convert the current frame to an SkBitmap without constructing a WebImage. R=bauerb@chromium.org, haraken@chromium.org TBR=jam Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ieb71bde672d1acd84ec36a0e991d9ee44adba718 Reviewed-on: https://chromium-review.googlesource.com/1128365 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#573865}
-
Morten Stenshorne authored
Custom layout children may not establish new formatting contexts, and since the custom container itself is laid out by the legacy engine, we need to force its children to be laid out by legacy as well. Added a margin collapsing test that used to fail in NG because of this. Change-Id: Id320f60fb76b0ed6563fb2b88f6936ac37efc1fd Reviewed-on: https://chromium-review.googlesource.com/1131179Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#573864}
-
Chris Harrelson authored
It was fixed by CL 1125302, but the disable happened in parallel with that CL. Bug: 860031 Change-Id: If505fbcd255daf2da765f1d2f381c286d52efbe5 Reviewed-on: https://chromium-review.googlesource.com/1131815 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573863}
-
Koji Ishii authored
This patch changes NGPaintFragment::DebugName to be more informative to make reviewing paint changes easier, as suggested by atotic@ in CL:1128683. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I3255788fea8de74319ffdcc4f4f6ca1e00e0b2e2 Reviewed-on: https://chromium-review.googlesource.com/1130955Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#573862}
-
Dmitry Bezheckov authored
R=thakis@chromium.org Test= base_unittests.ProcessTest.WaitForExitWithTimeout. To reproduce use memory sanitizer (msan) Bug: 861726 Change-Id: If82e2ae32ba71572fa0ec85595b4a00f9a046a1b Reviewed-on: https://chromium-review.googlesource.com/1126927Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#573861}
-
Orin Jaworski authored
Answer icons were being rendered using an odd/even technique with a circle of diameter 24, but the internal icons were not properly sized. Now the icons are kept intact with the original design size of 16, and the circle is rendered manually. Bug: 841594 Change-Id: I5d31e43c4c0bdb70f6fe7dcbb85228a268d73571 Reviewed-on: https://chromium-review.googlesource.com/1130350Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573860}
-
Francois Doray authored
A lot of tests indirectly depend on TabManager. To avoid having to initialize metrics::DesktopSessionDurationTracker in each of these tests once UsageClock is used in TabManager, this CL makes UsageClock resilient to the absence of metrics::DesktopSessionDurationTracker. Bug: 775644 Change-Id: I6ae9a5a01f867df483c334da6df1a7f6510a7702 Reviewed-on: https://chromium-review.googlesource.com/1131929Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573859}
-
Mohsen Izadi authored
ServerGpuMemoryBufferManager uses a thread task runner to make sure tasks are run on the expected thread. This CL passes in a task runner to the constructor so this can be done against a thread other than the one that created the instance. This is to make ServerGpuMemoryBufferManager ready to be used in content where buffer allocation happens on IO thread. BUG=733482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie864e827de7f0464e2518316c4b7880a347f4074 Reviewed-on: https://chromium-review.googlesource.com/1131559 Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#573858}
-
danakj authored
R=dcheng@chromium.org, gab@chromium.org, kylechar@chromium.org Change-Id: Ida5db202ad12fc66e671ca74ec8aa0b81c6159c9 Reviewed-on: https://chromium-review.googlesource.com/1131828Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#573857}
-
Min Qin authored
If download resumes when only service manager is running, download controller could be called when there is no BrowserThread. The BrowserThread will only be introduced when full browser is started. Remove these 2 DCHECks as they will no longer be accurate. BUG=842245 Change-Id: I8ae4819852465fa2a88240fddedf3c0b6dc0d8fb Reviewed-on: https://chromium-review.googlesource.com/1129627Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573856}
-
Lindsay Pasricha authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I56e160def6e650e65bd1861e6143894072546b4c Reviewed-on: https://chromium-review.googlesource.com/1118845 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#573855}
-
Reilly Grant authored
This change updates the Web Bluetooth WebIDL files to match the recently merged pull request #402 by hiding interfaces which aren't useful in insecure contexts. Bug: 860798 Change-Id: I59fb1d0765754fce2eb6aefc458f550b09422c96 Reviewed-on: https://chromium-review.googlesource.com/1128462Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#573854}
-