- 04 Mar, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/393efd6d94e4..66e045655d89 git log 393efd6d94e4..66e045655d89 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 jacktfranklin@chromium.org Migrate `replaceControlCharacters` to StringUtilities Created with: gclient setdep -r src/third_party/devtools-frontend/src@66e045655d89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94c8e6d5fcc2a5181665dd5ec159684480a21f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087177Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746733}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/028a7a725cc6..d62881ce79c8 git log 028a7a725cc6..d62881ce79c8 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src f32bf1c930c8..97484d689869 (16 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e1688b60caf7..a6d3a2dd41d4 (1 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 176f3a3dbbc9..126720bd2e57 (2 commits) 2020-03-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src 56364b6b6026..8985fc91089f (2 commits) Created with: gclient setdep -r src/third_party/angle@d62881ce79c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I0a3f11d98a5675b351b1324101b1ba259459253b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087178Reviewed-by:
-
Mohamed Amir Yosef authored
Bug: 1044038 Change-Id: Id4f53493068b51d3a42ea23ac626b3251554b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083308Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#746731}
-
Michael Lippautz authored
Incremental steps may process ephemerons. When we are at a very deep stack there's a chance that the hang monitor interrupts us because InvokeEphemeronCallbacks is taking too long. Add deadline logic to InvokeEphemeronCallbacks to make the situation even more unlikely. Bug: 1058151 Change-Id: Ic0d455097284be83314c1e4dce6e29803bc33d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087391Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746730}
-
Hirokazu Honda authored
This is a reland of ed3b55f6 Original change's description: > media/gpu/test: Group ivf frames whose timestamps are same > > The served stream in webrtc can be dumped by the chrome > option [1]. When the stream structures spatial-layers, one > spatial layer is separately saved in one ivf in the dumped > ivf file. > > On the other hand, to play the ivf file properly, it is needed > to group the spatial layers, which have the same timestamp in > ivf frame header. IvfFileReader [2] in webrtc does so in fact. > > This applies the group logic to our own ivf parser used in > VDA test. This enables us to test SVC stream in VDA test. > > [1] --force-fieldtrials=WebRTC-DecoderDataDumpDirectory/;tmp; > [2] https://source.chromium.org/chromium/chromium/src/+/master:third_party/webrtc/modules/video_coding/utility/ivf_file_reader.h > > Bug: 1044816 > Test: video.DecodeAccel.vp9_ksvc > Change-Id: I9a0bcfa9083dc71333ad3c727d6cbb6d902202bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032453 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: David Staessens <dstaessens@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740575} Bug: 1044816 Change-Id: Ic617db810b7d46e2065b6363d27ac1326b35abbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072341Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746729}
-
Tim van der Lippe authored
This test appears to be a noop and it is unclear what the original intention of the test was. R=aerotwist@chromium.org Change-Id: I9c398c0af9761f7ffdea8326c8be51f79dcd4f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083309 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Cr-Commit-Position: refs/heads/master@{#746728}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f1fe4488c8cf..cbf6d8deb6c9 Created with: gclient setdep -r src-internal@cbf6d8deb6c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6f1b898e94f6d26038603418569e852424e78dba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087176Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746727}
-
Jose Lopes authored
This is a repeating callback because SplitRange causes SourceBufferRange to return a new instance of that same class, and both instances share the callback: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_range.cc?rcl=e501b7156b763939111552df391c615761c3c1bf&l=273 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007805 Change-Id: I9847d5ef4590bd86ec8b6c221884368d28181a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080477 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#746726}
-
Stepan Khapugin authored
Just moves ownership of BrowserViewWrangler to SceneController. It is still created by MainController. Bug: 1045658 Change-Id: Ie886cf0e54b236e66aa07ffe33be840fac327623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084993 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746725}
-
Keishi Hattori authored
Bug: 1044268 Change-Id: I00f1c5f368ba5f97b0507c1b24f6396d2bb8eb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087192Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746724}
-
Mohamed Amir Yosef authored
Before this patch: FindBestMatches deduplicate credentials using only the username. As a result, if two credentials with the same username exist in both stores, only one is returned. After this patch: FindBestMatches does the deduplication within account and profile store separately. Bug: 1057647 Change-Id: I0e4d321c907ee370ad6d3b42933b8aa7efd1158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084992Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#746723}
-
Stephen Nusko authored
When generating input events for fling updates, use the current animation time instead of the current clock ticks. This ensures latency measurements for fling animation frames are correctly aligned with BeginFrame timestamps. We've compared the computation of the deltas which are producer for the scrolls for various phones to ensure this is an improvement in animation smoothness. The thing to note when looking at these screenshots are the smoothness of the curve (ignoring the flat parts). For more details about how these are generated see internal bug: b/149825814 Nokia: https://drive.google.com/file/d/1Y2aPWatHg6ON98HosY9KYrgLM2SeGT_j/view?usp=sharing Pixel2: https://drive.google.com/file/d/1Va7ojVlQdk8NLdtCjdxntU5zjMUFlgbP/view?usp=sharing Pixel4: https://drive.google.com/file/d/1iazS1N1odhOqpGWTEjh_VRFi0VubZYwi/view?usp=sharing Change-Id: I7383539605f9588640c86b7342b4d93f0d65ccb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052174 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746722}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates SyncController class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I662b1b9ba4276d76c1ec2dc06cca36ae192c43ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085272 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Adds basic UI tests for the consent, empty credentials and stale credentials screens. Bug: 1045448, 1045452, 1045453 Change-Id: I1b103fb09f84ddc2c1b1e8dd27d718a92541d75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086232 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746720}
-
Christian Dullweber authored
SitePerProcessMouseWheelHitTestBrowserTest.MouseWheelEventPositionChange is flaky on multiple Linux bots. Tbr: alexmos@chromium.org Bug: 1033388 Change-Id: I395f75fbf7ec928df4803bef60d34fb5d5b68b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087392Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#746719}
-
Mohammed Abdon authored
Removing session activation observer for account id in case they exist Bug: NA Change-Id: Iac08d08f2b0dab1cc6eda922267c902b036822a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082925Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Mohammed Abdon <mohammedabdon@chromium.org> Cr-Commit-Position: refs/heads/master@{#746718}
-
arthursonzogni authored
One comment was: ~~~ // This is nullptr when the worker is still starting up (until // CompleteStartWorkerPreparation() is called). ServiceWorkerVersion* running_hosted_version() const; ~~~ This is not true (anymore?). The pointer is constant and never null. Bug: 1031542 Change-Id: I44907a27c65a6ad228014f0ad4fbeded8bbab807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083456Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746717}
-
Rainhard Findling authored
* Safety check buttons are now either normal (white background) or action buttons (blue background). * This synchronizes the safety check UI with the latest UI mocks, which differentiate different levels of calls-to-action by their importance. Bug: 1015841 Change-Id: I5c4b4444033b041735656ed58eceb34cfb036942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080249Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#746716}
-
Mathias Bynens authored
This patch makes it possible to emulate various vision deficiencies, including color vision deficiencies and blurry vision, in the Blink Renderer. The various deficiencies can be triggered by the new Emulation#setEmulatedVisionDeficiency command in the Chrome DevTools Protocol. Design doc: https://goo.gle/devtools-cvd Bug: chromium:1003700 Change-Id: Ie86d14b215b93aa219b91b0e7877898d2d47bc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063136 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#746715}
-
Jose Lopes authored
This is a repeated callback because it's called from a while loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=db95e8ed4d10f4770b37e265ca78c906e344c6ef&l=212 * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_h264.cc?rcl=db95e8ed4d10f4770b37e265ca78c906e344c6ef&l=361 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 TBR=danakj@chromium.org Bug: 714018 Change-Id: Ifb0f1119c2ed834bdfa4328afce0931c7776a626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080354 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Ioana Pandele authored
The experiment is now over and needs to be disabled. Bug: 1021013 Change-Id: I90b835de241c0692bd8b12a8a22bc7b6113ffaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074639Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#746713}
-
Friedrich Horschig authored
This reverts commit 76648dac. Reason for revert: As described in crbug.com/1056527, Android WebView still relies on this. An upstream fix is too risky so I'll revert this CL for now. Bug: 1056527 Original change's description: > Remove redundant OnEndEditingTextfield event > > The event OnEndEditingTextField seems to be redundant (esp. with focus > changes) and isn't correct in all cases: If users interact with native > UI like an autofill dropdown, the event will try to close this piece of > UI although this isn't always necessary. > > This CL therefore removes the event which allows dropdowns to remain > open after interaction if they require it (e.g. see use case in linked > bug). > > Bug: 1043963 > Change-Id: I5c7a6ede34fb574bd3f91d4b16fbb4e2a78a8d24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034527 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738105} TBR=vasilii@chromium.org,dvadym@chromium.org,fhorschig@chromium.org,ajgo@chromium.org Bug: 1043963 Change-Id: I3bf88ec43fa6ae9bf0d11f295bc1b0debbba71ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087331Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#746712}
-
Javier Ernesto Flores Robles authored
Renames no credential illustration imageset to fix extension compilation. Bug: NA Change-Id: I05e34571871255d907b7476a8f123dd6ab506f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085252Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#746711}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f92fd4849f47..393efd6d94e4 git log f92fd4849f47..393efd6d94e4 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 jacktfranklin@chromium.org Remove `String.isDigitAt` Created with: gclient setdep -r src/third_party/devtools-frontend/src@393efd6d94e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8131a19b8f49597dd928af45654f99b4bbcac5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087174Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/024aa8877850..0fd4f5cda74d git log 024aa8877850..0fd4f5cda74d --date=short --first-parent --format='%ad %ae %s' 2020-03-04 eseckler@google.com Merge "protos: Add support for counters in TrackEvent" Created with: gclient setdep -r src/third_party/perfetto@0fd4f5cda74d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I05718732cc24b49940d0c7971223d7524d52e309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087172Reviewed-by:
-
Christian Dullweber authored
This reverts commit e19d9ff7. Reason for revert: broke virtual/web-bluetooth-new-permissions-backend/external/wpt/bluetooth/idl/idlharness.tentative.https.window.html Original change's description: > bluetooth: Implement FakeBluetoothDelegate > > This change implements FakeBluetoothDelegate which fakes the behavior of > the new Web Bluetooth permissions implemented behied the > WebBluetoothNewPermissionsBackend flag. Therefore, the > web-bluetooth-new-permissions-backend virtual test suite runs the Web > Bluetooth tests with this flag enabled. > > Design doc: > https://docs.google.com/document/d/1h3uAVXJARHrNWaNACUPiQhLt7XI-fFFQoARSs1WgMDM/ > > Bug: 577953 > Change-Id: I5f81b92433009fc34a6a5e5495fdba72500db41e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080813 > Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746429} TBR=peter@chromium.org,scheib@chromium.org,reillyg@chromium.org,odejesush@chromium.org Change-Id: I32caff48eb12c6bc1c0517a897e996f0d9276c1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 577953, 1058319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087332Reviewed-by:
-
Alex Ilin authored
This reverts commit 8698d875. Reason for revert: causes AutofillAssistantFormActionTest#testFormAction fail on Lollipop Phone Tester https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/24483 Original change's description: > [Autofill Assistant] Hotfix for radio buttons in FormAction. > > Without this CL, UI and model can go out-of-sync when tapping the radio > button directly (see screenshots in linked bug). This is a hotfix for > this issue. A proper fix requires a refactoring of the FormAction to > make the selection state part of its model (same as was done for the > T&C selection state in the CollectUserDataModel). > > Bug: b/150201921 > Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489 > Commit-Queue: Clemens Arbesser <arbesser@google.com> > Reviewed-by: Mathias Carlen <mcarlen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746539} TBR=mcarlen@chromium.org,arbesser@google.com,marianfe@google.com Change-Id: Ie495ee0ae938de693dd9b5667086dca05b5d9d32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/150201921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087571Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#746707}
-
Jose Lopes authored
This is a repeating callback because it's called from a while loop: * https://cs.chromium.org/chromium/src/media/formats/mp2t/es_adapter_video.cc?rcl=2d18a6603bb1f5bbe784dad83e7cad005808686a&l=166 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I3b7dfb4b58ec6918ebc4dc504b839bddd115c64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080261 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fdaf67e5529..f1fe4488c8cf Created with: gclient setdep -r src-internal@f1fe4488c8cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8d2a986c634a7e4ad45487d7adb1e2eae88876e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086995Reviewed-by:
-
Carlos Caballero authored
A navigation might start but not commit, that is the navigation fails and the page will not change. A good example thereof is a navigation that returns a 204. Still in this case some state will have been cleared in the DidStartNavigation method. Which means the state shows does no longer correspond to the page we are on. There is really no reason to not wait until DidNavigationFinish to reset all this state, so this patches does so. The only exception are cookies, as these might get accessed during the navigation. A follow up patch will take care of these. Bug: 998171 Change-Id: I6146986a8b146128fad388da88f4fd2238571822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895512Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746704}
-
Anastasiia Nikolaienko authored
This is a reland of e78513d7 Original change's description: > Migrate authenticator.js and it's dependencies to JS modules > > Bug: 1054394 > Change-Id: I106bd0edc547dc6eb2d680b409d1348d5b964079 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066548 > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745762} Bug: 1054394 Change-Id: Ie1a63f522f5e29b2af327010236f962836a36074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083317Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#746703}
-
Mario Sanchez Prada authored
Based on crrev.com/c/1847304, by Colin Blundell <blundell@chromium.org> This CL starts converts the message that kills the renderer, on top of the infrastructure already laid out by crrev.com/c/1991446. In addition to that, this CL implements the required changes to move to a model where the mojo pipe for RenderAccessibility is only valid while a kWebContents-compatible accessibility mode is enabled, in order to address some security-related concerns. And it also adds a new unit test to check that this new logic works as expected (i.e. that the mode changes in the renderer when the pipe is closed from the browser side). Bug: 1010831 Change-Id: Ic71c33f654af9fbc1c453d2aa04c858e8285c1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015045Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#746702}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e1688b60caf7..a6d3a2dd41d4 git log e1688b60caf7..a6d3a2dd41d4 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 andreperezmaselco.developer@gmail.com Refactor FuzzerPass::ApplyTransformation code duplication. (#3206) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a6d3a2dd41d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ie83162057831184bf50b5ba5eba19e4b2c9c090d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087171Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e9493f29dbf..028a7a725cc6 git log 9e9493f29dbf..028a7a725cc6 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 ancheng.qiao@arm.com Skip if GL_EXT_texture_compression_dxt1 isn't supported Created with: gclient setdep -r src/third_party/angle@028a7a725cc6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: I4b79ec813633c06b5dd08481b4a0f1ebd9a5d355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086991Reviewed-by:
-
Kent Tamura authored
- DidDetachLayoutTree() - DidRecalcStyle() - DidSetSuggestedOption() - PopupDidHide() Move parts of the contents of DetchLayoutTree(), DidRecalcStyle(), SetSuggestedOption(), and PopupDidHide() of HTMLSelectElement to them. We need to call SelectType::DidDetachLayoutTree() in |HTMLSelectElement ::ChangeRendering()| before replacing select_type_. When a SELECT changed its type from MenuList to ListBox, DetachLayoutTree() in this function triggered the popup-disconnecting code after switching to ListBox. After this CL, select_type_->DidDetachLayoutTree() in DetachLayoutTree() doesn't trigger the popup-disconnecting code because select_type_ is a ListBoxSelectType. This CL has no behavior changes. Bug: 1052232 Change-Id: Iaff5691a670bd7570c7c47334f548cc84c4dc0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084332Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#746699}
-
Frédéric Wang authored
This CL implements new API in order to determine metrics of stretchy math operators and shape them, following the algorithm of [1]. This will be used to implement stretchy MathML symbols (for radicals and operators). It relies on information from the OpenType MathVariants table [2] and corresponding iterators implemented in [3]. [1] https://mathml-refresh.github.io/mathml-core/#the-glyphassembly-table [2] https://docs.microsoft.com/en-us/typography/opentype/spec/math#mathvariants-table [3] https://chromium-review.googlesource.com/c/chromium/src/+/2074678 Bug: 6606 Change-Id: I362edd91fa0ff7f1d2da4381dac1e731be1e0858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051923Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#746698}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8985fc91089f..c40c4bc38a76 git log 8985fc91089f..c40c4bc38a76 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 johnkslang@users.noreply.github.com Add "news" section and component status. Created with: gclient setdep -r src/third_party/glslang/src@c40c4bc38a76 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ide6e636cc97c1529aee89a1e590c8a1781523b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087031Reviewed-by:
-
James Cook authored
We're breaking the SplitSettingsSync project into two milestones: SplitSettingsSync is now: 1. The new OS sync settings section 2. The new OS prefs data model type 3. Toggles for Apps, OS prefs, Wallpaper and Wi-Fi in the new section 4. OS data types use the sync transport layer The new "SplitSyncConsent" feature is: A. New out-of-box consent dialog for OS sync B. Browser sync opt-in flow on Chrome OS C. Unconsented primary account on Chrome OS This CL adds the new base::Feature and moves the appropriate parts of the code to the new flag. Bug: 1013466 Test: updated browser_tests and unit_tests Change-Id: I5439b7dbac29a3a242e82ff63e099512e2aac655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073161 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746696}
-
Chih-Hsuan Kuo authored
Bug=1054761 Test=build and pass CQ Merge-With: eureka-internal/367058 Change-Id: I64e33d87398eab09704ea63b6eaf8e3922e3f98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066397 Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746695}
-
Omer Katz authored
All known data races in HashTable based collections have been resolved. Bug: 986235 Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#746694}
-
