- 26 Jun, 2020 40 commits
-
-
Andrew Grieve authored
Why do this? * It's best practice to target the latest sdk, so this makes for a better default. * Many targets were neglecting to ever update this value TBR=agrieve # Minor BUILD.gn refactoring Bug: None Change-Id: Idb3983bcfb7a1ddaf13900e0acdbee425a450225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265513 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783112}
-
Maksim Ivanov authored
Move the code in the certificateProvider API that parses the certificate into a separate function, so that it's reusable from the implementation of the new certificateProvider API (that will be added in a follow-up CL). Bug: 1078761 Change-Id: Iec9a9dc76f39b7463da21f8e1f21e7b08e69c126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247784 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#783111}
-
Mitsuru Oshima authored
* add no_deps checks * moved the ownership of surface managers to Display. Bug: 1090616 Change-Id: If6f68cc1af7e8f86e048963e527bdfd5e9f6b617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250895 Commit-Queue: Mitsuru Oshima (OOO) <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#783110}
-
Dale Curtis authored
Per AAudio authors this call may not always be asynchronous. R=tguilbert Bug: 801435 Change-Id: I0beec009bdd500c05a00fe00c98585b168f2dd99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269749 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#783109}
-
Scott Violet authored
This is a copy of the desktop expectations. BUG=626703,1025626 TEST=none Change-Id: Id0918c640a45644e96590e5d8f38c96f276d5ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270684 Commit-Queue: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#783108}
-
file:///Joshua Bell authored
Regular file names (but not folder names, or metadata) were marked "draggable", which implcitly made them non-user-selectable. Explicitly mark them with "user-select: auto". Bug: 1083760 Change-Id: Ide7a7153c0dcd9331dea33323eeac36599bb7757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268298 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#783107}
-
Tarun Bansal authored
Add logic to delay invoking the offline indicator callback if the app is in background. When the app is brought to foreground, the offline notification is not sent immediately. Instead, OfflineDetector waits for 2 seconds before invoking the callback. Change-Id: Ic48d63baa5e0b4e809cdce2681a824b0b269a7a9 Bug: 1093574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253154 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#783106}
-
David Bertoni authored
ExtensionApiTest.FileAPI was disabled many years ago for a Webkit roll issue and should have been re-enabled once that was fixed. ExtensionApiTest.XHROnPersistentFileSystem was flaky on Linux, but was disabled on all platforms. It showed no flakiness on any platform. Bug: 671144 Change-Id: I34345161bcc9d2c19579ad76e0293fba8adf3859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268643Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#783105}
-
Adam Langley authored
Change-Id: I3d1f5a8773a6ee6f81039c141e428e6df415cfce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255213 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#783104}
-
Toni Barzic authored
The icons used to be resized by MenuItemView, but that recently changed. This makes sure that icons in the shelf/app list context menus have correct size. BUG=1097624 Change-Id: If9f2f8d9d24302637253ccb0d3e7dea2b10113e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269538Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#783103}
-
Etienne Pierre-Doray authored
This reverts commit 6eb566d2. Reason for revert: Cause failure in CheckedLockImpl::Acquire crbug.com/1099649 Original change's description: > [Jobs API]: Use worker_lock in JobTaskSource. > > Possible race when Join(): > - thread A: Join: worker_released_condition_->Wait() > - thread C: WillRunTask: > GetMaxConcurrency() returns > 0 > - thread B: already running, finishes all the work > GetMaxConcurrency() goes 0 > - thread B: DidProcessTask: > worker_released_condition_->Signal(), > - thread A: Join returns (GetMaxConcurrency() is 0) > - thread C: TryIncrementWorkerCountFromWorkerRelease > worker count goes 1 > - thread C: runs worker_task after Join > > To fix race when Joining, all writes to |state_| are protected by > |worker_lock|. Memory ordering is no longer necessary. > > Alternative: cancel before Join returns with a compare and swap and > loop again if new workers. > > Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781453} TBR=gab@chromium.org,etiennep@chromium.org Bug: 1099649 # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I4860090b05afdc8b1e29fbdf2b984756ffbf08c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270618Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#783102}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a14393ff9a04..09fbf76efc8b 2020-06-26 sigurds@chromium.org [cleanup] Correctly reference SourceRange in UIUtils If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I06efefadc2f2e2515b18e45bed0a5d0b5e288758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270530Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783101}
-
Jesse McKenna authored
This change makes ScopedBufferLock more readable by replacing the confusingly named UnlockedNoncontiguousBuffer() with IsContiguous(), and instead unlocking the 2D buffer as part of the fallback to LockSlow() if the 2D buffer is noncontiguous. Change-Id: I446de78823c99422e9a2a2675a4ddb2dce7ec0d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268592Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#783100}
-
Maksim Ivanov authored
Extract the code related to API event creation in the chrome.certificateProvider API into separate functions. This is preparation CL for the introduction of the new version of the chrome.certificateProvider API. No functional changes expected - this is a pure refactoring CL. Bug: 1078761 Change-Id: I2324a07b6db6fae0d8e1cc634ea0bfd865168b2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247781 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#783099}
-
Andrew Grieve authored
E.g. showed on this code review: https://chromium-review.googlesource.com/c/chromium/src/+/2258578 I've found that it's basically always the case that when this number grows significantly, that it's from string literals. Bug: None Change-Id: Id3889d164dd2d85860fd01025de3d84a1cded5f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269738 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783098}
-
Collin Baker authored
In normal mode, BrowserView's layout is invalidated if the top container's preferred size changes. In immersive mode, this wasn't happening since the top container is held under a sibling view. To ensure BrowserView's layout logic is used in this case, the overlay view it provides is changed to propagate preferred size changes to BrowserView. Fixed: 1096569 Change-Id: Ibf4166422f178b28a652a5f9956eaf5bd913a8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265412Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#783097}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifc8c1f09caecda5f94d6a5a3bf59e0b26a0fa707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269743Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783096}
-
Abhijeet Singh authored
This CL allows the QuickAnswersView to gain focus when it is created by pressing the "Got it" button on the UserConsentView or when an answer is updated after clicking the Retry button, since these are explicit user actions. This allows for a more consistent experience, more so when the screen-reader is enabled. Bug: b:152059023 Test: Tested on Atlas test device. Change-Id: I6a6ba338c2ffbf8b03bdaf4d8adf2f0a158746f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268474 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#783095}
-
Ng Zhi An authored
Proper fix for process-graph.py (changes were reverted in https://crrev.com/c/2266652). Bug: chromium:941669 Change-Id: I38242be26371246a33a88630a1480ce8446b7680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267737 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#783094}
-
Kevin Marshall authored
Allows a value to be specified for "--max-decoded-image-size-mb" on Fuchsia WebEngine, which prevents very large images from using up all available RAM. Some decoders such as JPEG are able to decode to subsampled buffers when decoding image files with very large dimensions. For other formats which do not have this capability, decoding is blocked if the image is too large. Bug: 1096748 Bug: b/159385040 Change-Id: I0298aa903fea97e9e22aac8d37a910819d99730d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258362 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@google.com> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#783093}
-
John Williams authored
Bug: 1095222, b/159069899 Change-Id: I98eefb2eaa7b7086a26590a09bfc811b854e8e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264497 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#783092}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c9f311e46255..5046324e5fc5 2020-06-26 cwallez@chromium.org Skip MultithreadingTest.MultiCreateContext on Ozone 2020-06-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll VK-GL-CTS from 23498d296498 to 2e189d3854db (1 revision) 2020-06-26 cwallez@chromium.org Suppress dEQP GLES3 attribute aliasing on Vulkan If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I6da7082f40c077788a66923115544b4cf6f82792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783091}
-
Henrique Nakashima authored
- Make centering force proportional to the available space in each dimension to use the screen better. - Stronger repulsion between nodes to make the labels easier to read. - Run the simulation for longer before freezing it. Bug: 1093962 Change-Id: I3c663ab6a827998e2112f22d4123d6ab23fd8141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268586 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783090}
-
Maksim Ivanov authored
Refactor CertificateProviderService to defer the input data hashing till the very last point before sending the signature request to the extension. As a consequence, change the CryptohomeKeyDelegate D-Bus service to pass the unhashed data. Also kill the call in the CertStoreInstance Mojo service that was passing pre-hashed data (that service will anyway be deleted in one of follow-ups - see b/119914122). This is a preparation step for introducing a new version of the chrome.certificateProvider API that will pass the unhashed inputs to the extension. There's no use-visible changes expected. All changes, except the one of CertStoreInstance, are backwards-compatible, and the CertStoreInstance is an unlaunched functionality that will be deleted soon (see b/119914122). Bug: 1078761 Change-Id: I656f46c41fdd5fd779e27abe76ee6c01ea2349f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246177 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#783089}
-
Bailey Berro authored
Punted to M86. Bug: 1062499 Change-Id: I58ba4b879de7ec0d91e432da7a4a6722db91e0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268119 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#783088}
-
Mirko Bonadei authored
This is a reland of 3a2a481f This CL moves the declare_arg of gtest_enable_absl_printers to //build_overrides (which is already imported by googletest and abseil-cpp BUILD.gn files) in order to avoid the "undefined identifier" error when build_with_chromium=true. Original change's description: > Add gtest absl deps to the absl component. > > This CL conditionally adds absl/debugging deps to the absl component > if build_with_chromium=false. This will allow downstream projects to > use gtest with absl (for pretty printers and matchers) but it will > remove these dependencies in Chromium to avoid to add static > initializers. > > When static initializers will be removed, the dependency will not be > conditional so Chromium will also be able to set > 'gtest_enable_absl_printers=true'. > > Bug: 1046390 > Change-Id: Ifffea81ba8f7a9412bebc3798e8f79eaff2777d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262972 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782889} Bug: 1046390 Change-Id: Id977a6a868b389b4d9924eb3af5a5f5cd0c3f4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270298 Auto-Submit: Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#783087}
-
Moe Ahmadi authored
Omnibox page classification detection logic is failing to correctly report interactions from the WebUI NTP. This is due to the WebUI NTP not using the instant process. This CL fixes that by making the ChromeLocationBarModelDelegate::IsInstantNTP logic correctly identify both the local NTP and the WebUI NTP without the need for checking whether the NTP uses the instant process. As a result interactions from the WebUI NTP will continue to be reported as OmniboxEventProto::INSTANT_NTP_WITH_[OMNIBOX|FAKEBOX]_AS_STARTING_FOCUS without the NTP actually using the instant process. This logic *should* eventually be refactord into chrome/browser/search/search.cc once the WebUI NTP is fully launched and the references to the instant process are removed. Bug: 1098513 Change-Id: I6d4a9e75a45cd70232ffa3541b122c639a428a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265415 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783086}
-
Livvie Lin authored
For lookalike interstitials, call CancelAndDisplayError from ShouldAllowResponse rather than at the request stage, so that the provisional load has already started. This will allow PrepareErrorPage to trigger. This CL also puts a placeholder method in ChromeWebClient for preparing the lookalike interstitial HTML when it sees a lookalike error code. Bug: 1058898 Change-Id: Iff830bb48cdee60cc1e2b8b5f74ebe858c2d5993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261614Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#783085}
-
Jazz Xu authored
This CL fix the issue by creating a dragging widget when user start dragging. Bug: 1099387 Change-Id: Id0b1dab56216f7ec5614ae11580ce08ea208daf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267729 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#783084}
-
Scott Little authored
The histogram OfflinePages.TabRestore is still in use, so this CL extends the expiration of this histogram. Fixed: 1089163 Change-Id: I4392c187acd66178b5590157ca531041072b3f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269482 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783083}
-
Jana Grill authored
Show notifications informing the user that ADB sideloading device policy has been changed to DISALLOW or DISALLOW_WITH_POWERWASH by the domain admin. In the latter case also ensure that the device is powerwashed. Bug: 1082668 Test: Unit tests Change-Id: I00a3e493a58822ca8d19bde4182b42974d072794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203205Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#783082}
-
Scott Little authored
The histogram NewTabPage.OfflineUrlsLoadTime seems to have been removed from the code quite a while ago, and M58 is the latest milestone that I can find data for. This CL marks this histogram as obsolete. Fixed: 1089098 Change-Id: I0ab5a29b7686fd6675e68cf5814af40a4be3e8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269541 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783081}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. Note that some WebMediaStream -> MediaStreamDescriptor, and similar conversions were also performed. BUG=704136 R=guidou@chromium.org Change-Id: I7c8cd40f009e6e464487fdd46983567a13c9ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260932 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#783080}
-
Scott Little authored
This histogram seems to have been removed a long time ago. I'm not sure exactly which milestone it was, so this CL marks OfflinePages.ClearAllStatus2 as obsolete after M83. Fixed: 1089139 Change-Id: I4fcb4c60f4cc7e495b5906f62229e8c91350c010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268640 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783079}
-
Jeffrey Kardatzke authored
This is an implementation of media::ContentDecryptionModule that adapts the calls to a mojo interface for chromeos::cdm::mojom::ContentDecryptionModule. It also adapts the client interface chromeos::cdm::mojom::ContentDecryptionModuleClient and directs those to the callbacks provided when the media::CdmFactory creates the implementation. This also implements media::Decryptor. BUG=b:153111783 TEST=Unit tests pass Change-Id: Ie6b65a7f490d5130548c060fe5b3c96920128e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253461 Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#783078}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 39368e75. With Chromium commits locally applied on WPT: 3398d444 "[COOP] moving reporting tests to reporting/" 771fe13c "[LayoutNG] Avoid break between last child and container edge." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm domenic@chromium.org, wjmaclean@chromium.org: external/wpt/origin-isolation jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jsbell@chromium.org: external/wpt/service-workers/cache-storage mkwst@chromium.org: external/wpt/cookies external/wpt/upgrade-insecure-requests mstensho@chromium.org: external/wpt/css/css-multicol yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: Ic991fea33a8ad329bfcbb4dc4c79b499c04e12c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269880Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783077}
-
Aaron Colwell authored
Several pieces of code related to web view guests generate site URLs solely for the purpose of getting the appropriate StoragePartition. Now that there is a way to get a StoragePartition using a StoragePartitionConfig, all of these pieces of code can be migrated away from using site URLs and just use StoragePartitionConfigs directly. Bug: 1085275 Change-Id: Id7b4b6e0be52f762236e7b2281644f270a92193e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254347 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#783076}
-
Nico Weber authored
Bug: 1098899 Change-Id: I7f03ab3d7305beec8057351f6c0aa50ccb9e4503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270700 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#783075}
-
Tom Anderson authored
Most of SendRequest doesn't depend on the template parameter |Reply|, so move the common code into a non-template function defined in the source file. This should hopefully reduce binary size since SendRequest() gets instantiated for every Request type (654 in total). BUG=1066670 R=sky Change-Id: Iee5934f42b1c4ceb02b3279452e4cadbb7a620fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268841Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#783074}
-
Scott Little authored
The histograms OfflinePages.PageLifetime.* and OfflinePages.PageSize.* are still in use, so this CL extends their expiration. Fixed: 1089761, 1089762, 1089763, 1089764 Change-Id: I1781c89bb8b505918da20cecc486a69f68038951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268593 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#783073}
-