GitLab

Remove SocketWrapper, which should no longer be needed since we're explicitly telling writers not to touch channels in CloseInternal().

BUG=
TEST=Unit-tests should pass.  End-to-end remoting sessions should not make calls to deleted StreamSocket instances for channels during shutdown.


Review URL: http://codereview.chromium.org/7289032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91874 0039d316-1c4b-4281-b951-d872f2087c98

Selecting the 'Add Page' menu from the bookmark bar opens up the bookmark editor dialog with empty title and URL fields. Pre-fill these entries with the title and URL of the current page.

BUG=26052
TEST=manually

Review URL: http://codereview.chromium.org/7310023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91873 0039d316-1c4b-4281-b951-d872f2087c98

This change moves the multi-profile commands from the wrench menu to the avatar menu.

To make multi-profiles usuable until the new options UI is ready I'm making the avatar always visible. I'll change it back once the options UI code is checked in.

BUG=
TEST=


Review URL: http://codereview.chromium.org/7328005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91872 0039d316-1c4b-4281-b951-d872f2087c98

Likewise for cancelPendingOperation.
This fixes failing JS calls from choice.html (e.g., "OK" button for "Invalid Access Code")

Also replace occurrences of:
  function f() {}
  remoting.f = f;
with:
  remoting.f = function() {}
to be consistent.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7329011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91871 0039d316-1c4b-4281-b951-d872f2087c98

Requested by jam.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7330011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91870 0039d316-1c4b-4281-b951-d872f2087c98

Revert 91861 - When the download folder does not exist, change the download folder to a user's "Downloads" (or something depending on the platform)

Description of reverted commit follows:
  - Set the download folder to Foo. You can download a PDF file to Foo without being asked anything (if you do not choose "Ask where to save each file before downloading"). Then delete Foo. Now, if you try to download the PDF file, then a file chooser dialog is displayed suggesting your "Downloads" folder.
  - Set the download folder to Foo. Save an HTML to Bar by right-clicking and choosing "Save as ..." on the tab. If you try to save the HTML, the file chooser dialog is displayed suggesting Bar. Then delete Bar. Now, if you try to save the HTML, the file chooser dialog is displayed suggesting Foo. Then delete Foo. If you try to save the HTML, the file chooser dialog is displayed suggesting your "Downloads" folder.
  - Set the download folder to Foo. Observe that Foo is displayed as the download location in the preferences page. Then delete Foo and reload the preferences page. Observe that your "Downloads" folder is displayed as the download location in the preferences page. If you are opening multiple preferences pages, then this change is automatically reflected to all the preferences pages.
  BUG=32552
  TEST=SavePageBrowserTest.SavedFolder1,SavePageBrowserTest.SavedFolder2,SavePageBrowserTest.SavedFolder3,DownloadTest.DownloadedFolder,DownloadManagerTest.StartDownload,BaseFileTest.*,DownloadFileTest.RenameFileFinal
  Review URL: http://codereview.chromium.org/6973052

TBR=haraken@google.com
Review URL: http://codereview.chromium.org/7324031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91869 0039d316-1c4b-4281-b951-d872f2087c98

Now that the reference build includes webkitRequestAnimationFrame (r91338), we
can use it for the frame rate performance test.

TEST=performance_ui_tests --gtest_filter=FrameRateTest_Reference.*


Review URL: http://codereview.chromium.org/7329008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91868 0039d316-1c4b-4281-b951-d872f2087c98

willchan pointed out that NewRunnableFunction will copy parameters even if the method signature contains references. See:
http://codereview.chromium.org/7321011/diff/2001/chrome/browser/profiles/profile_manager.cc#newcode46

BUG=
TEST=


Review URL: http://codereview.chromium.org/7328021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91867 0039d316-1c4b-4281-b951-d872f2087c98

Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl.

I also added a gyp option: pepper_scripting. The default is that scripting is on in this CL, but it will make it easy to turn it off in local builds. Soon we'll switch the default to no scripting, and soon after we can remove the option entirely.

BUG=82606
TEST=these tests

Review URL: http://codereview.chromium.org/7312008

TBR=dmichael@chromium.org
Review URL: http://codereview.chromium.org/7329024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91866 0039d316-1c4b-4281-b951-d872f2087c98

tests. Delete unused test script.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7331004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91864 0039d316-1c4b-4281-b951-d872f2087c98

Patch by scottfr@chromium.org:
http://codereview.chromium.org/7272036/

BUG=none
TEST=navigate to chrome://media-internals without crashing

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:13887
TEST=none


Review URL: http://codereview.chromium.org/7003121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91862 0039d316-1c4b-4281-b951-d872f2087c98

When the download folder does not exist, change the download folder to a user's "Downloads" (or something depending on the platform)

- Set the download folder to Foo. You can download a PDF file to Foo without being asked anything (if you do not choose "Ask where to save each file before downloading"). Then delete Foo. Now, if you try to download the PDF file, then a file chooser dialog is displayed suggesting your "Downloads" folder.
- Set the download folder to Foo. Save an HTML to Bar by right-clicking and choosing "Save as ..." on the tab. If you try to save the HTML, the file chooser dialog is displayed suggesting Bar. Then delete Bar. Now, if you try to save the HTML, the file chooser dialog is displayed suggesting Foo. Then delete Foo. If you try to save the HTML, the file chooser dialog is displayed suggesting your "Downloads" folder.
- Set the download folder to Foo. Observe that Foo is displayed as the download location in the preferences page. Then delete Foo and reload the preferences page. Observe that your "Downloads" folder is displayed as the download location in the preferences page. If you are opening multiple preferences pages, then this change is automatically reflected to all the preferences pages.

BUG=32552
TEST=SavePageBrowserTest.SavedFolder1,SavePageBrowserTest.SavedFolder2,SavePageBrowserTest.SavedFolder3,DownloadTest.DownloadedFolder,DownloadManagerTest.StartDownload,BaseFileTest.*,DownloadFileTest.RenameFileFinal


Review URL: http://codereview.chromium.org/6973052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91861 0039d316-1c4b-4281-b951-d872f2087c98

wall clock time.

TEST=none
BUG=57448
Review URL: http://codereview.chromium.org/7237044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91860 0039d316-1c4b-4281-b951-d872f2087c98

Some tests still rely on scripting, so we changed to using InstancePrivate (since scripting will disappear from Instance soon). Also use conditional compilation so that if compiled as untrusted with NaCl, the tests use Instance instead of InstancePrivate. This means that tests which rely on scripting aren't runnable in NaCl.

I also added a gyp option: pepper_scripting. The default is that scripting is on in this CL, but it will make it easy to turn it off in local builds. Soon we'll switch the default to no scripting, and soon after we can remove the option entirely.

BUG=82606
TEST=these tests

Review URL: http://codereview.chromium.org/7312008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91859 0039d316-1c4b-4281-b951-d872f2087c98

Updates the setter as well.

Some other changes:
- Improve the comments in the BookmarkNode class.
- Reorganize the member variables of BookmarkNode class to match with the
  getter/setter accessors.
- Reorder some functions in the source file to match with the declaration in the header file.

BUG=None
TEST=None

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7318001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91858 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:14002
TEST=Set cloud policies using testserver, corrupt some files, check about:histograms


Review URL: http://codereview.chromium.org/7105018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/7328019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=ui_unittest

Review URL: http://codereview.chromium.org/7044062
Patch from Ian Vollick <vollick@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91855 0039d316-1c4b-4281-b951-d872f2087c98

Fix a bug of hide key where the keyboard does now show up after the hide key is
pressed while Omnibox has the focus and Omnibox is touched.
I changed the way of retrieving the text input type to use
InputMethod::GetTextInputType rather than TextInputClient::GetTextInputType
because NULL is always set to touch_pressed_handler when omnibox is touched.
I also added code to check the touch event type so that the notification is sent
only when text element is touched.

BUG=none
TEST=manually


Review URL: http://codereview.chromium.org/7324029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91854 0039d316-1c4b-4281-b951-d872f2087c98

Each compositor has it's own context. We should share shaders between them because compiling shaders is expensive. To do this, I pin the very first context created with a ref count. Then I use context sharing to share the shaders.

BUG=none
TEST=by hand with intel, nv, nouveau, and tegra drivers on a TOUCH_UI build

Review URL: http://codereview.chromium.org/7327001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91853 0039d316-1c4b-4281-b951-d872f2087c98

This makes sure we record the Permissions_Install* histograms for web store installs and cancelations. It also creates a few new histograms, starting with Permissions_WebStoreInstall, that are specific to the web store.

BUG=87468
TEST=about:histograms/Extensions

Review URL: http://codereview.chromium.org/7326002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91852 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91851 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan

Review URL: http://codereview.chromium.org/7326015


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91850 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91847 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/7326015



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=88341

Review URL: http://codereview.chromium.org/7310003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91844 0039d316-1c4b-4281-b951-d872f2087c98

Reverted commit details:
  BUG=63658
  TEST=All policy unit_tests should pass.
  Review URL: http://codereview.chromium.org/7283018

TBR=pastarmovj@chromium.org
Review URL: http://codereview.chromium.org/7326011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63658
TEST=All policy unit_tests should pass.


Review URL: http://codereview.chromium.org/7283018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15580
TEST=manual

Review URL: http://codereview.chromium.org/7331009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91841 0039d316-1c4b-4281-b951-d872f2087c98

Also a couple of minor fixes:
- Menu width changed: 150 -> 250
- Setup font size and direction when updating the content.
- Refresh network control position, when updating the content.

BUG=chromium-os:17338
TEST=manual

Review URL: http://codereview.chromium.org/7329018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91840 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91839 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ojan
Review URL: http://codereview.chromium.org/7331011



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=Save a file with characters @!'() #$&,;=. Click on it in the downloads panel and it should launch correctly.

Review URL: http://codereview.chromium.org/7324012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91837 0039d316-1c4b-4281-b951-d872f2087c98

It had broken the mac canaries with the warning:
cc1plus: warnings being treated as errors
/b/build/slave/Webkit_Mac10_5__dbg__2_/build/src/webkit/appcache/appcache_update_job_unittest.cc:556:
warning: 'appcache::AppCacheUpdateJobTest' has a field
'appcache::AppCacheUpdateJobTest::io_thread_' whose type uses the anonymous
namespace

This is the old gcc bug. I think the problem is Mac 10.5 vs 10.6. I'm working around by removing the anonymous namespace.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7328017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91836 0039d316-1c4b-4281-b951-d872f2087c98

Original review URL: http://codereview.chromium.org/7168019
(reverted due to clang build breakage)

BUG=86308
TEST={QuotaDatabaseTest,QuotaManagerTest}.OriginModifiedSince

Review URL: http://codereview.chromium.org/7331006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91835 0039d316-1c4b-4281-b951-d872f2087c98

ProtocolHandlerRegistry::MaybeCreateJob (issue 88735)

BUG=88735,88640
TBR=thakis
Review URL: http://codereview.chromium.org/7237048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=successful build on mac canaries
TBR=willchan
Review URL: http://codereview.chromium.org/7328015


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91833 0039d316-1c4b-4281-b951-d872f2087c98