GitLab

This patch changes the nodes container in the rtree to use a vector.
In order to preserve the consistent access to elements, it reserves the
vector to the needed capacity. The wasted space is <= 6 elements.

Added a unittest to verify the reserve path is correct for up to 1000
rects. However, locally I've tested this for up to 520k rects (and
still testing for up to 1m rects).

The perf results from N7v2 are below.
Before the patch:
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 75723.8671875 runs/s
*RESULT rtree_construct: 1000= 11985 runs/s
*RESULT rtree_construct: 10000= 715.2415161132812 runs/s
*RESULT rtree_construct: 100000= 54.19050216674805 runs/s
[       OK ] RTreePerfTest.Construct (8243 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 352105 runs/s
*RESULT rtree_search: 1000= 97542.0234375 runs/s
*RESULT rtree_search: 10000= 10274.0595703125 runs/s
*RESULT rtree_search: 100000= 866.167236328125 runs/s
[       OK ] RTreePerfTest.Search (8122 ms)

After the patch:
[ RUN      ] RTreePerfTest.Construct
*RESULT rtree_construct: 100= 112420 runs/s (+48%)
*RESULT rtree_construct: 1000= 13482.32421875 runs/s (+12%)
*RESULT rtree_construct: 10000= 666.6328125 runs/s (-7%)
*RESULT rtree_construct: 100000= 55.98017501831055 runs/s (+3%)
[       OK ] RTreePerfTest.Construct (8340 ms)
[ RUN      ] RTreePerfTest.Search
*RESULT rtree_search: 100= 365225 runs/s
*RESULT rtree_search: 1000= 98002.0078125 runs/s
*RESULT rtree_search: 10000= 10344.048828125 runs/s
*RESULT rtree_search: 100000= 866.0883178710938 runs/s
[       OK ] RTreePerfTest.Search (8092 ms)

BUG=674169
R=danakj@chromium.org, dskiba@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591533002
Cr-Commit-Position: refs/heads/master@{#439686}

The recent Mojo conversion changed the communication pattern between the
IPC Server and Client classes used for remote security key message
forwarding.  This change has caused a regression in the scenario where
the security key request originates from outside the remoted session.
The desired behavior is to pass a message to the local SK handler so
it can route/handle the request.  Due to the change in the following
CL, we would instead report that the remote client would handle it,
then return a failure when they sent the request:
https://codereview.chromium.org/2478443002/

The reason for this change is that the session detection logic was wrapped
in the OnChannelConnected() method.  Because you cannot close an IPC channel
from within that method, we would defer the close operation.  With the old
architecture, the client would be waiting for a specific IPC message to
complete the connection (and signal success) but instead would receive
the deferred close/error message and pass on the right message to the local
handler.  This behavior was changed such that the client would now signal
success in its own 'OnChannelConnected()' and then receive the deferred
error.

In order to make this scenario more robust, I have added specific success
and failure IPC messages to be passed to the client from the server and
will use that when establishing the connection.  I've also separated out
the concept of an invalid session vs. and actual connection error so the
IPC client class can provide more accurate details to the local handler.

BUG=674236

Review-Url: https://codereview.chromium.org/2575963002
Cr-Commit-Position: refs/heads/master@{#439685}

Now that the "media" service is used on every Cast build, we no longer
need this thread-hopping class.

BUG=660736
Test: Cast compiles, no functionality changes

Change-Id: I89639dfb874e1a3b46d63666b83f0227250e526b
Review-Url: https://codereview.chromium.org/2586353002
Cr-Commit-Position: refs/heads/master@{#439684}

This code allowed packaged apps to have their window controls (close
button, minimimise button etc.) come from HTML. This feature was never
completed or launched.

BUG=389639

Review-Url: https://codereview.chromium.org/2551303003
Cr-Commit-Position: refs/heads/master@{#439683}

Review-Url: https://codereview.chromium.org/2584113002
Cr-Commit-Position: refs/heads/master@{#439682}

The unit test for audit.js only covers basic/successful cases.
This CL is to add another unit test that tests failure cases with the
expected text result.

In the course of refining the failure output message, some editorial
edits also have been made in audit.js.

BUG=672988
TEST=LayoutTests/webaudio/unit-tests/audit-failures.html

Review-Url: https://codereview.chromium.org/2568573002
Cr-Commit-Position: refs/heads/master@{#439681}

BUG=672719
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2588653002
Cr-Commit-Position: refs/heads/master@{#439680}

Some tests were setting a new key window but failing to restore the original
window after the test concluded.  Leaving the app without a key window breaks
subsequent tests on iOS 9.0, including ContextualSearchJsTest.

BUG=None

Review-Url: https://codereview.chromium.org/2588223002
Cr-Commit-Position: refs/heads/master@{#439679}

If a virtual file is selected, then coerce it to the first streamable
MIME type. As a result, users will be able to pick Google Docs documents
from Drive as PDF files, as in the past.

TEST=Tested manually by picking a hosted document from Drive with
     enabled support for virtual files.
BUG=b/33185812

Review-Url: https://codereview.chromium.org/2545343002
Cr-Commit-Position: refs/heads/master@{#439678}

Review-Url: https://codereview.chromium.org/2586943004
Cr-Commit-Position: refs/heads/master@{#439677}

This CL fixes a typo, "police" --> "policy".

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583403002
Cr-Commit-Position: refs/heads/master@{#439676}

This change fixes two problems:
1.) Security key responses would not be delivered if the read end of
    the socket was closed before the response was received.  This
    should be allowed since the write end was still open.
2.) An SSH error was always written when the socket was closed.  This
    was misleading when no error occrred and the socket was being
    closed for a valid reason.

The old behavior would close the socket as soon as a read returned 0
bytes (or an error).  The auth handler would read a request and forward
it to the remote machine, then immediately try to read another request.
If the code on the other end had closed its side of the connection, the
auth handler would receive EOF and close the socket.  It would also
write an error to the write end of the socket which was also wrong.

The simpler change is to only write an error if the request timed out or
if we encountered a socket read error.  Otherwise we just close our end
of the socket and the listener receives an EOF.

The bigger change is that we no longer queue up another socket read
operation until after we have received the response from the remote
machine.  The SecurityKeySocket is meant to receive and respond to one
request at a time (per its class comments), and this new behavior also
makes lifetime management of the socket less complex.

BUG=671041

Review-Url: https://codereview.chromium.org/2589933002
Cr-Commit-Position: refs/heads/master@{#439675}

This test now uses testharness. It no longer relies on event timing.

BUG=664859

Review-Url: https://codereview.chromium.org/2578143003
Cr-Commit-Position: refs/heads/master@{#439674}

This patch unskips [1] which was fixed by [2].

[1] PaintPropertyTreeBuilderTest.ContainPaintChangesUpdateOverflowClip
[2] https://chromium.googlesource.com/chromium/src/+/3446d1745a09854682d54031e433429d68589fce

TBR=wangxianzhu@chromium.org
BUG=645667
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2588953002
Cr-Commit-Position: refs/heads/master@{#439673}

Unlike SSL interstitial, when destructing safe browsing interstitial,
SafeBrowsingBlockingPage::OnDontProceed() function gets called. This
function takes cares of recording the DONT_PROCEED action. Therefore,
no need to recording DONT_PROCEED in SafeBrowsingErrorUI's destructor.

BUG=675786

Review-Url: https://codereview.chromium.org/2594453002
Cr-Commit-Position: refs/heads/master@{#439672}

bug fixes, minor encoder updates

BUG=675306

Review-Url: https://codereview.chromium.org/2584033003
Cr-Commit-Position: refs/heads/master@{#439671}

Also, deprecate QUIC as a ProxyScheme, and deprecate refresh_time
from the client config proto.

A new class DataReductionProxyServer is added that stores the
net::ProxyServer information of the DRP server, along with other
attributes. For users with client config services, these attributes
are populated from the client config. For users with hard-coded
proxy, attributes are also hard-coded.

The attributes are currently unused, and will be used in a subsequent CL.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

BUG=570435,671810, 675769

Review-Url: https://codereview.chromium.org/2575323002
Cr-Commit-Position: refs/heads/master@{#439670}

Review-Url: https://codereview.chromium.org/2586913003
Cr-Commit-Position: refs/heads/master@{#439669}

Now that Chrome can be built upstream, we should run integration
tests.

BUG=675788

Review-Url: https://codereview.chromium.org/2588193002
Cr-Commit-Position: refs/heads/master@{#439668}

https://pdfium.googlesource.com/pdfium.git/+log/0fdeeb817556..04a407093c13

$ git log 0fdeeb817..04a407093 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 tsepez Missing null initializer in CPDF_StreamParser::ReadInlineStream

BUG=675752

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2588183002
Cr-Commit-Position: refs/heads/master@{#439667}

BUG=673501

Review-Url: https://codereview.chromium.org/2589753003
Cr-Commit-Position: refs/heads/master@{#439666}

BUG=none

Review-Url: https://codereview.chromium.org/2592513002
Cr-Commit-Position: refs/heads/master@{#439665}

The texture type is always GL_TEXTURE_2D on non-ozone non-macos platforms.
Make that more obvious when reading the code.

BUG=675431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2587823002
Cr-Commit-Position: refs/heads/master@{#439664}

Revert of [Reland] Scheduler refactoring to virtually eliminate redundant DoWorks (patchset #11 id:200001 of https://codereview.chromium.org/2546423002/ )

Reason for revert:
http://crbug.com/674895 (revert of dependent CL must land before this one: https://codereview.chromium.org/2583333002/)

Original issue's description:
> Scheduler refactoring to virtually eliminate redundant DoWorks
>
> Note this patch, while useful in it's own right, needs base messageloop
> cancellation support for full effect.  Until that patch lands there may be
> some pointless wakeups for canceled DoWorks. This is of particular concern
> for using the scheduler on the compositor thread.
>
> Includes fix for telemetry and tsan issues.
>
> BUG=578176, 674238, 674157
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Committed: https://crrev.com/3a6ffff92addfa71d401e2718ab99677520f250c
> Committed: https://crrev.com/8c6cf02ab73c8026ac2b0ca2aa8d6fd9bd8f2db0
> Cr-Original-Commit-Position: refs/heads/master@{#438173}
> Cr-Commit-Position: refs/heads/master@{#438857}

TBR=skyostil@chromium.org,haraken@chromium.org,alexclarke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=578176, 674238, 674157, 674895

Review-Url: https://codereview.chromium.org/2590593002
Cr-Commit-Position: refs/heads/master@{#439663}

This reduces the risk of memory leaks.

BUG=636158, 613701
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2585863003
Cr-Commit-Position: refs/heads/master@{#439662}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/017e985b..02552140

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2583303003
Cr-Commit-Position: refs/heads/master@{#439661}

Create OWNERS file for ios test code.

Review-Url: https://codereview.chromium.org/2580413003
Cr-Commit-Position: refs/heads/master@{#439660}

Although WebView does not support password manager feature, renderer code
could still request this interface, so we register a dummy binder which
just drops the incoming request, to avoid the 'Failed to locate a binder
for interface' error log.

BUG=662040

Review-Url: https://codereview.chromium.org/2584903003
Cr-Commit-Position: refs/heads/master@{#439659}

Previously, the updated test would overflow the frame.  This caused the
test assertions to fails because when RLS is enabled and the frame
overflows, the scrolling contents are painted into the scrolling
contents layer of the LayoutView's CompositedLayerMapping.

This change just ensures that the test doesn't overflow the frame.

BUG=490942
R=skobes@chromium.org,pdr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2587073004
Cr-Commit-Position: refs/heads/master@{#439658}

Revise CompositorAnimations::canStartAnimationOnCompositor() to
consider direct compositing reasons rather than layer compositing
state.

BUG=674317
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2578343002
Cr-Commit-Position: refs/heads/master@{#439657}

LayoutInline is laid out by its container and should not be a relayout
boundary. This patch prohibits it.

BUG=671328

Review-Url: https://codereview.chromium.org/2586853002
Cr-Commit-Position: refs/heads/master@{#439656}

BUG=672263

Review-Url: https://codereview.chromium.org/2587963003
Cr-Commit-Position: refs/heads/master@{#439655}

Replace using the wrong render_process_id for launching external protocol
requests in chrome_resource_dispatcher_host_delegate.cc.

Previously, handlers for external protocols like 'mailto:' weren't working for
OOPIFs because the render_process_id used to retrieve the content::WebContents
object was incorrect.

BUG=668289
TEST=See bug for repro steps

Review-Url: https://codereview.chromium.org/2538353002
Cr-Commit-Position: refs/heads/master@{#439654}

Add dependencies on ProfileSyncServiceFactory, HistoryServiceFactory,
and DataReductionProxyChromeSettingsFactory, to match the usage in
BuildServiceInstanceFor.

BUG=675794

Review-Url: https://codereview.chromium.org/2582133002
Cr-Commit-Position: refs/heads/master@{#439653}

FileBrowser.Load.Script represents how long it took to parse javascript,
html and CSS.

TEST=None
BUG=674827

Review-Url: https://codereview.chromium.org/2585483003
Cr-Commit-Position: refs/heads/master@{#439652}

Move the code that maps <BufferFormat,BufferUsage> to GL texture
type into the gpu-host component, so that it can be used by both
chrome and mus.

BUG=675431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2585653003
Cr-Commit-Position: refs/heads/master@{#439651}

https://skia.googlesource.com/skia.git/+log/65869fb64b56..ace343286d90

$ git log 65869fb64..ace343286 --date=short --no-merges --format='%ad %ae %s'
2016-12-19 herb Fix, cleanup and document the clamp tiler better.
2016-12-19 caryclark handle empty contours in a couple more places
2016-12-19 jvanverth Fix precision errors in large circle rendering.
2016-12-19 msarett Fix swapped interpretation of c and e in SkColorSpace_ICC

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=rmistry@google.com

Review-Url: https://codereview.chromium.org/2593433002
Cr-Commit-Position: refs/heads/master@{#439650}

There is no need to do instant apps check when viewing offline pages
since we wouldn't be able to load the app without network.

BUG=675216

Review-Url: https://codereview.chromium.org/2582343003
Cr-Commit-Position: refs/heads/master@{#439649}

Review-Url: https://codereview.chromium.org/2587533002
Cr-Commit-Position: refs/heads/master@{#439648}

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a |Request| type and
a |request| method (differing only by case of the first character);
after a naive rename by the rewrite_to_chrome_style tool we would end up
with |Request| being the name of both the type and the method (with both
living in the same namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex.
  GetContext().

Note that this CL doesn't change *all* instances of "request()"
substring.  In particular - we avoid changes that would introduce
setGetRequest identifiers because of https://crbug.com/673039.

BUG=582312
TBR=sky@chromium.org, melandory@chromium.org, rdevlin.cronin@chromium.org, nasko@chromium.org

Review-Url: https://codereview.chromium.org/2573523002
Cr-Commit-Position: refs/heads/master@{#439647}