- 12 Oct, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/09c355ef00f4..aebffd21b13f Created with: gclient setdep -r src-internal@aebffd21b13f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I816f02425f0557bf4030f14078bb453721cca6fe Reviewed-on: https://chromium-review.googlesource.com/c/1278300Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599107}
-
Kunihiko Sakamoto authored
This fixes a bug where Resource Timing for prefetched Signed Exchange had negative duration value. Bug: 803774 Change-Id: I77006c803c12a6f645f2d5145a4e37e9321757f8 Reviewed-on: https://chromium-review.googlesource.com/c/1278546Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599106}
-
Mohamed Amir Yosef authored
At startup, the persisted sync metadata (if available) are loaded and tracked. This CL adds some integrity checks and makes sure that corrupted metadata are ignored, and that Sync starts clean in such case. Bug: 516866 Change-Id: Idf42cce2306f18a94941d40caa1816f737732156 Reviewed-on: https://chromium-review.googlesource.com/c/1274106Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#599105}
-
Yuki Yamada authored
This adds a comment for the previous change: https://chromium-review.googlesource.com/c/chromium/src/+/1276406 Bug: 893951 Change-Id: Ib7a14eedb9922a03c0f6121205c55a9924a5fd7c Reviewed-on: https://chromium-review.googlesource.com/c/1278070 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#599104}
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I5de8d5b1bdb154455a59e5106ebcefd4973d5bcd Reviewed-on: https://chromium-review.googlesource.com/c/1275746 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599103}
-
Justin Cohen authored
This bot was erronously moved from Xcode 10 beta 4 all the way to Xcode 10.1 beta. Now that Xcode 10 GM is in goma, roll to Xcode 10. Note: This rolls to 10a254a, which is slightly different than the package goma installed, but it has the same compiler (clang-1000.11.45.2) so it should work the same. If not, we'll have to investigate why and upload a new package to CIPD. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I46e90d60eb562f69d1848df3ff48db3d82cf1cc1 Reviewed-on: https://chromium-review.googlesource.com/c/1278331Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#599102}
-
John Z Wu authored
1. Disable feature SyncUserConsentSeparateType for now. 2. Use ReloadCredentials since LoadCredentials DCHECKs and fix up the tests. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3a9af1b353b3138b411ee9fdab6cc67c447ee109 Reviewed-on: https://chromium-review.googlesource.com/c/1278471Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599101}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c4533eae082f..671809e62e80 git log c4533eae082f..671809e62e80 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 jiajia.qin@intel.com ES31: Add vector and matrix support in SSBO for D3D 2018-10-12 jiajia.qin@intel.com ES31: Collect shader storage blocks info for d3d. Created with: gclient setdep -r src/third_party/angle@671809e62e80 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie918b1391ee226eb39be833dc7768cec9bdbee65 Reviewed-on: https://chromium-review.googlesource.com/c/1278299Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599100}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a72c51a329f..89e4bf93b1a1 git log 9a72c51a329f..89e4bf93b1a1 --date=short --no-merges --format='%ad %ae %s' 2018-10-12 derat@chromium.org chromeos_config: Run Tast on {amd64-generic,betty}-paladin. Created with: gclient setdep -r src/third_party/chromite@89e4bf93b1a1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I29f302fb260fcd75ce3d9d3b538f0eed2c2a1f21 Reviewed-on: https://chromium-review.googlesource.com/c/1278493Reviewed-by:
-
Joel Hockey authored
Split crostini UI tests from crostini.js into test files: * crostini_mount.js * crostini_share.js * crostini_tasks.js The existing tests are getting a bit too large and pushing the bot testing time limits. Bug: 878324 Change-Id: I882a38e3f644916e3c904709f3bfc540034b1383 Reviewed-on: https://chromium-review.googlesource.com/c/1278429Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#599098}
-
Keiichi Watanabe authored
Use prefix "UsingRealWebcam_" for names of tests that require real webcam and add checking whether webcam is found or not. Accordingly, exclude such test cases from test suites for devices that have no camera. Bug: 893494 Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebox (guado) and it failed. Test: Ran capture_unittests excluding UsingRealWebcam_ tests on Chromebox (guado) and it passed. Test: Ran capture_unittests including UsingRealWebcam_ tests on Chromebook (kevin) and it passed. Change-Id: I5c91380b7674aeace6a7d1764f7fad31f02f8af7 Reviewed-on: https://chromium-review.googlesource.com/c/1276407 Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org> Reviewed-by:Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#599097}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/616feb1a7c2c..09c355ef00f4 Created with: gclient setdep -r src-internal@09c355ef00f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I31399eb2e92dae352d53dc7fcde8bf49c0966418 Reviewed-on: https://chromium-review.googlesource.com/c/1278531Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 10421 10431 10436 10446 10458 10478 10484 10489 10494 10496 10498 10499 10503 10509 10514 10516 10519 10523 10525 10530 10541 10549 10550 10552 1 lines were removed and 3 lines were deflaked by consecutive results since 10503. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I937b189ec5c0061d7c1607828b6ac5fc0bfe71b4 Reviewed-on: https://chromium-review.googlesource.com/c/1270498 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#599095}
-
Findit authored
This reverts commit a12ef847. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599001 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYTEyZWY4NDdhNTdmNGFhMDI4MmNhNDdiNTU1YzA0ZGExOGIwMGY5ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29516 Sample Failed Step: content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Fling bubbles from OOPIF properly. > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > of both the oopif and the bubbling target. The fling controller of the oopif > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > immediately before getting sent to the renderer since we are in bubbling mode. > Then the oopif's fling controller receives the unconsumed GSU ack and generates > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > fling controller receives and processes the GFS and generates GSUs which are > sent to the target's renderer. > > If the GSE generated by the oopif's fling controller gets bubbled before > the GFS, the bubbling target gets reset and the target does not receive the > GFS. This cl fixes the issue by making sure that the events generated by the > oopif's fling controller are not bubbled to the target. Also in case of > GFS bubbling, the GFC should also get sent to the bubbling target to make > sure that the fling controller in charge of flinging receives the GFC. > > > Bug: 884728, 249063 > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Charlie Reis <creis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599001} Change-Id: Ie8178e456d50cdd43fdeb86939180d20b96bcc36 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728, 249063, 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1278536 Cr-Commit-Position: refs/heads/master@{#599094}
-
Leon Han authored
Currently some modules (push_messaging, background_fetch etc.) are calling blink::SWRegistration::WebRegistration() to get a pointer to blink::WebSWRegistration to continue their work there. However, they use that blink::WebSWRegistration just to retrieve the service worker registration id, i.e. what they really want is not blink::WebSWRegistration, but just the registration id. So, this CL removes blink::SWRegistration::WebRegistration() and provides a new function blink::SWRegistration::RegistrationId() for those users instead. This CL is in preparation for https://crrev.com/c/1275300 which plans to merge content::WebSWRegistrationImpl into blink::SWRegistration and remove the public interface blink::WebSWRegistration completely. BUG=789857,879019 Change-Id: Iafb245ec6f978dfaa294f58ee800d80c5ba60fac Reviewed-on: https://chromium-review.googlesource.com/c/1275298 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599093}
-
Fergal Daly authored
Make the state transitions more clear and document which transitions consume a character. Bug: 805271 Change-Id: I363cb6c9d459b560d0ec1b4cb6649cce981deffc Reviewed-on: https://chromium-review.googlesource.com/c/1275747Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#599092}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1cd39fa9ea0c..8f4bc41c4231 git log 1cd39fa9ea0c..8f4bc41c4231 --date=short --no-merges --format='%ad %ae %s' 2018-10-11 oprypin@webrtc.org Revert "Move CryptoOptions to api/crypto from rtc_base/sslstreamadapter.h" Created with: gclient setdep -r src/third_party/webrtc@8f4bc41c4231 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I926d7ea870bf3c7c76c519c12806778129e89659 Reviewed-on: https://chromium-review.googlesource.com/c/1277843Reviewed-by:
-
Tommy Steimel authored
This change adds a UI affordance that the window is resizable and draggable on ChromeOS. This adds a ResizeHandleButton made specifically as the affordance. This icon is on the edge of the window that points to the center of the workspace screen. For example, if the window is on the bottom right quadrant, the icon will be on the top left. In the case where the window is on the bottom left quadrant, the icon replaces the close button. The close button is then shifted to the top left corner. Bug: 890113 Change-Id: Iea6b543e4ee5751d8478dc76daa024f5e85292d2 Reviewed-on: https://chromium-review.googlesource.com/c/1275526 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599090}
-
Gang Wu authored
Wired most of the UMA logging, there are two methods in the bridge not connected since it is new UMA, will do in next CL. Bug: 831641 Change-Id: I154261aa3266d1f6d0af07ccb7510b3879f2744e Reviewed-on: https://chromium-review.googlesource.com/c/1275130 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#599089}
-
Aga Wronska authored
Logging demo setup steps will help to determine at what point problems occured for example in case of infinite loading. Change-Id: I04725e4c9d0de12553f6f14fb3d8ee7d106e9699 Reviewed-on: https://chromium-review.googlesource.com/c/1277957Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#599088}
-
Ian Clelland authored
This queues a report through the Reporting API whenever the Generic Sensor API is used in a frame in which the specific sensor is not allowed according to feature policy. Bug: 867471 Change-Id: I9c50f4a331b2b2230890ee0c357047704af8425a Reviewed-on: https://chromium-review.googlesource.com/c/1263041Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#599087}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d23bbdb87b57..9a72c51a329f git log d23bbdb87b57..9a72c51a329f --date=short --no-merges --format='%ad %ae %s' 2018-10-12 vapier@chromium.org paygen: download_cache_unittest: convert to lib.gs & delete gslib.Cat 2018-10-12 vapier@chromium.org paygen: gslib: drop unused Stat Created with: gclient setdep -r src/third_party/chromite@9a72c51a329f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5c3d6623dd88c54fd144213025257ecc157d0565 Reviewed-on: https://chromium-review.googlesource.com/c/1278489Reviewed-by:
-
Roger Tawa authored
Bug: 893874 Change-Id: Id07fb2e9d67403cb77d571df41b4b2aef11bb46d Reviewed-on: https://chromium-review.googlesource.com/c/1278475 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#599085}
-
Ryan Hansberry authored
Links can't be opened like they usually would be in OOBE, because there's no browser to open them in. This CL creates a webview modal which is displayed when the user clicks on one of the two "Learn More" links in the MultiDevice OOBE screen, and loads it with the appropriate URL. Screenshot: https://screenshot.googleplex.com/JL9nfShorRA.png Bug: 893349 Change-Id: I1ac06ea26857adcdf1f3113756e95e15b2f8a127 Reviewed-on: https://chromium-review.googlesource.com/c/1275296 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#599084}
-
Dominick Ng authored
This will allow WebAPKs to be bounced to the desktop browser on Chrome OS devices. BUG=893927 Change-Id: Ic70b58d2ab2b23960cc894dd3420174b523908e6 Reviewed-on: https://chromium-review.googlesource.com/c/1272756Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#599083}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f2ed299569c0..c4533eae082f git log f2ed299569c0..c4533eae082f --date=short --no-merges --format='%ad %ae %s' 2018-10-12 yizhou.jiang@intel.com Enable ANGLE_texture_multisample in glsl in es 3.0 Created with: gclient setdep -r src/third_party/angle@c4533eae082f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ie5a6b652c2c723a90215ae863749da0c24965d4d Reviewed-on: https://chromium-review.googlesource.com/c/1278528Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I81c44eb87bd68655b6cbc34a68cde6f851a839f0 Reviewed-on: https://chromium-review.googlesource.com/c/1278328Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599081}
-
Kyle Horimoto authored
This ensures that connections to our Mojo services are disconnected, which will result in the Shutdown() code added in this CL will run: https://chromium-review.googlesource.com/c/chromium/src/+/1274886 Bug: 884066 Change-Id: Ifb4fad53fc9d1a693ae83099dc43ee9908303ea7 TBR: jhawkins@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1277588 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#599080}
-
Sadrul Habib Chowdhury authored
It looks like on android, presentation timestamps can sometimes be very large. DumpWithoutCrashing() in such cases to collect some data to understand why/when/where this is happening. BUG=894440 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I22817f68014c3f57f7180accc593506eee86f291 Reviewed-on: https://chromium-review.googlesource.com/c/1276549 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599079}
-
Azeem Arshad authored
This CL adds a special note under messages for android entry in notification permissions to indicate usage in ChromeOS multidevice features. This note will be displayed whenever the messages sync feature is enabled. Please refer screenshot: https://screenshot.googleplex.com/VnGZ1qApzHk.png Bug: 845706 Change-Id: Ibcbe706cf9c579d980e4440825b8bc70b64466df Reviewed-on: https://chromium-review.googlesource.com/c/1260503 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Albert J. Wong authored
Bug: 419087 Change-Id: Ic870c7059fef752560d0299064a0cef4a1733f3a Reviewed-on: https://chromium-review.googlesource.com/c/1277594 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#599077}
-
Becky Zhou authored
Bug: 894660 Change-Id: Ib8b7d6484bd050daf4d295c1c9367bd132cb9e80 Reviewed-on: https://chromium-review.googlesource.com/c/1278269Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#599076}
-
wutao authored
This cl checks the |allowed_status| before starting assistant service. Bug: b/117371953 Test: manual. Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77 Reviewed-on: https://chromium-review.googlesource.com/c/1278345 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#599075}
-
David Black authored
Per request from UI/UX folks, enlarging DialogPlate icons sizes to 24dip and adjusting left inset for voice input modality layout container. Note that the vector icon files themselves were also updated per request in the bug to ensure consistency of internal padding. Also per request, the greeting label is shifted up by 4dip. See bug for discussion/screenshots. Bug: b:112313532 Change-Id: I5b72c6867452470abbc8bd562c83ba37492279ea Reviewed-on: https://chromium-review.googlesource.com/c/1276947 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599074}
-
David Black authored
This CL moves processing logic out of UiElementContainerView and into AssistantResponseProcessor which is owned by AssistantInteractionController. The controller will now initiate processing of the Assistant response before it is finalized. This cleans up the view logic considerably as well as provides better synchronization of animations since processing will have already occurred prior to the stage initiating a change. Bug: b:117344968, b:116751668 Change-Id: I3ac1300978a3448fd7e244b6a7312ec9bf3c39bd Reviewed-on: https://chromium-review.googlesource.com/c/1265820 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Pavel Feldman authored
Bug: 893705 Change-Id: I6df37f886de9c080fa20c972df7457b0a726ce3e Reviewed-on: https://chromium-review.googlesource.com/c/1278206Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599072}
-
Zhizhou Yang authored
This patch will remove a linker flag for ThinLTO. The flag was first introduced to work around a nacl crash bug. After the compiler upgrade, there is no need to keep this work around. I tested the nacl_helper code size changes on several different boards: on samus: 30MB -> 11MB on elm: 19MB -> 7MB on veyton-minnie: 19MB -> 7MB Tested correctness by trying to reproduce https://crbug.com/799642 and no error shows up. BUG=chromium:799642 TEST=USE="afdo_use" emerge-samus chromeos-chrome Change-Id: I6fff65700e6d5a5d0e02ad810def5317ea912263 Reviewed-on: https://chromium-review.googlesource.com/c/1277596Reviewed-by:
Mark Seaborn <mseaborn@chromium.org> Commit-Queue: Zhizhou Yang <zhizhouy@google.com> Cr-Commit-Position: refs/heads/master@{#599071}
-
Scott Chen authored
The original CL 1252906 was reverted due to breaking unit tests for branded window builds. This CL fixes that by removing obsolete unit tests. It was testing the mechanism that conditionally directs users to the chrome://welcome/email and chrome://welcome/apps experiment URLs, which will no longer be used. Bug: 874153 Change-Id: I3b92b53e191606a6f5889cf17b15a570ce566994 Reviewed-on: https://chromium-review.googlesource.com/c/1275294Reviewed-by:
-
Patti authored
This reverts commit c3acb7ba. Reason for revert: This change may be causing ash_unittests to fail on multiple builders - see crbug.com/894683 Original change's description: > splitscreen: Adjust bubble dialog bounds if splitscreen is active. > > When a dialog is added to a window that's currently showig in > splitscreen, we should adjust the dialog bounds to show the dialog > aligned within its own side of the split, rather than across the divider > bar. > > Note the divider is still placed on top of the snapped windows and its > transient children if they are placed in default container. > > Bug: 878268 > Change-Id: Ibdd71f1d42aac419ef73ae9f7a2f78af6bf36880 > Reviewed-on: https://chromium-review.googlesource.com/c/1274197 > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598827} TBR=xiyuan@chromium.org,xdai@chromium.org Change-Id: I74d78ce0184d2028811872ac633da33ede16f296 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878268, 894683 Reviewed-on: https://chromium-review.googlesource.com/c/1277907Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599069}
-
Kent Tamura authored
This CL makes LayoutTests/PRESUBMIT.py and some tests in LayoutTests/ workable in blink/web_tests/ too. Moving LayoutTests directory gets easier by this CL. * PRESUBMIT.py - Use PresubmitLocalPath() instead of 'LayoutTests' - Remove unnecessary check for existence of 'LayoutTests' in AffectedFiles(), which returns files under the PRESUBMIT directory. _FindNewViolationsOfRule() also handles only files under the PRESUBMIT directory. * Tests - Update code searching for 'LayoutTests' so that it searches for 'web_tests' too. - Drop 'LayoutTests' from test expectations if we can - Introduce relativeTestPath() Change-Id: I741ab3cb29d8e6c2a35e3b7669f92744f76c2839 Bug: 843412 Reviewed-on: https://chromium-review.googlesource.com/c/1276047Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599068}
-
