- 09 Apr, 2013 10 commits
-
-
kaanb@chromium.org authored
BUG=175012 Review URL: https://chromiumcodereview.appspot.com/13543007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192971 0039d316-1c4b-4281-b951-d872f2087c98
-
varunjain@chromium.org authored
BUG=218270 Review URL: https://chromiumcodereview.appspot.com/13529009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192970 0039d316-1c4b-4281-b951-d872f2087c98
-
jvoung@google.com authored
Make the pnacl component place files in a profile-specific directory for chromeos. We don't want to share data between users on chromeos because of questions about integrity of these files. This adds a notification watcher and will re-register pnacl with a different version whenever the user logs into a different account. Files are installed to a stateful partition, which should be okay. The stateful partition is mounted no-exec, but the pnacl files are not typical executables. This is a temporary solution to help with testing out PNaCl on chromeos. We will need to find a different solution later that does not involve multiple copies, one for each user. BUG=221381 TEST= manual with: 1) export GYP_DEFINES="chromeos=1" 2) build 3) out/Release/chrome --enable-pnacl --enable-nacl --user-data-dir=/tmp/temp_profile_chromeos --login-profile=user --login-manager 4) wait 20 seconds and see /tmp/temp_profile_chromeos/test-user/pnacl/0.0.0.5 show up Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192415 Review URL: https://codereview.chromium.org/13071002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192969 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
Also, add an option 'chrome-version' to run_all_tests.py so that we can run tests on a specified version of chrome. And disable one failed java test on Win7. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13827002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192967 0039d316-1c4b-4281-b951-d872f2087c98
-
hubbe@chromium.org authored
BUG=181072 Review URL: https://chromiumcodereview.appspot.com/13293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192965 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
FileSystemURL::virtual_path is a superficial path specified by the user of FileSystem API. It does not necessarily denote the 'virtual path' of Drive files like drive/foo.txt, when the Drive filesystem is mounted onto of another filesystem (e.g., onto an isolated filesystem). Basically, virtual_path() should never be directly used inside the Drive filesystem. BUG=none Review URL: https://chromiumcodereview.appspot.com/13767002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192962 0039d316-1c4b-4281-b951-d872f2087c98
-
noahric@chromium.org authored
O1D is a replacement for O3D. We want to support it on cros as well as win/mac/lin, so we've written a ppapi implementation of it. BUG=None Review URL: https://chromiumcodereview.appspot.com/12733004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192961 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
It was caused by -menu getting called before the view got added to the window, which was creating the C++ controller with a nil NSWindow. (This was being done by the localizer inspecting the view.) Add an early return in that case - so the menu only gets created once the view is attached to the window. BUG=227388 TEST=As per bug. Review URL: https://chromiumcodereview.appspot.com/13801018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192958 0039d316-1c4b-4281-b951-d872f2087c98
-
dharcourt@chromium.org authored
This padding was in some previous versions but got lost somewhere along the way. This change restores it so there are always at least 12 pixels between the baseline of the last line of text and the bottom of the card or the image below the text. This will be true for WebKit, simple, basic, and image notifications but also for list ones. Note that although there will be exactly 12 pixels of space on Windows, there will be 13 pixels On Chrome OS because different fonts are used there, and also that if the Chrome OS system font changes that number of pixels may change slightly. This change also makes the padding between the top of notification text and the notification card be 12 pixels, as it was designed to be. It had somehow become 11 pixels. BUG=225871 TEST=Bring up a notification, take a screenshot, and count pixels. Review URL: https://chromiumcodereview.appspot.com/13560002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192957 0039d316-1c4b-4281-b951-d872f2087c98
-
ckocagil@chromium.org authored
BUG=227332 TEST=Drag-drop operations on Win Aura shouldn't crash the renderer or hit asserts Review URL: https://chromiumcodereview.appspot.com/13523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192954 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Apr, 2013 30 commits
-
-
mdempsky@google.com authored
Review URL: https://chromiumcodereview.appspot.com/13804003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192953 0039d316-1c4b-4281-b951-d872f2087c98
-
scheib@chromium.org authored
This allows packaged applications to launch windows already into a fullscreen, maximized, or minimized state. Design doc: https://docs.google.com/a/google.com/document/d/1__SPIxd_sFVYFNdP55CouE-p61uLOWEL-X-2TEOJFdY/edit BUG=163626 TEST=Manual testing is appropriate as this functionality is tightly coupled with operating system functionality and related automated tests have always been disabled flaky. Please use the window-state sample: https://github.com/GoogleChrome/chrome-app-samples/tree/master/window-state. Review URL: https://chromiumcodereview.appspot.com/13609003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192952 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/13524005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192951 0039d316-1c4b-4281-b951-d872f2087c98
-
skaslev@chromium.org authored
BUG=124671, 161008 Review URL: https://chromiumcodereview.appspot.com/13560016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192950 0039d316-1c4b-4281-b951-d872f2087c98
-
dsinclair@chromium.org authored
The code to handle cache clearing didn't land in time for the M27 branch so it has been decided to disable this feature for M27. This patch will be rolled back after it lands on the M27 branch. BUG=228989 Review URL: https://chromiumcodereview.appspot.com/13800013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192949 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiu@chromium.org authored
This patch fixes most of the problems with the allow/block flow: - removes got_user_gesture - uses the redirect list for URLs instead of recording them every time - better identifies when the user has clicked on a link and when the page was redirected. R=bauerb@chromium.org BUG=168772 TEST=browser_tests --gtest_filter=ManagedModeBlockModeTest.* Review URL: https://chromiumcodereview.appspot.com/13533017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192948 0039d316-1c4b-4281-b951-d872f2087c98
-
vitalybuka@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/13771017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192947 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
1. Device changes may cause an already in process stream creation to use the wrong buffer size => CHECK() failure. 2. Low latency stream Open() failure causes AudioOutputResampler to fall back to a high latency buffer size, which will cause a stream to be created with the wrong buffer size => CHECK() failure. Fixing 2 has the added advantage of removing an extra useless hop between stream Open() failure and switching to a fake audio output device. BUG=225249 TEST=audio works. Review URL: https://chromiumcodereview.appspot.com/13390010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192946 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
This lands server change 44867738. Review URL: https://codereview.chromium.org/13529032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192945 0039d316-1c4b-4281-b951-d872f2087c98
-
mostynb@opera.com authored
When starting with --wait-for-debugger command line option, it's ending up in a busy loop waiting for a variable to be changed. Change that busy loop from a macro to a function. It avoids having to step on instruction level to find the right stack frame before the variable is visible. Review URL: https://chromiumcodereview.appspot.com/13597005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192944 0039d316-1c4b-4281-b951-d872f2087c98
-
toyoshim@chromium.org authored
The URL for Chrome OS file manager extension is checked separately for now. But this must be done in IsTranslatableURL() at once. BUG=none TEST=unit_tests Review URL: https://codereview.chromium.org/13770003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192943 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
BUG=140402 TEST=NONE; Test logs don't spew this NOTIMPLEMENTED. TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/13759002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192942 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=155363 R=msw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/13602010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192941 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
This function was used in only one place and that place was wrong. The implementation was long and complicated on Windows, and long and complicated and copied verbatim from elsewhere with 3 lines different on Posix. The place it was used was in the proxy launcher when copying the profile. It's not clear to me why we wouldn't want the profile files in the filesystem cache when running tests. Quite the opposite, we want the tests to run as fast as possible. The only place this should matter is in the startup tests. And the startup tests do things to the profile after it gets copied that should page some files back in! This adds another step to the startup tests to evict the profile files for cold startup tests only. This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. patch from issue 13394003 Review URL: https://codereview.chromium.org/13646016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192940 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
R=rch@chromium.org, jar@chromium.org Review URL: https://codereview.chromium.org/13520010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192939 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
Go to the bug tracker to see how it looks like. BUG=221420 TEST=None Review URL: https://codereview.chromium.org/13686019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192938 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiu@chromium.org authored
Adds a new dialog that allows a user to edit the list of manual exceptions for managed mode. Authentication is not yet tied in. R=bauerb@chromium.org, markusheintz@chromium.org, jhawkins@chromium.org BUG=171370 Review URL: https://chromiumcodereview.appspot.com/12594029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192937 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
When LCD text needs to be disabled for a layer, we can invalidate just the tiles containing text. This only works with impl-side painting where it is very cheap to mark tiles that have text. BUG=181245 Review URL: https://chromiumcodereview.appspot.com/13726013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192936 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
This lands server change 44799980. Review URL: https://codereview.chromium.org/13454035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192933 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
button_close_hover.png, button_close.png. These need to be landed before the CL that uses them. BUG=none TBR=noelallen@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/13741028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192930 0039d316-1c4b-4281-b951-d872f2087c98
-
dbeam@chromium.org authored
R=estade@chromium.org BUG=227498 Review URL: https://chromiumcodereview.appspot.com/13699005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192929 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
TBR=guoyang@chromium.org BUG=169678 Review URL: https://codereview.chromium.org/13741024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192928 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
R=cduvall@chromium.org Review URL: https://codereview.chromium.org/13604002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192927 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://indexeddb-internalsalecflett@chromium.org authored
This is the just the WebUI code necessary to show HTML at the chrome://indexeddb-internals URL. The page just says "Welcome" to start. BUG=174188 Review URL: https://chromiumcodereview.appspot.com/13230003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192926 0039d316-1c4b-4281-b951-d872f2087c98
-
nileshagrawal@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/13483027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192925 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
The client plugin may crash if a signaling message is receive before the client started connection. It's likely to be a leftover from a previous session, so it's safe to ignore it. BUG=226775 Review URL: https://chromiumcodereview.appspot.com/13594011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192923 0039d316-1c4b-4281-b951-d872f2087c98
-
alyssar@google.com authored
This will prevent naming conflicts with similar classes in net/quic BUG= Review URL: https://chromiumcodereview.appspot.com/13741012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192922 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
Review URL: https://codereview.chromium.org/13744002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192921 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
From last 0.6 release, main changes are: 1. Implement get/set geolocation command. 2. Fix bugs with frame/navigation handling. 3. Implement window control commands for desktop. 4. Implement file upload in SendKeys command. 5. Implement proxy capability. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13770010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192920 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
This paves the way for making a EulaAcceptedNotifierAndroid class. Also enables EULA logic tests on all platforms, not just ChromeOS (since the EULA criteria are being mocked already). No functionality changes. BUG=226757 TEST=Existing unit tests. Review URL: https://chromiumcodereview.appspot.com/13620010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192915 0039d316-1c4b-4281-b951-d872f2087c98
-