- 17 May, 2018 40 commits
-
-
Maksim Sisov authored
This cl adds an initial display fetching support for Ozone/Wayland: - First, DesktopScreenOzone adds itself as an observer to a NativeDisplayDelegate, which has its own implementation based on a platform. - Then, DesktopScreenOzone initializes NativeDisplayDelegate and, in case of WaylandNativeDisplayDelegate, WaylandNativeDisplayDelegate sets itself as an observer to a PrimaryOutput. - Once PrimaryOutput creates current display's snapshot and current mode , (WaylandNativeDisplayDelegate::)OnOutputReadyForUse is called, WaylandNativeDisplayDelegate notifies its observers (DesktopScreenOzone in this case) through OnConfigurationChanged method. - Then, DesktopScreenOzone calls NativeDisplayDelegate::GetDisplays, which returns a vector of display snapshots through a callback, and DesktopScreenOzone::OnHostDisplaysReady creates a display::Display with parameters it gets from display::DisplaySnapshot. Preliminary support for mode changes has also been added. If we take a normal run-time browser flow, WaylandOutput::OutputHandleMode can be called on every display change (it can be a resolution change, a refresh rate change and etc). Once |current_mode_| is updated, OnOutputReadyForUse is again called and DesktopScreenOzone fetches the newest list of displays, which is then used to create a display::Display with the ids provided. As a result, ProcessDisplayChanged is called and stored display::Display updated by checking its id. Note: it's impossible to run Wayland without --in-process-gpu flag as long as support for gpu process communication with wayland connection is not in place yet, but it's under development and going to be pushed soon. To try this, compile with the following gn args use_ozone = true ozone_platform_wayland = true TEST=./out/Debug/chrome --ozone-platform=wayland --in-process-gpu Bug: 578890 Change-Id: Ia0f61f1af24eeb46433d22cf31f69396325e4c78 Reviewed-on: https://chromium-review.googlesource.com/1051829Reviewed-by:Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#559446}
-
Gyuyoung Kim authored
TBR=haraken Bug: None Change-Id: Icaa75e99a1804390f12fead5e5ece9c46e68a718 Reviewed-on: https://chromium-review.googlesource.com/1063519Reviewed-by:
Gyuyoung Kim <gyuyoung.kim@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559445}
-
Moe Ahmadi authored
-As EG synchronization is disabled, manually waits until payment screen shows. -Clears profiles before starting each test, so that each test starts with a clean state. Bug:833562 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e21537e91e57a7f38ff3715f4999ad73481eb56 Reviewed-on: https://chromium-review.googlesource.com/1059654Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#559444}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: I89bc10d563c0a33c5b804a15ba06581f813aac58 Reviewed-on: https://chromium-review.googlesource.com/1063651Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559443}
-
Kent Tamura authored
This is a reland of 55d941b0 This CL has no diiferences from it. http://crrev.com/559440 should fixed a build issue on non-goma Windows. Original change's description: > Reland "Remove unnecessary include_dirs settings from BUILD.gn in Blink" > > This is a reland of 7f4f1890 > This CL has no differences from it. http://crrev.com/559003 should > fix a build issue. > > Original change's description: > > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > > > Now we have no Blink-relative #includes. > > > > Bug: 836071 > > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > > Reviewed-on: https://chromium-review.googlesource.com/1058876 > > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > > Commit-Queue: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#558629} > > TBR=peria@chromium.org > > Bug: 836071 > Change-Id: I452a61199a31b6a6a617e2985331ab6a034c6c7c > Reviewed-on: https://chromium-review.googlesource.com/1059636 > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559018} TBR=peria@chromium.org Bug: 836071 Change-Id: Iade8aebc34d13ac08b257e2c7451071064b8474b Reviewed-on: https://chromium-review.googlesource.com/1063411Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559442}
-
Sasha Morrissey authored
Fix check in 'Manage with Drive' action, and add test to ensure it doesn't regress again. Also added getLastVisitedUrl() in util.js to get the URL opened by the Manage in Drive button. Bug: 831480 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I382a662607103d60a5c9a7c58643eff0f9f62106 Reviewed-on: https://chromium-review.googlesource.com/1058884 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#559441}
-
Kent Tamura authored
Change it from root_build_dir to "//". /FI flag argument produces #include virtually, and there is no reason to use a path relative to root_build_dir, which is //out/$config typically. We should use a path relative to the repository root as usual. This is a preparation to remove "." from include_dirs defined in the BUILD.gn. Bug: 836071 Change-Id: I19351b752957e85f9f1aee9fc981e0a8d0f31ff8 Reviewed-on: https://chromium-review.googlesource.com/1063510Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#559440}
-
Pavol Marko authored
Sends the brand code in the DeviceRegisterRequest. The server may remove initial enrollment device state from its database when the device successfully enrolls. As initial enrollment device state is keyed by the serial number / brand code tuple, brand code is now also transferred on enrollment. Bug: 839353 Test: unit_tests --gtest_filter=CloudPolicyClientTest* Change-Id: I57205c2eb3b219ab7c2793a47e935e376216e703 Reviewed-on: https://chromium-review.googlesource.com/1057675Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#559439}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78fd93090e2f..b690905ad0c0 $ git log 78fd93090..b690905ad --date=short --no-merges --format='%ad %ae %s' 2018-05-16 benjhayden Add paper-progress to third_party/polymer2. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8a40c6c8aaf6b1e7786a38220ef8faf8656762df Reviewed-on: https://chromium-review.googlesource.com/1063328 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559438}
-
Lei Zhang authored
It has only a single function left with two callers. TBR=bradnelson@chromium.org Change-Id: Ib844f573f356cefd1b70bbdc9960d5164876f440 Reviewed-on: https://chromium-review.googlesource.com/1056389 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#559437}
-
Sheng-Hao Tsao authored
VAAPI JEA generates incorrect encoded image when the APP1 segment in the header has a thumbnail image. This CL works around the problem by providing an all-zero APP1 buffer with the same size and fill in the real APP1 buffer data after the encode is done. BUG=b:79840013 TEST=Verified on nautilus that GCA can take photos. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ic8dd17487a03af7a881a6d2804baee73bbbd13a1 Reviewed-on: https://chromium-review.googlesource.com/1061277Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#559436}
-
Bence Béky authored
Crash happens on line 170, but we do not know if handshake_stream_ or connect_delegate_ is null, or something else is broken. After this change the line number of the crash will help us narrow down the issue. Bug: 842575 Change-Id: I21ef22dd969bdd55c61c7da92d29edb97b9c7193 Reviewed-on: https://chromium-review.googlesource.com/1062835Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#559435}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iabd16a2cba1eb0e00b1fdfd779bae18ecaf7fc4f Reviewed-on: https://chromium-review.googlesource.com/1063553Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559434}
-
Brandon Jones authored
Change-Id: Iebf8e26c6a6d8637260cfaa43db8b4fa73e3f9d2 TBR: ddorwin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1062973 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#559433}
-
Gustaf Ullberg authored
Crashdumps indicate that HB_gain can become NaN. When the gain is applied to the input signal all samples become NaN, which causes the crashes described in chromium:826914. Changes: - Check if HB_gain becomes NaN and then set it to 1 (no high-band attenuation). If this CL does not fix the issue it should be reverted. If this CL does fix the issue we should investigate further. Bug: chromium:826914 Change-Id: Idfcee178715180faf57a3d26918e941b99a09071 Reviewed-on: https://chromium-review.googlesource.com/1061499Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#559432}
-
John Chen authored
Disable testCloseWindow and testCloseWindowUsingJavascript, which have been flaky recently. Also increase logging verbosity level to help diagnose this issue. TBR=kereliuk@chromium.org Bug: chromedriver:2431 Change-Id: Ic501ed3ea97817d76cfe37f5a58aee2f3f7254fe Reviewed-on: https://chromium-review.googlesource.com/1063530Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559431}
-
Hajime Hoshi authored
The task runner is used at UpdateInternalInstanceId and DeleteSoon, and I think unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was ThreadTaskRunnerHandle::Get(). We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Change-Id: I11679337908b6c64f3f6604639f2aed3b7c60ab0 Reviewed-on: https://chromium-review.googlesource.com/1055367Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559430}
-
Yutaka Hirano authored
It is suspected that due to sandbox a user-agent string gotten in a renderer process is difference from that gotten in the browser process. This CL removes the call in renderer. Instead, the value is passed from the browser process. This is a speculative fix. If it doesn't fix the issue, I will revert it. Further refactoring will be done in subsequent CLs (after confirming that this CL fixes the issue). Bug: 818450 Change-Id: Ie657c858f582ecdaee5c3245751068615969c890 Reviewed-on: https://chromium-review.googlesource.com/1031693 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Mike Wasserman authored
Add an InputDeviceServer instance to ui::ws2::WindowService. Add an InputDeviceClient instance to MusClient, remove from Chrome. (allows mojo apps using ws2 & MusClient to access InputDeviceManager) Split out TouchDeviceServer ownership to ui::Service. (IIUC, this won't be needed at all for ash->ws2 usage) Refine the server interface registration (BindSourceInfo not needed). Make the shortcut viewer dependency on InputDeviceManager explicit. Fix the DCHECK in ksv unit tests, and a crash showing the KSV in Mash. This is a prerequisite for making Keyboard Shortcut Viewer a mojo app: https://chromium-review.googlesource.com/c/chromium/src/+/1060163 Bug: 841020 Change-Id: I9de8e9ccf249aa40e7a297261d9d2e0f2989fbfe Reviewed-on: https://chromium-review.googlesource.com/1062770Reviewed-by:
-
Jun Mukai authored
This extension allows the cursor shape by its ID rather than graphical data through surface. This is an extension, so the existing behavior will work as-is without any changes. Bug: b/70666810 Change-Id: Iafa576a6d2e0103f7bc1b6eb295a0187f967a80a Reviewed-on: https://chromium-review.googlesource.com/1040670 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559427}
-
Alan Cutter authored
There's no UX on a PWA window to indicate incognito status, disable the ability to get in this situation (also it DCHECKs). Bug: 843869 Change-Id: I6b48258dfbe118ea67aae9b9a5375b198eaa4e75 Reviewed-on: https://chromium-review.googlesource.com/1062991 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#559426}
-
Takayoshi Kochi authored
Use UKM for document.registerElement() to help investigate which site is actively using Custom Elements V0 API. The motivation is to drive usage down, by outreaching those users. As of today the usage is around 5% so we sample this feature as well as the existing kElementCreateShadowRoot. https://www.chromestatus.com/metrics/feature/timeline/popularity/457 Bug: 843080 Change-Id: I8a94fdcf2d0c905a3a978cb78673c0544b2155a2 Reviewed-on: https://chromium-review.googlesource.com/1059100 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Hayato Ito authored
Make IncremantalShadowDOM flag stable. PSA in blink-dev is here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1TXLVz_H1S0/n4cdluQjAwAJ Bug: 776656 Change-Id: I8d6c02d793ad30c4774fe069b84127e5575b3678 Reviewed-on: https://chromium-review.googlesource.com/908269Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL sets IsReady() false at MockPendingScript construction and sets it true in ScriptRunnerTest::NotifyScriptReady(). This removes most of IsReady() EXPECT_CALL()s. Bug: 842349 Change-Id: I633f4fa17add8f149efc068b8b2a4573db2a6c53 Reviewed-on: https://chromium-review.googlesource.com/1041131 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#559423}
-
Lei Zhang authored
Get rid of deprecated linked_ptr usage. Use RefCounted because the object has shared ownership. BUG=556939 Change-Id: Iab75d2a4cf834227764d4ac1888e3efa690b2ce2 Reviewed-on: https://chromium-review.googlesource.com/1053992 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#559422}
-
Scott Violet authored
The WindowService (indirectly) installs observers on various objects created by Ash. Because of this the WindowService really needs to be destroyed before ash's Shell. This patch introduces the WindowServiceOwner, which owns the WindowService. ServiceManager supports this by way of providing a function to bind the ServiceRequest directly. When the request is seen WindowServiceOwner creates a ServiceContext, which owns the WindowService. WindowServiceOwner owns the ServiceContext. Shell owns the WindowServiceOwner, so we can guarantee a particular shutdown ordering. I also made it so the WindowService is immediately created. This was mostly because it simplified the code slightly, but I could make it lazily created if necessary. BUG=837692 TEST=none (test will follow) Change-Id: I2628292c73f4fe86e48cad55d2b63e9345fcd831 Reviewed-on: https://chromium-review.googlesource.com/1062717 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559421}
-
https://pdfium.googlesource.com/pdfium.git/+log/98ec53359b8e..db3c6cefcedd $ git log 98ec53359..db3c6cefc --date=short --no-merges --format='%ad %ae %s' 2018-05-17 thestig Update third_party/base/compiler_specific.h. 2018-05-16 npm Move JBig2 HuffmanTables into JBig2_HuffmanTable.cpp Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie8437df3f524273976b9ed4ee01ecff5172572f9 Reviewed-on: https://chromium-review.googlesource.com/1062917 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559420}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05da1c16dfb4..ed4921b9d473 $ git log 05da1c16d..ed4921b9d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms 5cc905d..e4c0e54 (1 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I132d2bd4bbf51e92acb210ad6665b29e20a7e0f7 Reviewed-on: https://chromium-review.googlesource.com/1062918Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559419}
-
Mike Frysinger authored
Change-Id: I1af04d08c63f66d58cbb97fc1c824509138f0fd2 Reviewed-on: https://chromium-review.googlesource.com/1063151Reviewed-by:
-
Mike Frysinger authored
This syncs the set of permissions from Secure Shell that we want/use in newer versions of hterm. Bug: 822490, 646690 Change-Id: I7abadb369b3178739808aa41fd0cae9ef3c0759e Reviewed-on: https://chromium-review.googlesource.com/1061619Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Sheng-Hao Tsao authored
This CL allows EXIF buffer to be absent in a JEA request. BUG=b:79251580 TEST=Still capture with JEA works with EXIF length equaling 0 Change-Id: I4e9ff0a162bb3ac3f227f44716575234350eb2e0 Reviewed-on: https://chromium-review.googlesource.com/1061774Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#559416}
-
Koji Ishii authored
Following bot results are included. 5553 5560 5564 7 lines were removed and 0 lines were deflaked by consecutive results since 5428. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I31c70a938e2c28178bcf9136beca4639d961e678 Reviewed-on: https://chromium-review.googlesource.com/1062665 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Mike Frysinger authored
The options page has been around for 5+ years, but only accessible if you typed the URL directly, or used the Ctrl-Shift-P shortcut added in the last year or so. While we've been updating the manifest files in the nassh repo, we had forgotten about this one. Although it wasn't useful before the recent Terminal/Crostini work as crosh hasn't been a visible "app", only via the Ctrl-Alt-T shortcut on a Chromebook. Bug: 843613 Change-Id: I32a67cd85d5eafe147672cd93c35dea0cc5edcdd Reviewed-on: https://chromium-review.googlesource.com/1061618 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#559414}
-
Xiaocheng Hu authored
LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel() hard-maps the left side of an atomic inline to the DOM position at its start, and the right side to its end, which is wrong if the atomic inline is RTL. This patch fixes the issue. Note: this patch doesn't fix selection flickering when dragging mouse over an atomic inline surrounded by bidi text, due to bugs in bidi adjustment in SelectionController. Bug: 811502, 834066 Change-Id: Id1687922f3d713cb2eb4b8668cb0687196a2fc44 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1062831Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alexandros Frantzis authored
This commit prepares ozone_demo to use GpuFences for overlay planes, when support for them lands in any of the Ozone backends. The --use-gpu-fences ozone_demo flag controls whether to enable the use of fences or use the existing glFinish mechanism. Bug: 828393 Test: Run ozone_demo on Ozone-DRM Change-Id: I797e9445479ff4a9768cb89033d1dd6fd826b5ae Reviewed-on: https://chromium-review.googlesource.com/1021693 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#559412}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibb6b5ef9c34efcfd06bb9e362a7ec2cad16c2609 Reviewed-on: https://chromium-review.googlesource.com/1063150Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559411}
-
James Darpinian authored
The flakiness is on all platforms. https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpncHVfdGVzdHMucGl4ZWxfaW50ZWdyYXRpb25fdGVzdC5QaXhlbEludGVncmF0aW9uVGVzdC5QaXhlbF9XZWJHTFNhZENhbnZhcww Bug: 835867 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I959dd5e6db6f8ca4f50effeca828a8cd98f6b5fa Reviewed-on: https://chromium-review.googlesource.com/1062911 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559410}
-
Koji Ishii authored
This patch adds ComputedStyle::GetFontBaseline function, and use it in all places in LayoutNG. It should depend on 'writing-mode' and 'text-orientation', but in many places in LayoutNG it is determined only from 'writing-mode'. This fixes 4 tests but discovers 2 failures. As in the added comment, the inline boxes and text should be aligned to parent's dominant baseline. In many places in LayoutNG and also in the current engine, we check the baseline of the child box. Some of these look incorrect, but fixing them is for future CLs. This CL just replaces each code with the common function. A design question is whether to add this to NGConstraintSpace or not, because the layout depends on parent's dominant baseline. This patch does not do this but instead pass when necessary, because it is only needed for inline context, and we don't create NGConstraintSpace for inline descendants. This may be revisited in future. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba77fd528fb0ea54526f45d8dfd83bbcfb48411c Reviewed-on: https://chromium-review.googlesource.com/1059974 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#559409}
-
Gary Kacmarcik authored
This class contains all the platform-independent code for creating the Keyboard Map. Bug: 832811 Change-Id: Icb4dbf85419c72e795b090bae816b0b1c6b03f67 Reviewed-on: https://chromium-review.googlesource.com/1062925 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559408}
-
Tom Anderson authored
Includes 4 changes: https://chromium.googlesource.com/chromium/buildtools/+log/a9e946f166b73f9dc170129f6586a1e68efb0ab3..94288c26d2ffe3aec9848c147839afee597acefd Notably, libc++ and libunwind are rolled. BUG=767901 R=thakis Change-Id: Ie4ce691439dea7a362501ebaba9c2ccc130ea90a Reviewed-on: https://chromium-review.googlesource.com/1063019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559407}
-
