- 16 Feb, 2018 6 commits
-
-
chrome://ukmMohamad Ahmadi authored
Bug: 809507 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I584f0412c197f24236b5402f97d9000a9bf92d66 Reviewed-on: https://chromium-review.googlesource.com/916707Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537112}
-
Gary Kacmarcik authored
Bug: 677564 Change-Id: Ie12715cb93b6339571109978d6f198ec4e6113f6 Reviewed-on: https://chromium-review.googlesource.com/910318 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#537111}
-
Victor Costan authored
Bug: 805814 Change-Id: Ib2441c3ed2060e73062c3993a6876314cac9a669 Reviewed-on: https://chromium-review.googlesource.com/921321 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#537110}
-
Mohammad Refaat authored
Bug: 759229, 779106 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia79cc0ba778e1b24de5cfddab2068f165b77d64e Reviewed-on: https://chromium-review.googlesource.com/922924Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#537109}
-
Steven Bennetts authored
i18n() asserts if any unsafe tags are passed to it. We need to HTMLEscape any network names passed to i18n(). Bug: 811562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3112dc2f38b0560d1d6ad9fdde91581f1c498a45 Reviewed-on: https://chromium-review.googlesource.com/920903Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#537108}
-
Steven Bennetts authored
Bug: 811659 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id8937bcbd6828c8fc38b0e27e6505582ce6c25ca Reviewed-on: https://chromium-review.googlesource.com/920647Reviewed-by:
-
- 15 Feb, 2018 34 commits
-
-
Matthew Jones authored
This reverts commit 106dd071. Reason for revert: ToastHWATest still breaking because of this patch: https://ci.chromium.org/buildbot/chromium.android/Lollipop%20Phone%20Tester/18803 Original change's description: > Second reland of "Encapsulate Chrome thread profiling setup into a single class" > > Fixes Android test failure by avoiding implicit creation of the render > thread. Also moves the decision on whether to profile extension processes into > the StackSamplingConfiguration, and cleans up comments. > > This is a reland of f8ad6e3e. > > Original change's description: > > Reland "Encapsulate Chrome thread profiling setup into a single class" > > > > This is a reland of aa63fc1d. > > > > Original change's description: > > > Encapsulate Chrome thread profiling setup into a single class > > > > > > Creates a simple abstraction around the fairly complex profiling setup. > > > This CL switches over the GPU and renderer process usage to this class. > > > The browser process usage will be converted to use this class after it > > > is extended to support periodic profiling (in a follow-on CL). > > > > > > Bug: 808588 > > > Change-Id: I6195571bf3ddd08291f288f475569bd9a88795ef > > > Reviewed-on: https://chromium-review.googlesource.com/905451 > > > Reviewed-by: Scott Violet <sky@chromium.org> > > > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#535125} > > > > TBR=sky > > > > Bug: 808588 > > Change-Id: I34f1910116c4e7a500e353c27b85bf7534be43c7 > > Reviewed-on: https://chromium-review.googlesource.com/907508 > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Commit-Queue: Mike Wittman <wittman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#535170} > > Bug: 808588 > Change-Id: Id34e6a3e57c144697413ecced43146bf3e6521e9 > Reviewed-on: https://chromium-review.googlesource.com/917197 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#537023} TBR=sky@chromium.org,wittman@chromium.org Change-Id: I38fc0f48e73cb4f7c4ac1a31235f655c406f85b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808588 Reviewed-on: https://chromium-review.googlesource.com/922942Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#537106}
-
Ella Ge authored
This Cl add deprecate warning for document.createTouch and createTouchList. This two feature has been deprecate from spec and has very low usage now. To be removed in M68 intent to deprecate and Remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc Bug: 518868 Change-Id: Id043619f55a241e982fc6347cab26061ed664112 Reviewed-on: https://chromium-review.googlesource.com/915035 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#537105}
-
Xianzhu Wang authored
Previously we called CompositedLayerRasterInvalidator:: GenerateForPropertyChanged() for each GraphicsLayer that didn't need repaint. This caused performance issues during 1) document lifecycle update when nothing changed 2) GraphicsLayer::Paint called from cc_blink::WebContentLayerImpl which are supposed to be super fast. Instead of calling the function for each GraphicsLayer, now call SetNeedsRepaint for non-composited fixed-position layers on viewport scroll to ensure performance for the critical case. This CL will improve SPv175 record_time (fully cached situation) by about 20% (https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180215060448/html/index.html). Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5a3a4fe538f0d807d8bc3dba1dda201e7d659901 Reviewed-on: https://chromium-review.googlesource.com/920658 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537104}
-
Martin Sramek authored
Currently, consent auditor only supports one feature (Chrome Sync), but we use the enum-type histogram for extensibility in the future. As this histogram didn't fit into existing categories, a new top-level category "Privacy" is introduced. TBR=markusheintz@chromium.org Bug: 781765 Change-Id: I6e4d93e1a45ce1f06e4d18b0cb6e5fa5b4673273 Reviewed-on: https://chromium-review.googlesource.com/911572 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#537103}
-
Yuke Liao authored
FullscreenTestCase/testShowHeaderWhenChildTabCloses is flaky on devices. Bug: 812664 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7e632efa8823e253264c0d20012ac80c628562e7 Reviewed-on: https://chromium-review.googlesource.com/922261Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#537102}
-
Chris Hamilton authored
This also fixes a small bug in the UpdateTitle function. Receiving a title is not an indication of data having been received as renderers have code for setting an empty title before data has started to arrive. This will be used by an upcoming component that tracks the number of WebContents that are simultaneously loading, in order to give session-restore's TabLoader a better view of the work being performed on the system. BUG=749785 Change-Id: I2fac76f18f122926af5e09f7ae41ff0d83eef225 Reviewed-on: https://chromium-review.googlesource.com/909334Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#537101}
-
Matthew Jones authored
This change replaces the browser controls update logic in overlay panels with a native mojo version. This was the only usage of updateBrowserControls in java web contents which can now be removed. The number of parameters used by the function in OverlayPanel has been reduced to handle how it is being used -- either completely shown or completely hidden. BUG=810937 Change-Id: If17709f43a150dec30b0b9cd0644161b1f5ad265 Reviewed-on: https://chromium-review.googlesource.com/917218 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#537100}
-
chcunningham authored
New test fast/layers/scrollable-area-removed-on-scroll-crash.html Test was added yesterday here https://chromium.googlesource.com/chromium/src/+/3ab971569afab25c6e330b3898fba29288b68732 No-Tree-Checks: true No-Try: true TBR: flackr@chromium.org Bug: 812702 Change-Id: I456220e68f10a39fd607bbce55b5300ff25041e6 Reviewed-on: https://chromium-review.googlesource.com/922266Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#537099}
-
Nico Weber authored
Namely, Wtautological-unsigned-zero-compare and Wtautological-unsigned-enum-zero-compare, see http://llvm.org/viewvc/llvm-project?view=revision&revision=322901 If we have to disable them again in the future, it's probably better to use -Wno-tautological-in-range-compare then. Bug: 763392,767059 Change-Id: I8374fc2b9854618052b784be0371f8744b057701 Reviewed-on: https://chromium-review.googlesource.com/922022Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#537098}
-
Anita Woodruff authored
- The test method was unused since crrev.com/c/906491 Change-Id: Ia298a907a0eb3fc147b14cbb9ba724e515d70876 Reviewed-on: https://chromium-review.googlesource.com/922082 Commit-Queue: Anita Woodruff <awdf@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#537097}
-
Torne (Richard Coles) authored
Instead of hardcoding startswith('Class') to try to deal with generics (which doesn't work when disassembling a class file as the type is java.lang.Class there), just use the existing _StripGenerics function to remove generics from types before converting them to C types. Bug: 787557 Change-Id: Iae2b760bcb8f1407e1e13ba9d692cd463a5a3ad2 Reviewed-on: https://chromium-review.googlesource.com/922501Reviewed-by:agrieve <agrieve@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#537096}
-
https://pdfium.googlesource.com/pdfium.git/+log/46f79aaad833..625e6fec9ddd $ git log 46f79aaad..625e6fec9 --date=short --no-merges --format='%ad %ae %s' 2018-02-15 rharrison Correctly seek when header size is larger then expected Created with: roll-dep src/third_party/pdfium BUG=811733 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7ce520f7395224d24f8d793ff1e58035b8d75033 Reviewed-on: https://chromium-review.googlesource.com/922382Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#537095}
-
bsheedy authored
Adds a new xr.webvr.live.static benchmark. This is a superset of xr.webvr.wpr.static, as some of the sites we would like to run using WPR don't work properly when replayed. So, run against the live sites for these pages. Bug: 808597 Change-Id: I520d9a71c8a13878f02c8c6bddfbced2240ab9bd Reviewed-on: https://chromium-review.googlesource.com/912548 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#537094}
-
Min Qin authored
During annotation, an extra 16 characters(zone identifier) are appended to the file name. That may cause the file path to exceed the 260 character limit. This CL fixes that problem by truncating the file name when generating it. BUG=809759 Change-Id: Ie0baa318ccf5824e3ed4df8cf23386653b6747d7 Reviewed-on: https://chromium-review.googlesource.com/919445 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
-
Matthew Jones authored
This change is a bit of pre-work before adding an asset for the location bar background for Chrome Modern in the compositor. Params have been renamed (and don't necessarily control anything) and some obsolete code has been removed. BUG=803098 Change-Id: I0dd4ec76b9a583a434bda94ecf06f131d1b05925 Reviewed-on: https://chromium-review.googlesource.com/909300Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
kylechar authored
With the pass through command decoder there is no QueryManager instance. It looks like CommandBufferStub was updated to take this into account but not InProcessCommandBuffer. Add equivalent logic to InProcessCommandBuffer so it doesn't crash. This was causing a crash on Windows with the VizDisplayCompositor feature. Bug: 787099 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iea195682548737cbfdfdb53c1521b1931fb5224f Reviewed-on: https://chromium-review.googlesource.com/921925Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#537091}
-
kylechar authored
Add an OutputSurface for Windows that supports overlays when running with --enable-features=VizDisplayCompositor. The OutputSurface just needs to provide a CompositorOverlayCandidateValidatorWin. Bug: 787486 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I01cf5baea5298386e53d831d0674bde79d1fce28 Reviewed-on: https://chromium-review.googlesource.com/921661 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#537090}
-
Yuke Liao authored
NavigationAndLoadCallbacksTest.StopFinishedNavigation is failing consistently on devices. Bug: 812669 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I35912dc09646bf8dcfdbbbccebe5774cdc060ef2 Reviewed-on: https://chromium-review.googlesource.com/922321Reviewed-by:
-
Joe Mason authored
R=csharp Change-Id: I69cd8dcb037e782cb0a1538a35ea0383a7d39b6e Reviewed-on: https://chromium-review.googlesource.com/922163Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#537088}
-
Leonard Grey authored
Change-Id: I3188b7b0081e1e81cba3a5a09fdbcf536e1416bf Reviewed-on: https://chromium-review.googlesource.com/922023Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#537087}
-
Yixin Wang authored
Change-Id: Ib93379613e109aa76860b9f4e5f21320a8e7f152 Reviewed-on: https://chromium-review.googlesource.com/898097Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#537086}
-
Hans Wennborg authored
The WTF::HashTableAddResult from calling font_data_table_.insert() was being lifetime-extended in MSVC builds to the end of the function, causing the HashTableAddResult's destructor to run after the hash table had been changed, causing a dcheck. Bug: 812600 Change-Id: Ifa2b05ef92370c7ba043eea4258f4086274d1871 Reviewed-on: https://chromium-review.googlesource.com/921942Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#537085}
-
Kenneth Russell authored
This reverts commit 8348d507. Reason for revert: Broke multiple Windows bots per http://crbug.com/812693 . Original change's description: > [test_env.py] Warm up vpython virtualenv cache on swarming task shards. > > This will prevent tests sensitive to cold vpython startup time from > timing out. > > Bug: 804174 > Change-Id: Ieaf6e0d94fa668fd26481fe3efcaf6d0e968864d > Reviewed-on: https://chromium-review.googlesource.com/917802 > Reviewed-by: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536766} TBR=iannucci@chromium.org,dpranke@chromium.org,kbr@chromium.org,dnj@chromium.org,tandrii@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I02c3b0b1a44c24fc4f20e09431fac21053df74a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804174, 812693 Reviewed-on: https://chromium-review.googlesource.com/922581Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#537084}
-
Brian Salomon authored
Bug: 809692 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3796906eb7bcb64a919591c1e05f97a2ff7e44ee Reviewed-on: https://chromium-review.googlesource.com/905484Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#537083}
-
Yi Gu authored
Currently the names of Animation related classes on cc side is very confusing. e.g. cc::Animation is quite different from blink::Animation. blink::Animation is corresponding to cc::AnimationPlayer which owns multiple cc::AnimationTicker which owns multiple cc::Animation. To be consistent with blink, it’s better to rename the relevant classes. In addition, the cc::AnimationTicker behaves as the cc counterpart of blink::KeyframeEffect therefore it should be renamed as well. Corresponding changes are also made to the clients of cc::Animation (vr, ui, blink) in this patch. Summary: This patch: Animation -> KeyframeModel AnimationTicker -> KeyframeEffect Follow up patch: AnimationPlayer -> Animation Bug: 807667 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I24c240b514da38541e4dd8a5550a9092ebd11430 Reviewed-on: https://chromium-review.googlesource.com/906830 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#537082}
-
John Chen authored
Fixes hanging of ChromeDriver after switching to a window with its contents overwritten by document.write function. Bug: chromedriver:450 Change-Id: I5b1ba5ddd409dd5740c560dad76ab964bfa5c498 Reviewed-on: https://chromium-review.googlesource.com/914807Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#537081}
-
Stefan Zager authored
When SetPrinting(false) is called, the autosizer's page info needs to be updated *before* layout runs. BUG=799014 R=thestig@chromium.org,robhogan@chromium.org Change-Id: I7594eb7c2e50ebad2a005e10cba6663b23387fd2 Reviewed-on: https://chromium-review.googlesource.com/920001Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#537080}
-
David Trainor authored
Turn off the IllegalStateException that gets thrown and return early. This doesn't harm anything, but just makes it harder to track down the cause. Will reinstitute logging in the near future. BUG=786916 Change-Id: I761a588121ad032555e44eafae083dcff469558c Reviewed-on: https://chromium-review.googlesource.com/920044Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
Sergey Kuznetsov authored
channel_->ClearIPCTaskRunner() clears ipc_task_runner_ on ChildThreadImpl thread, but OnChannelOpened is called on another thread. This issues can be reproduced in synthetic environment: 1) Slowdown IO thread by applying patch: diff --git a/ipc/ipc_sync_channel.cc b/ipc/ipc_sync_channel.cc index c4f14dc..62adbd3 100644 --- a/ipc/ipc_sync_channel.cc +++ b/ipc/ipc_sync_channel.cc @@ -27,6 +27,8 @@ #include "ipc/ipc_sync_message.h" #include "mojo/public/cpp/bindings/sync_event_watcher.h" +#include "base/threading/platform_thread.h" + using base::WaitableEvent; namespace IPC { @@ -495,6 +497,8 @@ void SyncChannel::SyncContext::OnChannelError() { } void SyncChannel::SyncContext::OnChannelOpened() { + base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(1)); + shutdown_watcher_.StartWatching( shutdown_event_, base::Bind(&SyncChannel::SyncContext::OnShutdownEventSignaled, 2) Run unit test, that have InProcessUtilityThreadHelper, for example ExtensionServiceTest.ManagementPolicyRequiresEnable 3) The test will crash with stack: [FATAL:scoped_refptr.h(208)] Check failed: ptr_. Stack Trace: 000aa409 logging::LogMessage::~LogMessage() 00086191 scoped_refptr<base::SequencedTaskRunner>::operator->() const 000d7d13 base::WaitableEventWatcher::StartWatching ... 0001dce5 IPC::SyncChannel::SyncContext::OnChannelOpened() 0009075d base::OnceCallback<void ()>::Run() && 000991fb base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) 000af463 base::internal::IncomingTaskQueue::RunTask(base::PendingTask*) 000b1401 base::MessageLoop::RunTask(base::PendingTask*) 000b16ed base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) 000b17c3 base::MessageLoop::DoWork() 000b3329 base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) 000b11bf base::MessageLoop::Run(bool) 000c9e01 base::RunLoop::Run() 000eb387 base::Thread::Run(base::RunLoop*) 000eb645 base::Thread::ThreadMain() 000e6865 base::(anonymous namespace)::ThreadFunc(void*) Change-Id: I7c61e1d967876dd414e19261528d5871f7fbbbf3 Reviewed-on: https://chromium-review.googlesource.com/922201Reviewed-by:Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#537078}
-
Vladimir Levin authored
Loading the Document object into memory seems to take a bit of time and it shows up on perf profiles. We do this on every BlockFlowPainter to check if we have pending stylesheets, and then avoid painting descendants to avoid FOUC. Instead, this patch adds a bool to PaintInfo to track whether we should avoid painting descendants (ie if we have pending stylesheets). I think it is sufficient to only add this check in PaintLayerPainter, since other call sites would have to go through the body BlockFlowPainter and early out before painting things like scrollbars (which create their own PaintInfo). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I216518b94ddc4041282898afb57cc1e8a5c1c394 Reviewed-on: https://chromium-review.googlesource.com/917535Reviewed-by:
-
John Chen authored
The tests in Python ChromeDriverPageLoadTimeoutTest class routinely times out on Mac. Increase the timeout value on Mac to compoensate. Change-Id: I8ca89eb82a14cbb950144164a6680d28268112fc Reviewed-on: https://chromium-review.googlesource.com/919251Reviewed-by:
-
Roman Sorokin authored
By default authpolicyd uses 'strong' kerberos encryption types (AES-based algorithms only). That is not feasible for all Active Directory infrastructure. So we allow user to use weaker types for the domain join as well. e.g. 'all' options also includes RC4-HMAC into permitted encryptions. For more info see: https://wiki.samba.org/index.php/Samba_4.6_Features_added/changed#Kerberos_client_encryption_types BUG=chromium:805908 CQ-DEPEND=CL:893271,CL:908550 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibe40db451bb4656dbf18a5c7639891e2d9bb91a0 Reviewed-on: https://chromium-review.googlesource.com/893564 Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#537075}
-
Dmitry Skiba authored
This is a follow up to crrev.com/c/917230, which enabled lazy initialization of TTS voices on low-end Android devices. While it's critical to not bind to TTS on low-end devices, it's nice to also avoid doing that on mid- and high-end devices. This CL removes 'is low-end' check so that TTS voices are always lazily initialized on Android. If there are complaints we have an option to revert this CL, but not the previous one. Bug: 811929 Change-Id: I9eaeea75e7879780934f62d453c6b70fce68ee7c Reviewed-on: https://chromium-review.googlesource.com/919069 Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#537074}
-
Donn Denman authored
This reverts commit e5c83b43. Reason for revert: Broke normal usage (crbug.com/812542) Original change's description: > [TTS] Hide the CS UI when entering airplane mode. > > When Contextual Search enters a disabled state it removes notifiers > for showing the UI. However if the UI is already showing it should > hide it immediately. This CL adds a call to hide when disabling for > any reason, including network connectivity loss. > > BUG=783352 > > Change-Id: I826d38264cd6c0cb5ca6ece804c2f44c3b0ee924 > Reviewed-on: https://chromium-review.googlesource.com/917647 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536738} TBR=donnd@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 783352 Change-Id: I33da18a5e3d71dfd71717e0488d272d843a838c7 Reviewed-on: https://chromium-review.googlesource.com/922221Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537073}
-
