- 16 Jan, 2020 40 commits
-
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=drubery@chromium.org Bug: 1041419 Change-Id: Ic101be4bcd915eee3dfdd21fa4b81df1fd63aac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997810 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#732464}
-
Mike Wittman authored
This reverts commit 3b0ecec8. Reason for revert: the original change doesn't seem responsible for the flaky Clusterfuzz CHECK failure. The flakiness actually got 25x worse with the revert in place. Original change's description: > Revert "[Sampling profiler] Minimize use of loader lock on profiled threads" > > This reverts commit bab78c6c. > > Reason for revert: temporarily reverting to check whether this CL triggered the flaky Clusterfuzz CHECK failure in https://crbug.com/1034896. > > Original change's description: > > [Sampling profiler] Minimize use of loader lock on profiled threads > > > > Saves off the function pointer obtained from ntdll.dll so that we don't > > need to repeatedly query its module handle and take the loader lock > > while doing so. > > > > Bug: 1028808 > > Change-Id: I25c0dd2872524a28a87df7c4bf2db7551eab6311 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940882 > > Auto-Submit: Mike Wittman <wittman@chromium.org> > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#719811} > > TBR=wittman@chromium.org,brucedawson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1028808, 1034896 > Change-Id: Ifbda46060fbac279bee2289a6ac8f1df6afb0cbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998008 > Reviewed-by: Mike Wittman <wittman@chromium.org> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730687} TBR=wittman@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1028808, 1034896 Change-Id: If72cdc37cb7b6f22331220f840785ae1c902cd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003367Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732463}
-
Alison Maher authored
It was discovered that creating a custom layout for an element with only text as children causes a crash. This reason being that these text children were not getting blockified. To fix this, LayoutNGCustom::AddChild()/RemoveChild() should go through LayoutBlock::AddChild()/RemoveChild() in the above case to ensure that the text children become blockified. (https://chromium-review.googlesource.com/c/chromium/src/+/1745396/12/third_party/blink/renderer/core/layout/custom/layout_custom.cc) Bug: 1038501 Change-Id: I0816dab025f70613634a7c968f3d8abfe46ae01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992213Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#732462}
-
Gayane Petrosyan authored
Removes all the flags and finch features used for Richer Picker/Colors launch. It also removes Colors related configs passed to JS, but defaults to true for Richer Picker config. Richer Picker bit is a bit more complicated to remove and will be done in follow up. Bug: 1022548 Change-Id: I87522150028d063d756961d44314ad9ed8bfa61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003074Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#732461}
-
Gayane Petrosyan authored
screenshot: https://screenshot.googleplex.com/7195BT4gJFQ.png Bug: 993920 Change-Id: Id6d013e7046c8cdb59c0cbf79836188fb4d9962c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953568 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#732460}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=schenney@chromium.org Bug: 1041419 Change-Id: I18cfb646296e2ba5ed9edda14e7a51ffb7990712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998687 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#732459}
-
Jan Wilken Dörrie authored
TBR=masonfreed Bug: 1042694 Change-Id: Ia8dadfe7f64d50deb2caeca8d4159f3e351b1de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002817Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732458}
-
Connie Wan authored
Similar to crrev.com/c/1975035 Change-Id: I3a124fee1dc82932301a8bcf16b6a0b5628ee61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003356 Auto-Submit: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#732457}
-
Markus Handell authored
This change adds an additional unit test for the case encountered in crbug.com/1040339. It's verified to crash if the fix for 1040339 is reverted. Bug: 1040339 Change-Id: I940aef360589eb917b49e91f6eb84ad4014e0e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003175Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#732456}
-
Stefan Zager authored
This adds a fast path for the common case of an IntersectionObserver where the root element is a scroller, observing elements that scroll with the root's contents. In that case, we cache the state of the target's geometry prior to applying the scroll offset and clip of the root element. For subsequent intersection calculations, if the only thing that has changed is the scroll offset of the root element, we can use the cached geometry and just apply the new scroll offset, skipping a lot of heavy lifting. Running a release build of chrome on my linux workstation, this patch decreases the running time of perf_tests/intersection-observer/scroller.html by ~60%. Note that this optimization does not affect implicit-root observers, even for targets in the top document. It should be possible in a future CL to extend the cache-ing mechanism to handle that (even more common) case. Change-Id: I104672703783835bb9f85c637cefad802ba2b71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972784 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732455}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=mattreynolds@chromium.org Bug: 1041419 Change-Id: Ib1ee8d1b1861e40d422f5836045216d36822f451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997956 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732454}
-
kylechar authored
//ui/compositor doesn't need a dependency on //components/viz/service. Only test code should have the dependency at this point. Remove unused includes and dependency. Also make //components/viz/service and //components/viz/host have a public_dep on //components/viz/common. //components/viz/client already has the appropriate public_dep. Bug: 936425 Change-Id: Icbcb2a23a897be68c09d8a544a2cc29243b1ea53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000330Reviewed-by:
Sean Gilhuly <sgilhuly@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#732453}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/59e7ca81..c06633ee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7598fc79e64e1b74ed384ef9955782fe00063588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004693Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732452}
-
Vladimir Levin authored
This patch ensures that we don't enter infinite recursion when trying to text-fragment navigate in a document that has locked subtrees. R=bokan@chromium.org, chrishtr@chromium.org Bug: 1041866 Change-Id: I6c0a7be555fb8b78a8332ccbfe9fc09e48c9d7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001389Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#732451}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1041419 Change-Id: I4b2a38df9f4ec3c86b5cf57380f44a1bd271a8a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994439 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732450}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=sergeyu@chromium.org Bug: 1041419 Change-Id: I75346d1b1f7232a79fc0b335102f05bbd943ebe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998634 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732449}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d203754bc116..3ed344dd784e git log d203754bc116..3ed344dd784e --date=short --first-parent --format='%ad %ae %s' 2020-01-16 cepheus@frii.com Fix #2059, and also attempt to skip test bots [skip ci] 2020-01-16 johnkslang@users.noreply.github.com Merge pull request #2033 from ShchchowAMD/binding_contradictory 2020-01-15 johnkslang@users.noreply.github.com Merge pull request #2058 from KhronosGroup/vulkan-1.2 Created with: gclient setdep -r src/third_party/glslang/src@3ed344dd784e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: I9addc7661b6325d01f85b8bb9a06626e54e5017e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004891Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732448}
-
Jan Wilken Dörrie authored
TBR=masonfreed Bug: 1026712 Change-Id: Ic310d987a4215d7aff325ece76424bdf6499bc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002916Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#732447}
-
Jeremy Roman authored
This reverts commit 4ba80e19. Reason for revert: crashes in content::AncestorThrottle::ProcessResponseImpl are in top 5 crashes on multiple platforms Original change's description: > CSP: Enable out of blink enforcement of frame-ancestors. > > Bug: 1032139 > Change-Id: Iac59a5e6c8452da0cf7e7ebc549a10d8970cc8c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988684 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729823} TBR=nasko@chromium.org,jam@chromium.org,lfg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032139,1041133 Change-Id: Id8eb28a5f2b6fc82ae94e0abb6f6d3c965bc6937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003553Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732446}
-
Xianzhu Wang authored
When creating a paint chunk for a SVG inline flow box, use the inline flow box instead of the containing layout object as the DisplayItemClient because the layout object may create multiple paint chunks for multiple inline flow boxes. Bug: 1039070 Change-Id: I9a4b332205f22d3b57b0794b6d52ddb696835693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002898Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732445}
-
behdad authored
Skip failing tests of vulkan_pixel_skia_gold_test: Pixel_WebGLGreenTriangle_AA_NoAlpha Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear Pixel_WebGLGreenTriangle_NoAA_NoAlpha TBR=bsheedy@chromium.org Bug: chromium:1042693 Change-Id: I9dc03d61a9e28a6b035a33058acff27697f23df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003557Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732444}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pfeldman@chromium.org Bug: 1041419 Change-Id: I45a68dce550384b6788c1d666d39d7dfbd94fb08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998858 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#732443}
-
Joshua Pawlicki authored
Bug: 1035895 Change-Id: I25bd0b0202540210c698263ef702dec48d62de78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003364 Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#732442}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=pkl@chromium.org Bug: 1041419 Change-Id: Ic52468b78c9fc7623519e87af64397452228d52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997973 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732441}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0d2c75f4d56a..01c0d6bd8d7f git log 0d2c75f4d56a..01c0d6bd8d7f --date=short --first-parent --format='%ad %ae %s' 2020-01-16 m.maiya@samsung.com Vulkan: Use dynamic buffers for staged updates Created with: gclient setdep -r src/third_party/angle@01c0d6bd8d7f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jonahr@google.com Change-Id: Iefb11eb2324fddd9bda9bd8c12c4b4725ee62f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#732440}
-
Henrique Nakashima authored
Register it in ChromePreferenceKeys and use SharedPreferencesManager consistently instead of SharedPreferences directly. Bug: 1022108 Change-Id: Idd37d5d5624167e836cd49c2887e748f0d966566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001118 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#732439}
-
Stefan Zager authored
GeometryMapper is much faster than MapLocalToAncestor. Running a release build of chrome on my linux workstation, this patch decreases the average run time of perf_tests/intersection-observer/scroller.html by ~65%, and perf_tests/intersection-observer/many-objects.html by ~50%. Change-Id: Ifcc97d02297ce9a5ff205b0178cb524c0570a0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999455Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#732438}
-
Stephan Hartmann authored
Fix compilation issue in GCC with CrossThreadCopierPassThrough and VideoTrackInterface. Bug: 819294 Change-Id: Id453c3a7bc63fc75a0f882af450730ada5b717de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002512Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#732437}
-
David Tseng authored
This recently came up in the Gerrit code review UI (see enclosed test for snippet). Given a node which has ChromeVox focus, this change uses the node's name even when it is generated from contents. Previously, ChromeVox attempted to generate its own descendant name computation which omitted some details. In particular, Chrome uses the nested div's aria-label to mean an override of the static text descendant. Change-Id: I38f96a38915a23448ce1a6302de4cfd67e5089fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001739Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#732436}
-
Khushal authored
Importing a mailbox to an SkImage may fail. Null check for that before using an SkImage from AcceleratedStaticBitmapImage. R=fserb@chromium.org Bug: 1034231 Change-Id: Id281a2cbafd79c2ca56b240d7690cf60b1ea2672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001526 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#732435}
-
Eric Seckler authored
Now including updated TrackDescriptor fields. Bug: 928738 Change-Id: I3236448bc995732724ecfd576c72d9352956ab03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002523 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#732434}
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=lambroslambrou@chromium.org Bug: 1041419 Change-Id: Ifd8d08b1a26e308bf3d25dfa8cb7a4e8e5853a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998199 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#732433}
-
Marcin Radomski authored
- Add MixerUnderrun proto for reporting mixer input/output underruns to OutputStreamConnections - Add MixerInput::Source::OnOutputUnderrun virtual method, called on every mixer input whenever StreamMixer detects an output underrun - Add OutputStreamConnection::Delegate::OnMixerUnderrun virtual method, called in response to MixerUnderrun proto simulated poor network conditions Bug: b/142084721 Test: manual verification of values logged from RecordUnderruns() in Merge-With: eureka-internal/350603 Change-Id: I6ad4dcdd573a5a6b9d89baf5f15abac0a109ee92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992068Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Marcin Radomski <dextero@google.com> Cr-Commit-Position: refs/heads/master@{#732432}
-
Kyle Milka authored
This also causes the tint to be applied to the third party apps we show in the share sheet: http://screen/gvhOS1M534a.png Likely the tint need to be applied in Java or create separate xml files for 1P vs 3P share options. Bug: 1009124 Change-Id: Ie6e283c1a283efd1ec238bb8f337f77350a2518e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003191Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#732431}
-
Robbie Gibson authored
This CL adds the TextZoomMediator to handle communication between the UI and the FontSizeTabHelper that actually does the zooming. The actual zoom does not happen yet, but that will be added in the next CL. Bug: 1028938 Change-Id: I9e90814990beddd674285d5fdd7025351cc1ce51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991621 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#732430}
-
Philip Rogers authored
Painting will early-out unless a non-empty frame size is used. This patch makes the CompositingSimTest setup set a frame size. This issue sunk several hours when writing https://crrev.com/732194. Bug: 1014273 Change-Id: Id1d95daa8c96397bdccc36b0bc498a1ba8a24ac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003556 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#732429}
-
Leonard Grey authored
Bug: None Change-Id: I3a1e8849a9fe97c44f0fa537124bdca29c4d4ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001178Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#732428}
-
Peter Kotwicz authored
This CL introduces CustomTabTabObserver which observes both the tab (extends EmptyTabObserver) and observes the CustomTabActivity's current tab changing. The new class is useful because it reduces the number of observers which need to be registered/unregistered. The new class is similar to ActivityTabTabObserver. BUG=None Change-Id: I9e7a938c802a119081be46914a78825103753e2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001250 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#732427}
-
Tricia Crichton authored
Previously, an additional call to Debugger.enable was needed to take a heap snapshot. But this is no longer needed. Bug: chromedriver:3299 Change-Id: I0c5fd66390ea84370e4a408fe1d44f0a916700a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988986Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#732426}
-
Dan Beam authored
This effectively means that if you cancel the dialog, your checkbox selection changes will be dropped. This is desired and how most dialogs work. Fixed: 35098 Change-Id: I1d3086c86440528e7b6002b177c690d51030f1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003393 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#732425}
-