GitLab

Cast was originally intended to tell vp8 to only reference buffers which have been ACKed.
However, that mode was buggy and disabled. This CL fixes it again. The three-buffer mode
lets the receiver drop frames and continue, which should be quite useful if we want lower
latency.

BUG=351596

Review URL: https://codereview.chromium.org/339743002

Cr-Commit-Position: refs/heads/master@{#293243}

Code cleanup:  Remove network_prediction_enabled_ from NetPrefObserver, and
enabled_ and set_enabled() from PrerenderManager.  Earlier CLs on this issue
update the Prerender mechanism and make these members/methods obsolete.

BUG=334602

Review URL: https://codereview.chromium.org/519583005

Cr-Commit-Position: refs/heads/master@{#293242}

https://chromium.googlesource.com/chromium/blink/+log/9d34a87dee82cbdcd5876669aa1cd1a430289e09..9a051c526402aedfa6bc73e6699838c777b679cf
TBR=tkent@chromium.org,arv@chromium.org

Review URL: https://codereview.chromium.org/539713002

Cr-Commit-Position: refs/heads/master@{#293241}

the history thread.

BUG=402104
TEST=None

Review URL: https://codereview.chromium.org/531493002

Cr-Commit-Position: refs/heads/master@{#293240}

BUG=402797
TBR=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/478773002

Cr-Commit-Position: refs/heads/master@{#293239}

This CL is the combination of https://codereview.chromium.org/493143004/ and
https://codereview.chromium.org/523723002/. They were reviewed separately to
make the review process easier.

Full a more detailed explanation of the refactor, see http://crbug.com/406656

Bugs fixed:
- Attempting to fullscreen HTML5 content with --enable-simplified-fullscreen
caused UI problems.
- Omnibox/toolbar did not slide in Canonical Fullscreen.
- Presentation Mode and Canonical Fullscreen tab strip layout is incorrect when
menubar is hidden.
- Canonical Fullscreen should ignore the mouse tracking area.

Refactor mostly consisted of:
- Deleted FullscreenModeController.
- External (outside of BWC) invocations of fullscreen mode are much simpler.
- Significant code reduction and logic simplification in BWC.

BUG=406656, 405561
TBR=rsesek

Review URL: https://codereview.chromium.org/533383002

Cr-Commit-Position: refs/heads/master@{#293238}

None of these are needed anymore since trials
can be marked as "starts_active" server-side.

BUG=none

Review URL: https://codereview.chromium.org/536033002

Cr-Commit-Position: refs/heads/master@{#293237}

This CL adds a new dependency on the protocol buffer compiler
from the android source tree, since this compiler supports
generating Java files using the nano runtime.

The initial version of this dependency is 2.2.0a, but checked
out as what the Android 4.4.4 Release 2.0.1 tag points to.

This CL adds a new protoc binary (for compiling protos) that supports
this, and also adds a Java library with the runtime.

To simplify use of this, it also updates build/protoc_java.gypi to
support generating nano protos by specifying an optional
proto_runtime argument. The argument defaults to 'lite' which does
the same thing as before this change, and setting it to 'nano'
generates the new style Java files.

The plan is to quickly deprecate the 'lite' runtime for Java, since
it is too big and uses too many methods.

TBR=darin@chromium.org,cjhopman@chromium.org
BUG=377891,410067

Review URL: https://codereview.chromium.org/532303003

Cr-Commit-Position: refs/heads/master@{#293236}

With this, CTObjectsExtractorTest and MultiLogCTVerifierTest pass on OpenSSL
builds.

BUG=408687

Review URL: https://codereview.chromium.org/519473002

Cr-Commit-Position: refs/heads/master@{#293235}

This is just a couple of quick sanity checks to prevent future regressions
like the one in the linked bug. It tests both a Search+Shift shortcut and
the corresponding Prefix Key shortcut.

Adds support for sending the meta modifier key in
aura/x11 tests.

BUG=404470

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547

Review URL: https://codereview.chromium.org/490443002

Cr-Commit-Position: refs/heads/master@{#293234}

Fixed bug in recording where it would not download credentials.

BUG=

Review URL: https://codereview.chromium.org/538603002

Cr-Commit-Position: refs/heads/master@{#293233}

This CL:
- Prevents HomeCardGestureManager from calling OnGestureProgressed() with
  |from_state| == |to_state|
  - This fixes the minimized home card's opacity being incorrectly set when
    dragging down from the minimized state
- Removes unnecessary |HomeCardGestureManager::last_state_|

BUG=409666
TEST=HomeCardGestureManagerTest.*

Review URL: https://codereview.chromium.org/529813002

Cr-Commit-Position: refs/heads/master@{#293232}

BUG=110610
TBR=mmenke@chromium.org,pkasting@chromium.org,rsleevi@chromium.org

Review URL: https://codereview.chromium.org/536053003

Cr-Commit-Position: refs/heads/master@{#293231}

This behavior is required by ObserverListThreadSafe and may leads to crashes if not followed

BUG=404767

Review URL: https://codereview.chromium.org/502003003

Cr-Commit-Position: refs/heads/master@{#293230}

This is an instrumented version of the patch that will be reverted in a few days. This is meant to catch crashes in edge cases and log enough for us to repro them.

BUG=407376
TEST=this may crash for a few people

Review URL: https://codereview.chromium.org/537703003

Cr-Commit-Position: refs/heads/master@{#293229}

BUG=338338
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/524983002

Cr-Commit-Position: refs/heads/master@{#293228}

When a user's cryptohome directory is created with a pre-hashed key,
the credentials provided need to be hashed in the same way whenever the
crypthome is to be unlocked/mounted. This CL updates the Login*() methods
in CryptohomeAuthenticator to retrieve key metadata and apply the correct
hashing algorithm to the given credentials. Follow-up CLs will update
the other CryptohomeAuthenticator methods to also work with pre-hashed
keys.

BUG=367847
TEST=Extended unit tests

Review URL: https://codereview.chromium.org/517653002

Cr-Commit-Position: refs/heads/master@{#293227}

Given that the metrics reporting pref is labelled in the UI as requiring
a restart to apply, this is a much simpler way of gating Domain
Reliability uploads on it.

We simply don't create the Service (so we don't collect data and upload
it) if the pref is false.

This will need to be revisited when we also start using the Monitor for
JavaScript hooks (e.g. the Navigation Error Logging API).

BUG=407170

Review URL: https://codereview.chromium.org/525303004

Cr-Commit-Position: refs/heads/master@{#293226}

BUG=163393
NOTRY=true

Review URL: https://codereview.chromium.org/542483002

Cr-Commit-Position: refs/heads/master@{#293225}

After sending an email to the native-client-discuss list, it was determined
that this feature for redirecting stdout and stderr to JavaScript isn't very
useful. This drops support for that feature; a follow up change to the NaCl
repository will remove support there (and the SRPC message).

BUG=406558

Review URL: https://codereview.chromium.org/513273003

Cr-Commit-Position: refs/heads/master@{#293224}

Restrict the number of cases where we force the compositor to do a synchronous paint to resizing and restore/maximize operations.

Forcing the compositor to do a synchronous paint in window size changed notifications sends over
a synchronous IPC to the GPU process which blocks the UI thread. We have been seeing cases where
Chrome seems to freeze while performing operations like typing in the omnibox, etc.

BUG=397633
R=sky,cpu

Review URL: https://codereview.chromium.org/528173002

Cr-Commit-Position: refs/heads/master@{#293223}

Currently there is not enough unit test cases available to cover
the functionality of Paste Popup menu behavior. This patch covers
essential unit test cases for the same.

BUG=

Review URL: https://codereview.chromium.org/534343002

Cr-Commit-Position: refs/heads/master@{#293222}

BUG=409938

Review URL: https://codereview.chromium.org/538543004

Cr-Commit-Position: refs/heads/master@{#293221}

- Initialize URL standard schemes on load.
- Use NULL-resistant string conversions.

BUG=410374

Review URL: https://codereview.chromium.org/536023003

Cr-Commit-Position: refs/heads/master@{#293220}

Test plan:

First: download chrome-mac.zip from https://download-chromium.appspot.com/?platform=Mac

Then:

$ unzip chrome-mac.zip
$ cd chrome-mac
$ find . -name "*.pak" | grep chrome
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_200_percent.pak
./Chromium.app/Contents/Versions/39.0.2136.0/Chromium Framework.framework/Resources/chrome_100_percent.pak

$ find . | grep content
0 # no results

Check with python:

$ cd ~/chromium/src/tools/grit
$ python
>>> from grit.format import data_pack
>>> pack = data_pack.ReadDataPack('
~/Download/chrome-mac/Chromium.app/Contents/Versions/39.0.2136.0/Chromium
Framework.framework/Resources/chrome_100_percent.pak')
>>> pack.resources[4700]
>>>'\x89PNG\r\n\x1a\n\x00\x00\x00\rIHDR\x00\x00\x00\x0e\x00\x00\x00\x10\x08\x06\x00\x00\x00&\x94N:\x00\x00\x01\x87IDAT(S\x8d\x90I/CQ\x18\x86\xbf\xb5_\x84\xa5\x84\x9f6XX\xb3\xb0\xb7"$j\xe8\xc05T\xe7\x95H\x8cM\xec\xc4XA\xd5\x90\xe2VU\x1a\xa5\x86xb8\xb4h\xaf\xd7\xf9\x0e\xb7Q\xb9\xa2o\xf2,\xce9\xcf\xb39\x14\x08\x04P\nDTF?\xe7\xf7\x07\xa0e?\xf0\x981\xe7)\xa3CQ\x14\xb0W\x14\xfb|~\x9c\xdf\xe98N\xe7LI\xde\xbc\xcb\x90\xc7n!\xf6z\xbd8\xb9\xd6\x119}\x93\x183\xcej\xea\xb5\x10\xf2\xd8\x97\xb1\xdb\xedA\xfcJ\xc7v\xe2\x15\xbf\xc7wG"\xb4\xd9lEpC.\x97[\x86f\xdb\x8ag\x11\x89k\xb8\xb8\xcb\xe1^\xcbK\xf8?\xb8!\xa7s\x0c\xf1K\x1d\x1b\xc7/\xa6\x84O2\xd8Ofqp\xf6E\xeaV\x0774:\xeaD,\x9dGH}.\tv\xb9\xa1\xe1\xe1\x11\xa8\xe2\xb0v\xa8\x95\x04\xbb\xa2!R\x94!\xa8\x17y\xacD\xb5\x02\xcb\xd1G\xccD\xa2\x08\xee\xc4\x8a\xee\x19\xe1rC48\xa8\xe0H\x84\x8b{\x0f\x12Oh\x1e\xb5\xe3\xe5\xa8\x9b\xac\x904\xcf5b6\xac\x1a\xef$\\n\x88\x1c\x8e\x01\x1c\x9e\xe7\xb1\xb0\xfb\x00\xdb\x92W\xc8\x95\x85\xc8\xa0~\xb2\n\x13\x9b\x11\x12\x0e\tW6d\xb7;d\xe8Z\r\x9aF\xdfP\xc3T5\xcd\x85\x13\x1c\x82\x1b\xb2Z\xedXO\xa4\xd18]\xf3gd\xd0\x12lB4\xf5\x0en\xa8\xbf\xdf\x8a\xb6\x85\xd6\x7f#\xe3\xaew\xad\x07\xbd\xd6>Pgg\x17\xda\xdb;\xcc\xa0\x1f\x14\xbdu[,\xf8\x04*e\x8e;5\xb6\x8b\x00\x00\x00\x00IEND\xaeB`\x82'

NOTE: 4700 is the ID of IDR_BROKENIMAGE defined in
out/Debug/gen/content/app/resources/grit/content_resources.h, which
shows content_resources_100_percent.pak gets included within
chrome_100_percent.pak

BUG=176960
TEST=see test plan above
R=tony@chromium.org

Review URL: https://codereview.chromium.org/521473002

Cr-Commit-Position: refs/heads/master@{#293219}

When a pop-up is opened the window size is 367 and content size is 451
and scrollbar of thumblength 202 is created. Pop-Window height has been
resized to 451 because of JS . Before resizing of Pop-Window scrollbar
thumb_length of 202 is been applied. After resizing Pop-Window vertical
scrollbar is disabled during UpdateScrollbarGeometry(has_thumb_ = false).

Now When PaintedScrollbarLayer::UpdateThumbAndTrackGeometry is called
after pop-up window resize, as has_thumb_ = false , UpdateProperty on
thumb_length_ is not applied, due to which we are seeing the unwanted
scrollbar

BUG=400136

Review URL: https://codereview.chromium.org/524373003

Cr-Commit-Position: refs/heads/master@{#293218}

Review URL: https://codereview.chromium.org/539633002

Cr-Commit-Position: refs/heads/master@{#293217}

Apart from the places which expect a SyncLoadResult, it's only read in
RedirectToFileResourceHandler. In that case, it's always net::OK;
ResourceLoader checks request_->status().is_success() first in
OnResponseStarted before calling CompleteResponseStarted().

BUG=none

Review URL: https://codereview.chromium.org/517853004

Cr-Commit-Position: refs/heads/master@{#293216}

Two main cases:
1. <label> not wrapping input + span
2. for accessibility -- for=<selector-id> should instead use aria-labelledby

BUG=409938

Review URL: https://codereview.chromium.org/536703002

Cr-Commit-Position: refs/heads/master@{#293215}

This matches the logic in nss_ssl_util.cc.

Note: this CL has a test which only affects Windows XP. We
have no try coverage on XP, so if the XP bots break, please
revert.

BUG=405630

Review URL: https://codereview.chromium.org/495663002

Cr-Commit-Position: refs/heads/master@{#293214}

This is a re-work of palmer's patch at https://codereview.chromium.org/515023002/ which has more context, but comes down to stricter bounds checking.

We also correct an arithmetic bug when copying the image behind a control that is positioned before the origin of the image.

BUG=398384

Review URL: https://codereview.chromium.org/519873002

Cr-Commit-Position: refs/heads/master@{#293213}

R=dmazzoni@chromium.org
BUG=408405
TEST=keyboard navigate to bookmark star, press space: bookmark deletes and focus still exists.

Review URL: https://codereview.chromium.org/510213002

Cr-Commit-Position: refs/heads/master@{#293212}

Trying to initialize it causes content_shell --enable-browser-side-navigation
to crash on startup.

It corresponds to ResourceRequestInfo::GetVisibilityState, but that's only used
for categorizing requests made from prerender which needs a different bit
(WebPageVisiblityStatePrerender vs. others), so we'll need to revisit it
anyway.

BUG=376014

Review URL: https://codereview.chromium.org/534393002

Cr-Commit-Position: refs/heads/master@{#293211}

BUG=

Review URL: https://codereview.chromium.org/537573004

Cr-Commit-Position: refs/heads/master@{#293210}

unset GYP_DEFINES
python build/gyp_chromium
ninja -C out/Release -t commands base >gyp.txt

gn gen out/gn --args="is_debug=false is_component_build=false"
ninja -C out/gn -t commands base >gn.txt

python tools/gn/bin/gyp_flag_compare.py gyp.txt gn.txt >flags.txt

Outputs this at the moment: https://gist.github.com/sgraham/93e159eba1601a9e3668

(only work on Linux because of lack of handling @rsp files)

NOTRY=true
R=ajwong@chromium.org, brettw@chromium.org

Review URL: https://codereview.chromium.org/539603003

Cr-Commit-Position: refs/heads/master@{#293209}

Remove unused QUIC_VERSION_20.

We are already speaking QUIC_VERSION_21 in the wild, and QUIC_VERSION_20
was never intended to be used. Not much code removed in this CL, but
should make end to end tests a bit faster.

Merge internal change: 74594489
https://codereview.chromium.org/532093002/

Change GetLeastUnacked() to return the next packet that could be sent
when there are no packets in flight instead of 0.

This should help solve the problem we are seeing in trace logs from
internal servers where the ack line drops to 0.

Merge internal change: 74396185
https://codereview.chromium.org/530343002/

Change IsRetransmittable to not check transmission type but instead let
ShouldDiscardPacket check it directly.

Merge internal change: 74359363
https://codereview.chromium.org/536743002/

Change the QUIC CongestionMap to be based on a vector.

Saves ~0.75% CPU when profiling.

Merge internal change: 74321352
https://codereview.chromium.org/528083004/

Some improvements to quic_client_bin.
  - user can supply specific version
  - added a number of comments
  - added a number of descriptive ERROR logs on failure
  - removed unneeded flow control options (SetDefaults covers this)

Merge internal change: 74309904
https://codereview.chromium.org/532073002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/530343003

Cr-Commit-Position: refs/heads/master@{#293208}

This callback has the reentrance issue as calling MediaPlayerBridge::Release() will call into function.
The worst case happens when BrowserMediaPlayerManager dtor is called. In that case, this function will be called on each player, while BMPM is in a partially destroyed state.
Since BMPM controls the lifetime of the players, it can call OnMediaResourcesReleased() when it calls Release() on a player.
For MSE case, we also simplified the situation here since we can check MSP::IsSurfaceInUse(). This CL also fixes that call.

BUG=410096

Review URL: https://codereview.chromium.org/534063002

Cr-Commit-Position: refs/heads/master@{#293207}

These were failing on Android Builder (dbg) FYI bot.

BUG=409152
TBR=qinmin@chromium.org

Review URL: https://codereview.chromium.org/522943003

Cr-Commit-Position: refs/heads/master@{#293206}

Adds a DebugInfo message to the DistilledPageProto. The data for this message
is copied from the DomDistillerResult proto DebugInfo.

For now, only a field for the distiller log exists.

Depends on https://codereview.chromium.org/493853006/

BUG=409274

Review URL: https://codereview.chromium.org/504263002

Cr-Commit-Position: refs/heads/master@{#293205}

The CL https://codereview.chromium.org/415343002/ accidentally
introduced new files in //chrome/chrome_browser.gypi without
adding a newline.

This CL just cleans up the style of the .gypi.

BUG=383630

Review URL: https://codereview.chromium.org/533173003

Cr-Commit-Position: refs/heads/master@{#293204}