- 30 Jun, 2018 40 commits
-
-
Ryan Hamilton authored
Merge internal change: 202544067 Change-Id: Ibf16eef2c6f61fe1e34920494a03a7ae5c93e433 Reviewed-on: https://chromium-review.googlesource.com/1119259Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#571752}
-
Chris Harrelson authored
TBR=trchen@chromium.org Bug: 855542 Change-Id: I4c06b96829b2e7f18924be69b562ac8ccf5bf3bc Reviewed-on: https://chromium-review.googlesource.com/1121376 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571751}
-
Gyuyoung Kim authored
StagingBufferPool has been only supporting the MemoryCoordinator. However, it is not enabled by default. So it would be good if we support the memory pressure handler until the MemoryCoordinator is enabled by default. Especially, it will help low-end devices to reduce memory usage under the out-of-memory situation. Bug: 856527 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I52be2b732199c66ddaac015fb29aae274ff2fb1d Reviewed-on: https://chromium-review.googlesource.com/1114559 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571750}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1bf75a651fe5..de3a6f421ec7 git log 1bf75a651fe5..de3a6f421ec7 --date=short --no-merges --format='%ad %ae %s' 2018-06-30 vapier@chromium.org deploy_chrome: drop setuid bit on chrome sandbox 2018-06-29 dgarrett@google.com chromeos_config: Move release builders to swarming. Created with: gclient setdep -r src/third_party/chromite@de3a6f421ec7 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:312380,chromium:576409,chromium:853969 TBR=chrome-os-gardeners@chromium.org Change-Id: I545b6ab9a3cf2a6b1bb90c714f8e160275521340 Reviewed-on: https://chromium-review.googlesource.com/1121596Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571749}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I64d43f73ef31320163291c309ad756f93af8e473 Reviewed-on: https://chromium-review.googlesource.com/1121522Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#571748}
-
Nico Weber authored
Run cast_unittests, cc_unittests, chromedriver_unittests, components_browsertests, snapshot_unittests on the cros bots. Also run printing_unittests on the cros dbg bot (it's already running on the rel bot). These tests already run and pass on the cros memory bots, so it's not clear why they shouldn't run on the regular cros bots. Bug: 843511 Change-Id: Ia845a7477fcab01bbb8df257585cbde4463a9e8c Reviewed-on: https://chromium-review.googlesource.com/1120232Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571747}
-
Nico Weber authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1120225, the test doesn't pass on the 32-bit linux dbg bot. TBR=kbr Bug: 859264,843511 Change-Id: I99ddef5bc637444ccb0023df528123f14bee0fed Reviewed-on: https://chromium-review.googlesource.com/1121521Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#571746}
-
Eric Karl authored
Now that we use this class from the Viz/Gpu process, we need the @MainDex annotation. Bug: 858835 Change-Id: Ia444f26f25d2d0532bfb15b0ef552dc2995d4a2b Reviewed-on: https://chromium-review.googlesource.com/1119332Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#571745}
-
Nico Weber authored
Found by a marginally improved version of https://chromium-review.googlesource.com/c/chromium/src/+/1097616 , see patch set 4 there. Bug: 843511 Change-Id: I591567c66f6afa63853e23112fcf432fa61006a0 Reviewed-on: https://chromium-review.googlesource.com/1120752Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6ef24d7824d2..a72f400c5ff3 git log 6ef24d7824d2..a72f400c5ff3 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 jmadill@chromium.org run_code_generation: Compare hashes instead of mtime. 2018-06-29 oysteine@google.com Removed an assert about addTraceEvent not returning empty handles. 2018-06-29 jmadill@chromium.org Vulkan: Add Features class. Created with: gclient setdep -r src/third_party/angle@a72f400c5ff3 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:844421 TBR=ynovikov@chromium.org Change-Id: I652601668a8cba23e34ecd78158fb1b70628e6c6 Reviewed-on: https://chromium-review.googlesource.com/1121260Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571743}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0894dc84013c..09646f2d0497 git log 0894dc84013c..09646f2d0497 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 tsepez@chromium.org Use UnownedPtr<CXFA_Node> or comment raw pointers as tree nodes. Created with: gclient setdep -r src/third_party/pdfium@09646f2d0497 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4afa3e3d0411134d55fe4a40b5e18295df3f6445 Reviewed-on: https://chromium-review.googlesource.com/1121498Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571742}
-
Aleks Totic authored
Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I99071670521a938d87a90bb2d1a7e481f7e74bdb Reviewed-on: https://chromium-review.googlesource.com/1121578Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#571741}
-
Bill Orr authored
This reverts commit f0ce7bce. Reason for revert: Found the issue with tests, will rebase with fix. Original change's description: > Revert "Create mojo interfaces to replace VRDevice, XrSessionController" > > This reverts commit f793e166. > > Reason for revert: Some tests are broken - I'll revert to investigate then reland. > > Original change's description: > > Create mojo interfaces to replace VRDevice, XrSessionController > > > > Devices are converted over to XrRuntime. > > > > Bug: 795510 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: Ibd50a6eb6b5e971ceba260dc46852157222b3228 > > Reviewed-on: https://chromium-review.googlesource.com/1093386 > > Commit-Queue: Bill Orr <billorr@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#571595} > > TBR=dcheng@chromium.org,mthiesse@chromium.org,billorr@chromium.org,offenwanger@chromium.org > > Change-Id: I496be5fe20f9dc67999aa0cac86c41f79206e841 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 795510 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/1121497 > Commit-Queue: Bill Orr <billorr@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571710} TBR=dcheng@chromium.org,mthiesse@chromium.org,billorr@chromium.org,offenwanger@chromium.org Change-Id: Ibe4d12804afc6482dc53623436ed1126d1885fc5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 795510 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1121636Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571740}
-
Peter Kasting authored
I'm not opposed to leaving this under Finch control for future experimentation, but I don't really know how to use FEATURE_WITH_PARAMS_VALUE. Bug: 857610, 857282, 855729 Change-Id: Ibe1b9c13003f2da78b241e775f37b2e9ab7e71f7 Reviewed-on: https://chromium-review.googlesource.com/1119362 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#571739}
-
Mrunal Kapade authored
ScriptPromiseProperties.h -> script_promise_properties.h BUG= Change-Id: I0df4d9d80662c67dc895be36b80db1fa698dc896 Reviewed-on: https://chromium-review.googlesource.com/1121242Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#571738}
-
Klaus Weidner authored
The "Don't submit exclusive WebXR frames without valid frame ID" patch from https://crrev.com/1117770 was incomplete, it results in closing Mojo connections due to a sanity check that treats the received frame_id==-1 as invalid. Just ignore these on the Renderer side instead of attempting to submit as missing frames. BUG=855722,858838 Change-Id: I5a5c70979be2bb9a2c9429b6efa78fdd6029d4db Reviewed-on: https://chromium-review.googlesource.com/1121344Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#571737}
-
Victor Costan authored
This CL changes the signatures of cookieStore.{get,getAll,set,delete} and introduces the CookieStoreDeleteOptions and CookieStoreSetExtraOptions dictionary. The CL also updates the CookieListItem dictionary. TBR=haraken Bug: 729800 Change-Id: Iaa62b5a51cc79b19cb567be30a2f0dda54e326d8 Reviewed-on: https://chromium-review.googlesource.com/1117868 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571736}
-
Ned Nguyen authored
NOTRY=true # test by CQ TBR=eyaich@chromium.org Bug: 855063,859251 Change-Id: I2df70bc2b258debe1fa723fb8cda4f189db1745d Reviewed-on: https://chromium-review.googlesource.com/1121520Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#571735}
-
Scott Chen authored
Bug: 857424 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I205f279363b21324cc89d7c0ab44bd042beab588 Reviewed-on: https://chromium-review.googlesource.com/1121107Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#571734}
-
Orin Jaworski authored
When the steady omnibox is hovered, the location bar smoothly animates to a slightly different shade of gray instead of switching instantly. Bug: 853241 Change-Id: I5c51607a602f7e7245dddd46060d6dc25f4f4581 Reviewed-on: https://chromium-review.googlesource.com/1119494 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#571733}
-
James Cook authored
When an accessibility extension requests an action the request comes into the browser process AutomationManagerAura. We send the action data over mojo to the remote app and dispatch it there using the existing views toolkit accessibility code. TBR=slan@chromium.org Bug: 851578 Test: added unit tests Change-Id: I37fde88af43de4cee45ca563d4b279a3ddeb02d6 Reviewed-on: https://chromium-review.googlesource.com/1118828Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#571732}
-
Xiaohan Wang authored
Also roll DEPS to pick up new CDM interface changes. Bug: 856925 Change-Id: I2f7a2e40375a7c007891ba6b82078771e3fae31b Reviewed-on: https://chromium-review.googlesource.com/1119386 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#571731}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cf5de1da0720..20b4b0dcf066 git log cf5de1da0720..20b4b0dcf066 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 buildbot@webrtc.org Roll chromium_revision a714568f..810d8218 (571512:571617) Created with: gclient setdep -r src/third_party/webrtc@20b4b0dcf066 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie1afc0610230346ce43cf97df59bb1dd9831383d Reviewed-on: https://chromium-review.googlesource.com/1121258Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571730}
-
Ned Nguyen authored
NOTRY=true # this does not have unittest TBR=eyaich@chromium.org Bug: 859251 Change-Id: Ic3da603cb16b5d41ecc2368ff7492735ec26e147 Reviewed-on: https://chromium-review.googlesource.com/1121519Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9fc102362c3c..b7b9d02ac020 git log 9fc102362c3c..b7b9d02ac020 --date=short --no-merges --format='%ad %ae %s' 2018-06-29 stani@google.com Add a runtime flag to enable ATRACE 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 cdf50444934c..6ef24d7824d2 (2 commits) 2018-06-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-29 csmartdalton@google.com Don't use geometry shaders on older Adreno chips Created with: gclient setdep -r src/third_party/skia@b7b9d02ac020 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I27ff0fdc5c1281f0241ebd5ebfe38fcd67d14f1b Reviewed-on: https://chromium-review.googlesource.com/1121261Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571728}
-
dpapad authored
Also removing an exclusion for cr-events which does not seem to exist anymore. Bug: None Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iab248dff3b1426567cba0a33e6d2fc0ed4c2dd6f Reviewed-on: https://chromium-review.googlesource.com/1119638 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#571727}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d4c2a8799861..024a3317597b git log d4c2a8799861..024a3317597b --date=short --no-merges --format='%ad %ae %s' 2018-06-29 tandrii@chromium.org my_activity: deduplicate bugs from change description. Created with: gclient setdep -r src/third_party/depot_tools@024a3317597b The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I84eea0edb55a7efb42f0e6ef9347b7c9e379292f Reviewed-on: https://chromium-review.googlesource.com/1121257Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571726}
-
Bret Sepulveda authored
Bug: 848379 Change-Id: I49106f2a7ebd5c39ad7508d8385d9b0babb6aa3b Reviewed-on: https://chromium-review.googlesource.com/1121385 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Chris Harrelson authored
They can't composite anyway. Bug: 856808 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie7071658827b7bc23315db775c7d872817190fb4 Reviewed-on: https://chromium-review.googlesource.com/1119584 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#571724}
-
Mrunal Kapade authored
navigator-keyboard-map-two-parallel-requests.https.html also does same thing. BUG= Change-Id: If5acfe46aada93528f8821030996a9745bc19168 Reviewed-on: https://chromium-review.googlesource.com/1121346Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com> Cr-Commit-Position: refs/heads/master@{#571723}
-
Xiaocheng Hu authored
The layout test has several independent test cases contained in one big test() function body. This patch breaks it into smaller ones, with one test() for each test case. In this way, the test message is more useful when some of them fail. Change-Id: Ibece27a46a0c949a45b205910c7223c1e5312b4a Reviewed-on: https://chromium-review.googlesource.com/1121348Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#571722}
-
Balazs Engedy authored
Implement advancing from transport selection to the step where the user is asked to insert a USB security key. Bug: 849323 Change-Id: Idd7ee863d8c5a826e156e8b9fea1bfdd1ee2347c Reviewed-on: https://chromium-review.googlesource.com/1104687 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#571721}
-
Bruce Dawson authored
While testing with link.exe on Windows I hit a warning about duplicate definitions of ui::GenerateDomKeyboardLayoutMap. This is because this function is defined in three source files - *_win.cc, *_mac.mm, and *_ozone.cc, and the *_ozone.cc file is always compiled. This means that it is undefined which version the linker will select when building for Windows and Mac. This ODR violation appeared in crrev.com/c/1093891 Bug: 857277 Change-Id: I05e9a3216a5e9c2c0925bd83267b03e6cb9aa2f6 Reviewed-on: https://chromium-review.googlesource.com/1117865Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#571720}
-
John Rummell authored
std::vector<SubsampleEntry> is provided so that the accelerator can determine what part of the slice is encrypted. BUG=837455 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I484d23f16697d3e730328afebfec08d5fa6bf6c4 Reviewed-on: https://chromium-review.googlesource.com/1101902 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#571719}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/81fcde731fe4..0894dc84013c git log 81fcde731fe4..0894dc84013c --date=short --no-merges --format='%ad %ae %s' 2018-06-29 tsepez@chromium.org Use UnownedPtr to CXFA_Node from outside the tree Created with: gclient setdep -r src/third_party/pdfium@0894dc84013c The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If26a161c999a68c8daeaf2b9bb5b248a8aa001e8 Reviewed-on: https://chromium-review.googlesource.com/1121259Reviewed-by:
-
Daniel Rubery authored
Missing these caused the crash. Bug: 849351 Change-Id: I38a156a708c544bf02fe50d5d67a3aec8e4ed4ac Reviewed-on: https://chromium-review.googlesource.com/1121253Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#571717}
-
Ted Choc authored
This CL: https://chromium-review.googlesource.com/1114002 Introduced the behavior to take the span action when clicking the infobar textview. The gotcha is that onClick is called regardless of whether you clicked on a link and it executed the onClick of it already. This resulted in the action being double executed if you actually clicked on the span. Thus, onClick is not a good option, which leaves onTouchEvent as the best next option. The annoying bit is that super.onTouchEvent always returns true, so we can't use that as a signal to perform the click action. I believe the source of this is that setting a link movement causes the text view to be clickable and onlongclickable, which results in View#onTouchEvent to always return true. I didn't want to attempt to disable those two as I'm sure that would have further ramifications. The base class thankfully had the utility to detect whether the user was tapping on a span, so I just expose that and use it in onTouchEvent. BUG=856915 Change-Id: I602bd426477501875f0fcf21eac0ad5bc3f09658 Reviewed-on: https://chromium-review.googlesource.com/1119028 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#571716}
-
Shakti Sahu authored
Change-Id: I960bd9e85f6e8db1c6a5c11814edf87f77f87c1a Reviewed-on: https://chromium-review.googlesource.com/1121208Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#571715}
-
Stefan Zager authored
And there was much rejoicing throughout the land. BUG=823365 R=skobes@chromium.org,pdr@chromium.org Change-Id: Iadef3f9dc5785e1218555a771667474a0fa3ba60 Reviewed-on: https://chromium-review.googlesource.com/1119772 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#571714}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d1692d4ac997..34f0d7e2e45f git log d1692d4ac997..34f0d7e2e45f --date=short --no-merges --format='%ad %ae %s' 2018-06-29 benjhayden@chromium.org /api/test_suites lists test suites for V2SPA. Created with: gclient setdep -r src/third_party/catapult@34f0d7e2e45f The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id157b639d713681051f48bfc9bf27e5a31ae32d2 Reviewed-on: https://chromium-review.googlesource.com/1121219Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#571713}
-
