- 30 Aug, 2019 40 commits
-
-
Bret Sepulveda authored
To avoid trying to automatically come up with a good default title, or forcing the user to name a group as soon as it's created, this patch makes groups have an empty title by default. To support a group having an empty title, this patch also does the following: * Use a differently-sized, circular header chip when there is no title. * Changes header chips with a title to be rounded, to match the empty header chips. * Initializes the group editor bubble with the current title, and allow the user to input an empty title (rather than using the old title). * Generates a descriptive name for groups in the tab context menu, which is: '"[Title of first tab in group]" and X other tab[s]'. Bug: 905491 Change-Id: I0f331a1938572b7283e0c2685126c30dc83c10dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769553Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#692240}
-
Amin Hassani authored
A few of the error code enum values were missing. This CL adds those. Also renamed the newly introduced download error code names to camel case like the rest of them. Bug: None Test: None Change-Id: I4ec732798812d56d2c4b91f258b28221dcbcdd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774101 Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#692239}
-
chrome://flags/#omnibox-on-focus-suggestionsMoe Ahmadi authored
- Adds a flag to chrome://flags to control omnibox::kOnFocusSuggestions. - Adds a variation to the flag entry that allows enabling zero-prefix suggestions in the NTP Realbox. Bug: 996516 Change-Id: Ia501cf6951a591130e9845c57e90f889b7b33c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775581 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#692238}
-
Antonio Rivera authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1771053 I missed one recently-added case. Test: cast_media_unittests passes Bug: b/139928913 Change-Id: Ifcaa595d16bd66b5cf745220ac6c96f87ea04907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779174 Auto-Submit: Antonio Rivera <antoniori@google.com> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692237}
-
Andrew Luo authored
The fact that the WebView Nougat bot stayed green meant that the test filter was not needed, so have deleted it. Also added a presubmit check. Change-Id: I0b18239cb102203120a77f19029fc6ae66f579c2 Bug: 997759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778982Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692236}
-
Robert Ogden authored
Bug: 996870 Change-Id: If3c919a6898bc31270f8bdff924b54bfd664bf8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779307Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#692235}
-
Joshua Peraza authored
726ab2a65539 Integrate Crashpad with Chrome OS db6f51d3fca8 fuchsia: Check results of Initialize() subcalls in ProcessReaderFuchsia 50aa576622fd Disable implicit fallthrough warning for zlib 1c7023875b74 [build] //zircon/public/fidl --> //zircon/system/fidl 7b5a55c3b188 Move whitelist ownership to ProcessSnapshotSanitized 10a1d2d87743 [fuchsia] Use the appropriate separator for FIDL library names b71f61f8e31f fuchsia: Defer initialization of memory map 23a1be41ce3a linux: refactor snapshotting into CaptureSnapshot() 80473094a4d2 linux, compat: add a memfd_create wrapper cd92fba233d3 linux: Move Cros crash handling to CrosCrashReportExceptionHandler Change-Id: I035a3ad1e3eed573a9c8871c096181baf4178ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779013Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#692234}
-
Kevin Plybon authored
Change-Id: Ia11ad3ef0217373937fbb0438fb519041c637a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779073 Auto-Submit: Kevin Plybon <kplybon@google.com> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692233}
-
Lan Wei authored
We are proposing to use SendCommandAndIgnoreResponse to dispatch event to avoid waiting for the reply of sending events, so that we can dispatch more than one events in one tick. In order to control the time to send events we need to use tick duration for every tick, it can come from pause action or pointermove action. We have add a default tick duration right now that we will dispatch events in one tick per frame, but changing the tick duration in the Action API will control how many ticks in one frame, so that we can control how often we want to dispatch events. Bug: 606367 Change-Id: Ib4745d37181de0724fe5e84fa32d893840ace910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752338 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#692232}
-
Evan Stade authored
Previously, this code used NOTIFICATION_SESSION_STARTED for initial login, and then UserManager::SessionStateObserver::ActiveUserChanged for swapping between users. It should be possible just to always rely on ActiveUserChanged. If the profile isn't loaded yet (as with initial login), add a profile created observer. This should mean SetProfile gets called slightly earlier as SESSION_STARTED comes rather late. This seems like an improvement because SetProfile will not be delayed until after the post-login steps (e.g. when the profile picture is being chosen). ChromeUserManager is changed slightly, listening to NOTIFICATION_PROFILE_ADDED rather than NOTIFICATION_PROFILE_CREATED. For async profile creation, NOTIFICATION_PROFILE_ADDED comes after NOTIFICATION_PROFILE_CREATED, but for synchronous profile creation (e.g. the startup profile), it's inverted; in both cases the two notifications are sent synchronously, i.e. as part of the same task. To make sure the profile is both initialized and registered with ProfileManager by the time ProfileCreatedObservers get notified, ChromeUserManager should make use of NOTIFICATION_PROFILE_ADDED. Bug: 268984 Change-Id: I53c1793f2a14642fb1e4cd32066e2a57eeebd1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769227 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#692231}
-
Angel Alvarez authored
Modifies Offline Page model to use on-the-fly hash computation and provides the public directory directly to the archiver if the feature is enabled. Does not change ArchivePublisher since when provided the public directory, the publish operation is just a rename to a human readable name. Modifies Offline Page Archiver to not compute the digest if one is provided. Bug: 915966 Change-Id: I9b1fc34cd01d09262086ca3754f34fe5e4a3ff9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772395Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Angel Alvarez <angelii@google.com> Cr-Commit-Position: refs/heads/master@{#692230}
-
Michael Thiessen authored
After updating the enum in https://chromium-review.googlesource.com/c/chromium/src/+/1426920 the UMA histogram wasn't updating and I couldn't figure out why. I just realized that I updated enums.xml, but missed updating histograms.xml [[andthatsreallythemostimportantpart.jpg]] Change-Id: Ia163b455c2b6310adbeab93f53dd0b4c6135211c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776378 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#692229}
-
Yue Li authored
The stylus Assistant mode feature is restricted to Google devices. Add a util method to check the board type while adding the metalayer tool. Bug: 996312 Test: Run existing tests Change-Id: Iaa75fe8901d6be382c2525dfa64bb193f84ccaeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779187 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Fred Mello authored
Related to: https://chromium-review.googlesource.com/c/chromium/src/+/1769516 Bug: 996821 Change-Id: I959c1ae55c1f6dac2d2fc7796ce7ee95b34cdcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772437Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#692227}
-
John Delaney authored
This change adds a threshold for peak windowed cpu usage to the heavy ad thresholds. Relevant histograms are versioned. Bug: 989141 Change-Id: I71d1064cb809ca3adafb1dd576e7d2a6363036cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769514 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692226}
-
Lorne Mitchell authored
All settings specified via the module.json were not calling ls(). They were being picked up by our localization system and existed in GRDP files. This fix simply calls ls() on the setting's title descriptor. Screenshot of settings: https://imgur.com/YuJ647w Bug: 941561 Change-Id: I051fae1f7398cb5b2efc7d277abc391b41bfa603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775438 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#692225}
-
Jenny Zhang authored
Bug: 995962 Change-Id: I7944ae293fb146e3d9314a8b029fcab6ba2809de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778595Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/952ccb9..53f6b23 53f6b23 Fix leakage in adoptCalendar Bug: chromium:997401 Change-Id: I3e152496ac9e4ee6bf2c95e90d23e489d672ff68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777048 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692223}
-
Ryan Hamilton authored
Bug: 984738 Change-Id: I5432006796a0959a0d32bd062cf4c37180acc3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778593 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692222}
-
Min Qin authored
Currently the text uses "incognito", it should be "guest". BUG=998139 Change-Id: I4b1f83394dfc1e4b4f72b9d6f274bdbe8f99f89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772503Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692221}
-
kylechar authored
By default LayerTreeSettings::enable_surface_synchronization was false. Most cc_unittests were running with the default. This CL switches the default to true and fixes most tests. The primary change for tests is with regards to LocalSurfaceId allocation. With surface sync off LocalSurfaceIds would be allocated automatically. With surface sync on the test has to ensure new LocalSurfaceIds are allocated at the correct time. Bug: 985009 Change-Id: I9bd62da2b96f9eddb4ea85656c61364c0ee5ada8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774309 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#692220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d70702fad6d1..408dc11ec29e Created with: gclient setdep -r src-internal@408dc11ec29e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7fcbd88f680c5ca88c1cdac1b5150c843bb83263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778632Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a1c4425..fe2e9f99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22bc0c90524002cc05ddb4ce9ac3744496ba7fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779262Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692218}
-
Etienne Pierre-doray authored
To avoid having 2 tasks with same queue_time, each PushTask is preceded by a FastForward(). Bug: 998477 Change-Id: Ibecca4edf6d4c53420c0584676356284681d4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778925 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692217}
-
Sebastien Marchand authored
Using an EmbeddedTestServer bound to a specific port is flaky because it's not guaranteed that this port will be available when running the test, switching to a URLLoaderInterceptor fix this. Bug: 998071 Change-Id: Ieae65bb2e9a12f5e5cf3aaaa772667a1d0e2aef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779201Reviewed-by:
-
Andrew Grieve authored
Change-Id: I4e275a5cc27460a2d6b66c10f486c8f5d0636626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778589 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#692215}
-
Toni Barzic authored
Updates how apps grid horizontal margins are calculated with kScalableAppList feature enabled. Adds some tests that verify the apps grid layout in fullscreen state. Bug: 999273 Change-Id: I63f36f6b946afc7b55b66568a8113bf19ce381b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776715 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692214}
-
Sigurdur Asgeirsson authored
As-is, a late UserMessageReadAckEvent will call Delegate::PortStatusChanged with an invalid PortRef. Change-Id: I9f089df40692fc2c39c2de035b6890a1d2995e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779183 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#692213}
-
Kyle Horimoto authored
Before this CL, clicking on a non-connectable Cellular network in the mobile subpage would result in no action except for some UI jank. This was due to the fact that the network cannot be configured and thus it is not possible to attempt a connection. This CL fixes this situation by navigating to the network's detail page in this situation. Bug: 947351 Change-Id: If390de1f8fd5476fbae193a9597f64dc31fa9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777067 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692212}
-
Alex Chau authored
- Added transparent SharedClipboardShareActivity that mimic a BottomSheet to show device list. BottomSheet cannot be used if calling acitivty is not part of Chrome. - Re-used layout of self-share device picker for UI consistency - Implemented sending and error notification in Android Bug: 996318, 996322 Change-Id: I08708e17af3422ebdb19c71f7db387cff6c8ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776053 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692211}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d7245686774..4ece96d76d9d git log 8d7245686774..4ece96d76d9d --date=short --no-merges --format='%ad %ae %s' 2019-08-30 csmartdalton@google.com Reland "Initiate MSAA resolves during DAG generation" 2019-08-30 ethannicholas@google.com .fp files now support user-defined functions 2019-08-30 ethannicholas@google.com removed dead code from SkSLPipelineStateCodeGenerator Created with: gclient setdep -r src/third_party/skia@4ece96d76d9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ia3275e8722a7eb71b6e8dafd2630aafa2bae4f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692210}
-
Maksim Ivanov authored
Display a big lock icon in the top-left corner of the security token PIN dialog, which is shown during the SAML user sign-in on Chrome OS when a security token (e.g., a smart card) is used. The icon corresponds to the UI mocks prepared for this dialog. Bug: 964069 Change-Id: I39afcb9d5e5776f7c1ec02ca2a0b56015f8aca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751184 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#692209}
-
Mounir Lamouri authored
As part of the load algorithm, the video gets paused but the pause event is not fired (per spec). As a result, the video wake lock would stay around on the paused video. Emptied is fired in this case and can be used as a proxy. Bug: 980024 Change-Id: I0c6f2e14a8f3732250d339e01fe1e598bea614d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779186Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#692208}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f5980f492582..f06000e894cd git log f5980f492582..f06000e894cd --date=short --no-merges --format='%ad %ae %s' 2019-08-30 avi@chromium.org Support macOS 10.15 Catalina. 2019-08-30 bsheedy@chromium.org Revert "Reland "Reland "Support minidump symbolization on ChromeOS""" Created with: gclient setdep -r src/third_party/catapult@f06000e894cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:998877,chromium:998871,chromium:978952 Change-Id: I1b81f463284b403155eb32d290ee7b9e98e6400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778648Reviewed-by:
-
Stefan Zager authored
For an observer with multiple observations, this avoids doing redundant work to compute the local bounds of the root and its transform to absolute coordinates. BUG=956071 Change-Id: I587997da1f5f120a1fd276f703aa1e5a1131696b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774246 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692206}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0033328dd22..6d684b4c7991 git log f0033328dd22..6d684b4c7991 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 680d3761 Created with: gclient setdep -r src/third_party/swiftshader@6d684b4c7991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie198b23e1f2803e66f10cb1615c71e204b961517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778630Reviewed-by:
-
Tommy Nyquist authored
The feature_engagement component needs to be configured according to whatever experiment is being tested. The documentation for how to do this was written a while ago, and has since then become outdated. This CL updates the documentation to how things are supposed to be configured now, since there's been a couple of instances recently as to why the feature engagement does not work as expected. Bug: None Change-Id: Ibdfcb1d118dde660be8de7b59d944a641f1792f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749005 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692204}
-
Jeevan Shikaram authored
This CL adds an uninstall button that allows a user to uninstall apps from App Management. Bug: 999431, 979531 Change-Id: Ib2e88f5e7bb7f0fac09067a38bfd139a7adf168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777465Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692203}
-
Stefan Zager authored
Most of the ideas for improving the performance of IntersectionObserver are contingent on processing the observations for a single observer at the same time. Prior to this patch, the processing model was: document -> element -> observation with element as target -> observation with element as target -> element -> observation with element as target -> observation with element as target With this patch, the model becomes: document -> element -> implicit-root observation with element as target -> implicit-root observation with element as target -> explicit-root observer with element as root -> observation -> observation -> explicit-root observer with element as root -> observation -> observation So, explicit-root observers will process all of their observations together. This isn't possible for implicit-root observers, because the targets of an implicit-root observer may be spread across multiple documents in multiple tabs or windows. BUG=956071 Change-Id: I72e9fe1c4a9d0e0cd37e401cbb3a40774d5589b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774244Reviewed-by: -
Fabrice de Gans-Riberi authored
* Simplify CastComponent constructor to take a single structure. * Spin-off from https://crrev.com/c/1770434 Bug: 976975 Change-Id: Icb42418bfa60e1b6f34bd3f29f1f1c29d754cf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778915 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692201}
-
