- 01 Sep, 2020 40 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium bba395ff. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I33160e412b63acb8f9a48772b7ef17a2dd552444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386759Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803376}
-
James Vecore authored
Adds an empty receive dialog stub that will host high visibility, confirmation and on-boarding pages within os-settings. The dialog does not set a title, sub-title or have buttons because a shared page component will handle these so they are consistent. This also allows page in and out animations to include the titles and buttons which would not be possible if the title and buttons were re-used between pages. Trigger Url: chrome://os-settings/multidevice/nearbyshare?receive Screenshot: http://screen/3jNcwoQgcQNtq4D.png See follow-up CLs for usage. Bug: b:163148440, b:163147818 Change-Id: I81fa2550ee7bd84cef851a31cc1a1b3fdc0affd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384542Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#803375}
-
Kuo-Hsin Yang authored
This is required to move the experiment to beta. BUG=b:151690175 TEST=presubmit passed Change-Id: I3e066526bc391d18f63632b888ff08a87659dab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383407Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#803374}
-
Melissa Zhang authored
This CL adds metrics for the sharesheet. We record when a user makes an action and how many apps are showing in the sharesheet with each invocation. Bug: 1097623 Change-Id: I089524187db80aa31bff3ff2c11ac366da073f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379394 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#803373}
-
Andrew Grieve authored
And have upload_html_viewer.py check that caspian files exist Bug: None Change-Id: I9775e5c983cbb8d4a4aa4b74037eee88dffcee99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387400 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803372}
-
Gyuyoung Kim authored
As the first step to convert FrameHostMsg_SynchronizeVisualProperties to Mojo, this CL moves content::FrameVisualProperties to //third_party/blink/public/common. TBR=dtapuska@chromium.org Bug: 1093956 Change-Id: Ic2b337dd0e40bebf12c3b650fab56d3203445135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383594 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#803371}
-
Yuta Hijikata authored
This patch flips the default log format of chrome for chrome os to syslog format. For more detail go/cros-syslog-format-log-chrome. BUG: 1093033 TEST: base_unittests Change-Id: Ic5f40d1769439960c1d49799c1f201ce69110f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377669 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#803370}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I42c87d7ed13b1a9a3ec11ae5bca50c8b0c0cc381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387344Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803369}
-
Kyle Horimoto authored
Fixed: 1123073 Change-Id: Ie822a54e391c87f622b8d92e55dfeb224046cf23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386580 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#803368}
-
David Black authored
Previously the `HoldingSpaceKeyedService` was constructed with a `BrowserContext` and internally converted to `Profile` as needed. Now, we'll take a `Profile` at construction time and avoid any downstream conversions. This CL also addresses a race condition that could occur when partitioning `HoldingSpaceItems` by existence. Previously, input order was not guaranteed to match output order. Now they will which should stabilize browsertests. Bug: 1119496 Change-Id: I8e213eeed8f4b4169bc033130fcdebf473c1fd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386383 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803367}
-
Kyle Horimoto authored
This code used oppressive language which needed to be removed, but it wasn't actually being used anyway, so I removed it. Bug: 1123072 Change-Id: I7034dfde159d317699988d4eeae417debb7c1fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387124 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Daniel Classon authored
Adds deep links to the Privacy Page. Splits the Privacy Page tests into AllBuilds and PrivacyPageTest_OfficialBuild in order to test deep linking to the collect crash reports setting. Bug: 1084154 Change-Id: I88cc0444260d951efd2972c5c8e825ef18c4b760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386424 Commit-Queue: Daniel Classon <dclasson@google.com> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: Ie6287c10e3a2e4ce2dc46f6a3d7d84b4df35f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383591 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#803364}
-
Chris Blume authored
On Android, color gamut changes dynamically with the content being displayed. This is currently under a Finch flag at 50% canary/dev/beta and 1% stable. When not enabled, wide color content is not displayed in wide color. The Finch experiment has been successful. This CL enables the feature by default. R:khushalsagar@chromium.org Bug: 735658 Change-Id: I9eda388690e3d2fa37d597925c32e38afd7ffe11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370803Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#803363}
-
Daniel Classon authored
Adds deep links to the Date Time page and Time Zone subpage. Also adds a focus method to settings-radio-group to help with deep linking. Bug: 1084154 Change-Id: I53cfc17e386ce6799dff95a5d7afccfe7a847f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382960 Commit-Queue: Daniel Classon <dclasson@google.com> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Minggang Wang authored
Currently, the worker thread calls the Terminate() of the child threads during executing PrepareForShutdownOnWorkerThread(). This patch removes the explicit calling, because the nested workers are observers of the terminating worker's worker global scope, the child threads will get terminated when notified with ContextDestroyed(). Change-Id: I7b9fd424c5b954b31ff83b1027608e5e24c04bbd Bug: 1104847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377580Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#803361}
-
Xinghui Lu authored
This is a follow up CL for https://crrev.com/c/2359749. It is for pure refactoring. The plan for this two-sided patch is: 1) Add the new class under feedback/ and AppHooks method upstream with no reference. 2) Extend the new class downstream and add the new AppHooks method. 3) Update upstream references to point to the new AppHooks method. 4) Cleanup. This CL is for step 1). Step 2) will be done in https://crrev.com/i/3227761 once this CL is landed. Bug: 1117343 Change-Id: I312f3459360fa5e1b78f6e301b052a36bed2e9b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364581Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803360}
-
Yulun Wu authored
This CL adds light mode for login shelf buttons, text, icons, and wallpaper. Bug: 1110757 Change-Id: I1057aa89bf777f3f35564d7876256f9381059e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363799Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Thomas Tellier <tellier@google.com> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803359}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7b69a44c8b1c..9e02f4716a1e 2020-08-31 deadbeef@webrtc.org Fix destruction order of PortAllocator and PacketSocketFactory. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaff60306d3724cb402b96af01e9960a73d88d032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803358}
-
Gang Wu authored
This reverts commit 78a7ace4. Reason for revert: This CL make PhotoPickerDialogTest flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.components.browser_ui.photo_picker.PhotoPickerDialogTest%23* Original change's description: > Remove ApplicationStatus usage from PhotoPicker. > > ApplicationStatus only works in //chrome. See crbug.com/470582 > > Bug: 1110930 > Change-Id: I71a6a5701aa40434588830cfcc6dee8ff6f5143a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378633 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803247} TBR=finnur@chromium.org,dtrainor@chromium.org,estade@chromium.org Change-Id: I78eaf08ba277d516584ae75d38ce64909ba36bff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387196Reviewed-by:
Gang Wu <gangwu@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803357}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e1e6f2940c25..59d28532a179 2020-08-31 jdarpinian@chromium.org Fix GL_EXT_texture_compression_s3tc_srgb on macOS 2020-08-31 m.maiya@samsung.com Vulkan: Optimize atomic counter buffer offset calculations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I48f674818122da58bb223f71a26ec51697c4ed80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386666Reviewed-by:
-
Devlin Cronin authored
InfoBarDelegate::infobar_ was uninitialized during construction - which is bad for delegates that try to access InfoBarDelegate::infobar(). Properly initialize it to nullptr. Bug: None Change-Id: I8f52e02fbca1486f7c60c8f2791cd7e8c464d5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387118 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803355}
-
Kenichi Ishibashi authored
GetNew{Registration,Version,Resource}Id() are async now. Remove outdated comments. Bug: N/A Change-Id: I329d7a4de8949a7493d0751c24701b2a56ad0ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386677Reviewed-by: -
Lukasz Anforowicz authored
This CL adds extra crash keys logged when a DumpWithoutCrashing happens while handling a network::ResourceRequest: one for |resource_type| and one for |load_flags|. This extra crash keys should help ensure that the expected values are seen in the most common cases of DwoC seen in https://crbug.com/1056949. See also the "Callstack and request properties corresponding to the most frequent DwoC" section in a (Google internal) doc here: https://docs.google.com/document/d/1Q8UxpBLyv0SorQKLvY8M5npvyMroMlo9i6ZpUMol9aY/edit#heading=h.hquty15bu38n Bug: 1056949 Change-Id: I765a1baac9e756747a54cf5b60cab54c63b520fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386417 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#803353}
-
Jonathan Ross authored
Update GpuMemoryAblationExperiment to have more fine grained controls for setting the size of each ablation. Rather than there being 3 hard coded sizes, the multiplier for the size is read in. With setup to parse Finch parameters, and additional command line flag for use with running experiments outside of Finch trials. Bug: 908462 Change-Id: Ie6e03809f788334d15d20ba1756f94640d84bd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360572Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#803352}
-
Joel Hockey authored
The combination of loading html-imports.min.js but also having the renderer parse and load imports for file:// URLs, causes polymer to fail to load in FileManagerUITests. Adding a check for toast.shadowRoot and creating one if required fixes the test (crrev.com/c/2373967/15). Bug: 1111393 Change-Id: I79decc2a58192598b57f7c485073edaea3a87e78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386681Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#803351}
-
nancylingwang authored
For the adaptive icon, there are 2 files opened for each icons, so when there are many apps installed, many files are opened to load the image, which might cause the system crash: Too many open files This CL modifies the code to reduce the unnecessary icon loading, and reduce the duplicated open files: 1. For OnIntentFiltersUpdated, we don't need to update the icon to reload the icon. 2. Modify the background image source in ArcAppIcon to set the null host, because ArcAppIcon::Source checks the host and call LoadForScaleFactor to read icon files. Since that has been done by the foreground image, we don't need to do it for the background image again. b:166430206 Change-Id: Iecc76ca8e02bc5ef2230f99553abb8fb4a00362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386435 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#803350}
-
Haiyang Pan authored
This reverts commit 564da6d9. Reason for revert: Very likely the cause of crbug.com/1122472 See the analysis in crbug.com/1123677#c4 for detail Original change's description: > Make ContentCapture ready for experiment > > Currently the triggering of ContentCapture is unpredictable, it is > hard for us to get the unbiased result for the UserActivatedDelay > experiment. > > This patch adds an ExperimentContentCaptureConsumer which triggers > the ContentCapture independently and is enabled by default. > > The allow list check is moved to consumer if the experiment > is enabled. > > As ContentCapture is potentially used for all Android versions, > we plan to run the experiment for all of them. > > This mechanism will also be used for future experiments. > > This patch hasn't supported multiple consumers yet. > > Test: Added new tests and pass the existing tests > > Bug: 1114819, 1119663 > Change-Id: I72e0b991767329caec37080caae2d5c2a9068eaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368104 > Commit-Queue: Tao Bai <michaelbai@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801672} TBR=michaelbai@chromium.org,wangxianzhu@chromium.org,dtrainor@chromium.org,changwan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1114819 Bug: 1119663 Bug: 1122472 Change-Id: Ife98d73f4e77062606f18adb0ba12e9baaf4f6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386578Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#803349}
-
Gang Wu authored
This reverts commit e5b906d1. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1134 Original change's description: > Don't show default undo bar for closure in TabGridDialog > > This CL prevents default undo closure snack bar from showing when a > closure happens within TabGridDialog. We use the visibility of > TabGridDialog as a proxy to decide whether a closure happens in dialog. > This is the step2 in https://docs.google.com/document/d/1OOlOVYtcFXE--8TMdcFAqAMqcsRyEsvJr0vzsNCR_F4/edit?usp=sharing. > > Bug: 1119899 > Change-Id: Ibdfe53847af25921f32436d80a5868b97340a524 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369469 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803203} TBR=yusufo@chromium.org,mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org Change-Id: Ie98c1246828bc48c3569184c2565338d54f67629 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386374Reviewed-by:
-
Kuo Jen Wei authored
CCA has 3 kinds of property currently undefined to closure compiler: 1. Properties set by external browsing context. 2. Properties defined in dataset. 3. properties defined under * type. This CL use bracket property accessors to access these properties for avoiding being caught in closure compiler strict mode check. Bug: 1122444 Test: tast run <DUT> "camera.CCAUI*" Change-Id: I8f57adc6ca536629377af4976bb45515b4efc2be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383590 Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
-
Gang Wu authored
This reverts commit 3c8430ae. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1133 Original change's description: > Batch BottomSheetControllerTests > > This patch batches all the tests in BottomSheetControllerTest. > Consequently, some new methods to reset the sheet's state were added > to the test support classes and BlankCTATabInitialState was updated to > support any subclass of ChromeActivity. > > Bug: 1122163 > Change-Id: I3fbb73431eff206010d93d8c5e26e4942b84adb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377664 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803156} TBR=mthiesse@chromium.org,mdjones@chromium.org Change-Id: I41a36c86f34d947b69e00a92109f56f0bfcda760 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1122163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386500Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/473462adb6b1..ed15af5c4eed 2020-08-31 bpastene@chromium.org gclient: Don't try opening pseudo-terminal pipes when running hooks. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1122671 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ide32db2ba64b52f31792412aaf913fb349871735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386661Reviewed-by:
-
Ilya Sherman authored
https://crrev.com/c/2366154 landed in parallel with https://crrev.com/c/2380889, and the two collided. This CL fixes the collision. R=sweilun@chromium.org Bug: 758782 Change-Id: I10a1b4770877e1394a642a34bdbf9212c1d5a838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387135 Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#803344}
-
John Williams authored
Bug: 1095764, b/159154368 Change-Id: I36829467e3a6477499c76ae0b15e110acba00c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346911Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#803343}
-
K. Moon authored
Triggers process-wide initialization of PDFium when an instance of chrome_pdf::PdfViewWebPlugin is initialized for the first time. PDFium will be shut down when all plugin instances have been destroyed. Also renames IsSDKInitializedViaPepper() to IsSDKInitializedViaPlugin(), in order to reflect that the SDK may be initialized by either the Pepper or Pepper-free plugin. Fixed: 1123552 Change-Id: I00ce39779edfe61726b6a55240300ece1aa8527c Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386597 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#803342}
-
Gavin Williams authored
This change adds a check to see if a user's Google Drive directory is mounted on Chrome OS. If Drive is not mounted then we don't show the Save to Drive option in the dropdown. Reasons why Drive could not be mounted (callback would return false) include: Drive is disabled by the user, disabled by enterprise policy, or is in a crashing state. Also remove "isDriveMounted" as a print preview handler message callback because this data is now sent back with the initial settings. Bug: 1112416 Change-Id: I26acf17a41cb178f99c630b2daf43d02ae08134d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382204 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#803341}
-
Shimi Zhang authored
In some OEM Android framework clipboard service code, there are strict mode violations, which makes the calling thread/process to crash. We need to suppress the crash by disabling strict mode. Bug: 1123727, 1113428 Change-Id: Iee30100c0ae41fee1856a7b5d8c43e1a28132959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386662Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#803340}
-
Matt Menke authored
StringPieces all the way through the MIME sniffing code. This CL only updates net/ consumers to use the overloads, which are all test-only code. I'll update consumers and remove the old methods in another CL. Bug: 1123179 Change-Id: I04328913fa1c7bfd9049fa7aaae6a8a538cbe8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382896 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#803339}
-
Glen Robertson authored
Fixes a `gn check` failure. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I5dcc0ff5d00bfa04c241a07fc62c63c502a1ad74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384691 Auto-Submit: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#803338}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/77fb6d1812df..1eb42f5ea752 2020-08-31 jleconte@google.com Monorail links are missing project in chart tooltip. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: sadrul@google.com Change-Id: I65471b51127bef995827df65ab841ebe073abc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384525Reviewed-by:
-
