GitLab

This is re-implementing the HTML icon sizes parsing algorithm
given that it is missing a re-usable place for it. There is
a follow-up bug opened at http://crbug.com/416477

BUG=366145

Review URL: https://codereview.chromium.org/591073002

Cr-Commit-Position: refs/heads/master@{#296386}

BUG=338303

Review URL: https://codereview.chromium.org/560523004

Cr-Commit-Position: refs/heads/master@{#296385}

Revert of [Android] JUnit runner + gyp changes. (patchset #15 id:280001 of https://codereview.chromium.org/574433003/)

Reason for revert:
Speculative revert: Android test started flaking a ton after this landed. Affected targets androidwebview_instrumentation_tests, chromeshell_instrumentation_tests, contentshell_instrumentation_tests. This CL seems the most likely in the blamelist of https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/15905.

Original issue's description:
> [Android] JUnit runner + gyp changes.
>
> This adds Java code for running junit tests, as well as gyp targets for
> both runnable and non-runnable host-side JARs.
>
> BUG=316383
>
> Committed: https://crrev.com/2e56d4508e33de5fc60bbbb41c5a5d5534e88174
> Cr-Commit-Position: refs/heads/master@{#296340}

TBR=cjhopman@chromium.org,nyquist@chromium.org,aurimas@chromium.org,jbudorick@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=316383

Review URL: https://codereview.chromium.org/597123002

Cr-Commit-Position: refs/heads/master@{#296384}

BUG=397105

Review URL: https://codereview.chromium.org/560033002

Cr-Commit-Position: refs/heads/master@{#296383}

This is not yet supporting icons.sizes. It will be
implemented in a separate CL because the algorithm might be
more complex and could require some code sharing with Blink.

BUG=366145

Review URL: https://codereview.chromium.org/590563002

Cr-Commit-Position: refs/heads/master@{#296382}

There were some cases where we use CanMaximize to determine if
minimization should be disabled. They now use CanMinimize:
- custom_frame_view_ash
- hwnd_message_handler

All classes that implement CanMaximize now implement
CanMinimize in the same way, so there should no change in
behavior.

BUG=328241,341010

Review URL: https://codereview.chromium.org/583603004

Cr-Commit-Position: refs/heads/master@{#296381}

BUG=none

Review URL: https://codereview.chromium.org/594243002

Cr-Commit-Position: refs/heads/master@{#296380}

The Resources folder need to have that capitalization otherwise when
building on a case-sensitive filesystem the build results in two
directories:
  Chromium Framework.framework/Versions/A/resources/
  Chromium Framework.framework/Versions/A/Resources/

This ultimately lead to a compilation error when running the script
tools/swarming_client/isolated_format.py.

BUG=260301

Review URL: https://codereview.chromium.org/593123002

Cr-Commit-Position: refs/heads/master@{#296379}

Right now, if the runloop is observing handles and a delayed task tries
to quit it, it will block until one handle gets a signal. This CL
ensures that a delayed task can quit the runloop.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/588593002

Cr-Commit-Position: refs/heads/master@{#296378}

Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.

This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).

To keep this CL reasonably simple this issues will be addressed later.

TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418

Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
Cr-Commit-Position: refs/heads/master@{#296360}

Review URL: https://codereview.chromium.org/517233002

Cr-Commit-Position: refs/heads/master@{#296377}

BUG=None

Review URL: https://codereview.chromium.org/595273003

Cr-Commit-Position: refs/heads/master@{#296376}

BUG=None

Review URL: https://codereview.chromium.org/580363005

Cr-Commit-Position: refs/heads/master@{#296375}

Windows Media Player plugin for Chrome uses NPAPI which is now deprecated and disabled by Chrome. This commit removes plugin's supported MIME types and prevents the prompt to install the plugin from showing up

BUG=

R=bauerb@chromium.org

Review URL: https://codereview.chromium.org/597883002

Cr-Commit-Position: refs/heads/master@{#296374}

Maintain a whitelist of which browsers it makes sense to compare with --browser=reference (doesn't include system)

BUG=416705
TEST=None.
TBR=tonyg
NOTRY=True

Review URL: https://codereview.chromium.org/601713002

Cr-Commit-Position: refs/heads/master@{#296373}

Unlike other permissions, granting notifications for a given domain
will grant them even if such domain happens to be an iframe of
an embedder. Most other permissions are granted only for a combination of
iframe + embedder.

This reverts an unintentional behavioral change, and moves
us back to the situation we currently ship in stable while
we figure out if it is a good idea or not to change the behavior.

BUG=416645

Review URL: https://codereview.chromium.org/593153002

Cr-Commit-Position: refs/heads/master@{#296372}

Following up on http://crbug.com/338289#c13, this CL removes the kill switch for PSL matching. Apart from the linked check with our PM, the consideration is that PSL matching has been in stable for a couple of releases now on all platforms (except for KDE, see below), and the bugs seen so far were of low severity, exposing problems in password manager rather than with PSL matching itself.

It also replaces a couple of callsites of IsMatchingEnabled with ShouldPSLDomainMatchingApply -- the former did not take sites with a unified login origin into consideration, and on the affected callsites it seemed like it should.

One caveat: PSL matching has not been added to KDE on Linux yet (it's planned, just not a top priority). Given that PSL is live on other Linux environments, and all other platforms, the concerns about needing the kill switch for KDE are low.

As a follow-up to this CL, the (never submitted) internal CL with the corresponding Finch config will be closed.

BUG=338289

Review URL: https://codereview.chromium.org/508143002

Cr-Commit-Position: refs/heads/master@{#296371}

BUG=417189
NOTRY=True
TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/603473002

Cr-Commit-Position: refs/heads/master@{#296370}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/594133003

Cr-Commit-Position: refs/heads/master@{#296369}

* Check if keyboard mic is available in MediaStreamManager and inform AudioManager if so.
* AudioManager sets the effect in AudioParameters returned from GetInputStreamParameters if available.

BUG=345296

Review URL: https://codereview.chromium.org/583833008

Cr-Commit-Position: refs/heads/master@{#296368}

Removes the superflous cvox.AbstractMsgs class and moves what was rpeviously
ChromeMsgs out of host.

BUG=341953
R=dtseng@chromium.org

Review URL: https://codereview.chromium.org/593133002

Cr-Commit-Position: refs/heads/master@{#296367}

Previous try: https://codereview.chromium.org/137993011
Reverted: https://codereview.chromium.org/139153005

BUG=76280
R=jln@chromium.org

Review URL: https://codereview.chromium.org/583363004

Cr-Commit-Position: refs/heads/master@{#296366}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/600673002

Cr-Commit-Position: refs/heads/master@{#296365}

expected.

BUG=405413

Review URL: https://codereview.chromium.org/488533002

Cr-Commit-Position: refs/heads/master@{#296364}

We used to just leak everything on Mac. Since r295194, we clean up
references to Profiles being deleted, in Chrome's AppListViewDelegate.
This has caught out the Mac app list trying to access stuff it shouldn't
if Cocoa is still drawing it while Chrome is shutting down. Tests
started failing flakily.

This CL adds AppListViewDelegateObserver::OnShutdown to that Chrome's
AppListViewDelegate can notify the AppListView that it's shutting down.

On Views platforms, the Widget is just closed (which also happens just
after the chrome::NOTIFICATION_APP_TERMINATING broadcast). However, (a)
Cocoa doesn't have a `CloseAllSecondaryWidgets` call to trigger this and
(b) just closing the NSWindow isn't usually enough on Cocoa to avoid
accessing C++ objects due to reference counting.

We could also go through the platform-specific AppListService (e.g. by
passing in the AppListService that creates a Chrome
AppListViewDelegate), but this seemed neater.

This de-flakes a bunch of applist tests on Mac. The Mac-specific
ShowAppListUsingShim test is also augmented with extra checks for the
OnShutdown stuff.

BUG=415264
TEST=AppListServiceMacInteractiveTest.ShowAppListUsingShim,
AppListServiceInteractiveTest.*

Review URL: https://codereview.chromium.org/593563002

Cr-Commit-Position: refs/heads/master@{#296363}

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/599463002

Cr-Commit-Position: refs/heads/master@{#296362}

Revert of DevTools socket tunnel. (patchset #11 id:300001 of https://codereview.chromium.org/517233002/)

Reason for revert:
Fails to compile on Android: https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20(dbg)/builds/2163

devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/SocketTunnelServerTest.java:291: cannot find symbol
symbol: method sleep()
                sleep();
                ^

Original issue's description:
> Implementation of DevTools socket tunneling service for remote debugging.
>
> Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.
>
> This CL doesn't care of a few known issues:
> 1. Data channel buffer overflow. Data channel automatically closed in this case.
> 2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
> 3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).
>
> To keep this CL reasonably simple this issues will be addressed later.
>
> TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
> BUG=383418
>
> Committed: https://crrev.com/15044609893faf9b2c2a533aa9a136f288ea20a1
> Cr-Commit-Position: refs/heads/master@{#296360}

TBR=mnaganov@chromium.org,tedchoc@chromium.org,erikwright@chromium.org,serya@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=383418

Review URL: https://codereview.chromium.org/597063002

Cr-Commit-Position: refs/heads/master@{#296361}

Test APK in addition to instrumentation tests contains launching activity and foreground service what let duplicate ChromeShell debug socket to a differently named socket. If a device with running ChromeShell and DevToolsBridgeTest's service connect to a Desktop chrome (with USB debugging enabled) then chrome://inspect#devices will show 2 ChromeChell items. Both are debuggable (https://codereview.chromium.org/521573002/ should be applied to Desktop chrome to make the process less surprising). It's suitable for manual tests.

This CL doesn't care of a few known issues:
1. Data channel buffer overflow. Data channel automatically closed in this case.
2. Uncontrolled number of pending sockets. DevTools throttles opening sockets and and keeps sockets that exceeds a threshold hanging.
3. Uncontrolled number of threads (it's actually not a problem if #2 solved, thanks to DevTools throttling).

To keep this CL reasonably simple this issues will be addressed later.

TEST=org.chromium.components.devtools_bridge.SocketTunnelServerTest, see description fro manual testing.
BUG=383418

Review URL: https://codereview.chromium.org/517233002

Cr-Commit-Position: refs/heads/master@{#296360}

BUG=402356
TEST=browser_tests --gtest_filter=SyncFileSystemTest.AuthorizationTest

Review URL: https://codereview.chromium.org/493043002

Cr-Commit-Position: refs/heads/master@{#296359}

Cr-Commit-Position: refs/heads/master@{#296358}

Revert of EventSender: Added checks for missing arguments (patchset #4 id:60001 of https://codereview.chromium.org/584203003/)

Reason for revert:
This makes the fast/events/hit-test-counts.html layout test fail. Reverting for now.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fevents%2Fhit-test-counts.html&testType=layout-tests

Original issue's description:
> Added checks for missing arguments in event_sender.cc. Also simplified the uses of x & y in EventSender::GestureEvent.
>
> BUG=415970
>
> Committed: https://crrev.com/302907463636d2ddfe25c5381bd1f2b64016d1c6
> Cr-Commit-Position: refs/heads/master@{#296256}

TBR=dpranke@chromium.org,rbyers@chromium.org,earthdok@chromium.org,mustaq@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415970

Review URL: https://codereview.chromium.org/600733002

Cr-Commit-Position: refs/heads/master@{#296357}

BUG=344769

Review URL: https://codereview.chromium.org/554213002

Cr-Commit-Position: refs/heads/master@{#296356}

The Android link disambiguation popup is rendered by PopupZoomer on the Java side. This CL tries to recreate that UI in Aura using a BubbleDelegate.

This part works just like the Android code:

When Blink detects an ambiguous gesture it calls RenderViewImpl::didTapMultipleTargets(), which uses paintCompositedDeprecated() in the WebWidget to get a zoomed bitmap region containing the ambiguous links the gesture could possibly indicate. RenderViewImpl then sends a ShowDisambiguationPopup message via IPC which ultimately ends up in RenderWidgetHostImpl::OnShowDisambiguationPopup(), which marshals the bitmap and then then calls ShowDisambiguationPopup on the view_.

This part is specific to aura:

After a series of delegation steps the callback ends up in WebContentsViewAura::OnLinkDisambiguationPopupRequested, which converts the target rectangle from pixels to DIPs and then requests the popup be rendered by asking its WebContentsViewDelegate, ChromeWebContentsViewDelegateViews, which owns a LinkDisambiguationPopup and asks it to render.

The LinkDisambiguationPopup uses BubbleDelegate to show the zoomed image. Any GestureEvents it receives converted into the coordinate space of the content view and then are relayed via callback back to WebContentsViewAura, which then converts them in to Blink events and sends them on to the RenderWidgetHostImpl for relaying back to Blink.

jam: content/ parts
sky: everything else?

BUG=385249

Review URL: https://codereview.chromium.org/351683002

Cr-Commit-Position: refs/heads/master@{#296355}

BUG=380213, 416961, 408734, 370175
R=stevenjb@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/593273002

Cr-Commit-Position: refs/heads/master@{#296354}

This is the preparation for introducing other types of file system supported by
external file system backend into the drive protocol handler.

The CL does not change the format of drive URL.

BUG=367027
TEST=Open HTML, MHTML, PDF, GDOC, OGG, MP4 files on the drive volume.

Review URL: https://codereview.chromium.org/560313002

Cr-Commit-Position: refs/heads/master@{#296353}

This patch will fixed the build errors which is due to while notification flag is
enabled and extension flag is disabled.

BUG=None

Review URL: https://codereview.chromium.org/582673002

Cr-Commit-Position: refs/heads/master@{#296352}

Adding split view divider widget which could be dragged to exit the split view.

BUG=403207,408691

Review URL: https://codereview.chromium.org/545393002

Cr-Commit-Position: refs/heads/master@{#296351}

Previously, this test would crash if the output wasn't quoted properly
(since it assumes that cmd_string.length() >= program_string.length() +
2). Instead, directly compare the string with the expected output. This
also guards against the possibility of mis-constructing the expected
string.

Review URL: https://codereview.chromium.org/589393002

Cr-Commit-Position: refs/heads/master@{#296350}

If you click on the SSL interstitial's error code, the following is
now shown:
* subject
* issuer
* validity end date
* current date
* pem encoded chain

This CL adds a placeholder for debugging information to the security
interstitial. It's intentionally meant to be flexible, so that it could
support other debugging information in the future from other warnings.

BUG=413838

Review URL: https://codereview.chromium.org/584463005

Cr-Commit-Position: refs/heads/master@{#296349}

call OnTerminating in unit test.

BUG=None

Review URL: https://codereview.chromium.org/599683003

Cr-Commit-Position: refs/heads/master@{#296348}

App windows launched in windows ASH should not be messing with the AppUserModelId for the remote HWND.

This causes problems on Windows 7 Chrome OS mode where launching popup app windows in Chrome OS mode
causes the taskbar button for the remote HWND to change to the application button. On Windows 8
these calls silently fail.

BUG=409824

Review URL: https://codereview.chromium.org/589303002

Cr-Commit-Position: refs/heads/master@{#296347}