GitLab

The coordinate system for the window controller is flipped, but the code was
treating it as though it was unflipped.

BUG=315977
TEST=slightly less padding at top of dialog
R=groby@chromium.org

Review URL: https://codereview.chromium.org/72513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235682 0039d316-1c4b-4281-b951-d872f2087c98

The parameters of InstallObserver::OnBeginExtensionInstall() have been
moved to a struct to allow additional parameters to be added easily
without changing the signature of the function.

BUG=None
TEST=unit_tests, browser_tests

Review URL: https://codereview.chromium.org/72463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317879

Review URL: https://codereview.chromium.org/71753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235680 0039d316-1c4b-4281-b951-d872f2087c98

This functions is called every time a profile is loaded, including
during startup.

BUG=None

Review URL: https://codereview.chromium.org/62953020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235679 0039d316-1c4b-4281-b951-d872f2087c98

> Fix cancelling of device enumeration requests.
> 
> TEST= Log using --vmodule=media_stream_manager*=3,media_stream_dispatcher*=3 and make sure the log print out media_stream_manager.cc(316)]CancelRequest(
> after
> MediaStreamDispatcher::StopEnumerateDevices() while using the webcam on youtube.com/my_webcam?privacy=public
> 
> BUG=317534
> R=xians@chromium.org
> 
> Review URL: https://codereview.chromium.org/72683002

TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/74753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235678 0039d316-1c4b-4281-b951-d872f2087c98

This mimics the organization of chrome/browser/ui as well.

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/71743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235677 0039d316-1c4b-4281-b951-d872f2087c98

AFAICT, the last clients of this code no longer depend on it, so get
it removed before someone else decides to depend on it.

BUG=161116,294306

Review URL: https://codereview.chromium.org/71723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235676 0039d316-1c4b-4281-b951-d872f2087c98

We use the SurfaceFlinger data to compute the lengths of the frames (normalized
to vsyncs). Sometimes the data is inconsistent and we get two frames that are
less than 1 vsync apart. Filter out these frame lengths (threshold length is
currently 0.5 vsyncs) and print a warning.

BUG=318093

Review URL: https://codereview.chromium.org/71353006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312466

Review URL: https://codereview.chromium.org/71013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235674 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 9afacfdd.

Better than even odds that this patch fixed the underlying issue:

https://codereview.chromium.org/57423008/

BUG=314576
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/70493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318432
TEST=tools/perf/run_benchmark media.tough_media_cases (with tough_video_cases.json edited to include invalid media URLs)

Review URL: https://codereview.chromium.org/70333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235672 0039d316-1c4b-4281-b951-d872f2087c98

Make the test resilient to spurious page scale changes that
can occur after calling WebView.setInitialScale.

Also, update AwViewportTest#testNoUserScalableQuirk to wait
for page scale change events instead of page scale polling.

BUG=319353

Review URL: https://codereview.chromium.org/71203004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235671 0039d316-1c4b-4281-b951-d872f2087c98

BUG=319986

Review URL: https://codereview.chromium.org/70233017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235670 0039d316-1c4b-4281-b951-d872f2087c98

- Default to dev directory for devsite-prod build.
- Remove unneeded build artifacts for devsite-prod build.

R=sbc@chromium.org

Review URL: https://codereview.chromium.org/72213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235669 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to break Linux ASAN tests:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%283%29&number=18746
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%282%29&number=19801

> Add UMA for <webview> APIs: a. ClearData, b. when Permission request is allowed.
> 
> BUG=317084
> Test=None
> 
> Review URL: https://codereview.chromium.org/69913002

TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/65043018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235668 0039d316-1c4b-4281-b951-d872f2087c98

This tries to grab useful diagnostic information from the system when
CreateDIBSection fails since we're about to crash anyway. This tries to categorize
the failure as being out of GDI handles, out of memory generally, or unknown and
puts more information on the stack.

Based on code from cpu@ in r116646 and from vangelis@ in https://codereview.chromium.org/57053002/

R=cpu
TBR=reed
NOTRY=true since nacl_integration is being stupid
BUG=275046

Review URL: https://codereview.chromium.org/70193011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235667 0039d316-1c4b-4281-b951-d872f2087c98

BUG=319061

Review URL: https://codereview.chromium.org/70183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235666 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org,willchan@chromium.org
BUG=271572
TEST=none

Review URL: https://codereview.chromium.org/70103018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316402

Review URL: https://codereview.chromium.org/70083009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235664 0039d316-1c4b-4281-b951-d872f2087c98

BUG=319956

Review URL: https://codereview.chromium.org/74293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235663 0039d316-1c4b-4281-b951-d872f2087c98

Add support to PowerPolicyController for controlling the
screen brightness. This isn't controlled by any prefs or
enterprise policies yet.

BUG=310429

Review URL: https://codereview.chromium.org/69813007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235662 0039d316-1c4b-4281-b951-d872f2087c98

Create a new test framework class named ProfileSyncServiceSimpleTest and
use it to replace several ProfileSyncServiceTests.  This newer framework
takes advantage of MockSyncBackendHost and allows us to use a real
ProfileSyncService in these tests.

The resulting tests are better at testing the ProfileSyncService, but
they no longer test any part of the SyncBackendHost code.   This is a
desirable trade off because these are unit tests.

BUG=312994

Review URL: https://codereview.chromium.org/69583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235661 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235660 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following CLs:

Update to NSPR 4.10.2.
https://codereview.chromium.org/68173008/

R=rtenneti@chromium.org
BUG=318442
TEST=none

Review URL: https://codereview.chromium.org/73253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235659 0039d316-1c4b-4281-b951-d872f2087c98

Added the upload file path to PrivetURLFetcher and PrivetLocalPrintOperation.

BUG=318373
R=gene@chromium.org, vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/72033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235658 0039d316-1c4b-4281-b951-d872f2087c98

Animations that are in the WaitingForDeletion state cannot make any
further progress, so we do not need to tick LayerAnimationControllers that
only have such animations.

BUG=319557

Review URL: https://codereview.chromium.org/73343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=302476

Review URL: https://codereview.chromium.org/69293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235656 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/68893032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235655 0039d316-1c4b-4281-b951-d872f2087c98

Set DebugInfoEventListener's kMaxEntries to ModelType::MODEL_TYPE_COUNT to ensure we don't lose debug info.

BUG=319463

Review URL: https://codereview.chromium.org/68893022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235654 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235653 0039d316-1c4b-4281-b951-d872f2087c98

intervals.

a) t <= 10ms
b) 10ms < t <= 20ms
c) 20ms < t (or no previous time)

R=jar@chromium.org

Review URL: https://codereview.chromium.org/68793007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235652 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a layout bug that was dormant since previously notifications
were always expanded.

BUG=NONE

Review URL: https://codereview.chromium.org/68713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235651 0039d316-1c4b-4281-b951-d872f2087c98

Current location is obtained from user prefs.
In addition, s/Value::CreateStringValue/new SringValue/g.

BUG=296501
TEST=manual tests on Falco.

Review URL: https://codereview.chromium.org/68573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235650 0039d316-1c4b-4281-b951-d872f2087c98

Add minimum timeout for privet transient errors, so that when printers give a
zero timeout, Chrome still waits between retries.

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/69393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235649 0039d316-1c4b-4281-b951-d872f2087c98

This patch focuses on the deletion of IBusEngineService keeping the logic as-is.


BUG=275262

Review URL: https://codereview.chromium.org/70053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317084
Test=None

Review URL: https://codereview.chromium.org/69913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235647 0039d316-1c4b-4281-b951-d872f2087c98

This is part of the AppShell extensions refactor project.

BUG=316367
TEST=unit_tests, browser_tests
TBR=dmazzoni@chromium.org for trivial fix to tts_extension_loader_chromeos.h

Review URL: https://codereview.chromium.org/69883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235646 0039d316-1c4b-4281-b951-d872f2087c98

UserImageManagerImpl uses background threads and delayed tasks to load
images, save images and schedule downloads. There are races in this
implementation so that an earlier operation can complete after a later
operation, clobbering its result. Delayed tasks using base::Unretained()
may cause crashes on shutdown if the unretained object no longer exists.
Some of the races were partially worked around with global state variables
that do not account for the fact that operations for multiple users may be
going on in parallel.

This CL is an almost complete rewrite of the UserImageManagerImpl that
addresses the races and thread safety issues. Pending tasks are
encapsulated by a Job class with at most one Job running per user at a
time.

Migration of old user images is simplified by this CL: There used to be a
delay between user login and migration, postponing the I/O-heavy operation
until after login is complete. However, the implementation was wrong and
migration of PNG images was actually carried out immediately. Only for
users who had selected one of the default images was the migration
delayed, which is unnecessary as it does not involve any file I/O or
transcoding. Since there have been no complaints about the performance
impact of migration during login, this CL removes the delay altogether.

The CL also updates the UserImageManagerImpl browser test, re-enabling the
previously flaky NonJPEGImageFromFile.

BUG=152957,152959,257009
TEST=Updated browser tests; manual tests with chromeos=1 and VM

Review URL: https://codereview.chromium.org/69863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235645 0039d316-1c4b-4281-b951-d872f2087c98

Speculative; will follow up with more details

> Remove blacklisting of Mac OS 10.6 and 10.7.
> 
> Add blacklisting of VMWare driver on 10.7 because it hangs.
> 
> Disable compositing expectation test on 10.7 because it will
> give different results depending on whether it is running on
> a VM or real hardware.
> 
> TBR=vangelis
> BUG=266186
> 
> Review URL: https://codereview.chromium.org/68253005

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/75013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235644 0039d316-1c4b-4281-b951-d872f2087c98

While setting the new UTF-8 version of the window title property fixes
the symptoms, qe're still setting the legacy property incorrectly. To
really fix that bad data, we'll need the equivalent of
UTF8ToCompoundText() and vice versa.

BUG=319071

Review URL: https://codereview.chromium.org/68523019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235642 0039d316-1c4b-4281-b951-d872f2087c98