- 10 Aug, 2020 40 commits
-
-
Miguel Casas authored
Many moons ago, DisplayConfigurator::SetColorMatrix() / SetGammaCorrection() were only called once after parsing a hypothetical ICC file -- those days CrOS didn't manipulate the display's color characteristics, so we configured either / both, and cleared the ColorSpace to avoid overwriting those two DRM tables unnecessarily. Note that the matrix/de/gamma tables were loaded after every wake up. Time after that came Night Light and other color mgmt projects, and this code path started being used when coming out of sleep/hibernate etc, with the caveat that after applying their matrix/de/gamma tables, the cached colorspaces was/were still cleared and lost. The fix is then simple: since we need the |color_space| to stick around, this CL avoids clearing it. RunColorCorrectionClosureSync() is then superfluous and can be removed, making evident that searching for |display_id| in |cached_displays_| is only for verification purposes: Bug: b:159224397, 1091552 Change-Id: I553646217c1012221844242c96148b8526657217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342583Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#796442}
-
Nela Kaczmarek authored
Bug: 1108279 Change-Id: I0d50e041c78f871fa9167ff157aa301559c6ff91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341646 Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796441}
-
Wan-Teh Chang authored
For the tests that iterate over multiple image formats, swap the loop so that instead of one test that loops over image file extensions, it creates multiple tests that each test one image file extension. Stephen McGruer outlined this change in https://crrev.com/c/2304961. Test: third_party/blink/tools/run_web_tests.py -t Default \ external/wpt/html/canvas/element/manual/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html Bug: 1099028 Change-Id: Iac122b5aee4fecd66962e75ed4bd7ddca55b0add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346828Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#796440}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fb57bbd19358..a1d5ae72b241 2020-08-10 teddy.wang@siliconmotions.corp-partner.google.com usergroup_baseline: Add smdisplay user to video group 2020-08-09 manojgupta@google.com chromeos_config: Only keep base/test images for sanitizers 2020-08-08 andrewlassalle@chromium.org dlc_lib: Add allowlist for test boards 2020-08-08 andrewlassalle@chromium.org dlc_lib: Check for lsb-release file before opening it 2020-08-08 tcwang@google.com afdo: Fix breakage due to renaming of Chrome debug binary 2020-08-08 lamontjones@chromium.org SysrootService: use package_indexes list when present. 2020-08-08 saklein@chromium.org service/test: Fix ebuild test metrics. 2020-08-08 vapier@chromium.org gerrit: add a help-all subcommand 2020-08-07 saklein@chromium.org service/sdk: Change argument from proto to string. 2020-08-07 erikchen@chromium.org Add lacros support to deploy_chrome.py 2020-08-07 lamontjones@chromium.org api: freshen python bindings. 2020-08-07 sanikak@chromium.org auto_updater_transfer: remove fallback devserver calls If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id47fb717106272df57d047f3106d159b96764c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796439}
-
Avi Drissman authored
It is undefined behavior in C++ to access memory of one type with a pointer of another type. Use bit_cast to safely do it. Bug: none Change-Id: I170c81e0cc7dc5b7bcf63b0776758c4c65a748bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340180 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796438}
-
Jérôme Lebel authored
The goal of those 5 patches is to remove const on the following methods: * IsValidIdentity() * GetIdentityWithEmail() * GetIdentityWithGaiaID() * GetCanonicalizeEmailsForAllIdentities() * HasIdentities() * GetAllIdentities() * GetAllIdentitiesSortedForDisplay() This is required for crrev.com/i/3208484, to not start async identity fetch in ChromeIdentityServiceImpl instance when the cache is not populated. => crrev.com/c/2345305 Add temporary methods * crrev.com/i/3201649 Switch to the temporary methods * crrev.com/c/2345146 Remove const in the methods * crrev.com/i/3201650 Switch back the original methods * crrev.com/c/2344467 Remove temporary methods Bug: 897470 Change-Id: I96ee862b20081858732fc4d12024bc45d56c3ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345305 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796437}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d5099cc1545f..8956bfb9c99d 2020-08-10 nguyenmh@google.com Use striping when making test batches If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id99f0f1555ce5f41b8639ed5545b0d463523c499 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346945Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This also fixes crbug/1112417 since the added test catches the multi FCM responses case and the extra report of crbug/1113213 Bug: 1113213, 1112417 Change-Id: I91083a8abc8452bc7983bc35214ffa6ded7af7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339282 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#796435}
-
Liquan (Max) Gu authored
Description: PaymentRequestImpl(PRImpl) and ComponentPaymentRequestImpl(CPRImpl) will have mutual reference starting from their constructors. Change: * Before - PRImpl was created at PRFactory#createImpl. After - PRImpl is created at CPRImpl#init. * Rename ComponentPaymentRequestDelegate BrowserPaymentRequest, and make it an individual file. This gives the interface independent semantics (no longer just part of CPRImpl) - "the browser part of the PaymentRequest implementation" Bug: 1102522 Change-Id: I19a5144c23f0f45a8ef7ce3d72752a2b90bef296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340402 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796434}
-
Ryan Daum authored
* Change the TTS extension API to use the upstream TTS controller now that it's been moved out of chrome/ and into content/. * Requires downstream changes in internal/ to rework the platform, until those changes land, TTS will become a no-op. * Using upstream TtsController instead of our fork automagically makes it possible to enable and use the Speech Synthesis API Bug: internal b/162974460 Merge-With: eureka-internal/434822 Test: manual, on device Change-Id: I3acde313d177b74408394046a283b2da02dbff41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340703Reviewed-by:Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Randy Rossi <rmrossi@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#796433}
-
Brandon Goddard authored
This Cl adds new histograms to track experiment usage in the devtools. Explainer: https://docs.google.com/document/d/1pcvN11C4onSXqOE0dTjUUHodMj55bRVl_5_e3kMg_rs/edit?ts=5f2329dc#heading=h.ezo3vjjctj8wz Corresponding Frontend CL: https://crrev.com/c/2341950 Bug: 1107636 Change-Id: If7ecaef09bdf97452a2309f30121674206e02e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341215Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#796432}
-
David Maunder authored
Now with fields such as Title being migrated to UserData objects we enforce that the attribute cannot be acquired after destroy() has been called. Unfortunately, in PseuoTab getTitle() was called after destroy() causing the app to crash which is an invalid assumption. This CL adds an isInitialized() check before the getTitle() call. Bug: 1114564 Change-Id: I064ae7d3601d45116cb198885ef64ff42a2aac7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346785Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#796431}
-
David Roger authored
To fix issues with SAML signout, the signout flow was changed to go through Gaia (http://crbug.com/1068978). However, this does not work when the account is already invalid (Gaia signout is a no-op in this case). As a result, when signing out from an invalid account (i.e. in Sync paused state), the account was not immediately removed from the device, and would linger until the next reconcilor run. This CL explicitly removes the account if it's invalid. Fixed: 1114646 Change-Id: Ibd7b4466ecb7d0ac6951d6b30814ef2e5c521bb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346245Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#796430}
-
Alice Wang authored
This CL adds |Signing in...| string for the sign-in in progress screen title of the web sign-in bottom sheet. Screenshot: https://crbug.com/1102784#c3 Bug: 1102784 Change-Id: I9c3e33da3986bcb7156ef67e27dbe088342cbce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309700 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796429}
-
Xinghui Lu authored
Bug: 1114761 Change-Id: Id46125f5a1d28c4af39be7bbd75d08172c1a1490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345715Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796428}
-
Lei Zhang authored
When calling chrome.fileSystem.chooseEntry() to save edited PDFs, there is an option for the file types to accept. For each file type, the description is optional. The API documentation [1] says "if not present, a description will be automatically generated", but the generated description ended up being an empty string in this case. Fix this by manually setting the file type description. [1] https://developer.chrome.com/apps/fileSystem Bug: 1114127 Change-Id: If3440fcd13a152bb55e8f80193b4960103776cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343782Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796427}
-
Jesse McKenna authored
This change makes IdleWakeups count the cumulative number of processes created and destroyed with the target executable name during the monitoring period, and display these counts in its final summary. This enables the measurement of process turnover resulting from operations of interest, which would otherwise not be reflected in total process count (as a destroyed process and created process that both occur in between polls would cancel each other out and go undetected). Note that it is still possible to miss a process if its lifetime is so short that it is created and destroyed entirely between samples. Counting is done by comparing the previous snapshot's set of process IDs with the target executable name against the new snapshot's. The accuracy of the counts added by this change was verified by comparing against those collected by an ETW trace (System Activity > Processes) over the same period. In this comparison, IdleWakeups identified all created and destroyed Chrome processes apart from a utility process with a lifetime of only 0.08 seconds between samples. Change-Id: I93d674377906f6bd543da2c7b65792bb811fd91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342251 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#796426}
-
Peter Wen authored
Lint no longer requires manifest_package to be specified, so remove this arg from lint.py as well as the gn templates. Bug: 1108791 Change-Id: I4b48dc1ce3eb40ef8b4e703ca4ece475f2d28c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339929 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#796425}
-
Bo Liu authored
Need to ensure AwBrowserProcess.start isn't called multiple times for a single process. Also add an annotation to disable batching and use it for app cache tests, since app cache can only be set once and the setting is global. Bug: 989569 Change-Id: I360230ac612a004bda94dded1d9dd6cb2e3f14cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335673Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796424}
-
Peter Kotwicz authored
BUG=None Change-Id: I03c770a9f06ebdb310cf1ace86cfc3b76b897e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345487Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#796423}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cac176496829..039f681a841a 2020-08-10 johnstiles@google.com Label constants with k prefix (not g) and use constexpr. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: fmalita@google.com Change-Id: I1b4d5a967110ed0f4f15a4acb4aa257d9611c2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346705Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib78ac377c2210a475b6fdd39900ca046679e64e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346867Reviewed-by:
-
Liviu Tinta authored
Add methods to check each pointer event has corresponding compat mouse event regardless of the interleaving order in which pointer events and mouse events are generated. Change-Id: Id6667e14c72338b2d18cc1ca5730ba5b4c25a63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342288 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796420}
-
Guido Urdaneta authored
These tests were using fake audio, but the issue is fixed and now they can use real audio. Bug: 1047655 Change-Id: Iedcc48f1fc19f8d5e4afd5ec04a90c991dae3e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346348 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#796419}
-
Peter Wen authored
Rather than use one universal baseline.xml for lint, allow each target that wants to use lint baselines to specify its own via the gn variable lint_baseline. This also allows better co-location of baseline.xml and the code that it refers to. Also fixes the existing lint issues for cast apk. Bug: 1108791 Change-Id: I982cd35636ce9e08817be6cf8b6cccd18455d8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327834 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
-
sauski authored
To prevent the HaTS Next survey from attempting to open windows in the non-primary OTR profile it runs in, a WebContentsDelegate is introduced to handle attempts to create new WebContents. These are re-opened in the browser which initiated the HaTS survey instead. Bug: 1110888 Change-Id: I96942014fbeb9e78f036d87187902a9dd1dcc66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324129 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#796417}
-
Jeffrey Young authored
Ambient settings page section to selected preferred unit. https://screenshot.googleplex.com/nUzVCEC9eH7.png Preferred unit displayed in ambient mode. https://screenshot.googleplex.com/NE93vpZzarx.png BUG=b:154046129 Change-Id: I79e0bd111c486283bc0a0793527d394f86a870e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339218Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796416}
-
Yutaka Hirano authored
We have used deprecation reports for Atomics.wake to test ReportingObserver for workers, but now Atomics.waks is being removed so this test will not work. We have some WPTs using ReportingObservers in workers, in wpt/html/cross-origin-embedder-policy, so we won't lose test coverage by removing this test. Bug: v8:7883 Change-Id: I63728234f0c008d826cb8c889461a0ec8b17ce53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336131 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#796415}
-
Ella Ge authored
Tests: CrComponentsCrPolicyNetworkBehaviorMojoTest.All CrComponentsNetworkConfigTest.All CrComponentsPolicyNetworkIndicatorMojoTest.All failing on linux-chromeos-dbg bot because file not found. The path should be cr_components/ instead of settings/ TBR=jhawkins@chromium.org Bug: 1114675 Change-Id: I1867ef3da6e8cc15e5c24a3da65df4991557de44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346845Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#796414}
-
Sahel Sharify authored
This cl adds platform browser tests for payment handler uninstallation. Bug: 1068734 Change-Id: Ibc7fa4e28afec32ee21a2378c3899b4c61d2daa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341013Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796413}
-
Stephen McGruer authored
This augments the Chromium log formatter to handle process_output messages, allowing it to capture logs for a test from ChromeDriver. The logs are accumulated for each test, then inserted into the output JSON as an artifact if the test has a CRASH status. The post-run script in wpt_common.py then converts the crash log lines to a file on disk. Also, the handling of the CRASH status in the Chromium log formatter is fixed; it was incorrectly mapping CRASH to FAIL. Finally, --enable-chrome-logs is passed as a webdriver-arg in run_wpt_tests.py, so that full browser logs are available. Bug: 1057197 Change-Id: I7b533398f8b008ea493c1d183f429b1b13d4a1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327613 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#796412}
-
Maksim Sisov authored
We need to avoid using non-Ozone/X11 code when OzonePlatform feature is enabled for Linux once use_x11 && use_ozone are set together. ----- PS: Please note that this is a temp solution that will help to choose between ozone and non-ozone X11 build. The switch that will be used to choose the path is --enable-features=UseOzonePlatform. Once non-Ozone X11 path is removed (hopefully by Q1 2021 depending on how th finch trial goes), the wrapper will be removed. Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: Ia1b9234cffdd6e40e50f39a6e35900c9f42e221e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315685Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#796411}
-
Richard Knoll authored
This adds Start/StorAdvertising to the NearbyConnections interface and hooks it up to the NearbyConnectionsManager on the browser side and to the NearbyConnections class on the utility process that delegates to the third_party library. Bug: 1076008 Change-Id: I2cf883432c625d3c34060536fcbfa13f190c98c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339470Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796410}
-
Ioana Pandele authored
The native pointer was set to 0 before calling a method on it. Bug: 1102025 Change-Id: I55bb0d60c02c70620738784f07d1c7764f63598e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346430Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#796409}
-
Sebastien Lalancette authored
- Added final Copy Link URL icon, - Fixed the string for Copy Link URL action, - Fixed the string used for Open in New Window action title (it should not have a capital 'i'), - Fixed new menu's Open in Incognito string. This CL adds the first icon (copy_link_url) for the new actions. If the proposed pattern is acceptable then the remaining icons will follow a similar pattern. - Icon resource under ui/menu/, - No "menu" prefix to the icon name, - PNGs with different scales used instead of PDF, - Template icon, to allow menus to set the color. Bug: 1093302 Change-Id: Ie22d50d78a4d38c56f9c04cfc2c9cbb66d83ef0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343320 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796408}
-
Antonio Sartori authored
This CL implements the part "Does source expression A subsume source expression B?" of the Content Security Policy: Embedded Enforcement subsumption algorithm following https://w3c.github.io/webappsec-cspee/#subsume-source-expressions in the services/network Content Security Policy module. This is part of a series of CL implementing the whole subsumption algorithm according to that spec. Bug: 1094909 Change-Id: I6e60608aa7734b2415cfec9d4b68a1d8dbf54b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315889 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796407}
-
Ella Ge authored
TBR=rogerta@chromium.org No-try: true Bug: 1113367 Change-Id: I2405c15ad68d30b3cbd92ac831a95758e1766123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346907Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/623cf68b45ca..b27f3f1980fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC eirage@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: eirage@google.com,andypaicu@google.com Change-Id: I906336f70bdf0a574104769edca16240cfad2797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346525Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796405}
-
Frédéric Wang authored
The HTML specifications [1] indicates that the "%s" token is preserved when parsing the URL and this is important to properly perform syntax validation. Currently, Chrome removes the token, which means that something like "ht%stp://example.org" is treated as a valid URL and bypasses the security check. This is however treated as invalid for the browser process validation and so leads to a crash (bad IPC message). The WPT tests are updated to provide the correct expectations. Those for which the %s token is inside the protocol are treated as relative URLs and are valid. Others where the %s token is inside the hostname or port should raise syntax errors. [1] https://html.spec.whatwg.org/multipage/system-state.html#normalize-protocol-handler-parameters Bug: 1112377 Change-Id: I962bcfdd593223568fc72475efeb299adaa72236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335434Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#796404}
-
Kevin Ellis authored
https://github.com/w3c/csswg-drafts/issues/5400 There is the issue that led to the spec change for play state: https://github.com/w3c/csswg-drafts/issues/2066 The issue addresses undesirable toggling of the play state due to inactive timelines, but does not seem to adequately address having an unresolved (null) timeline. Bug: 1113382 Change-Id: I33032ee1e9de10d3dce4958fce599bd98391328f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339676Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#796403}
-
